[SSSD] [sssd PR#388][comment] IDMAP: add a unit test

2017-09-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/388 Title: #388: IDMAP: add a unit test jhrozek commented: """ * master: 11a030ac6e064c50759b5397e1f4d0289f87f64a """ See the full comment at https://github.com/SSSD/sssd/pull/388#issuecomment-330948531 ___ sssd

[SSSD] [sssd PR#388][comment] IDMAP: add a unit test

2017-09-20 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/388 Title: #388: IDMAP: add a unit test fidencio commented: """ @sumit-bose: code looks good, ci passed and the test does cover the patch in PR #384. ACK! """ See the full comment at https://github.com/SSSD/sssd/pull/388#issuecomment-330834346 _

[SSSD] [sssd PR#388][comment] IDMAP: add a unit test

2017-09-20 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/388 Title: #388: IDMAP: add a unit test sumit-bose commented: """ CentOS CI passed, removing Change requested flag. """ See the full comment at https://github.com/SSSD/sssd/pull/388#issuecomment-330815225 ___ ss

[SSSD] [sssd PR#388][comment] IDMAP: add a unit test

2017-09-20 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/388 Title: #388: IDMAP: add a unit test sumit-bose commented: """ The internal CI run went well http://vm-058-233/logs/job/77/87/summary.html """ See the full comment at https://github.com/SSSD/sssd/pull/388#issuecomment-330789756 ___

[SSSD] [sssd PR#388][comment] IDMAP: add a unit test

2017-09-20 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/388 Title: #388: IDMAP: add a unit test sumit-bose commented: """ retest this, please """ See the full comment at https://github.com/SSSD/sssd/pull/388#issuecomment-330789627 ___ sssd-devel mailing list -- sssd-

[SSSD] [sssd PR#388][comment] IDMAP: add a unit test

2017-09-19 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/388 Title: #388: IDMAP: add a unit test fidencio commented: """ @sumit-bose: make check failed in CentOS CI. make-check: failure 00:00:17 ci-build-coverage/ci-make-check.log I'm adding the "Changes Requested" label due to the failure (no, I'm