[SSSD] [sssd PR#45][comment] tests: Add unit tests for UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME

2016-10-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/45 Title: #45: tests: Add unit tests for UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME jhrozek commented: """ * master: * eb9bc1c590b8c3b3b58574c70d9fe5357ef3e901 * 03713a6444fdecd01465b9d5fbfead9601adce6e """ See the full comment at https://g

[SSSD] [sssd PR#45][comment] tests: Add unit tests for UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME

2016-10-11 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/45 Title: #45: tests: Add unit tests for UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME sumit-bose commented: """ The patches look good and make sense. ACK """ See the full comment at https://github.com/SSSD/sssd/pull/45#issuecomment-252898723 __

[SSSD] [sssd PR#45][comment] tests: Add unit tests for UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME

2016-10-11 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/45 Title: #45: tests: Add unit tests for UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME fidencio commented: """ @jhrozek: code-wise the bew patches look good. However, I really would like to have a review from @sumit-bose here as well before consi