URL: https://github.com/SSSD/sssd/pull/46
Title: #46: sss_client: Defer thread cancellation until completion of nss/pam
operations
lslebodn commented:
"""
master:
* d2f93542650c2f9613043acfa8e2f368972a70cd
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/46
Title: #46: sss_client: Defer thread cancellation until completion of nss/pam
operations
sumit-bose commented:
"""
Testing went fine, but there is a "declared 'static' but never defined" issue.
If this patch can be push with
diff --git
URL: https://github.com/SSSD/sssd/pull/46
Title: #46: sss_client: Defer thread cancellation until completion of nss/pam
operations
sumit-bose commented:
"""
I'm fine with the patch as well. Shall I re-run the test with the original
reproducer or did you already run it?
"""
See the full
URL: https://github.com/SSSD/sssd/pull/46
Title: #46: sss_client: Defer thread cancellation until completion of nss/pam
operations
lslebodn commented:
"""
I asked Florian on IRC and he is fine with the last version.
@sumit-bose do you have other comments; can we push it?
"""
See the full
URL: https://github.com/SSSD/sssd/pull/46
Title: #46: sss_client: Defer thread cancellation until completion of nss/pam
operations
HouzuoGuo commented:
"""
All right, `once` is now gone and mutex is now guarding cancellation state.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/46
Title: #46: sss_client: Defer thread cancellation until completion of nss/pam
operations
sumit-bose commented:
"""
Ok, ACK then.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/46#issuecomment-258806379
URL: https://github.com/SSSD/sssd/pull/46
Title: #46: sss_client: Defer thread cancellation until completion of nss/pam
operations
HouzuoGuo commented:
"""
Hello! I don't have a strong preference whether to retain the original
behaviour in a compilation conditional or not, feel free to go
URL: https://github.com/SSSD/sssd/pull/46
Title: #46: sss_client: Defer thread cancellation until completion of nss/pam
operations
jhrozek commented:
"""
Well, if the old code would be disabled and there would be nobody using the new
config option from the start, I'm fine with switching as
URL: https://github.com/SSSD/sssd/pull/46
Title: #46: sss_client: Defer thread cancellation until completion of nss/pam
operations
sumit-bose commented:
"""
Looks lie a tie, @HouzuoGuo do you have any preference?
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/46
Title: #46: sss_client: Defer thread cancellation until completion of nss/pam
operations
lslebodn commented:
"""
On (28/10/16 03:24), sumit-bose wrote:
>On the other hand the magic of git makes it possible as well to recover the
>old code with
URL: https://github.com/SSSD/sssd/pull/46
Title: #46: sss_client: Defer thread cancellation until completion of nss/pam
operations
jhrozek commented:
"""
I wonder if @fweimer thinks it's worth merging the patch if the issue in
https://bugzilla.redhat.com/show_bug.cgi?id=1369130#c4 still
URL: https://github.com/SSSD/sssd/pull/46
Title: #46: sss_client: Defer thread cancellation until completion of nss/pam
operations
sumit-bose commented:
"""
The patch looks good and works as expected and removes the dependency to
libpthread.
If I understand the it correctly there is a small
URL: https://github.com/SSSD/sssd/pull/46
Title: #46: sss_client: Defer thread cancellation until completion of nss/pam
operations
sumit-bose commented:
"""
Here is the original reproducer/test program from
https://fedorahosted.org/sssd/ticket/1460 written by Fedora user werkt (I had
to
URL: https://github.com/SSSD/sssd/pull/46
Title: #46: sss_client: Defer thread cancellation until completion of nss/pam
operations
sumit-bose commented:
"""
Here is the original reproducer/test program from
https://fedorahosted.org/sssd/ticket/1460 written by Fedora user werkt (I had
to
URL: https://github.com/SSSD/sssd/pull/46
Title: #46: sss_client: Defer thread cancellation until completion of nss/pam
operations
jhrozek commented:
"""
ok to test
"""
See the full comment at
https://github.com/SSSD/sssd/pull/46#issuecomment-252854747
URL: https://github.com/SSSD/sssd/pull/46
Title: #46: sss_client: Defer thread cancellation until completion of nss/pam
operations
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/46#issuecomment-252853017
URL: https://github.com/SSSD/sssd/pull/46
Title: #46: sss_client: Defer thread cancellation until completion of nss/pam
operations
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/46#issuecomment-252853023
17 matches
Mail list logo
