URL: https://github.com/SSSD/sssd/pull/53
Title: #53: Fixes in the config API related to secrets responder
lslebodn commented:
"""
On (10/11/16 13:38), Jakub Hrozek wrote:
>Since there is no ticket, I only pushed the patches to master:
>682c9c3467055c2149af28826f7458b857b0f8c4
>da8801c363716533f
URL: https://github.com/SSSD/sssd/pull/53
Title: #53: Fixes in the config API related to secrets responder
jhrozek commented:
"""
Since there is no ticket, I only pushed the patches to master:
682c9c3467055c2149af28826f7458b857b0f8c4
da8801c363716533f60bc78e10f3a2100cebc3a1
"""
See the full co
URL: https://github.com/SSSD/sssd/pull/53
Title: #53: Fixes in the config API related to secrets responder
jhrozek commented:
"""
Thanks, ACK
"""
See the full comment at
https://github.com/SSSD/sssd/pull/53#issuecomment-259810451
___
sssd-devel maili
URL: https://github.com/SSSD/sssd/pull/53
Title: #53: Fixes in the config API related to secrets responder
fidencio commented:
"""
Change done and patchset updated.
Just to make things easier for the reviewer, here is what the fix up looks like:
```
[ffidenci@cat sssd]$ git diff
diff --git a/s
URL: https://github.com/SSSD/sssd/pull/53
Title: #53: Fixes in the config API related to secrets responder
jhrozek commented:
"""
On Tue, Nov 08, 2016 at 05:40:21AM -0800, lslebodn wrote:
> On (08/11/16 05:15), fidencio wrote:
> >@jhrozek:
> >For the first patch the tests are correct. @lslebodn
URL: https://github.com/SSSD/sssd/pull/53
Title: #53: Fixes in the config API related to secrets responder
lslebodn commented:
"""
On (08/11/16 05:15), fidencio wrote:
>@jhrozek:
>For the first patch the tests are correct. @lslebodn also complained that
>[secrets/users/] could be a valid case i
URL: https://github.com/SSSD/sssd/pull/53
Title: #53: Fixes in the config API related to secrets responder
fidencio commented:
"""
@jhrozek:
For the first patch the tests are correct. @lslebodn also complained that
[secrets/users/] could be a valid case in the way the code is in git right now
URL: https://github.com/SSSD/sssd/pull/53
Title: #53: Fixes in the config API related to secrets responder
jhrozek commented:
"""
Sorry for the delay in reviewing. I tried:
```
[secrets/foo]
[secrets/123]
```
as an invalid test and sssd noticed them as invalid. It also didn't complain
about a p
URL: https://github.com/SSSD/sssd/pull/53
Title: #53: Fixes in the config API related to secrets responder
lslebodn commented:
"""
Jakub is more familiar with that code.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/53#issuecomment-254771806
URL: https://github.com/SSSD/sssd/pull/53
Title: #53: Fixes in the config API related to secrets responder
jhrozek commented:
"""
On Wed, Oct 19, 2016 at 03:07:28AM -0700, fidencio wrote:
> @jhrozek I'm removing "Changes requested" label as the last patchset (from 2
> days ago) already contains
URL: https://github.com/SSSD/sssd/pull/53
Title: #53: Fixes in the config API related to secrets responder
fidencio commented:
"""
@jhrozek I'm removing "Changes requested" label as the last patchset (from 2
days ago) already contains the changes requested by Lukaš.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/53
Title: #53: Fixes in the config API related to secrets responder
fidencio commented:
"""
And CI has passed: http://sssd-ci.duckdns.org/logs/job/55/24/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/53#issuecomment-254306475
_
12 matches
Mail list logo
