URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5494
* `master`
* 5ce7ced269c7b3dd8f75122a50f539083b5697ae - pam_sss_gss: support
authentication indicators
"""
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
sumit-bose commented:
"""
Thanks, ACK.
bye,
Sumit
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5494#issuecomment-777231022
___
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
abbra commented:
"""
@sumit-bose thank you! I added this one line and re-pushed.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5494#issuecomment-776927996
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
sumit-bose commented:
"""
Hi,
thanks for the update. In my testing I only found that inheriting the option
from configured to trusted domain does not work. Something like:
```
diff --git
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
abbra commented:
"""
Moved the covscan fixes to PR https://github.com/SSSD/sssd/pull/5498
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5494#issuecomment-776655139
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
abbra commented:
"""
I'll move covscan fixes to a separate PR.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5494#issuecomment-776650660
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
alexey-tikhonov commented:
"""
> Would using `%find_lang` macro help?
I don't know, probably. But lets discuss this in a dedicated email thread as
this has nothing to do with this PR and
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
pbrezina commented:
"""
> I used `+%define _empty_manifest_terminate_build 0` to work-around covscan
> build issue and run a `version-diff-build`.
> I can confirm that this PR doesn't bring
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
alexey-tikhonov commented:
"""
I used `+%define _empty_manifest_terminate_build 0` to work-around covscan
build issue and run a `version-diff-build`.
I can confirm that this PR doesn't
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
alexey-tikhonov commented:
"""
Hi @abbra,
> I saw this issue myself and reported it to @pbrezina already. This is
> definitely a difference between 2.4.1 release and current git master
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
abbra commented:
"""
@alexey-tikhonov so I looked closer to covscan failure that prevents the clean
run. It is due to the following problem:
```
RPM build errors:
error: Empty %files file
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
abbra commented:
"""
Added few more covscan fixes.
@sumit-bose asked on IRC to add a way to 'cancel' authentication indicator
check in a subdomain. I added support for `-` to achieve that,
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
abbra commented:
"""
@alexey-tikhonov I ran covscan for my patches and while it still failed, at
least two issues addressed by the separate patches here were fixed. I seem few
more,
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
abbra commented:
"""
@alexey-tikhonov I fixed couple covscan-reported issues. There are others which
are due to covscan not finishing its analysis in the limited time and thus
killing its
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
alexey-tikhonov commented:
"""
For some reason covscan fails to build:
(f32) https://cov01.lab.eng.brq.redhat.com/covscanhub/task/202028/log/stdout.log
(f33)
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
alexey-tikhonov commented:
"""
For some reason covscan fails to build:
(f32) https://cov01.lab.eng.brq.redhat.com/covscanhub/task/202028/log/stdout.log
(f33)
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
abbra commented:
"""
Thanks, @frozencemetery, I updated the code according to the suggestions.
I also decided to unify a bit the man page example language -- I do talk about
x.509-based
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
abbra commented:
"""
It now works for me. Here is a test on Fedora 33:
```
[admin@master ~]$ export KRB5CCNAME=/tmp/admin.cc
[admin@master ~]$ sudo -l
pam_sss_gss: Initializing GSSAPI
URL: https://github.com/SSSD/sssd/pull/5494
Title: #5494: pam_sss_gss: support authentication indicators
abbra commented:
"""
This is a draft implementation of https://github.com/SSSD/sssd/issues/5482. I
haven't tested it yet myself.
"""
See the full comment at
19 matches
Mail list logo
