URL: https://github.com/SSSD/sssd/pull/5532
Title: #5532: ldap: retry ldap_install_tls() when watchdog interruption
pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5532
* `master`
* da55e3e69707de416b7949d08c165c950090bbb6 - ldap: retry ldap_install_tls()
when watchdog
URL: https://github.com/SSSD/sssd/pull/5532
Title: #5532: ldap: retry ldap_install_tls() when watchdog interruption
pbrezina commented:
"""
Ack from me.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5532#issuecomment-821246253
___
sss
URL: https://github.com/SSSD/sssd/pull/5532
Title: #5532: ldap: retry ldap_install_tls() when watchdog interruption
ikerexxe commented:
"""
> Retry logic means that something failed but we have resolved the server
> successfully so imho the retry logic should be implemented elsewhere. Also at
URL: https://github.com/SSSD/sssd/pull/5532
Title: #5532: ldap: retry ldap_install_tls() when watchdog interruption
sumit-bose commented:
"""
> Retry logic means that something failed but we have resolved the server
> successfully so imho the retry logic should be implemented elsewhere. Also at
URL: https://github.com/SSSD/sssd/pull/5532
Title: #5532: ldap: retry ldap_install_tls() when watchdog interruption
alexey-tikhonov commented:
"""
LGTM, but since this is an important patch, I'd like somebody to have a second
look.
@pbrezina or @sumit-bose , could you please take a look?
"""
URL: https://github.com/SSSD/sssd/pull/5532
Title: #5532: ldap: retry ldap_install_tls() when watchdog interruption
alexey-tikhonov commented:
"""
LGTM, but since this is an important patch, I'd like somebody to have a second
look here.
@pbrezina or @sumit-bose , could you please take a look?
URL: https://github.com/SSSD/sssd/pull/5532
Title: #5532: ldap: retry ldap_install_tls() when watchdog interruption
alexey-tikhonov commented:
"""
LGTM, but since this is an important patch, I'd like anyone to have a second
look here.
@pbrezina or @sumit-bose , could you please take a look?
""
URL: https://github.com/SSSD/sssd/pull/5532
Title: #5532: ldap: retry ldap_install_tls() when watchdog interruption
alexey-tikhonov commented:
"""
Ok.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5532#issuecomment-813946170
___
sssd-
URL: https://github.com/SSSD/sssd/pull/5532
Title: #5532: ldap: retry ldap_install_tls() when watchdog interruption
sumit-bose commented:
"""
> > Thanks. From functional point of view this now looks good.
> > I'm really not sure about implementation of FO code changes though.
> > Do we actually
URL: https://github.com/SSSD/sssd/pull/5532
Title: #5532: ldap: retry ldap_install_tls() when watchdog interruption
ikerexxe commented:
"""
> Thanks. From functional point of view this now looks good.
>
> I'm really not sure about implementation of FO code changes though.
> Do we actually need
URL: https://github.com/SSSD/sssd/pull/5532
Title: #5532: ldap: retry ldap_install_tls() when watchdog interruption
alexey-tikhonov commented:
"""
Thanks. From functional point of view this now looks good.
I'm really not sure about implementation of FO code changes though.
Do we actually need t
URL: https://github.com/SSSD/sssd/pull/5532
Title: #5532: ldap: retry ldap_install_tls() when watchdog interruption
ikerexxe commented:
"""
> -- `status ... is 'working'` despite `Will not retry`
Pushed a new revision that changes this behaviour.
"""
See the full comment at
https://github.co
URL: https://github.com/SSSD/sssd/pull/5532
Title: #5532: ldap: retry ldap_install_tls() when watchdog interruption
alexey-tikhonov commented:
"""
Hi,
thank you for updates and logs.
There is a weird thing in the log:
```
[sss_ldap_init_sys_connect_done] (0x0020): Assuming TLS handshake was
i
URL: https://github.com/SSSD/sssd/pull/5532
Title: #5532: ldap: retry ldap_install_tls() when watchdog interruption
ikerexxe commented:
"""
I've changed the PR taking into account your improvements.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5532#issuecomment-810005543
_
URL: https://github.com/SSSD/sssd/pull/5532
Title: #5532: ldap: retry ldap_install_tls() when watchdog interruption
alexey-tikhonov commented:
"""
Thank you.
Besides few minor/cosmetic remarks, looks good to me.
Covscan is clean.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/
URL: https://github.com/SSSD/sssd/pull/5532
Title: #5532: ldap: retry ldap_install_tls() when watchdog interruption
ikerexxe commented:
"""
> -- why `Marking port ... as 'not working'`? IIUC, this is exactly ip:port
> that is being retried (and succeeds).
I've also taken this into account in t
URL: https://github.com/SSSD/sssd/pull/5532
Title: #5532: ldap: retry ldap_install_tls() when watchdog interruption
alexey-tikhonov commented:
"""
> > Did you try your latest version with your reproducer?
>
> Yes, when the process fails it is retried.
Thanks for the logs. Functionally it looks
URL: https://github.com/SSSD/sssd/pull/5532
Title: #5532: ldap: retry ldap_install_tls() when watchdog interruption
ikerexxe commented:
"""
> Thanks for the updates.
> Did you try your latest version with your reproducer?
Yes, when the process fails it is retried.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/5532
Title: #5532: ldap: retry ldap_install_tls() when watchdog interruption
alexey-tikhonov commented:
"""
Thanks for the updates.
Did you try your latest version with your reproducer?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5532#is
URL: https://github.com/SSSD/sssd/pull/5532
Title: #5532: ldap: retry ldap_install_tls() when watchdog interruption
ikerexxe commented:
"""
Updated with Alexey's improvements.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5532#issuecomment-801112078
URL: https://github.com/SSSD/sssd/pull/5532
Title: #5532: ldap: retry ldap_install_tls() when watchdog interruption
ikerexxe commented:
"""
I've updated the PR by dropping the first patch and changing the second one to
detect if ldap_install_tls() failed because the watchdog interrupted it.
"""
21 matches
Mail list logo
