[SSSD] [sssd PR#5537][comment] negcache: use right domain in nss_protocol_fill_initgr()

2021-04-13 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5537 Title: #5537: negcache: use right domain in nss_protocol_fill_initgr() pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5537 * `master` * 231d1118727b989a4af9911a45a465912fe659d6 - negcache: use right domain in nss_protocol_fi

[SSSD] [sssd PR#5537][comment] negcache: use right domain in nss_protocol_fill_initgr()

2021-04-13 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5537 Title: #5537: negcache: use right domain in nss_protocol_fill_initgr() pbrezina commented: """ 1.16 did not apply, please open separate PR """ See the full comment at https://github.com/SSSD/sssd/pull/5537#issuecomment-818673129 _

[SSSD] [sssd PR#5537][comment] negcache: use right domain in nss_protocol_fill_initgr()

2021-04-13 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5537 Title: #5537: negcache: use right domain in nss_protocol_fill_initgr() pbrezina commented: """ Thank you. Ack. """ See the full comment at https://github.com/SSSD/sssd/pull/5537#issuecomment-818669134 ___ s

[SSSD] [sssd PR#5537][comment] negcache: use right domain in nss_protocol_fill_initgr()

2021-04-06 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5537 Title: #5537: negcache: use right domain in nss_protocol_fill_initgr() sumit-bose commented: """ > Ack to the code but there is conflict. Can you please rebase it? done """ See the full comment at https://github.com/SSSD/sssd/pull/5537#issuecomment-

[SSSD] [sssd PR#5537][comment] negcache: use right domain in nss_protocol_fill_initgr()

2021-04-06 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5537 Title: #5537: negcache: use right domain in nss_protocol_fill_initgr() sumit-bose commented: """ > Shall this target 1-16 as well? > (https://bugzilla.redhat.com/show_bug.cgi?id=1945552) yes """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#5537][comment] negcache: use right domain in nss_protocol_fill_initgr()

2021-04-01 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5537 Title: #5537: negcache: use right domain in nss_protocol_fill_initgr() pbrezina commented: """ Ack to the code but there is conflict. Can you please rebase it? """ See the full comment at https://github.com/SSSD/sssd/pull/5537#issuecomment-811823186

[SSSD] [sssd PR#5537][comment] negcache: use right domain in nss_protocol_fill_initgr()

2021-04-01 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5537 Title: #5537: negcache: use right domain in nss_protocol_fill_initgr() alexey-tikhonov commented: """ Shall this target 1-16 as well? (https://bugzilla.redhat.com/show_bug.cgi?id=1945552) """ See the full comment at https://github.com/SSSD/sssd/pull

[SSSD] [sssd PR#5537][comment] negcache: use right domain in nss_protocol_fill_initgr()

2021-03-29 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5537 Title: #5537: negcache: use right domain in nss_protocol_fill_initgr() sumit-bose commented: """ Hi, thanks for the review. I tired to use a single return but I agree that with your suggestions to code is more readable. New version contains the fixes