URL: https://github.com/SSSD/sssd/pull/5570
Title: #5570: LDAP: make connection log levels consistent
pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5570
* `master`
* 99beee3c320f2d81ffad6290c58ef303623b2f89 - LDAP: make connection log
levels consistent
"""
See the
URL: https://github.com/SSSD/sssd/pull/5570
Title: #5570: LDAP: make connection log levels consistent
alexey-tikhonov commented:
"""
> I have last question - in old log for `sdap_ldap_connect_callback_add` there
> was an `LDAP` keyword. In new log it has been removed.
I removed "LDAP" because
URL: https://github.com/SSSD/sssd/pull/5570
Title: #5570: LDAP: make connection log levels consistent
elkoniu commented:
"""
I have last question - in old log for `sdap_ldap_connect_callback_add` there
was an `LDAP` keyword. In new log it has been removed. If it is not something
which QA / cli
URL: https://github.com/SSSD/sssd/pull/5570
Title: #5570: LDAP: make connection log levels consistent
alexey-tikhonov commented:
"""
That's correct, but as I pointed out: "sdap_id_conn_data_expire_handler() just
calls the former", i.e. those two lines are always near in the log. It doesn't
mak
URL: https://github.com/SSSD/sssd/pull/5570
Title: #5570: LDAP: make connection log levels consistent
elkoniu commented:
"""
In the `sdap_id_conn_data_expire_handler` there is also an access to `struct
sdap_id_conn_data` which you used in `sdap_id_release_conn_data` to extract and
print file d
URL: https://github.com/SSSD/sssd/pull/5570
Title: #5570: LDAP: make connection log levels consistent
alexey-tikhonov commented:
"""
Added logging of `fd` to `sdap_id_release_conn_data()`
(`sdap_id_conn_data_expire_handler()` just calls the former).
"""
See the full comment at
https://github.
URL: https://github.com/SSSD/sssd/pull/5570
Title: #5570: LDAP: make connection log levels consistent
alexey-tikhonov commented:
"""
> I am not sure if `fs` / `uri` is easy accessible in case of those two log
> lines.
Well, I was thinking about getting those via `LDAP_OPT_SOCKBUF` and
`LDAP_O
URL: https://github.com/SSSD/sssd/pull/5570
Title: #5570: LDAP: make connection log levels consistent
elkoniu commented:
"""
I am not sure if `fs` / `uri` is easy accessible in case of those two log
lines.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5570#issuecomment-824825
URL: https://github.com/SSSD/sssd/pull/5570
Title: #5570: LDAP: make connection log levels consistent
alexey-tikhonov commented:
"""
I was thinking about printing `fd`/`uri`.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5570#issuecomment-824819451
_
URL: https://github.com/SSSD/sssd/pull/5570
Title: #5570: LDAP: make connection log levels consistent
elkoniu commented:
"""
LGTM. It is up to you if you want to introduce some common keyword in those 3
log lines for easy grep.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/557
10 matches
Mail list logo