[SSSD] [sssd PR#5685][comment] KCM: Add krb5-libs dependency in spec

2021-09-08 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5685 Title: #5685: KCM: Add krb5-libs dependency in spec pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5685 * `master` * 4b7b6fa70399654b8a6d2f691be832c0680ee1fb - KCM: Add krb5-libs dependency in spec """ See the full

[SSSD] [sssd PR#5685][comment] KCM: Add krb5-libs dependency in spec

2021-07-13 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/5685 Title: #5685: KCM: Add krb5-libs dependency in spec justin-stephenson commented: """ > Isn't BuildRequires useless at this place? Fixed. """ See the full comment at https://github.com/SSSD/sssd/pull/5685#issuecomment-879267562

[SSSD] [sssd PR#5685][comment] KCM: Add krb5-libs dependency in spec

2021-07-13 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5685 Title: #5685: KCM: Add krb5-libs dependency in spec pbrezina commented: """ Isn't BuildRequires useless at this place? """ See the full comment at https://github.com/SSSD/sssd/pull/5685#issuecomment-878991651

[SSSD] [sssd PR#5685][comment] KCM: Add krb5-libs dependency in spec

2021-06-18 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5685 Title: #5685: KCM: Add krb5-libs dependency in spec pbrezina commented: """ This fails CI for RHEL8 and Fedora 33. We still need to support those. Please exlucde the line for older versions (< F34, < RHEL8.5). It also should be a BuildRequire on

[SSSD] [sssd PR#5685][comment] KCM: Add krb5-libs dependency in spec

2021-06-17 Thread rwmjones
URL: https://github.com/SSSD/sssd/pull/5685 Title: #5685: KCM: Add krb5-libs dependency in spec rwmjones commented: """ > Justin, I believe what we need is to require krb5-libs >= the version that > contains required API. Yes I agree. """ See the full comment at

[SSSD] [sssd PR#5685][comment] KCM: Add krb5-libs dependency in spec

2021-06-17 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5685 Title: #5685: KCM: Add krb5-libs dependency in spec pbrezina commented: """ Justin, I believe what we need is to require krb5-libs >= the version that contains required API. """ See the full comment at

[SSSD] [sssd PR#5685][comment] KCM: Add krb5-libs dependency in spec

2021-06-17 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5685 Title: #5685: KCM: Add krb5-libs dependency in spec pbrezina commented: """ Justing, I believe what we need is to require krb5-libs >= the version that contains required API. """ See the full comment at

[SSSD] [sssd PR#5685][comment] KCM: Add krb5-libs dependency in spec

2021-06-15 Thread rwmjones
URL: https://github.com/SSSD/sssd/pull/5685 Title: #5685: KCM: Add krb5-libs dependency in spec rwmjones commented: """ I should add the reason why this will work is because the versioned symbols will be added to the RPM dependencies. eg. libvirt "provides": ``` $ rpm -q --provides

[SSSD] [sssd PR#5685][comment] KCM: Add krb5-libs dependency in spec

2021-06-15 Thread rwmjones
URL: https://github.com/SSSD/sssd/pull/5685 Title: #5685: KCM: Add krb5-libs dependency in spec rwmjones commented: """ Here's an example of how to do it from libvirt: https://gitlab.com/libvirt/libvirt/-/blob/master/src/libvirt_public.syms """ See the full comment at

[SSSD] [sssd PR#5685][comment] KCM: Add krb5-libs dependency in spec

2021-06-15 Thread rwmjones
URL: https://github.com/SSSD/sssd/pull/5685 Title: #5685: KCM: Add krb5-libs dependency in spec rwmjones commented: """ I don't believe this change is correct. `krb5-libs` was installed, it was just a too-old version, so this change wouldn't make any difference. In fact RPM automatic

[SSSD] [sssd PR#5685][comment] KCM: Add krb5-libs dependency in spec

2021-06-15 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/5685 Title: #5685: KCM: Add krb5-libs dependency in spec justin-stephenson commented: """ https://bugzilla.redhat.com/show_bug.cgi?id=1716981 """ See the full comment at https://github.com/SSSD/sssd/pull/5685#issuecomment-861422130