[SSSD] [sssd PR#5755][comment] Tests: support subid ranges managed by FreeIPA

2021-10-13 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5755 Title: #5755: Tests: support subid ranges managed by FreeIPA pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5755 * `master` * 8e22258c1d7ba8ee04e397ddf562f5efa21c3d06 - Tests: support subid ranges managed by FreeIPA """

[SSSD] [sssd PR#5755][comment] Tests: support subid ranges managed by FreeIPA

2021-09-20 Thread aborah-sudo
URL: https://github.com/SSSD/sssd/pull/5755 Title: #5755: Tests: support subid ranges managed by FreeIPA aborah-sudo commented: """ @sgoveas IDMCI passed with this PR without external repo . Every thing is working as expected :

[SSSD] [sssd PR#5755][comment] Tests: support subid ranges managed by FreeIPA

2021-09-09 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5755 Title: #5755: Tests: support subid ranges managed by FreeIPA alexey-tikhonov commented: """ Frankly, I don't understand what `exit_status` captures, but (besides one mistype - see recent comment) in general test looks good to me. @sgoveas , please

[SSSD] [sssd PR#5755][comment] Tests: support subid ranges managed by FreeIPA

2021-09-08 Thread aborah-sudo
URL: https://github.com/SSSD/sssd/pull/5755 Title: #5755: Tests: support subid ranges managed by FreeIPA aborah-sudo commented: """ > ``` > ./src/tests/multihost/ipa/test_subid_ranges.py:126:1: W391 blank line at end > of file This is fixed now >

[SSSD] [sssd PR#5755][comment] Tests: support subid ranges managed by FreeIPA

2021-09-08 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5755 Title: #5755: Tests: support subid ranges managed by FreeIPA alexey-tikhonov commented: """ 1) ``` ./src/tests/multihost/ipa/test_subid_ranges.py:126:1: W391 blank line at end of file ./src/tests/multihost/ipa/conftest.py:180:80: E501 line too long

[SSSD] [sssd PR#5755][comment] Tests: support subid ranges managed by FreeIPA

2021-09-08 Thread aborah-sudo
URL: https://github.com/SSSD/sssd/pull/5755 Title: #5755: Tests: support subid ranges managed by FreeIPA aborah-sudo commented: """ This PR is pass again in IDM-CI : https://ci-jenkins-csb-idmops.apps.ocp-c1.prod.psi.redhat.com/job/trigger-test-suite-tool/558/console """ See the full

[SSSD] [sssd PR#5755][comment] Tests: support subid ranges managed by FreeIPA

2021-09-08 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5755 Title: #5755: Tests: support subid ranges managed by FreeIPA alexey-tikhonov commented: """ Ok, thanks. Looks much better. ACK. Please run latest version in idm-ci. I will leave this to @sgoveas for a final ACK. """ See the full comment at

[SSSD] [sssd PR#5755][comment] Tests: support subid ranges managed by FreeIPA

2021-09-08 Thread aborah-sudo
URL: https://github.com/SSSD/sssd/pull/5755 Title: #5755: Tests: support subid ranges managed by FreeIPA aborah-sudo commented: """ NOW this PR is passed with IDM-CI :+1: https://ci-jenkins-csb-idmops.apps.ocp-c1.prod.psi.redhat.com/job/trigger-test-suite-tool/536/console """ See the full

[SSSD] [sssd PR#5755][comment] Tests: support subid ranges managed by FreeIPA

2021-09-07 Thread aborah-sudo
URL: https://github.com/SSSD/sssd/pull/5755 Title: #5755: Tests: support subid ranges managed by FreeIPA aborah-sudo commented: """ > ``` > ./src/tests/multihost/ipa/test_subid_ranges.py:57:80: E501 line too long (82 > > 79 characters) > ./src/tests/multihost/ipa/test_subid_ranges.py:63:80:

[SSSD] [sssd PR#5755][comment] Tests: support subid ranges managed by FreeIPA

2021-09-07 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5755 Title: #5755: Tests: support subid ranges managed by FreeIPA alexey-tikhonov commented: """ ``` ./src/tests/multihost/ipa/test_subid_ranges.py:57:80: E501 line too long (82 > 79 characters) ./src/tests/multihost/ipa/test_subid_ranges.py:63:80: E501

[SSSD] [sssd PR#5755][comment] Tests: support subid ranges managed by FreeIPA

2021-09-03 Thread aborah-sudo
URL: https://github.com/SSSD/sssd/pull/5755 Title: #5755: Tests: support subid ranges managed by FreeIPA aborah-sudo commented: """ > @aborah-sudo, is this test executed in PR CI? > At the moment I don't understand how both methods can succeed, because it > seems depending on execution order

[SSSD] [sssd PR#5755][comment] Tests: support subid ranges managed by FreeIPA

2021-09-03 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5755 Title: #5755: Tests: support subid ranges managed by FreeIPA alexey-tikhonov commented: """ @aborah-sudo, is this test executed in PR CI? At the moment I don't understand how both methods can succeed, because it seems depending on execution order

[SSSD] [sssd PR#5755][comment] Tests: support subid ranges managed by FreeIPA

2021-08-30 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5755 Title: #5755: Tests: support subid ranges managed by FreeIPA alexey-tikhonov commented: """ Hi @aborah-sudo, is this ready for review? """ See the full comment at https://github.com/SSSD/sssd/pull/5755#issuecomment-908243904

[SSSD] [sssd PR#5755][comment] Tests: support subid ranges managed by FreeIPA

2021-08-30 Thread aborah-sudo
URL: https://github.com/SSSD/sssd/pull/5755 Title: #5755: Tests: support subid ranges managed by FreeIPA aborah-sudo commented: """ > Hi @aborah-sudo, is thi ready for review? yes """ See the full comment at https://github.com/SSSD/sssd/pull/5755#issuecomment-908247409

[SSSD] [sssd PR#5755][comment] Tests: support subid ranges managed by FreeIPA

2021-08-30 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5755 Title: #5755: Tests: support subid ranges managed by FreeIPA alexey-tikhonov commented: """ Hi @aborah-sudo, is thi ready for review? """ See the full comment at https://github.com/SSSD/sssd/pull/5755#issuecomment-908243904

[SSSD] [sssd PR#5755][comment] Tests: support subid ranges managed by FreeIPA

2021-08-23 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5755 Title: #5755: Tests: support subid ranges managed by FreeIPA alexey-tikhonov commented: """ This awaits finalization of https://github.com/RedHatQE/shadow-utils/pull/1 first. """ See the full comment at