URL: https://github.com/SSSD/sssd/pull/684 Author: sumit-bose Title: #684: ifp: fix typo causing a crash in FindByNameAndCertificate Action: opened
PR body: """ Due to a typo in the recent refactoring the InfoPipe crashes in the FindByNameAndCertificate request. Additionally a state variable in set to the expected value. Related to https://pagure.io/SSSD/sssd/issue/3863 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/684/head:pr684 git checkout pr684
From e3e30c41449f3e66de701f53bdf0129d99cdf4f6 Mon Sep 17 00:00:00 2001 From: Sumit Bose <sb...@redhat.com> Date: Wed, 24 Oct 2018 17:27:21 +0200 Subject: [PATCH] ifp: fix typo causing a crash in FindByNameAndCertificate Due to a typo in the recent refactoring the InfoPipe crashes in the FindByNameAndCertificate request. Additionally a state variable in set to the expected value. Related to https://pagure.io/SSSD/sssd/issue/3863 --- src/responder/ifp/ifp_users.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/responder/ifp/ifp_users.c b/src/responder/ifp/ifp_users.c index dd44afcc45..df08364265 100644 --- a/src/responder/ifp/ifp_users.c +++ b/src/responder/ifp/ifp_users.c @@ -584,6 +584,12 @@ ifp_users_find_by_name_and_cert_send(TALLOC_CTX *mem_ctx, } if (!SBUS_REQ_STRING_IS_EMPTY(pem_cert)) { + state->pem_cert = talloc_strdup(state, name); + if (state->pem_cert == NULL) { + ret = ENOMEM; + goto done; + } + ret = sss_cert_pem_to_derb64(state, pem_cert, &state->derb64); if (ret != EOK) { DEBUG(SSSDBG_OP_FAILURE, "sss_cert_pem_to_derb64 failed.\n"); @@ -741,7 +747,7 @@ static void ifp_users_find_by_name_and_cert_done(struct tevent_req *subreq) return; } - ret = ifp_users_list_by_cert_step(req); + ret = ifp_users_find_by_name_and_cert_step(req); if (ret == EOK) { tevent_req_done(req); } else if (ret != EAGAIN) {
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
