URL: https://github.com/SSSD/sssd/pull/69
Title: #69: krb5: Use command line arguments instead env vars for krb5_child
lslebodn commented:
"""
I fixed few coding style issues. I hope you don't mind.
master:
* 167b05b28d6b969230973646bee2f1c1f49205d2
* f78b2dd73d26988068306cc22a504fd0e069d6cc
*
URL: https://github.com/SSSD/sssd/pull/69
Title: #69: krb5: Use command line arguments instead env vars for krb5_child
lslebodn commented:
"""
On (28/11/16 03:07), sumit-bose wrote:
>Hi Lukas,
>
>thank you for the review, I added my replies to your comments.
>
ACK
LS
"""
See the full comment
URL: https://github.com/SSSD/sssd/pull/69
Title: #69: krb5: Use command line arguments instead env vars for krb5_child
sumit-bose commented:
"""
Hi Lukas,
thank you for the review, I added my replies to your comments.
bye,
Sumit
"""
See the full comment at
https://github.com/SSSD/sssd/pull/6
URL: https://github.com/SSSD/sssd/pull/69
Title: #69: krb5: Use command line arguments instead env vars for krb5_child
lslebodn commented:
"""
I added few inline comments
"""
See the full comment at
https://github.com/SSSD/sssd/pull/69#issuecomment-262966524
___
URL: https://github.com/SSSD/sssd/pull/69
Title: #69: krb5: Use command line arguments instead env vars for krb5_child
lslebodn commented:
"""
On (16/11/16 12:27), sumit-bose wrote:
>Thank you for the rigid testing, it was a typo in the command line option
>names. To avoid this I switched to #d
URL: https://github.com/SSSD/sssd/pull/69
Title: #69: krb5: Use command line arguments instead env vars for krb5_child
sumit-bose commented:
"""
Thank you for the rigid testing, it was a typo in the command line option
names. To avoid this I switched to #defines for all option name usage.
"""
URL: https://github.com/SSSD/sssd/pull/69
Title: #69: krb5: Use command line arguments instead env vars for krb5_child
lslebodn commented:
"""
On (11/11/16 03:13), sumit-bose wrote:
>Sorry, this issue was introduced by a assume simple last minute change which I
>didn't test properly. I couldn't
URL: https://github.com/SSSD/sssd/pull/69
Title: #69: krb5: Use command line arguments instead env vars for krb5_child
sumit-bose commented:
"""
Sorry, this issue was introduced by a assume simple last minute change which I
didn't test properly. I couldn't decide if I want to keep the options i
URL: https://github.com/SSSD/sssd/pull/69
Title: #69: krb5: Use command line arguments instead env vars for krb5_child
lslebodn commented:
"""
The password changed failed for me with this patches. I had also applied
patches for PR #77.
But I doubt they could cause such change. I tested just wi
URL: https://github.com/SSSD/sssd/pull/69
Title: #69: krb5: Use command line arguments instead env vars for krb5_child
lslebodn commented:
"""
On (08/11/16 03:33), celestian wrote:
>Code looks good to me. CI tests passed:
>http://sssd-ci.duckdns.org/logs/job/56/34/summary.html
>
>=> ACK
just FYI
URL: https://github.com/SSSD/sssd/pull/69
Title: #69: krb5: Use command line arguments instead env vars for krb5_child
celestian commented:
"""
Code looks good to me. CI tests passed:
http://sssd-ci.duckdns.org/logs/job/56/34/summary.html
=> ACK
"""
See the full comment at
https://github.com/
11 matches
Mail list logo
