[SSSD] [sssd PR#690][comment] DYNDNS: Convert dyndns timer to be_ptask

2018-12-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/690 Title: #690: DYNDNS: Convert dyndns timer to be_ptask jhrozek commented: """ * master: df9e4802c060fc21d38f238265805092352e5c95 """ See the full comment at https://github.com/SSSD/sssd/pull/690#issuecomment-444620631

[SSSD] [sssd PR#690][comment] DYNDNS: Convert dyndns timer to be_ptask

2018-12-05 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/690 Title: #690: DYNDNS: Convert dyndns timer to be_ptask pbrezina commented: """ Where is it implemented? Ack to the patches! """ See the full comment at https://github.com/SSSD/sssd/pull/690#issuecomment-42609

[SSSD] [sssd PR#690][comment] DYNDNS: Convert dyndns timer to be_ptask

2018-11-29 Thread thalman
URL: https://github.com/SSSD/sssd/pull/690 Title: #690: DYNDNS: Convert dyndns timer to be_ptask thalman commented: """ > Where did you get this 60 seconds limit? I can not find it in original code: > > ```c > ad_dyndns_init: > if (period < 60) period = 60; > ``` I removed this part, I found

[SSSD] [sssd PR#690][comment] DYNDNS: Convert dyndns timer to be_ptask

2018-11-29 Thread thalman
URL: https://github.com/SSSD/sssd/pull/690 Title: #690: DYNDNS: Convert dyndns timer to be_ptask thalman commented: """ > Where did you get this 60 seconds limit? I can not find it in original code: > > ```c > ad_dyndns_init: > if (period < 60) period = 60; > ``` > > Also please remove

[SSSD] [sssd PR#690][comment] DYNDNS: Convert dyndns timer to be_ptask

2018-11-29 Thread thalman
URL: https://github.com/SSSD/sssd/pull/690 Title: #690: DYNDNS: Convert dyndns timer to be_ptask thalman commented: """ > Where did you get this 60 seconds limit? I can not find it in original code: > > ```c > ad_dyndns_init: > if (period < 60) period = 60; > ``` > > Also please remove

[SSSD] [sssd PR#690][comment] DYNDNS: Convert dyndns timer to be_ptask

2018-11-16 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/690 Title: #690: DYNDNS: Convert dyndns timer to be_ptask pbrezina commented: """ Please remove `be_nsupdate_init_timer` and the whole request `sdap_dyndns_timer_conn_send` from the code since it is not used anymore. However, you need to implement the

[SSSD] [sssd PR#690][comment] DYNDNS: Convert dyndns timer to be_ptask

2018-11-06 Thread thalman
URL: https://github.com/SSSD/sssd/pull/690 Title: #690: DYNDNS: Convert dyndns timer to be_ptask thalman commented: """ This limit was not in code, only in documentation (sssd-ad.5.xml). It is also inconsistent with sssd-ipa where there is no such limit and also default value for

[SSSD] [sssd PR#690][comment] DYNDNS: Convert dyndns timer to be_ptask

2018-11-06 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/690 Title: #690: DYNDNS: Convert dyndns timer to be_ptask pbrezina commented: """ Where did you get this 60 seconds limit? I can not find it in original code: ```c ad_dyndns_init: if (period < 60) period = 60; ``` Also please remove