URL: https://github.com/SSSD/sssd/pull/705
Title: #705: KCM: Add configurable quotas
jhrozek commented:
"""
* master:
* 247aa48004ceb2efba42e917cebecc0ab74dc207
* f024b5e46b62ad49f0099ed8db8155e7ea475639
* f00db73d7bbf312e3e2a772b8b10895d5460b989
* 940002ca21abde53ad81df622d1f4dd3b5e8e014
URL: https://github.com/SSSD/sssd/pull/705
Title: #705: KCM: Add configurable quotas
mzidek-rh commented:
"""
Sigh... I forgot to ACK this second day in a row. Sorry for the delay.
The patches work for me, there is a an unrelated failure on debian, other tests
passed.
ACK.
"""
See the full
URL: https://github.com/SSSD/sssd/pull/705
Title: #705: KCM: Add configurable quotas
jhrozek commented:
"""
@mzidek-rh please try now, there was some conflict between the tests, so I just
removed the secrets db with the quota tests. (Only the patch with the tests was
modified)
"""
See the
URL: https://github.com/SSSD/sssd/pull/705
Title: #705: KCM: Add configurable quotas
jhrozek commented:
"""
I can see the tests failing now, too..
Setting Changes requested so I can take a look..
"""
See the full comment at
https://github.com/SSSD/sssd/pull/705#issuecomment-515969272
URL: https://github.com/SSSD/sssd/pull/705
Title: #705: KCM: Add configurable quotas
mzidek-rh commented:
"""
Hi,
all the tests added in this patchset are failing for me. It would be nice if
someone could verify that the tests work and it is problem with my setup.
Also, when I run the tests
URL: https://github.com/SSSD/sssd/pull/705
Title: #705: KCM: Add configurable quotas
jhrozek commented:
"""
Rebased and added the title for each test. @mzidek-rh said he would look at the
test failures.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/705#issuecomment-503557824
URL: https://github.com/SSSD/sssd/pull/705
Title: #705: KCM: Add configurable quotas
jhrozek commented:
"""
The test needs to have a title added as PR #756 does.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/705#issuecomment-479843270
URL: https://github.com/SSSD/sssd/pull/705
Title: #705: KCM: Add configurable quotas
jhrozek commented:
"""
rebased
"""
See the full comment at
https://github.com/SSSD/sssd/pull/705#issuecomment-467054904
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/705
Title: #705: KCM: Add configurable quotas
mzidek-rh commented:
"""
Hi, can you please rebase these patches? I think the other KCM patchset that
was just pushed causes conflicts.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/705
Title: #705: KCM: Add configurable quotas
jhrozek commented:
"""
The tests were not cleaning after one another. I guess that's why I didn't see
the failed results on my machine when running the tests one-by-one. So far I
added a standalone fixup
URL: https://github.com/SSSD/sssd/pull/705
Title: #705: KCM: Add configurable quotas
mzidek-rh commented:
"""
Ah, I forgot to add a comment when adding the label.
There were some issues in multihost tests with the latest iteration of these
patches. I added changes requested label until they
URL: https://github.com/SSSD/sssd/pull/705
Title: #705: KCM: Add configurable quotas
mzidek-rh commented:
"""
Thanks this LGTM. I will do one more test with the rebased patches and give an
ack if everything goes well.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/705
Title: #705: KCM: Add configurable quotas
jhrozek commented:
"""
rebased
"""
See the full comment at
https://github.com/SSSD/sssd/pull/705#issuecomment-458698402
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/705
Title: #705: KCM: Add configurable quotas
pbrezina commented:
"""
@jhrozek Local run of integration tests failed but sssd-ci did succeeded? Did
you figure it out or should I look into it?
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/705
Title: #705: KCM: Add configurable quotas
jhrozek commented:
"""
OK, I'll squash this diff:
```
diff --git a/src/responder/secrets/secsrv.c b/src/responder/secrets/secsrv.c
URL: https://github.com/SSSD/sssd/pull/705
Title: #705: KCM: Add configurable quotas
jhrozek commented:
"""
I'm adding changes requested, but since the issue is 'only' in tests, I would
still appreciate a review
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/705
Title: #705: KCM: Add configurable quotas
jhrozek commented:
"""
I still need to amend the tests:
```
=== short test summary info
FAIL test_kcm.py::test_kcm_secrets_quota
FAIL
URL: https://github.com/SSSD/sssd/pull/705
Title: #705: KCM: Add configurable quotas
jhrozek commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/705#issuecomment-446184702
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/705
Title: #705: KCM: Add configurable quotas
jhrozek commented:
"""
The test failed because of pep8 failures in the test. Now it will hopefully
come back clean.
Still looking for a reviewer..
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/705
Title: #705: KCM: Add configurable quotas
jhrozek commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/705#issuecomment-444096360
___
sssd-devel mailing list --
20 matches
Mail list logo
