[SSSD] [sssd PR#709][comment] Regex fails if there's a whitespace before option name

2019-06-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/709 Title: #709: Regex fails if there's a whitespace before option name jhrozek commented: """ * master: aa73e296ba392f4222134ce68cd4ec5fe8adb7f5 """ See the full comment at https://github.com/SSSD/sssd/pull/709#issuecomment-500769293

[SSSD] [sssd PR#709][comment] Regex fails if there's a whitespace before option name

2019-06-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/709 Title: #709: Regex fails if there's a whitespace before option name jhrozek commented: """ Can either of you set +Accepted so I can push the patch? """ See the full comment at https://github.com/SSSD/sssd/pull/709#issuecomment-499847578 __

[SSSD] [sssd PR#709][comment] Regex fails if there's a whitespace before option name

2019-06-07 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/709 Title: #709: Regex fails if there's a whitespace before option name mzidek-rh commented: """ @thalman Thanks, you are correct, with the multiline feature suppressed the patch is safe. """ See the full comment at https://github.com/SSSD/sssd/pull/709#

[SSSD] [sssd PR#709][comment] Regex fails if there's a whitespace before option name

2019-06-07 Thread thalman
URL: https://github.com/SSSD/sssd/pull/709 Title: #709: Regex fails if there's a whitespace before option name thalman commented: """ Here is my investigation on this: In sssd we use INI_PARSE_NOWRAP i. e. no multiline items. On the other side we do not use INI_PARSE_NOSPACE so leading space/ta

[SSSD] [sssd PR#709][comment] Regex fails if there's a whitespace before option name

2018-12-19 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/709 Title: #709: Regex fails if there's a whitespace before option name mzidek-rh commented: """ I will check in ding-libs if we have support for whitespaces before option name, but I suspect that it could collide with the multiline values feature in ding

[SSSD] [sssd PR#709][comment] Regex fails if there's a whitespace before option name

2018-12-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/709 Title: #709: Regex fails if there's a whitespace before option name jhrozek commented: """ @mzidek-rh do you have some opinion on the patch? """ See the full comment at https://github.com/SSSD/sssd/pull/709#issuecomment-445157860 _

[SSSD] [sssd PR#709][comment] Regex fails if there's a whitespace before option name

2018-12-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/709 Title: #709: Regex fails if there's a whitespace before option name jhrozek commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/709#issuecomment-445157651 ___ sssd-devel m

[SSSD] [sssd PR#709][comment] Regex fails if there's a whitespace before option name

2018-12-06 Thread centos-ci
URL: https://github.com/SSSD/sssd/pull/709 Title: #709: Regex fails if there's a whitespace before option name centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/709#issuecomment-445134373