URL: https://github.com/SSSD/sssd/pull/715 Author: AdamWill Title: #715: Use 120 second default timeout for dbus (#1654537) Action: opened
PR body: """ As discussed in #1654537, first login to a system as a FreeIPA domain user now usually causes an expensive SELinux operation to happen; this can take longer than the default dbus message timeout of 25 seconds. To deal with this for now, let's use a 120 second default timeout; this is a big hammer, but unless we can refactor things to use a longer timeout just for that one call, or make the actual operation take less time, there's not much else we can do. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1654537 Signed-off-by: Adam Williamson <awill...@redhat.com> """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/715/head:pr715 git checkout pr715
From 1be129c589fd1bee292a740c021a1fb942f07a94 Mon Sep 17 00:00:00 2001 From: Adam Williamson <awill...@redhat.com> Date: Wed, 12 Dec 2018 22:28:15 -0800 Subject: [PATCH] Use 120 second default timeout for dbus (#1654537) As discussed in #1654537, first login to a system as a FreeIPA domain user now usually causes an expensive SELinux operation to happen; this can take longer than the default dbus message timeout of 25 seconds. To deal with this for now, let's use a 120 second default timeout; this is a big hammer, but unless we can refactor things to use a longer timeout just for that one call, or make the actual operation take less time, there's not much else we can do. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1654537 Signed-off-by: Adam Williamson <awill...@redhat.com> --- src/sbus/sbus_message.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/sbus/sbus_message.h b/src/sbus/sbus_message.h index e7b8fe594..d7d762aa4 100644 --- a/src/sbus/sbus_message.h +++ b/src/sbus/sbus_message.h @@ -27,8 +27,10 @@ #include "util/util.h" #include "sbus/sbus_errors.h" -/* Use reasonable default timeout which is computed in libdbus */ -#define SBUS_MESSAGE_TIMEOUT -1 +/* Use longer default timeout than libdbus default due to expensive + * selinux operation: see https://bugzilla.redhat.com/show_bug.cgi?id=1654537 + */ +#define SBUS_MESSAGE_TIMEOUT 120000 /** * Bound message with a talloc context.
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
