URL: https://github.com/SSSD/sssd/pull/734
Title: #734: sss_client: minor fixes
jhrozek commented:
"""
* master:
0d96e175a4dc177d372cd56a25f155d80f369121
08d5dabc50341034a41150018f8efd83555003c7
6e2df759de3b018c186900bde668da53ac675e10
bc92d36c96b4404353d991f42568b58cdf0a2d5a
"""
See the full
URL: https://github.com/SSSD/sssd/pull/734
Title: #734: sss_client: minor fixes
alexey-tikhonov commented:
"""
Re-pushed last patch: amended broken indentation
"""
See the full comment at
https://github.com/SSSD/sssd/pull/734#issuecomment-455543661
URL: https://github.com/SSSD/sssd/pull/734
Title: #734: sss_client: minor fixes
jhrozek commented:
"""
Thank you, this was so much easier to review.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/734#issuecomment-455352466
___
URL: https://github.com/SSSD/sssd/pull/734
Title: #734: sss_client: minor fixes
alexey-tikhonov commented:
"""
> each change, however cosmetic, _especially_ in the client code should be in
> its separate patch.
Re-pushed
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/734
Title: #734: sss_client: minor fixes
jhrozek commented:
"""
I have a generic comment: each change, however cosmetic, *especially* in the
client code should be in its separate patch. There are two reasons for this: 1)
you can write a commit message
