URL: https://github.com/SSSD/sssd/pull/766
Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals
jhrozek commented:
"""
* master: 0b210838e46302493e920fab080101b7f54c8b94
"""
See the full comment at
https://github.com/SSSD/sssd/pull/766#issuecomment-502801874
__
URL: https://github.com/SSSD/sssd/pull/766
Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals
jhrozek commented:
"""
LGTM and the test passes with a recent sssd build (I didn't try with the old
one, but I trust @mrniranjan when he says he did)
"""
See the full commen
URL: https://github.com/SSSD/sssd/pull/766
Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals
mrniranjan commented:
"""
@jhrozek @sumit-bose can you review the latest changes.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/766#issuecomment-502770926
URL: https://github.com/SSSD/sssd/pull/766
Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals
mrniranjan commented:
"""
Ran the kcm tests on (unpatched version) sssd-1.16.0-4.el8+5.s390x .
```
test_kcm.py::TestSanityKCM::test_kinit_kcm
test_kcm.py::TestSanityKCM::Run
URL: https://github.com/SSSD/sssd/pull/766
Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals
mrniranjan commented:
"""
Ran the kcm tests on (unpatched version) sssd-1.16.0-4.el8+5.s390x .
```
test_kcm.py::TestSanityKCM::test_kinit_kcm
test_kcm.py::TestSanityKCM::Run
URL: https://github.com/SSSD/sssd/pull/766
Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals
mrniranjan commented:
"""
@sumit-bose the latest patch addresses the version number being checked
against integer instead of hardcoded number .
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/766
Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals
mrniranjan commented:
"""
@jhrozek this patch is to address bz-[1585313
](https://bugzilla.redhat.com/show_bug.cgi?id=1585313)
"""
See the full comment at
https://github.co
URL: https://github.com/SSSD/sssd/pull/766
Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals
mrniranjan commented:
"""
@jhrozek i could run the tests against a build which doesn't contain the fix. I
have only checked this against latest build.
"""
See the full comm
URL: https://github.com/SSSD/sssd/pull/766
Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals
jhrozek commented:
"""
I don't understand this commit, sorry. How does it relate to the bug that was
fixed? I mean, the commit is OK, but I don't understand how would it test
URL: https://github.com/SSSD/sssd/pull/766
Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals
sumit-bose commented:
"""
ok to test
"""
See the full comment at
https://github.com/SSSD/sssd/pull/766#issuecomment-469171602
___
URL: https://github.com/SSSD/sssd/pull/766
Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/766#issuecomment-469169150
__
URL: https://github.com/SSSD/sssd/pull/766
Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals
mrniranjan commented:
"""
Ran Below tests on s390x . (Linux ibm-z-130.rhts.eng.bos.redhat.com
4.18.0-74.el8.s390x #1 SMP Wed Feb 27 17:18:28 UTC 2019 s390x s390x s390x
GNU/L
12 matches
Mail list logo
