URL: https://github.com/SSSD/sssd/pull/79
Title: #79: LIBSSS_CONFIG: Drop libsss_config
fidencio commented:
"""
Suggestion taken and changes done, thanks for the review!
I've just pushed a new version of the patch.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/79#issuecomment-2
URL: https://github.com/SSSD/sssd/pull/79
Title: #79: LIBSSS_CONFIG: Drop libsss_config
lslebodn commented:
"""
There is a tiny conflict due to change in `src/external/configlib.m4`
There is also typo in commit message `lib_config` and IMHO it might be
better to use "BUILD"
as a component
URL: https://github.com/SSSD/sssd/pull/79
Title: #79: LIBSSS_CONFIG: Drop libsss_config
fidencio commented:
"""
Change done. Here is the fix up patch that in order to help the reviewer:
```
[ffidenci@cat sssd]$ git diff HEAD
diff --git a/contrib/ci/deps.sh b/contrib/ci/deps.sh
index 9a7098c..387
URL: https://github.com/SSSD/sssd/pull/79
Title: #79: LIBSSS_CONFIG: Drop libsss_config
lslebodn commented:
"""
You forgot to rebuve build dependencies from spec file
and from ci.deps
contrib/ci/deps.sh:libaugeas-dev
contrib/sssd.spec.in:BuildRequires: augeas-devel
LS
"""
See the ful
URL: https://github.com/SSSD/sssd/pull/79
Title: #79: LIBSSS_CONFIG: Drop libsss_config
fidencio commented:
"""
CI: http://sssd-ci.duckdns.org/logs/job/56/93/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/79#issuecomment-259803386
___
