[SSSD] [sssd PR#818][comment] DP: add NULL check to be_ptask_{enable|disable}

2019-05-28 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/818 Title: #818: DP: add NULL check to be_ptask_{enable|disable} jhrozek commented: """ * master: 2720d97 * sssd-1-16: cb94d00 """ See the full comment at https://github.com/SSSD/sssd/pull/818#issuecomment-496660665 __

[SSSD] [sssd PR#818][comment] DP: add NULL check to be_ptask_{enable|disable}

2019-05-24 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/818 Title: #818: DP: add NULL check to be_ptask_{enable|disable} alexey-tikhonov commented: """ Honestly, I would prefer ``` if (!task) { return; } ``` instead of wrapping whole function content into `if (task != NULL) {}` At least `diff` would be smal

[SSSD] [sssd PR#818][comment] DP: add NULL check to be_ptask_{enable|disable}

2019-05-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/818 Title: #818: DP: add NULL check to be_ptask_{enable|disable} jhrozek commented: """ @thalman Hi Tomas, sorry I didn't clone and assign the bug to you earlier, but I wonder if you can look at the patch and review it? """ See the full comment at https