[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req fidencio commented: """ On Tue, Jan 3, 2017 at 11:06 AM, Pavel Březina wrote: > On 01/02/2017 10:44 PM, Jakub Hrozek wrote: > > On Mon, Jan 02, 2017 at 01:53:23AM

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req pbrezina commented: """ On 01/02/2017 10:44 PM, Jakub Hrozek wrote: > On Mon, Jan 02, 2017 at 01:53:23AM -0800, Pavel Březina wrote: >> @jhrozek >> * #1126 -- pam, ssh and pac (?) responders

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req jhrozek commented: """ On Mon, Jan 02, 2017 at 01:53:23AM -0800, Pavel Březina wrote: > @jhrozek > * #1126 -- pam, ssh and pac (?) responders needs to be amended, but the > change there is not

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req pbrezina commented: """ @jhrozek * #1126 -- pam, ssh and pac (?) responders needs to be amended, but the change there is not that huge. * #2320 -- not sure if this is needed anywhere with

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req spbnick commented: """ Another question is cache_req going to be used by PAM (if this question even makes sense)? """ See the full comment at

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req spbnick commented: """ Not a review, but rather a question to @pbrezina: why do some "plugin" functions receive both cache_req_data and cache_req, which also references cache_req_data, at the

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req jhrozek commented: """ @pbrezina @lslebodn is there any more work needed on https://fedorahosted.org/sssd/ticket/1126 or https://fedorahosted.org/sssd/ticket/2320 ? Do we anticipate to work

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req lslebodn commented: """ I fixed few coding style issues( indentation 80 columns limit ...) and removing files from makefile(distcheck failed with HEAD~1). I hope you don't mind. *

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req lslebodn commented: """ ACK Time for review for others expired :-). But you can still after commit. """ See the full comment at https://github.com/SSSD/sssd/pull/89#issuecomment-268099531

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req pbrezina commented: """ All your comments were addressed. I also added https://github.com/SSSD/sssd/pull/89/commits/cf975c06bfb6710d8254b052c42161ebcdc59d14 This patch should solve the

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req pbrezina commented: """ On 12/13/2016 10:01 PM, lslebodn wrote: > *@lslebodn* commented on this pull request. > > > > In

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req lslebodn commented: """ I almost forgot to write the most important message. AD related tests passed. LDAP related tests passed; there are some intermittent failures; but maybe not related to

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req lslebodn commented: """ I had a few inline comments; mostly nitpicks CI passed (rawhide failure is unrelated http://sssd-ci.duckdns.org/logs/job/58/78/summary.html """ See the full comment at

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req lslebodn commented: """ Just for the record; the last update fixed netgroup memory leak for long living clients """ See the full comment at

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req pbrezina commented: """ Fixed. """ See the full comment at https://github.com/SSSD/sssd/pull/89#issuecomment-266708967 ___ sssd-devel mailing list

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req lslebodn commented: """ I saw a crash as part of ad_testing. But it seems to be unrelated to AD tests. ``` #0 __strlen_sse2_pminub () at ../sysdeps/x86_64/multiarch/strlen-sse2-pminub.S:38 #1

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req lslebodn commented: """ I saw a crash as part of ad_testing. But it seems to be unrelated to AD tests. ``` #0 __strlen_sse2_pminub () at ../sysdeps/x86_64/multiarch/strlen-sse2-pminub.S:38 #1

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req pbrezina commented: """ Hi, I added: https://github.com/SSSD/sssd/pull/89/commits/a7dd2b118170e6dacaf41dba4874ad5754c25500 This should fix the AD failures, please test it again. """ See the

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req pbrezina commented: """ The crash was caused by the same issue as the valgrind log. It is fixed with: ```c diff --git a/src/responder/nss/nss_enum.c b/src/responder/nss/nss_enum.c index

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req pbrezina commented: """ The crash was caused by the same issue as the valgrind log. It is fixed with: ```c diff --git a/src/responder/nss/nss_enum.c b/src/responder/nss/nss_enum.c index

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req lslebodn commented: """ Another crash from AD related test. 0xbe was initialized either by `MALLOC_PERTRUB` or `TALLOC_FREE_FILL` ``` #0 0x7fa2dd6a8423 in setent_notify

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req pbrezina commented: """ On 12/08/2016 09:50 AM, lslebodn wrote: > Looks like there is use after free in latest version. sorry do not have > a reproducer yet; just a valgrind output > >

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req lslebodn commented: """ Looks like there is use after free in latest version. sorry do not have a reproducer yet; just a valgrind output ``` ==6612== 18 errors in context 1 of 1: ==6612==

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req pbrezina commented: """ Enumeration, services and memory leak were fixed. * Enumeration issue was caused by calling `talloc_get_type()` on non-talloc pointer. * Services issue was caused by

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req lslebodn commented: """ On (06/12/16 02:40), Pavel Březina wrote: >On 12/05/2016 04:36 PM, lslebodn wrote: >> SSS_SEED user offline authentication failed: >> >> * block access to the ldap >>

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req lslebodn commented: """ There is also a crash for group enumeration ``` (Wed Nov 30 09:22:36 2016) [sssd[nss]] [cache_req_search_done] (0x0400): CR #0: Returning updated object [Groups

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req lslebodn commented: """ When I was testing crash caused by enumeration I also found different valgrind errors. I double checked that these errors are not in master. ``` ==18958== 1 errors in

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req lslebodn commented: """ When I was testing crash caused by enumeration I also found different valgrind errors. I double checked that these errors are not in master. ``` ==18958== 1 errors in

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req pbrezina commented: """ On 12/05/2016 04:36 PM, lslebodn wrote: > SSS_SEED user offline authentication failed: > > * block access to the ldap > * sleep a bit (e.g. 4 seconds) > * seed the

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req lslebodn commented: """ Regression test for https://fedorahosted.org/sssd/ticket/2865 failed or it was https://fedorahosted.org/sssd/ticket/2170 Following C-code was executed for existing and

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req lslebodn commented: """ There is also a crash for group enumeration ``` (Wed Nov 30 09:22:36 2016) [sssd[nss]] [cache_req_search_done] (0x0400): CR #0: Returning updated object [Groups

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req lslebodn commented: """ There is a simple domain config with case_preserving ``` [domain/LDAP] id_provider = ldap ldap_uri = ldap://$SERVER ldap_search_base =

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req lslebodn commented: """ SSS_SEED user offline authentication failed: * block access to the ldap * sleep a bit (e.g. 4 seconds) * seed the SSSD cache with a user: sss_seed -D LDAP -n seeduser -u

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req pbrezina commented: """ Hi, thank you for testing. All mentioned above is hopefully fixed, except the "Identical request is in progress". I am unable to reproduce this and I'm surprised that

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req lslebodn commented: """ and I will check rest of ldap + AD related tests tomorrow. """ See the full comment at https://github.com/SSSD/sssd/pull/89#issuecomment-263641880

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req lslebodn commented: """ Few multi domain tests failed: The first one was related to enumeration. Other failures probably as well. ``` [sssd domains = LOCAL,LDAP services = nss, pam [nss]

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req lslebodn commented: """ One netgroupt test failed: Decrease the cache time out and add new entry for nisNetgroupTriple ``` echo "entry_cache_timeout = 60" >> /etc/sssd/sssd.conf // clear cache

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req lslebodn commented: """ Regression test for ticket https://fedorahosted.org/sssd/ticket/1229 failed. ``` > /var/log/sssd/sssd_nss.log" // clear case and restart sssd kill -STOP `pidof sssd_be`"

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req lslebodn commented: """ There is a Wformat-security warning and therefore mock build failed on fedora ``` src/db/sysdb_ops.c: In function ‘sysdb_search_object_attr’: src/db/sysdb_ops.c:4503:22:

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req pbrezina commented: """ Hi, thank you. I fixed those issues. """ See the full comment at https://github.com/SSSD/sssd/pull/89#issuecomment-262944217

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req spbnick commented: """ In general it is good to submit your patchset to CI with the tag "each", to have each patch tested (instead of only the last one), and catch this kind of thing. """

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req lslebodn commented: """ The 1st patch broke `nss-srv-tests` and therefore all following commits does not pass CI. ``` Subject:nss: move nss_ctx->global_names to rctx Hash:

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req lslebodn commented: """ and other warnings from static analyzers ``` Error: NULL_RETURNS (CWE-476): [#def42] sssd-1.14.90/src/util/sss_ptr_hash.c:302: returned_null:

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req lslebodn commented: """ Congratulation you broke integration tests on all distributions. ``` ldap_local_override_test.py::test_regr_2790_override FAILED