On 01/07/2014 04:53 PM, Jakub Hrozek wrote:
On Tue, Jan 07, 2014 at 03:31:50PM +0200, Nikolai Kondrashov wrote:
On 01/07/2014 02:33 PM, Jakub Hrozek wrote:
[PATCH 3/8] Remove extra flushing from debug message output
The code is fine, but why is it a separate patch and not part of #2 ? It
seems
On Tue, Jan 07, 2014 at 03:31:50PM +0200, Nikolai Kondrashov wrote:
> Hi Jakub,
>
> Thanks a lot for reviewing!
>
> On 01/07/2014 02:33 PM, Jakub Hrozek wrote:
> >I spoke about the same problem with Simo (or Stephen? Sorry, I forgot
> >over holidays) and it seems my opinion is in minority so I wo
Hi Jakub,
Thanks a lot for reviewing!
On 01/07/2014 02:33 PM, Jakub Hrozek wrote:
I spoke about the same problem with Simo (or Stephen? Sorry, I forgot
over holidays) and it seems my opinion is in minority so I won't block
the patchset over it.
I have some very minor comments about the patches
On Wed, Dec 25, 2013 at 02:10:20AM +0200, Nikolai Kondrashov wrote:
> On 12/23/2013 01:42 PM, Jakub Hrozek wrote:
> >On Sun, Dec 22, 2013 at 11:23:58AM +0200, Nikolai Kondrashov wrote:
> >>
> >> 1. There are 2273 uses of the old levels, *half* of all DEBUG macro
> >>invocations, so upda
On 12/23/2013 01:42 PM, Jakub Hrozek wrote:
On Sun, Dec 22, 2013 at 11:23:58AM +0200, Nikolai Kondrashov wrote:
1. There are 2273 uses of the old levels, *half* of all DEBUG macro
invocations, so updating them on occasion will take a *long* time.
2. Code is more often read tha
On Sun, Dec 22, 2013 at 11:23:58AM +0200, Nikolai Kondrashov wrote:
> On 12/21/2013 08:47 PM, Lukas Slebodnik wrote:
> >On (20/12/13 18:15), Nikolai Kondrashov wrote:
> >>Hi everyone,
> >>
> >>Please find attached the third version of the DEBUG macro refactoring
> >>patchset. The second version was
On 12/21/2013 08:47 PM, Lukas Slebodnik wrote:
On (20/12/13 18:15), Nikolai Kondrashov wrote:
Hi everyone,
Please find attached the third version of the DEBUG macro refactoring
patchset. The second version was lost to the maillist message size limit, so
I'll list the changes from the first one:
On (20/12/13 18:15), Nikolai Kondrashov wrote:
>Hi everyone,
>
>Please find attached the third version of the DEBUG macro refactoring
>patchset. The second version was lost to the maillist message size limit, so
>I'll list the changes from the first one:
>
>* level limiting condition moved to t
Hi Stephen,
Thanks for the review! Replies below.
On 12/20/2013 09:31 PM, Stephen Gallagher wrote:
I'd rather that 0005 and 0006 be squashed together and that the comment
be written as follows:
{{{
Make DEBUG macro invocations variadic
Use a script to update DEBUG macro invocations to use it
On 12/20/2013 09:43 PM, Stephen Gallagher wrote:
Actually, minor Nack on 0008:
#define DEBUG(level, format, ...) do { \
- -int __debug_macro_newlevel = debug_get_level(level); \
- -if (DEBUG_IS_SET(__debug_macro_newlevel)) \
- -debug_fn(__FUNCTION__, __debug_macro_newlevel, for
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 12/20/2013 02:31 PM, Stephen Gallagher wrote:
> On 12/20/2013 11:15 AM, Nikolai Kondrashov wrote:
>> Hi everyone,
>
>> Please find attached the third version of the DEBUG macro
>> refactoring patchset. The second version was lost to the
>> maillis
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 12/20/2013 11:15 AM, Nikolai Kondrashov wrote:
> Hi everyone,
>
> Please find attached the third version of the DEBUG macro
> refactoring patchset. The second version was lost to the maillist
> message size limit, so I'll list the changes from the
12 matches
Mail list logo
