Re: [SSSD] Do not start multiple backends for the same domain

2014-02-09 Thread Jakub Hrozek
On Sun, 2014-02-09 at 06:09 -0500, Stephen Gallagher wrote: > Hello, > > thank for quick review. Fixed patch is attached. > > > > > Ack Pushed to master. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/

Re: [SSSD] Do not start multiple backends for the same domain

2014-02-09 Thread Stephen Gallagher
- Original Message - From: "Pavel Reichl" To: sssd-devel@lists.fedorahosted.org Sent: Thursday, February 6, 2014 5:22:42 PM Subject: Re: [SSSD] Do not start multiple backends for the same domain On Thu, 2014-02-06 at 17:08 +0100, Stephen Gallagher wrote: > On 02/06/2014 04

Re: [SSSD] Do not start multiple backends for the same domain

2014-02-06 Thread Pavel Reichl
On Thu, 2014-02-06 at 17:08 +0100, Stephen Gallagher wrote: > On 02/06/2014 04:50 PM, Pavel Reichl wrote: > > Hello, > > > > in another thread Stephen Gallagher asked me to use static string > > to avoid code duplication. I've considered same thing for this > > patch in previous mail but probably

Re: [SSSD] Do not start multiple backends for the same domain

2014-02-06 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/06/2014 04:50 PM, Pavel Reichl wrote: > Hello, > > in another thread Stephen Gallagher asked me to use static string > to avoid code duplication. I've considered same thing for this > patch in previous mail but probably nobody noticed. > > So I

Re: [SSSD] Do not start multiple backends for the same domain

2014-02-06 Thread Pavel Reichl
Hello, in another thread Stephen Gallagher asked me to use static string to avoid code duplication. I've considered same thing for this patch in previous mail but probably nobody noticed. So I did it now. Please see new patch. PR >From b3f17ef73fe57fa832db351ecc3cf670c05b36cf Mon Sep 17 00:00:0

Re: [SSSD] Do not start multiple backends for the same domain

2014-01-20 Thread Pavel Reichl
On Mon, 2014-01-20 at 18:07 +0100, Pavel Reichl wrote: > On Fri, 2014-01-17 at 19:47 +0100, Jakub Hrozek wrote: > > On Fri, Jan 17, 2014 at 03:40:35PM +0100, Pavel Reichl wrote: > > > +DEBUG(SSSDBG_FATAL_FAILURE, > > > + ("Domain '%s' has too similar name to dom

Re: [SSSD] Do not start multiple backends for the same domain

2014-01-20 Thread Pavel Reichl
On Fri, 2014-01-17 at 19:47 +0100, Jakub Hrozek wrote: > On Fri, Jan 17, 2014 at 03:40:35PM +0100, Pavel Reichl wrote: > > +DEBUG(SSSDBG_FATAL_FAILURE, > > + ("Domain '%s' has too similar name to domain > > '%s'.\n", > > + domlist[i], doma

Re: [SSSD] Do not start multiple backends for the same domain

2014-01-17 Thread Jakub Hrozek
On Fri, Jan 17, 2014 at 03:40:35PM +0100, Pavel Reichl wrote: > +DEBUG(SSSDBG_FATAL_FAILURE, > + ("Domain '%s' has too similar name to domain '%s'.\n", > + domlist[i], domain->name)); > +sss_log(SSS_LOG_CRIT, > +

Re: [SSSD] Do not start multiple backends for the same domain

2014-01-17 Thread Pavel Reichl
On Thu, 2014-01-16 at 12:19 -0500, Stephen Gallagher wrote: > On 01/16/2014 12:11 PM, Pavel Reichl wrote: > > Hello, > > > > please see attached patch. > > > > I'd prefer if this was logged as a fatal failure (and logged to > syslog) and then failed to start up. Ignoring it silently may lead to

Re: [SSSD] Do not start multiple backends for the same domain

2014-01-16 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/16/2014 12:11 PM, Pavel Reichl wrote: > Hello, > > please see attached patch. > I'd prefer if this was logged as a fatal failure (and logged to syslog) and then failed to start up. Ignoring it silently may lead to domains being checked in inco

[SSSD] Do not start multiple backends for the same domain

2014-01-16 Thread Pavel Reichl
Hello, please see attached patch. PR >From c5ad372278d36199c7d3baa2d66cd25dcb2c366b Mon Sep 17 00:00:00 2001 From: Pavel Reichl Date: Thu, 16 Jan 2014 16:43:19 + Subject: [PATCH] CONFDB: omit domains with same name Omit domains given in the domains option which are the same or only differ i