Re: [SSSD] PATCH] Add userdel_cmd param

2010-04-06 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/01/2010 07:48 AM, Stephen Gallagher wrote: > On 04/01/2010 03:44 AM, Jakub Hrozek wrote: >> On 03/31/2010 08:58 PM, Stephen Gallagher wrote: >>> Nack. > >>> You can't return WTERMSIG(status) or WSTOPSIG(status), you're mixing >>> them with errno

Re: [SSSD] PATCH] Add userdel_cmd param

2010-04-01 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/01/2010 03:44 AM, Jakub Hrozek wrote: > On 03/31/2010 08:58 PM, Stephen Gallagher wrote: >> Nack. > >> You can't return WTERMSIG(status) or WSTOPSIG(status), you're mixing >> them with errno return codes. > > > > Ah, correct, thank you. Ack

Re: [SSSD] PATCH] Add userdel_cmd param

2010-04-01 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/31/2010 08:58 PM, Stephen Gallagher wrote: > Nack. > > You can't return WTERMSIG(status) or WSTOPSIG(status), you're mixing > them with errno return codes. > > Ah, correct, thank you. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/

Re: [SSSD] PATCH] Add userdel_cmd param

2010-03-31 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/24/2010 09:49 AM, Jakub Hrozek wrote: > On 03/23/2010 01:10 PM, Simo Sorce wrote: >> On Tue, 23 Mar 2010 11:59:22 +0100 >> Jakub Hrozek wrote: > >>> + >>> +cmd = talloc_asprintf(tctx, "%s %s", userdel_cmd, >>> +

Re: [SSSD] PATCH] Add userdel_cmd param

2010-03-24 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/23/2010 01:10 PM, Simo Sorce wrote: > On Tue, 23 Mar 2010 11:59:22 +0100 > Jakub Hrozek wrote: > >> + >> +cmd = talloc_asprintf(tctx, "%s %s", userdel_cmd, >> + tctx->octx->name); >> +if (!cmd) {

Re: [SSSD] PATCH] Add userdel_cmd param

2010-03-23 Thread Simo Sorce
On Tue, 23 Mar 2010 11:59:22 +0100 Jakub Hrozek wrote: > + > +cmd = talloc_asprintf(tctx, "%s %s", userdel_cmd, > + tctx->octx->name); > +if (!cmd) { Nack, if you do it this way you must shell escape the username. It's probably better to use fork/

[SSSD] PATCH] Add userdel_cmd param

2010-03-23 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Fixes: #229 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkuonwoACgkQHsardTLnvCXcnACfXxDzhq5vU2vuQUJhSZobMf5z 7A8AoOhznVpfQgciV0Q7VjNhSfNPooAf =haVk -EN