[SSSD] Re: [PATCH] Pavel's sssctl work

2016-06-27 Thread Jakub Hrozek
On Mon, Jun 27, 2016 at 06:05:50PM +0200, Jakub Hrozek wrote: > On Mon, Jun 27, 2016 at 01:26:09PM +0200, Pavel Březina wrote: > > Turned out I sent wrong patches. > > > > Thank you, Coverity came back clean, CI passed as well: > http://sssd-ci.duckdns.org/logs/job/46/13/summary.html > I did

[SSSD] Re: [PATCH] Pavel's sssctl work

2016-06-27 Thread Jakub Hrozek
On Mon, Jun 27, 2016 at 01:26:09PM +0200, Pavel Březina wrote: > Turned out I sent wrong patches. > Thank you, Coverity came back clean, CI passed as well: http://sssd-ci.duckdns.org/logs/job/46/13/summary.html I did some more manual testing (because there are no tests so far..) and found:

[SSSD] Re: [PATCH] Pavel's sssctl work

2016-06-24 Thread Lukas Slebodnik
On (24/06/16 13:07), Pavel Březina wrote: >On 06/23/2016 08:14 PM, Jakub Hrozek wrote: >> On Thu, Jun 23, 2016 at 01:51:53PM +0200, Jakub Hrozek wrote: >> > > Change to src/lib/sifp/sss_simpleifp.exports is wrong. >> > > Current version: >> > > We cannot add new function to already released

[SSSD] Re: [PATCH] Pavel's sssctl work

2016-06-24 Thread Pavel Březina
On 06/23/2016 08:14 PM, Jakub Hrozek wrote: On Thu, Jun 23, 2016 at 01:51:53PM +0200, Jakub Hrozek wrote: Change to src/lib/sifp/sss_simpleifp.exports is wrong. Current version: We cannot add new function to already released version They shoudl be added to new version. @see attached diff diff

[SSSD] Re: [PATCH] Pavel's sssctl work

2016-06-24 Thread Michal Židek
On 06/23/2016 08:14 PM, Jakub Hrozek wrote: On Thu, Jun 23, 2016 at 01:51:53PM +0200, Jakub Hrozek wrote: Change to src/lib/sifp/sss_simpleifp.exports is wrong. Current version: We cannot add new function to already released version They shoudl be added to new version. @see attached diff diff

[SSSD] Re: [PATCH] Pavel's sssctl work

2016-06-23 Thread Jakub Hrozek
On Thu, Jun 23, 2016 at 01:40:50PM +0200, Lukas Slebodnik wrote: > On (23/06/16 13:23), Jakub Hrozek wrote: > >On Wed, Jun 22, 2016 at 03:23:28PM +0200, Jakub Hrozek wrote: > >> On Tue, Jun 21, 2016 at 04:44:05PM +0200, Jakub Hrozek wrote: > >> > On Tue, Jun 21, 2016 at 04:15:06PM +0200, Pavel

[SSSD] Re: [PATCH] Pavel's sssctl work

2016-06-23 Thread Lukas Slebodnik
On (23/06/16 13:23), Jakub Hrozek wrote: >On Wed, Jun 22, 2016 at 03:23:28PM +0200, Jakub Hrozek wrote: >> On Tue, Jun 21, 2016 at 04:44:05PM +0200, Jakub Hrozek wrote: >> > On Tue, Jun 21, 2016 at 04:15:06PM +0200, Pavel Březina wrote: >> > > On 06/21/2016 03:50 PM, Jakub Hrozek wrote: >> > > >

[SSSD] Re: [PATCH] Pavel's sssctl work

2016-06-22 Thread Jakub Hrozek
On Tue, Jun 21, 2016 at 04:44:05PM +0200, Jakub Hrozek wrote: > On Tue, Jun 21, 2016 at 04:15:06PM +0200, Pavel Březina wrote: > > On 06/21/2016 03:50 PM, Jakub Hrozek wrote: > > > On Mon, Jun 20, 2016 at 07:13:10PM +0200, Jakub Hrozek wrote: > > > > Hi, > > > > > > > > Pavel's sssctl tool is at:

[SSSD] Re: [PATCH] Pavel's sssctl work

2016-06-21 Thread Pavel Březina
On 06/21/2016 04:40 PM, Jakub Hrozek wrote: On Tue, Jun 21, 2016 at 04:10:41PM +0200, Jakub Hrozek wrote: On Tue, Jun 21, 2016 at 03:50:17PM +0200, Jakub Hrozek wrote: On Mon, Jun 20, 2016 at 07:13:10PM +0200, Jakub Hrozek wrote: Hi, Pavel's sssctl tool is at:

[SSSD] Re: [PATCH] Pavel's sssctl work

2016-06-21 Thread Jakub Hrozek
On Tue, Jun 21, 2016 at 04:15:06PM +0200, Pavel Březina wrote: > On 06/21/2016 03:50 PM, Jakub Hrozek wrote: > > On Mon, Jun 20, 2016 at 07:13:10PM +0200, Jakub Hrozek wrote: > > > Hi, > > > > > > Pavel's sssctl tool is at: > > > > > >

[SSSD] Re: [PATCH] Pavel's sssctl work

2016-06-21 Thread Jakub Hrozek
On Tue, Jun 21, 2016 at 04:10:41PM +0200, Jakub Hrozek wrote: > On Tue, Jun 21, 2016 at 03:50:17PM +0200, Jakub Hrozek wrote: > > On Mon, Jun 20, 2016 at 07:13:10PM +0200, Jakub Hrozek wrote: > > > Hi, > > > > > > Pavel's sssctl tool is at: > > > > > >

[SSSD] Re: [PATCH] Pavel's sssctl work

2016-06-21 Thread Pavel Březina
On 06/21/2016 03:50 PM, Jakub Hrozek wrote: On Mon, Jun 20, 2016 at 07:13:10PM +0200, Jakub Hrozek wrote: Hi, Pavel's sssctl tool is at: https://fedorapeople.org/cgit/pbrezina/public_git/sssd.git/log/?h=sssctl I'll try to have a first pass at review today in the evening, but I thought

[SSSD] Re: [PATCH] Pavel's sssctl work

2016-06-21 Thread Jakub Hrozek
On Tue, Jun 21, 2016 at 03:50:17PM +0200, Jakub Hrozek wrote: > On Mon, Jun 20, 2016 at 07:13:10PM +0200, Jakub Hrozek wrote: > > Hi, > > > > Pavel's sssctl tool is at: > > https://fedorapeople.org/cgit/pbrezina/public_git/sssd.git/log/?h=sssctl > > > > I'll try to have a first pass at

[SSSD] Re: [PATCH] Pavel's sssctl work

2016-06-21 Thread Jakub Hrozek
On Mon, Jun 20, 2016 at 07:13:10PM +0200, Jakub Hrozek wrote: > Hi, > > Pavel's sssctl tool is at: > https://fedorapeople.org/cgit/pbrezina/public_git/sssd.git/log/?h=sssctl > > I'll try to have a first pass at review today in the evening, but I > thought I'll pass on the branch in case