[SSSD] Re: [PATCH] ini_augment: Use full path when reporting pattern mismatch

2016-09-13 Thread Michal Židek
On 09/13/2016 04:53 PM, Lukas Slebodnik wrote: On (01/09/16 17:35), Michal Židek wrote: On 09/01/2016 05:26 PM, Dmitri Pal wrote: Hello, I do not like either of the versions of the patch. It is OK to use path_concat instead of snprintf. The whole point of not using it was to simplify the code

[SSSD] Re: [PATCH] ini_augment: Use full path when reporting pattern mismatch

2016-09-13 Thread Lukas Slebodnik
On (01/09/16 17:35), Michal Židek wrote: >On 09/01/2016 05:26 PM, Dmitri Pal wrote: >> Hello, >> >> I do not like either of the versions of the patch. >> It is OK to use path_concat instead of snprintf. The whole point of not >> using it was to simplify the code and not have to check yet another

[SSSD] Re: [PATCH] ini_augment: Use full path when reporting pattern mismatch

2016-09-01 Thread Michal Židek
On 09/01/2016 05:26 PM, Dmitri Pal wrote: Hello, I do not like either of the versions of the patch. It is OK to use path_concat instead of snprintf. The whole point of not using it was to simplify the code and not have to check yet another error clause. But using path_concat is fine. The thing

[SSSD] Re: [PATCH] ini_augment: Use full path when reporting pattern mismatch

2016-09-01 Thread Dmitri Pal
Hello, I do not like either of the versions of the patch. It is OK to use path_concat instead of snprintf. The whole point of not using it was to simplify the code and not have to check yet another error clause. But using path_concat is fine. The thing that I do not like is that in the current

[SSSD] Re: [PATCH] ini_augment: Use full path when reporting pattern mismatch

2016-09-01 Thread Lukas Slebodnik
On (01/09/16 14:28), Michal Židek wrote: >On 09/01/2016 02:13 PM, Lukas Slebodnik wrote: >> On (01/09/16 13:15), Michal Židek wrote: >> > Hi, >> > >> > see the attached ding-libs patch for ticket #3166. >> > >> > This is how sssctl config-check prints the merging >> > issues without this patch:

[SSSD] Re: [PATCH] ini_augment: Use full path when reporting pattern mismatch

2016-09-01 Thread Lukas Slebodnik
On (01/09/16 13:15), Michal Židek wrote: >Hi, > >see the attached ding-libs patch for ticket #3166. > >This is how sssctl config-check prints the merging >issues without this patch: > >Messages generated during configuration merging: 2 >File blaa did not match provided patterns. Skipping. >File