[SSSD] Re: [PATCH] sudo: use cache_req interface

2016-04-19 Thread Lukas Slebodnik
On (19/04/16 11:24), Jakub Hrozek wrote: >On Tue, Apr 19, 2016 at 10:59:20AM +0200, Pavel Březina wrote: >> On 04/19/2016 09:59 AM, Lukas Slebodnik wrote: >> > On (01/03/16 13:53), Pavel Březina wrote: >> > > On 02/25/2016 02:08 PM, Jakub Hrozek wrote: >> > > > On Tue, Feb 09, 2016 at 02:07:21PM +0

[SSSD] Re: [PATCH] sudo: use cache_req interface

2016-04-19 Thread Jakub Hrozek
On Tue, Apr 19, 2016 at 10:59:20AM +0200, Pavel Březina wrote: > On 04/19/2016 09:59 AM, Lukas Slebodnik wrote: > > On (01/03/16 13:53), Pavel Březina wrote: > > > On 02/25/2016 02:08 PM, Jakub Hrozek wrote: > > > > On Tue, Feb 09, 2016 at 02:07:21PM +0100, Pavel Březina wrote: > > > > > First of t

[SSSD] Re: [PATCH] sudo: use cache_req interface

2016-04-19 Thread Pavel Březina
On 04/19/2016 09:59 AM, Lukas Slebodnik wrote: On (01/03/16 13:53), Pavel Březina wrote: On 02/25/2016 02:08 PM, Jakub Hrozek wrote: On Tue, Feb 09, 2016 at 02:07:21PM +0100, Pavel Březina wrote: First of the responders is converted -) Sorry for the first delay in review. Before reading the

[SSSD] Re: [PATCH] sudo: use cache_req interface

2016-04-19 Thread Lukas Slebodnik
On (01/03/16 13:53), Pavel Březina wrote: >On 02/25/2016 02:08 PM, Jakub Hrozek wrote: >>On Tue, Feb 09, 2016 at 02:07:21PM +0100, Pavel Březina wrote: >>>First of the responders is converted -) >> >>Sorry for the first delay in review. Before reading the code, I >>submitted the patches to automate

[SSSD] Re: [PATCH] sudo: use cache_req interface

2016-04-12 Thread Jakub Hrozek
On Fri, Apr 08, 2016 at 01:05:54PM +0200, Jakub Hrozek wrote: > On Fri, Apr 08, 2016 at 12:15:25PM +0200, Pavel Březina wrote: > > On 03/01/2016 01:53 PM, Pavel Březina wrote: > > >On 02/25/2016 02:08 PM, Jakub Hrozek wrote: > > >>On Tue, Feb 09, 2016 at 02:07:21PM +0100, Pavel Březina wrote: > > >

[SSSD] Re: [PATCH] sudo: use cache_req interface

2016-04-08 Thread Jakub Hrozek
On Fri, Apr 08, 2016 at 12:15:25PM +0200, Pavel Březina wrote: > On 03/01/2016 01:53 PM, Pavel Březina wrote: > >On 02/25/2016 02:08 PM, Jakub Hrozek wrote: > >>On Tue, Feb 09, 2016 at 02:07:21PM +0100, Pavel Březina wrote: > >>>First of the responders is converted -) > >> > >>Sorry for the first d

[SSSD] Re: [PATCH] sudo: use cache_req interface

2016-04-08 Thread Pavel Březina
On 03/01/2016 01:53 PM, Pavel Březina wrote: On 02/25/2016 02:08 PM, Jakub Hrozek wrote: On Tue, Feb 09, 2016 at 02:07:21PM +0100, Pavel Březina wrote: First of the responders is converted -) Sorry for the first delay in review. Before reading the code, I submitted the patches to automated te

[SSSD] Re: [PATCH] sudo: use cache_req interface

2016-03-01 Thread Pavel Březina
On 02/25/2016 02:08 PM, Jakub Hrozek wrote: On Tue, Feb 09, 2016 at 02:07:21PM +0100, Pavel Březina wrote: First of the responders is converted -) Sorry for the first delay in review. Before reading the code, I submitted the patches to automated tests, so far I found: Error: COMPILER_WARNING:

[SSSD] Re: [PATCH] sudo: use cache_req interface

2016-02-25 Thread Jakub Hrozek
On Tue, Feb 09, 2016 at 02:07:21PM +0100, Pavel Březina wrote: > First of the responders is converted -) Sorry for the first delay in review. Before reading the code, I submitted the patches to automated tests, so far I found: Error: COMPILER_WARNING: sssd-1.13.90/src/responder/sudo/sudosrv_get_s