-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 04/10/2013 08:23 AM, Jakub Hrozek wrote:
> On Tue, Apr 09, 2013 at 12:13:44AM +0200, Jakub Hrozek wrote:
>> On Tue, Apr 09, 2013 at 03:32:04AM +0530, Abhishek Singh wrote:
>>> Hi Jakub,
>>>
>>> Please check this patch.
>>>
>>
>> Ack with a one ch
On Tue, Apr 09, 2013 at 12:13:44AM +0200, Jakub Hrozek wrote:
> On Tue, Apr 09, 2013 at 03:32:04AM +0530, Abhishek Singh wrote:
> > Hi Jakub,
> >
> > Please check this patch.
> >
>
> Ack with a one change I can do myself before pushing, no need to
> re-send:
>
> I would prefer if the get_filepa
On Tue, Apr 09, 2013 at 03:32:04AM +0530, Abhishek Singh wrote:
> Hi Jakub,
>
> Please check this patch.
>
Ack with a one change I can do myself before pushing, no need to
re-send:
I would prefer if the get_filepath declaration didn't hardcode the array
size, but rather looked like:
static cha
Hi Jakub,
Please check this patch.
On Tue, Apr 9, 2013 at 3:16 AM, Jakub Hrozek wrote:
> On Tue, Apr 09, 2013 at 03:13:20AM +0530, Abhishek Singh wrote:
> > Hi Jakub,
> >
> > >You should also pass PATH_MAX-1 not PATH_MAX as the third argument of
> > >snprintf, otherwise you risk a off-by-one e
On Tue, Apr 09, 2013 at 03:13:20AM +0530, Abhishek Singh wrote:
> Hi Jakub,
>
> >You should also pass PATH_MAX-1 not PATH_MAX as the third argument of
> >snprintf, otherwise you risk a off-by-one error in case the buffers had
> >the same length.
>
> snprintf ? Do you mean strncpy instead of inste
Hi Jakub,
>You should also pass PATH_MAX-1 not PATH_MAX as the third argument of
>snprintf, otherwise you risk a off-by-one error in case the buffers had
>the same length.
snprintf ? Do you mean strncpy instead of instead of snprintf? since I
haven't used snprintf in my code.
On Tue, Apr 9, 201
On Fri, Apr 05, 2013 at 06:34:45PM +0530, Abhishek Singh wrote:
> Hi Jakub,
>
> I have made necessary changes, please review it.
>
> thanks,
>
Hi Abhishek,
the test compiles and runs fine, the patches apply cleanly on top of one
another and the teardown function is used cleanly.
I only have o
Hi Jakub,
I have made necessary changes, please review it.
thanks,
On Fri, Apr 5, 2013 at 4:09 AM, Jakub Hrozek wrote:
> On Thu, Apr 04, 2013 at 02:44:47AM +0530, Abhishek Singh wrote:
> > Hi Jakub,
> >
> > I have done requested changes and have attached the patch with this mail.
> > Kindly r
On Thu, Apr 04, 2013 at 02:44:47AM +0530, Abhishek Singh wrote:
> Hi Jakub,
>
> I have done requested changes and have attached the patch with this mail.
> Kindly review it.
>
> thanks,
>
>
Hi Abhishek,
this is much better and we're almost there. I only have a couple of
comments before I push
Hi Jakub,
I have done requested changes and have attached the patch with this mail.
Kindly review it.
thanks,
On Wed, Mar 27, 2013 at 6:37 PM, Simo Sorce wrote:
> On Wed, 2013-03-27 at 10:25 +0100, Jakub Hrozek wrote:
> > On Wed, Mar 27, 2013 at 09:39:53AM +0100, Jakub Hrozek wrote:
> > > On
On Wed, 2013-03-27 at 10:25 +0100, Jakub Hrozek wrote:
> On Wed, Mar 27, 2013 at 09:39:53AM +0100, Jakub Hrozek wrote:
> > On Tue, Mar 26, 2013 at 10:39:42PM +0100, Jakub Hrozek wrote:
> > > > From b9f90d1313b91fb7213b006b4efaaf6c50568e26 Mon Sep 17 00:00:00 2001
> > > > From: Abhishek Singh
> > >
On Wed, Mar 27, 2013 at 09:39:53AM +0100, Jakub Hrozek wrote:
> On Tue, Mar 26, 2013 at 10:39:42PM +0100, Jakub Hrozek wrote:
> > > From b9f90d1313b91fb7213b006b4efaaf6c50568e26 Mon Sep 17 00:00:00 2001
> > > From: Abhishek Singh
> > > Date: Sat, 23 Mar 2013 01:47:23 +0530
> > > Subject: [PATCH] f
On Tue, Mar 26, 2013 at 10:39:42PM +0100, Jakub Hrozek wrote:
> > From b9f90d1313b91fb7213b006b4efaaf6c50568e26 Mon Sep 17 00:00:00 2001
> > From: Abhishek Singh
> > Date: Sat, 23 Mar 2013 01:47:23 +0530
> > Subject: [PATCH] filename in comment is corrected
> >
> > ---
> > src/util/io.c | 2 +-
>
On Sat, Mar 23, 2013 at 01:49:26AM +0530, Abhishek Singh wrote:
> patches attached.
>
Hello Abhishek,
in general the tests look good to me, thank you! I only have a couple of
nitpicks now. See inline.
> From 2f3281a7b0af9f4a5f53dec0b911b024251ad828 Mon Sep 17 00:00:00 2001
> From: Abhishek Sing
patches attached.
On Sat, Mar 23, 2013 at 12:46 AM, Abhishek Singh <
abhishekkumarsingh@gmail.com> wrote:
> combined unit test patch for find_uid and io added.
>
>
> On Sat, Mar 23, 2013 at 12:17 AM, Abhishek Singh <
> abhishekkumarsingh@gmail.com> wrote:
>
>> changes done.
>>
>>
>> On S
combined unit test patch for find_uid and io added.
On Sat, Mar 23, 2013 at 12:17 AM, Abhishek Singh <
abhishekkumarsingh@gmail.com> wrote:
> changes done.
>
>
> On Sat, Mar 23, 2013 at 12:07 AM, Stephen Gallagher
> wrote:
>
>> -BEGIN PGP SIGNED MESSAGE-
>> Hash: SHA1
>>
>> On 03/22
changes done.
On Sat, Mar 23, 2013 at 12:07 AM, Stephen Gallagher wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On 03/22/2013 02:33 PM, Abhishek Singh wrote:
> > New tests added to success tests. Please review it.
> >
>
> Almost :)
>
> You can't just test for integer equivalence,
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 03/22/2013 02:33 PM, Abhishek Singh wrote:
> New tests added to success tests. Please review it.
>
Almost :)
You can't just test for integer equivalence, because it's conceivable
that there may be other flags returned beyond just the FD_CLOEXEC f
New tests added to success tests.
Please review it.
Thanks,
On Fri, Mar 22, 2013 at 4:48 PM, Stephen Gallagher wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On Fri 22 Mar 2013 04:32:52 AM EDT, Abhishek Singh wrote:
> >
> > Hi,
> >
> > I have attached a patch that contains cmocka
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On Fri 22 Mar 2013 04:32:52 AM EDT, Abhishek Singh wrote:
>
> Hi,
>
> I have attached a patch that contains cmocka unittest for io.c .
> Kindly review it.
>
This is a good start, but I'd like to see some more comprehensive
tests. In the success t
Hi,
I have attached a patch that contains cmocka unittest for io.c . Kindly
review it.
thanks
On Tue, Mar 19, 2013 at 12:52 AM, Jakub Hrozek wrote:
> On Tue, Mar 19, 2013 at 12:31:09AM +0530, Abhishek Singh wrote:
> > Changes done.
> >
> > My public repo of sssd : https://github.com/AbhishekK
On Tue, Mar 19, 2013 at 12:31:09AM +0530, Abhishek Singh wrote:
> Changes done.
>
> My public repo of sssd : https://github.com/AbhishekKumarSingh/sssd
>
Hi Abhishek,
this is much better, thank you!
I only have two minor style nitpicks now:
1) void test_check_if_uid_is_active_success(void ** s
On Tue, 2013-03-19 at 00:31 +0530, Abhishek Singh wrote:
> Changes done.
>
>
> My public repo of sssd : https://github.com/AbhishekKumarSingh/sssd
>
Thanks Abhishek,
in the futurte can you send the patch attached as type text/plain,
apparently you are sending it as application/octet-stream and
Changes done.
My public repo of sssd : https://github.com/AbhishekKumarSingh/sssd
On Mon, Mar 18, 2013 at 7:02 PM, Stephen Gallagher wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On 03/18/2013 09:17 AM, Abhishek Singh wrote:
> > Hi Jackub,
> >
> > I have attached a patch. Kindly
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 03/18/2013 09:17 AM, Abhishek Singh wrote:
> Hi Jackub,
>
> I have attached a patch. Kindly check it.
>
> thanks,
>
An excellent start, Abhishek!
I have a few comments (mostly style):
Please make sure to maintain the same whitespace that was
Hi Jackub,
I have attached a patch. Kindly check it.
thanks,
On Mon, Mar 18, 2013 at 6:23 PM, Abhishek Singh <
abhishekkumarsingh@gmail.com> wrote:
> Hi Jackub,
>
> I have attached cmocka test for 'find_uid.c' and coverage report. Kindly
> review it.
>
> thanks,
> Abhishek
>
>
> On Wed, Ma
Hi Jackub,
I have attached cmocka test for 'find_uid.c' and coverage report. Kindly
review it.
thanks,
Abhishek
On Wed, Mar 6, 2013 at 1:36 AM, Abhishek Singh <
abhishekkumarsingh@gmail.com> wrote:
> Hi Jackub,
>
> May be you can include the attached file here
> http://jhrozek.fedorapeople
Hi Jackub,
May be you can include the attached file here
http://jhrozek.fedorapeople.org/cmocka/
It's an example showing complete mocking of rect.c interface.
thanks,
Abhishek
On Thu, Feb 28, 2013 at 3:10 PM, Jakub Hrozek wrote:
> On Thu, Feb 28, 2013 at 01:17:41AM +0530, Abhishek Singh wrote
On Thu, Feb 28, 2013 at 01:17:41AM +0530, Abhishek Singh wrote:
> Hi All,
>
> This is Abhishek Kumar Singh. I want to apply for Gsoc this year. I have
> sound Knowledge of C, C++, Python, bash script, pytest, unit testing
> framework, code coverage. Currently am learning cmocka unit testing
>
> I
Hi All,
This is Abhishek Kumar Singh. I want to apply for Gsoc this year. I have
sound Knowledge of C, C++, Python, bash script, pytest, unit testing
framework, code coverage. Currently am learning cmocka unit testing
I will start with the idea "SSSD Test Suite Coverage" as a part of my Gsoc
2013
30 matches
Mail list logo
