Re: [SSSD] [PATCH] Add support for offline auth cache timeout

2009-10-20 Thread Simo Sorce
On Tue, 2009-10-20 at 16:13 -0400, Stephen Gallagher wrote: On 10/20/2009 12:19 PM, Sumit Bose wrote: On Tue, Oct 20, 2009 at 11:15:52AM -0400, Stephen Gallagher wrote: On 10/20/2009 10:37 AM, Stephen Gallagher wrote: This patch addresses: https://fedorahosted.org/sssd/ticket/60 This

Re: [SSSD] [PATCH] New option code for krb5 and ipa auth

2009-10-21 Thread Simo Sorce
On Tue, 2009-10-20 at 14:24 +0200, Sumit Bose wrote: + +dummy = dp_opt_get_cstring(opts, KRB5_CCNAME_TMPL); +if (dummy[0] != '/' strncmp(dummy, FILE:, 5) != 0) { +DEBUG(1, (Currently only file based credential caches are supported + and krb5ccname_template

Re: [SSSD] [PATCH] New option code for krb5 and ipa auth

2009-10-21 Thread Simo Sorce
On Tue, 2009-10-20 at 14:24 +0200, Sumit Bose wrote: +dummy = dp_opt_get_cstring(opts, KRB5_CHANGEPW_PRINC); +if (strchr(dummy, '@') == NULL) { +value = talloc_asprintf(opts, %...@%s, dummy, realm); +if (value == NULL) { +DEBUG(7, (talloc_asprintf

Re: [SSSD] [PATCH] add store/search/delete interface for custom sysdb objects

2009-10-21 Thread Simo Sorce
On Mon, 2009-10-19 at 16:42 +0200, Sumit Bose wrote: Hi, this patch adds a store/search/delete sysdb API for data not related to users of groups. The data is stored in cn=custom,cn=domain,cn=sysdb. The client must specify a subtree_name and an object_name to save the data in

Re: [SSSD] [PATCH] Fix up header file names in util.h and add sssd-i18n.h

2009-10-21 Thread Simo Sorce
Why did you move config.h below talloc.h etc.. ? Simo. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] Fix up header file names in util.h and add sssd-i18n.h

2009-10-21 Thread Simo Sorce
On Wed, 2009-10-21 at 20:21 +0200, Martin Nagy wrote: On Tue, 2009-10-20 at 22:16 -0400, Simo Sorce wrote: Why did you move config.h below talloc.h etc.. ? Simo. No functional reason, I think it's better if headers are first and headers are last so since I was changing those lines

[SSSD] [PATCH] fix offline detection/enumeration behavior in ldap_id

2009-10-21 Thread Simo Sorce
I was seeing the ipa backend blocking on start trying to contact the KDC and when failing not going offline, causing some applications (su -) to take a looong time to complete as they make many nss calls, and where waiting the KDC timeout for each call. Simo.

Re: [SSSD] [PATCH] fix offline detection/enumeration behavior in ldap_id

2009-10-22 Thread Simo Sorce
On Thu, 2009-10-22 at 08:20 -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/21/2009 01:33 AM, Simo Sorce wrote: I was seeing the ipa backend blocking on start trying to contact the KDC and when failing not going offline, causing some applications (su

Re: [SSSD] [PATCHES] Fix resolv bugs and improve test coverage

2009-10-22 Thread Simo Sorce
places I can't think of a better approach to it. Patch 0006: Ack. Patch 0007: Ack. They all look fine to me. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org

Re: [SSSD] [PATCH] Bring SSSDConfig API options up-to-date

2009-10-22 Thread Simo Sorce
On Thu, 2009-10-22 at 12:02 -0400, Stephen Gallagher wrote: Simo reviewed on IRC and realized that I was missing the 'chpass' type for the LDAP provider. I added this, and also updated the unit test to more gracefully handle changes in the control_provider_dict. Ack Simo. -- Simo Sorce

[SSSD] fix setting schema in ipa provider

2009-10-22 Thread Simo Sorce
one liner -- Simo Sorce * Red Hat, Inc * New York From 86e1b6c35ed196140f25235a3e1a9610133696fc Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Thu, 22 Oct 2009 12:33:14 -0400 Subject: [PATCH] Fix setting the schema in the ipa provider --- server/providers/ipa/ipa_common.c

Re: [SSSD] [PATCH] Add support for offline auth cache timeout

2009-10-22 Thread Simo Sorce
On Thu, 2009-10-22 at 12:09 -0400, Stephen Gallagher wrote: Whoops, forgot to convert days to seconds. New patch 0004 attached. ack to both. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [PATCHES] Minor fixes

2009-10-24 Thread Simo Sorce
Shouldn't require comments. Simo. -- Simo Sorce * Red Hat, Inc * New York From 4eaabf6c49cbbdc6ce505def73567e17cd231660 Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Sat, 24 Oct 2009 13:50:14 -0400 Subject: [PATCH] Add IPA conf template --- server/config/etc/sssd.api.d

[SSSD] [PATCH] Fix group enumerations for IPA/AD domains

2009-10-24 Thread Simo Sorce
With this patch we correctly parse groups. A 2 pass approach for setting members assures even complicated nested groups do not risk to miss memberships Simo. -- Simo Sorce * Red Hat, Inc * New York From 22abda63e1e1c58b745a3a79d68e96fc1bb39e0c Mon Sep 17 00:00:00 2001 From: Simo Sorce sso

[SSSD] [PATCH] Set Cache expiration in providers

2009-10-24 Thread Simo Sorce
always make sure to fetch entries from the source on login. Simo. -- Simo Sorce * Red Hat, Inc * New York From 57b86e930fc55fe59f92102f41b9eb8b6f903cb4 Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Sat, 24 Oct 2009 13:36:34 -0400 Subject: [PATCH] Move responsibility for entry

Re: [SSSD] [PATCHES] Minor fixes

2009-10-26 Thread Simo Sorce
On Mon, 2009-10-26 at 08:58 -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/26/2009 08:53 AM, Sumit Bose wrote: On Sat, Oct 24, 2009 at 02:07:15PM -0400, Simo Sorce wrote: Shouldn't require comments. Simo. [PATCH] Add IPA conf template, looks

[SSSD] [PATCH] fix set last login function in pam handler

2009-10-26 Thread Simo Sorce
See comments in commit message. Also add patch to fix some talloc_free - talloc_zfree cases in sysdb Simo. -- Simo Sorce * Red Hat, Inc * New York From 93543a3f6cc6fc9e2c38f2e5824363f5cc4c155d Mon Sep 17 00:00:00 2001 From: Simo Sorce s...@metason.pico.li.ssimo.org Date: Mon, 26 Oct 2009 15:11

Re: [SSSD] [PATCH] fix set last login function in pam handler

2009-10-26 Thread Simo Sorce
On Mon, 2009-10-26 at 15:19 -0400, Simo Sorce wrote: See comments in commit message. Also add patch to fix some talloc_free - talloc_zfree cases in sysdb As discussed on IRC respin to always set PAM_SYSTEM_ERR on error, given the set_last_login_send request never even have access to the preq-pd

Re: [SSSD] [PATCH] make ldap provider a little bit more resistant to errors

2009-10-26 Thread Simo Sorce
On Mon, 2009-10-26 at 18:56 -0400, Simo Sorce wrote: I was seeing in some non-easily reproduceable cases errors returned by ldap_search_ext() that would hose the connection. The same connection handler would be used after the offline timeout causing again the same error (and us going offline

Re: [SSSD] [PATCH] make ldap provider a little bit more resistant to errors

2009-10-26 Thread Simo Sorce
On Mon, 2009-10-26 at 20:15 -0400, Simo Sorce wrote: On Mon, 2009-10-26 at 18:56 -0400, Simo Sorce wrote: I was seeing in some non-easily reproduceable cases errors returned by ldap_search_ext() that would hose the connection. The same connection handler would be used after the offline

Re: [SSSD] [PATCH] Fix group enumerations for IPA/AD domains

2009-10-27 Thread Simo Sorce
On Sat, 2009-10-24 at 14:08 -0400, Simo Sorce wrote: With this patch we correctly parse groups. A 2 pass approach for setting members assures even complicated nested groups do not risk to miss memberships Rebased patch on top of master. Simo. -- Simo Sorce * Red Hat, Inc * New York From

Re: [SSSD] [PATCH] Fix group enumerations for IPA/AD domains

2009-10-27 Thread Simo Sorce
On Sat, 2009-10-24 at 14:08 -0400, Simo Sorce wrote: With this patch we correctly parse groups. A 2 pass approach for setting members assures even complicated nested groups do not risk to miss memberships Rebased on top of Sumit patch that stores the DN Also fixed an error in a debug message

Re: [SSSD] [PATCH] Fix group enumerations for IPA/AD domains

2009-10-27 Thread Simo Sorce
On Tue, 2009-10-27 at 09:21 -0400, Simo Sorce wrote: On Sat, 2009-10-24 at 14:08 -0400, Simo Sorce wrote: With this patch we correctly parse groups. A 2 pass approach for setting members assures even complicated nested groups do not risk to miss memberships Rebased patch on top of master

Re: [SSSD] [PATCH] Set Cache expiration in providers

2009-10-27 Thread Simo Sorce
On Tue, 2009-10-27 at 09:21 -0400, Stephen Gallagher wrote: Code looks good, but it won't apply on master. Please rebase and I will test and ack. Sent initially to the wrong thread. -- Simo Sorce * Red Hat, Inc * New York From 6bd1079b866e84de292b62e0e68d0ce65bff9c37 Mon Sep 17 00:00:00

Re: [SSSD] [PATCH] fix set last login function in pam handler

2009-10-27 Thread Simo Sorce
On Mon, 2009-10-26 at 15:55 -0400, Stephen Gallagher wrote: On 10/26/2009 03:51 PM, Simo Sorce wrote: On Mon, 2009-10-26 at 15:19 -0400, Simo Sorce wrote: See comments in commit message. Also add patch to fix some talloc_free - talloc_zfree cases in sysdb As discussed on IRC respin

Re: [SSSD] [Patch] Remove references to Data Provider service from sssd.conf and manpages

2009-10-27 Thread Simo Sorce
On Tue, 2009-10-27 at 08:56 -0400, Stephen Gallagher wrote: The previous patch I sent ensured that the DP wouldn't be loaded, but this patch removes all mention of it. Ack. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list

Re: [SSSD] [PATCH] Fix group enumerations for IPA/AD domains

2009-10-27 Thread Simo Sorce
On Tue, 2009-10-27 at 14:46 +0100, Sumit Bose wrote: On Tue, Oct 27, 2009 at 09:23:54AM -0400, Simo Sorce wrote: On Sat, 2009-10-24 at 14:08 -0400, Simo Sorce wrote: With this patch we correctly parse groups. A 2 pass approach for setting members assures even complicated nested groups

Re: [SSSD] [PATCH] Fix sssd.api.conf with correct entry_cache_timeout

2009-10-28 Thread Simo Sorce
On Wed, 2009-10-28 at 09:31 -0400, Stephen Gallagher wrote: Changeset 3a21103f61bf9b60256cc2d0da54b757b634319f moved the wrong option to the domain list, and also didn't update the unit tests. ACK Simo. -- Simo Sorce * Red Hat, Inc * New York

Re: [SSSD] [PATCH] Slight change for ipa options

2009-10-29 Thread Simo Sorce
On Thu, 2009-10-29 at 13:07 -0400, Stephen Gallagher wrote: On 10/28/2009 05:12 PM, Simo Sorce wrote: And other changes, see commit message. Nack. Please update /server/config/etc/sssd.api.d/* Ah I knew I was missing something, add sssd-ipa.conf removals. Simo. -- Simo Sorce * Red

[SSSD] [PATCH] Read rootDSE from LDAP server

2009-10-29 Thread Simo Sorce
See git commit comment for a detailed explanation. This is the first step toward making it possible to fully auto-configure ldap/ipa options given only the server name. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd

Re: [SSSD] [PATCH] Slight change for ipa options

2009-10-29 Thread Simo Sorce
On Thu, 2009-10-29 at 14:03 -0400, Stephen Gallagher wrote: You forgot to also add ldap_search_base to sssd-ldap.conf sigh ... -- Simo Sorce * Red Hat, Inc * New York From 29cf92397b1b41d540f78b48da694f219a5ce804 Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Wed, 28 Oct

Re: [SSSD] [PATCH] Read rootDSE from LDAP server

2009-10-29 Thread Simo Sorce
On Thu, 2009-10-29 at 15:08 -0400, Simo Sorce wrote: See git commit comment for a detailed explanation. This is the first step toward making it possible to fully auto-configure ldap/ipa options given only the server name. Works better with the actual patch ... -- Simo Sorce * Red Hat, Inc

Re: [SSSD] [PATCH] add sysdb_delete_recursive request to sysdb API

2009-10-29 Thread Simo Sorce
in sdap_cli_connect to do continuation functions (see the sdap_cli_*_step functions). The rest looks good to me. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org

[SSSD] [PATCH] start adding an attribute map for generic attributes

2009-10-29 Thread Simo Sorce
. This infrastructure is not used yet, will be in the next patches. Simo. -- Simo Sorce * Red Hat, Inc * New York From 7e3f9803b5ae3262d71766b95014943c56ad6041 Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Thu, 29 Oct 2009 18:16:59 -0400 Subject: [PATCH] Rename sdap_id_map to sdap_attr_map

Re: [SSSD] [PATCH] add sysdb_delete_recursive request to sysdb API

2009-10-30 Thread Simo Sorce
On Fri, 2009-10-30 at 12:01 +0100, Sumit Bose wrote: On Thu, Oct 29, 2009 at 11:26:39PM +0100, Sumit Bose wrote: On Thu, Oct 29, 2009 at 09:32:34PM +, Simo Sorce wrote: On Thu, 2009-10-29 at 19:40 +0100, Sumit Bose wrote: On Thu, Oct 29, 2009 at 01:39:21PM +0100, Sumit Bose wrote

Re: [SSSD] [PATCHES] Fail over helper functions and reference counting wrappers

2009-11-02 Thread Simo Sorce
explain it better. Martin, why there are so many static global variables in this code ? (static struct { ... } global ) Why aren't you using a context based approach like all the rest of the code in sssd ? Simo. -- Simo Sorce * Red Hat, Inc * New York

Re: [SSSD] [PATCH] add sysdb_delete_recursive request to sysdb API

2009-11-02 Thread Simo Sorce
fatal as all other errors bye, Sumit This new version adds a missing return after a tevent_req_done() call. ACK Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https

Re: [SSSD] [PATCH] start adding an attribute map for generic attributes

2009-11-02 Thread Simo Sorce
On Fri, 2009-10-30 at 08:05 -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/30/2009 04:44 AM, Sumit Bose wrote: On Thu, Oct 29, 2009 at 06:20:48PM -0400, Simo Sorce wrote: While adding infrastructure to use the USN counter for enumerations I found

Re: [SSSD] ipv6?

2009-11-03 Thread Simo Sorce
just missing? We actually don't resolve names ourselves but let the openldap and krb5 libraries do it. Apparently they prefer IPv4 addresses. Hopefully we will solve this by introducing our own resolver in the next weeks. Testing and bug reports about IPv6 are most welcome. Simo. -- Simo Sorce

Re: [SSSD] [PATCH] Make config_file_version a hidden setting in SSSDConfig API

2009-11-03 Thread Simo Sorce
file is not the right one. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] Add support for option descriptions to SSSDConfig API

2009-11-03 Thread Simo Sorce
as a lookup dictionary. ack (why didn't you create a separate file and just imported it ?) 0004: Enable translations on these strings. ack -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https

Re: [SSSD] [PATCH] Make config_file_version a hidden setting in SSSDConfig API

2009-11-03 Thread Simo Sorce
On Tue, 2009-11-03 at 10:05 -0500, Stephen Gallagher wrote: On 11/03/2009 09:37 AM, Simo Sorce wrote: On Thu, 2009-10-29 at 14:19 -0400, Stephen Gallagher wrote: The config_file_version should never be changed by the API, so we will hide the option inside the SSSDConfig API and remove

Re: [SSSD] what is sbus_timeout?

2009-11-04 Thread Simo Sorce
defined. I'd prefer to keep it undocumented for now, and not see it in the configuration files. Most people wouldn't know how to set it properly anyways. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel

Re: [SSSD] [PATCH] Add sysdb_attrs_replace_name to sysdb API

2009-11-04 Thread Simo Sorce
On Wed, 2009-11-04 at 15:05 +0100, Sumit Bose wrote: +if (e != NULL) { +dummy = talloc_strdup(talloc_parent(e-name), newname); The parent should be attrs, I would use that and not talloc_parent(), so even if the parent is something else, we get the new parent right. Simo. -- Simo

[SSSD] [PATCH] fix initgroups call

2009-11-04 Thread Simo Sorce
on the schema used (still doesn't fully support nested groups in AD, but that is not a priority right now) I have tested it with an IPA 1.2 server and seem to work properly. Simo. -- Simo Sorce * Red Hat, Inc * New York From d3e4d3e123950bb52c3424967f7b30d3148a586f Mon Sep 17 00:00:00 2001 From

Re: [SSSD] [PATCH] added access module of IPA provider

2009-11-05 Thread Simo Sorce
originalMemberOf in my recent patches. I guess you should use that one instead of IPA_HOST_ORIGMEMBEROF. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo

Re: [SSSD] [PATCH] added access module of IPA provider

2009-11-07 Thread Simo Sorce
version uses SYSDB_ORIG_MEMBEROF. Please commit this after Simo's initgr fix patch. Sorry does not apply on top of master anymore :/ Simo. rebased version attached. pushed. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel

Re: [SSSD] [PATCH] Cleanups

2009-11-07 Thread Simo Sorce
On Fri, 2009-11-06 at 21:37 -0500, Dmitri Pal wrote: Martin Nagy wrote: Simo Sorce wrote: This patch adds some cleanups and fixes coding style deviations. There are some more in the resolve code. You added braces to if constructs. I was under the impression that we

[SSSD] [PATCH] Fix for #236

2009-11-07 Thread Simo Sorce
Except some rare cases out use of tevent_req_is_error() was dangerous. Almost everywhere where we used it it was probably ok, but given the semantics of that function I think using the macro in this patch is much safer. Simo. -- Simo Sorce * Red Hat, Inc * New York From

Re: [SSSD] [PATCH] added access module of IPA provider

2009-11-07 Thread Simo Sorce
On Sat, 2009-11-07 at 13:16 -0500, Simo Sorce wrote: On Sat, 2009-11-07 at 10:59 +0100, Sumit Bose wrote: Looks good to me. The only thing is that I have defined SYSDB_ORIG_MEMBEROF originalMemberOf in my recent patches. I guess you should use that one instead

Re: [SSSD] [PATCH] Fix for #236

2009-11-07 Thread Simo Sorce
On Sat, 2009-11-07 at 13:24 -0500, Simo Sorce wrote: Except some rare cases out use of tevent_req_is_error() was dangerous. Almost everywhere where we used it it was probably ok, but given the semantics of that function I think using the macro in this patch is much safer. Bad patch, attached

Re: [SSSD] krb5 ticket renewal via gnome-screensaver not working

2009-11-07 Thread Simo Sorce
as well ? Otherwise just open a bug and we will verify asap. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

[SSSD] Emergency build fix

2009-11-07 Thread Simo Sorce
I pushed this patch to fix the ldap driver build. Sorry for the mess-up. Simo. -- Simo Sorce * Red Hat, Inc * New York From a69766ff324dcd2c3543c6969e3f77c38c4dc629 Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Sat, 7 Nov 2009 23:09:00 -0500 Subject: [PATCH] Fix ldap driver

[SSSD] [PATCH] Fix ldap enumeration

2009-11-07 Thread Simo Sorce
Save all entries, not just the first one. Simo. -- Simo Sorce * Red Hat, Inc * New York From 2a7b99215094508009f0b919aebb62ee7450825b Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Sun, 8 Nov 2009 01:17:22 -0500 Subject: [PATCH] Fix enumerations The counter was not set so we

Re: [SSSD] krb5 ticket renewal via gnome-screensaver not working

2009-11-09 Thread Simo Sorce
and then one in krb5_child_sig_handler. It is probably a good idea to address that with an API to register callback functions from a single function that runs witpid() Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel

Re: [SSSD] should not return x for password when there is no shadow information

2009-11-09 Thread Simo Sorce
On Mon, 2009-11-09 at 09:41 -0500, Brian J. Murrell wrote: On Mon, 2009-11-09 at 08:59 -0500, Simo Sorce wrote: If someone opens a bug for that, yes :-) Done. https://fedorahosted.org/sssd/ticket/266 However keep in mind that I don't care much for what pam_unix does in any pam

Re: [SSSD] [PATCH] implement cleanup task

2009-11-10 Thread Simo Sorce
On Tue, 2009-11-10 at 10:54 +1000, David O'Brien wrote: Simo Sorce wrote: Please update manpages for ldap_purge_cache timeout, as well as the SSSDConfig API configuration files. Like for other timeouts I'd like to keep this undocumented for now. I added the option for the API

Re: [SSSD] [PATCH] Simplify krb5 child handler

2009-11-10 Thread Simo Sorce
On Tue, 2009-11-10 at 11:47 +0100, Sumit Bose wrote: Hi, this patch simplifies then child handling of the kerberos provider to reduce the number of missleading debug messages. Ack. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel

[SSSD] [PATCH] rework check_cache()

2009-11-11 Thread Simo Sorce
it again in a few months time :) Unfortunately I don't have the time to actually test it today, although it should just work (latest famous words :) Simo. -- Simo Sorce * Red Hat, Inc * New York From a83c6e27616cf18650feeb83b9eee739f6c05c98 Mon Sep 17 00:00:00 2001 From: Simo Sorce sso

Re: [SSSD] krb5 ticket renewal via gnome-screensaver not working

2009-11-11 Thread Simo Sorce
to a default of FILE:%d/krb5cc_%U for the 1.0 release to avoid issues. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] rework check_cache()

2009-11-11 Thread Simo Sorce
On Wed, 2009-11-11 at 13:55 -0500, Simo Sorce wrote: Today I stumbled on check_cache while working on the initgroups caching. It took a long discussion on IRC with Steven to find out exactly how it behaved, and we found a bug in it. Given the complexity I decide to refactor it so

[SSSD] [PATCH] better var name

2009-11-11 Thread Simo Sorce
Comment in patch says all. Simo. -- Simo Sorce * Red Hat, Inc * New York From cf01eae6e4518c1abdd75c37b0796d468e76eaa5 Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Wed, 11 Nov 2009 20:44:23 -0500 Subject: [PATCH] Change var name to make its use more clear. Change memctx

Re: [SSSD] krb5 ticket renewal via gnome-screensaver not working

2009-11-15 Thread Simo Sorce
On Sun, 2009-11-15 at 08:22 -0500, Brian J. Murrell wrote: On Wed, 2009-11-11 at 19:03 -0500, Simo Sorce wrote: I have tested this yesterday (with git master), if you set FILE:% d/krb5cc_%U sssd will happily refresh the crdentials at screen unlock. Ahhh. ~light bulb goes on~ I am

[SSSD] [PATCH] failover fixes

2009-11-15 Thread Simo Sorce
but unfinished patch here: http://fedorapeople.org/gitweb?p=simo/public_git/sssd.git;a=commit;h=29830482f5e44b5425fb91f82fd5a4ee692f3ae2 -- Simo Sorce * Red Hat, Inc * New York From 504b9b6f6257c2e052d744287fd33f5164819d1e Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Sun, 15 Nov 2009

Re: [SSSD] [PATCH] failover fixes

2009-11-16 Thread Simo Sorce
On Mon, 2009-11-16 at 08:46 +0100, Martin Nagy wrote: Simo Sorce wrote: While working on a patch to use failover in the ldap driver I found a few bugs and a few things I felt missing. Attached a patch to fix bugs and add a function to get back a server name from a fo_server structure

Re: [SSSD] [PATCH] Ignore shadow attributes

2009-11-16 Thread Simo Sorce
() to autodetect what to use. Thoughts ? Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCHES] Handle case-sensitivity issues

2009-11-16 Thread Simo Sorce
? Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] Speed up NSS responses while offline

2009-11-16 Thread Simo Sorce
error and then schedule an out of band request to try to go online. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

[SSSD] [PATCH] Make use of failover code in backends.

2009-11-16 Thread Simo Sorce
is performed that changes the server currently in use then all providers can update their status. I have done limited testing with the ipa backend which exercises both the ldap and krb code, although the standalone krb code still doesn't implement using the failover code. Simo. -- Simo Sorce

Re: [SSSD] [PATCH] Make the password field configurable in NSS

2009-11-17 Thread Simo Sorce
at this stage. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCHES] Handle case-sensitivity issues

2009-11-17 Thread Simo Sorce
On Tue, 2009-11-17 at 09:58 -0500, Stephen Gallagher wrote: + +*ver = 0.4; +return ret; +} Shouldn't you use SYSDB_VERSION_0_4 here ? :-) Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel

Re: [SSSD] [PATCHES] Handle case-sensitivity issues

2009-11-17 Thread Simo Sorce
; +} + +i = 0; +while (i len) { +retval[i] = tolower(str[i]); +i++; +} +retval[len] = '\0'; + +return (const char *)retval; +} This one needs to be utf8 safe. Can't ACK. Simo. -- Simo Sorce * Red Hat, Inc * New York

Re: [SSSD] [PATCHES] Handle case-sensitivity issues

2009-11-17 Thread Simo Sorce
On Tue, 2009-11-17 at 14:02 -0500, Stephen Gallagher wrote: On 11/17/2009 11:15 AM, Simo Sorce wrote: On Tue, 2009-11-17 at 09:58 -0500, Stephen Gallagher wrote: + +*ver = 0.4; +return ret; +} Shouldn't you use SYSDB_VERSION_0_4 here ? :-) Simo. Absolutely

Re: [SSSD] [PATCH] Make the password field configurable in NSS

2009-11-18 Thread Simo Sorce
On Wed, 2009-11-18 at 10:58 -0500, Brian J. Murrell wrote: On Tue, 2009-11-17 at 09:02 -0500, Simo Sorce wrote: We don't support shadow maps so we never return shadow information currently. So you should _never_ return an x in the passwd map either then. It doesn't even need a distro

Re: [SSSD] [PATCH] Make the password field configurable in NSS

2009-11-18 Thread Simo Sorce
you make just one change and turn the default from x to * ? Once you do that and rebase on top of master I'll push. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org

Re: [SSSD] [PATCHES] Add new translations to the SSSD

2009-11-18 Thread Simo Sorce
thing that looks a bit strange is that revision dates are not updated while creation dates are. I would have expected the contrary, but I guess it is some side effect of the way we generate the files, and so far has caused no real problem. ACK. Simo. -- Simo Sorce * Red Hat, Inc * New York

Re: [SSSD] [PATCH] Make the password field configurable in NSS

2009-11-18 Thread Simo Sorce
On Wed, 2009-11-18 at 17:40 +0100, Jakub Hrozek wrote: Implementation looks fine, though. OK, new patch attached ACK Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https

[SSSD] [PATCH] move id range checks into providers

2009-11-18 Thread Simo Sorce
This way we check them once at storage time instead of checking again and again at search time. Applies only on top of the sysdb_enumgrent optimization patch. Simo. -- Simo Sorce * Red Hat, Inc * New York From 3bc78051e26983e5741c02d7fce82d4b683cc722 Mon Sep 17 00:00:00 2001 From: Simo Sorce

[SSSD] [PATCH] better cleanup task for ldap driver

2009-11-18 Thread Simo Sorce
See the commit comment, but, long story short, this is much better behavior then what we have now. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo

Re: [SSSD] [PATCH] better cleanup task for ldap driver

2009-11-19 Thread Simo Sorce
On Thu, 2009-11-19 at 08:55 -0500, Simo Sorce wrote: On Thu, 2009-11-19 at 09:18 +0100, Sumit Bose wrote: On Wed, Nov 18, 2009 at 07:23:09PM -0500, Simo Sorce wrote: See the commit comment, but, long story short, this is much better behavior then what we have now. I would

Re: [SSSD] [PATCH] Make use of failover code in backends.

2009-11-20 Thread Simo Sorce
On Fri, 2009-11-20 at 12:23 +0100, Sumit Bose wrote: On Mon, Nov 16, 2009 at 05:55:51PM -0500, Simo Sorce wrote: This patch implements the use of the fail_over code under the control of the data provider backend code. All providers share the same failover structure and if they use the same

Re: [SSSD] [PATCH] move id range checks into providers

2009-11-20 Thread Simo Sorce
On Fri, 2009-11-20 at 11:19 +0100, Sumit Bose wrote: On Fri, Nov 20, 2009 at 10:40:29AM +0100, Sumit Bose wrote: On Wed, Nov 18, 2009 at 12:09:58PM -0500, Simo Sorce wrote: This way we check them once at storage time instead of checking again and again at search time. Applies only

Re: [SSSD] [PATCH] correctly escape RDNs

2009-11-20 Thread Simo Sorce
On Fri, 2009-11-20 at 09:50 +0100, Sumit Bose wrote: On Thu, Nov 19, 2009 at 07:30:32PM -0500, Simo Sorce wrote: See commit comment. -- Simo Sorce * Red Hat, Inc * New York From 49862816e3b7077bc7a002c980901d31aff06269 Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com

Re: [SSSD] [PATCH] Make use of failover code in backends.

2009-11-20 Thread Simo Sorce
On Fri, 2009-11-20 at 15:16 +0100, Sumit Bose wrote: On Fri, Nov 20, 2009 at 08:59:49AM -0500, Simo Sorce wrote: On Fri, 2009-11-20 at 12:23 +0100, Sumit Bose wrote: On Mon, Nov 16, 2009 at 05:55:51PM -0500, Simo Sorce wrote: This patch implements the use of the fail_over code under

Re: [SSSD] [PATCH] Add empty NL translation

2009-11-20 Thread Simo Sorce
On Thu, 2009-11-19 at 09:20 -0500, Stephen Gallagher wrote: $SUBJECT ACK -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] Make use of failover code in backends.

2009-11-20 Thread Simo Sorce
On Fri, 2009-11-20 at 10:03 -0500, Simo Sorce wrote: ok, modified patch attached. Rebased on top of current master. Simo. -- Simo Sorce * Red Hat, Inc * New York From 623b66a6817c4b87eefddb2d0f2591d18b16ba76 Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Fri, 20 Nov 2009

Re: [SSSD] [PATCH] Optimize gorup enumerations

2009-11-20 Thread Simo Sorce
. Attached patch that correctly passes all tests. Simo. -- Simo Sorce * Red Hat, Inc * New York From 38664e3db3833f9e0194c9d738ce0facfadf9a7e Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Tue, 17 Nov 2009 20:22:36 -0500 Subject: [PATCH] Optimize sysdb_enumgrent This brings down

Re: [SSSD] ELAPI fundamental architectural issue

2009-11-20 Thread Simo Sorce
(ordered by default), so admins/apps can decide whether they care or not. Time stamping at the time of delivery would be bad as you can't reconstruct what happened in the code and would have no way to correlate what happened with other sources. Simo. -- Simo Sorce * Red Hat, Inc * New York

Re: [SSSD] [PATCH] move id range checks into providers

2009-11-20 Thread Simo Sorce
On Fri, 2009-11-20 at 10:40 +0100, Sumit Bose wrote: Works well, especially with Optimize-sysdb_enumgrent.patch, but please create a utility function or a macro for the range check and fix Revised patch to use a macro. -- Simo Sorce * Red Hat, Inc * New York From

[SSSD] [PATCH] raise a couple of timeouts

2009-11-20 Thread Simo Sorce
They were a bit too strict with high debug levels. Simo. -- Simo Sorce * Red Hat, Inc * New York From bcd36543f40ac48f944970735eddfd37f9cf9ab6 Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Fri, 20 Nov 2009 14:19:35 -0500 Subject: [PATCH] Raise some timeouts When using high

Re: [SSSD] ELAPI fundamental architectural issue

2009-11-20 Thread Simo Sorce
that use mixed async and sycn logging do so only when sending a sync log requires it to know the operation went through. In that case the application is prepared to wait the time it takes for the log to go through. Simo. -- Simo Sorce * Red Hat, Inc * New York

Re: [SSSD] [PATCH] Read KDC info from file instead from environment

2009-11-20 Thread Simo Sorce
to the client. I haven't removed them in this patch, because it would introduce a dependency to other not-committed patches. I thought it might be easier this way. - integration of the fail-over framework. ACK, it works for me. Simo. -- Simo Sorce * Red Hat, Inc * New York

Re: [SSSD] [PATCH] Ignore shadow attributes

2009-11-23 Thread Simo Sorce
still think that ldap_pwd_policy should be added so that you can force the code to use only that and fail if for some reason the ldap server does not support it (admin failed to properly configure one of the servers). But the patch looks good. ACK Simo. -- Simo Sorce * Red Hat, Inc * New York

Re: [SSSD] [PATCHES] Translation updates

2009-11-23 Thread Simo Sorce
On Mon, 2009-11-23 at 08:46 -0500, Stephen Gallagher wrote: Update the PL and NL translations. ACK Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman

Re: [SSSD] [PATCH] Read KDC info from file instead from environment

2009-11-23 Thread Simo Sorce
building the test is fixed). Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] Speed up NSS responses while offline

2009-11-23 Thread Simo Sorce
On Mon, 2009-11-23 at 11:02 -0500, Stephen Gallagher wrote: On 11/23/2009 09:16 AM, Simo Sorce wrote: Patch looks good except for adding a new param in the bus protocol. As discussed on IRC we can pass fast_reply as a parameter of the type, and make type a bitfield as it should have

Re: [SSSD] [PATCH] Read KDC info from file instead from environment

2009-11-23 Thread Simo Sorce
On Mon, 2009-11-23 at 17:45 +0100, Sumit Bose wrote: On Mon, Nov 23, 2009 at 11:00:11AM -0500, Simo Sorce wrote: On Mon, 2009-11-23 at 16:06 +0100, Sumit Bose wrote: Attached is a rebased and extendend version of the patch. The changes need to work together with the fail-over

[SSSD] [PATCH] Fix #289

2009-11-23 Thread Simo Sorce
Left out the filter users in group check by mistake when optimized enumerations. Simo. -- Simo Sorce * Red Hat, Inc * New York From cac0c85821887758c174ba45d47ba087c19b7e57 Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Mon, 23 Nov 2009 14:34:36 -0500 Subject: [PATCH] Fix

Re: [SSSD] [PATCH] fix internal consistency check

2009-11-24 Thread Simo Sorce
On Tue, 2009-11-24 at 09:04 +0100, Sumit Bose wrote: On Mon, Nov 23, 2009 at 05:21:37PM -0500, Simo Sorce wrote: We used to do this via a preprocessor macro so the build would fail but since we changed the original code to use enums instead this is not possible anymore. Turn

Re: [SSSD] [PATCH] Use ldb modules from build root for tests

2009-11-24 Thread Simo Sorce
if sysdb is compiled for the test. Maybe we want to set the path to something like $(libdir)/ldb for the real case, too? Ack. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https

<    1   2   3   4   5   6   7   8   9   10   >