[SSSD] [PATCH 1/5] mmap cache: public functions to invalidate records

These functions can be called from the nss responder to invalidate records that have ceased to exist or that need to be refreshed the first time an application needs them. --- src/responder/nss/nsssrv_mmap_cache.c | 125 + src/responder/nss/nsssrv_mmap_cache.h |

[SSSD] [PATCH] Comment fixup, for master

Found this comment was misplaced while working on another patch. For master only. Simo. -- Simo Sorce * Red Hat, Inc * New York >From 6a0cf3e956ed46ca0c06e9bf85ed88a3a3e6c25a Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Mon, 26 Nov 2012 11:25:04 -0500 Subject: [PATCH] Fix comment on wr

Re: [SSSD] IPA client randomly lose memory of users

On Tue, 2012-12-04 at 14:59 -0500, Qing Chang wrote: > On 04/12/2012 2:50 PM, Jakub Hrozek wrote: > > On Tue, Dec 04, 2012 at 02:38:34PM -0500, Simo Sorce wrote: > >> On Tue, 2012-12-04 at 14:31 -0500, Qing Chang wrote: > >>> On 04/12/2012 2:19 PM, Simo Sorce wrote: &

Re: [SSSD] [PATCH] Ghost user related fixes to the memberof plugin

o a subtree search on the whole tree with (&(objectclass=group)(memberof=)) (you might also add a &(ghost=*) ) ? This would give you all groups that are 'children' of the group you are actually handling with a single search and avoids searching user entries and then immediately disca

Re: [SSSD] [PATCH] Ghost user related fixes to the memberof plugin

On Wed, 2012-12-05 at 10:18 +0100, Jakub Hrozek wrote: > On Wed, Dec 05, 2012 at 12:39:33AM -0500, Simo Sorce wrote: > > On Tue, 2012-12-04 at 21:39 +0100, Jakub Hrozek wrote: > > > Hi, > > > > > > this thread obsoletes the previous memberof related threads in

Re: [SSSD] [PATCHES] Improve group handling in the PAC responder

0 }; the 'hash/index' is (gid & 0x2FF) > 0011 adds a new unit test Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] LDAP: If deref search fails, try again without deref

add in latency as now each time we reconnect we need to wait a few searches before we can start with business. I think this trade-off is wrong. We should not load the server more and we should not add yet more latency to our connection path, so I prefer on the fly detection like Jan did. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH 3/5] Hook for mmap cache update on initgroup calls

On Wed, 2012-12-05 at 18:19 +0100, Jakub Hrozek wrote: > On Tue, Dec 04, 2012 at 02:47:10PM -0500, Simo Sorce wrote: > > This set of functions enumerate the user's groups and invalidate > them all > > if the list does not matches what we get from the caller. > > I&

Re: [SSSD] [PATCH 2/5] Hook to perform a mmap cache update from sssd_nss

On Wed, 2012-12-05 at 18:14 +0100, Jakub Hrozek wrote: > On Tue, Dec 04, 2012 at 02:47:09PM -0500, Simo Sorce wrote: > > This set of functions enumerate each user/group from all domains > > and invalidate any mmap cache record that matches. > > +id = ldb_msg_fi

Re: [SSSD] IPA client randomly lose memory of users

5:48 2012) [sssd[be[sri.utoronto.ca]]] > [sysdb_search_user_by_uid] (0x0400): No such > entry This is interesting, do you have duplicated UIDs in your directory by chance ? Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list

Re: [SSSD] [PATCHES] Improve group handling in the PAC responder

On Wed, 2012-12-05 at 18:23 +0100, Sumit Bose wrote: > On Wed, Dec 05, 2012 at 09:04:46AM -0500, Simo Sorce wrote: > > On Wed, 2012-12-05 at 13:36 +0100, Sumit Bose wrote: > > > Hi, > > > > > > this series of patches fixes https://fedorahosted.

[SSSD] [PATCH 4/5] Add backchannel NSS provider query on initgr calls

This is needed in order to assure the memcache is properly and promptly cleaned up if a user memberships change on login. The list of the current groups for the user is sourced before it is updated and sent to the NSS provider to verify if it has changed after the update call has been made. --- s

[SSSD] [PATCH 3/5] Hook for mmap cache update on initgroup calls

This set of functions enumerate the user's groups and invalidate them all if the list does not matches what we get from the caller. --- src/providers/data_provider.h |1 + src/responder/nss/nsssrv.c | 53 + src/responder/nss/nsssrv_cmd.c | 91 ++

[SSSD] [PATCH 1/5] mmap cache: public functions to invalidate records

These functions can be called from the nss responder to invalidate records that have ceased to exist or that need to be refreshed the first time an application needs them. --- src/responder/nss/nsssrv_mmap_cache.c | 125 + src/responder/nss/nsssrv_mmap_cache.h |

[SSSD] [PATCH 5/5] Always append rctx as private data

This is used for the new calls back from the data provider. --- src/responder/common/responder_common.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/responder/common/responder_common.c b/src/responder/common/responder_common.c index 50705a3f227d38f7789d4adc5a69d2

[SSSD] [PATCH 2/5] Hook to perform a mmap cache update from sssd_nss

This set of functions enumerate each user/group from all domains and invalidate any mmap cache record that matches. --- src/providers/data_provider.h |6 ++ src/responder/nss/nsssrv.c | 15 + src/responder/nss/nsssrv_cmd.c | 100 src

[SSSD] [PATCH 0/5] [REV.1] Properly invalidate mmap cache data

in the provider code if initgroups return both 0 results and 1 result, because in that case it means that the user either does not exist at all or it is there but memberships have never been filled in so again there is really nothing to check in NSS. The rest is unchanged. Simo Sorce (5): mmap

Re: [SSSD] [PATCH] Ghost user related fixes to the memberof plugin

On Wed, 2012-12-05 at 21:21 +0100, Jakub Hrozek wrote: > > One more change. We don't have to store a (key,value) pairs in the > hash > table as the ghost user name is only stored in the key anyway. ACK Simo. -- Simo Sorce * Red Ha

[SSSD] [PATCH] Fix missing memory barrier in client code

This is a race condition that may cause the client to not be able to read the entry. It is not fatal, worst case the client will revert to the slow path and ask for the entry via the pipe. Fixes https://fedorahosted.org/sssd/ticket/1694 Simo. -- Simo Sorce * Red Hat, Inc * New York >F

Re: [SSSD] [PATCH] LDAP: Continue adjusting group membership even if there is nothing to add

On Wed, 2012-12-05 at 22:50 +0100, Jakub Hrozek wrote: > Please see the attached patch. ACK Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listi

Re: [SSSD] [PATCH] Bump the version and reset release back to 0

; This patch is only valid for the master branch. There would be a > separate one for the sssd-1-9 branch. ACK Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mai

Re: [SSSD] [PATCH] MEMBEROF: Fix cop-n-paste error

On Mon, 2012-12-10 at 08:38 +0100, Jakub Hrozek wrote: > Found by Coverity. > > https://fedorahosted.org/sssd/ticket/1703 ACK (this type of fixes can go in as a oneliner too if you want) Simo. -- Simo Sorce * Red Hat, Inc * New York ___ s

Re: [SSSD] [PATCH] NSS: Fix the error handler in sss_mc_create_file

e is open and no file is on disk ... Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] let krb5_kpasswd failover work

On Mon, 2012-12-10 at 16:00 +0100, Pavel Březina wrote: > https://fedorahosted.org/sssd/ticket/1680 ACK Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.

Re: [SSSD] [PATCH] NSS: Fix the error handler in sss_mc_create_file

On Mon, 2012-12-10 at 18:10 +0100, Jakub Hrozek wrote: > On Mon, Dec 10, 2012 at 09:06:16AM -0500, Simo Sorce wrote: > > On Mon, 2012-12-10 at 08:39 +0100, Jakub Hrozek wrote: > > > Coverity bug again. > > > > > > https://fedorahosted.org/sssd/ticket/1704 >

Re: [SSSD] [PATCH] NSS: Fix the error handler in sss_mc_create_file

On Tue, 2012-12-11 at 14:34 +0100, Jakub Hrozek wrote: > On Mon, Dec 10, 2012 at 12:19:06PM -0500, Simo Sorce wrote: > > On Mon, 2012-12-10 at 18:10 +0100, Jakub Hrozek wrote: > > > On Mon, Dec 10, 2012 at 09:06:16AM -0500, Simo Sorce wrote: > > > > On Mon, 2012-12-1

[SSSD] [PATCH] additional fix for #1694

Florian, found that the previous fix was not sufficient. Attached a better patch to close the remaining concurrency issues in the client. Simo. -- Simo Sorce * Red Hat, Inc * New York >From c884ad3be20c084dd214756829370c594b3c1b88 Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Tue, 11

Re: [SSSD] [PATCHES] sss_userdel and sss_groupdel remove entries from fastcache

te the user in the cache, not delete it. Is this intentional ? It looks backwards given you are calling a 'del' function. It looks to me that what you really want is an explicit delete function in sssd_nss that you can call from the cmdline, is that correct ? Simo. -

Re: [SSSD] [PATCHES] sss_userdel and sss_groupdel remove entries from fastcache

On Thu, 2012-12-13 at 13:19 -0500, Simo Sorce wrote: > On Thu, 2012-12-13 at 18:06 +0100, Michal Židek wrote: > > Patch 1: (sssd_nss part) In functions nss_cmd_getXXnam, if working with > > a local domain and no results were found in sysdb, the entries are > > invalidate

Re: [SSSD] [PATCH] sudo: support generalized time format

ral case. ACK. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[SSSD] [PATCH] Fix pam responder handling of coalesced requests

sssd_be process and trying to authenticate via the gnome screensaver. Fixes: https://fedorahosted.org/sssd/ticket/1655 -- Simo Sorce * Red Hat, Inc * New York >From 68f9ef840ada24f727aaea9c15cd1453b6d25644 Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Thu, 13 Dec 2012 18:13:06 -0500 Subj

Re: [SSSD] [PATCH] Fix pam responder handling of coalesced requests

On Fri, 2012-12-14 at 10:43 +0100, Jakub Hrozek wrote: > On Thu, Dec 13, 2012 at 11:25:25PM -0500, Simo Sorce wrote: > > In our responders we have a feature that allows to avoid dispatching > > multiple identical requests at the same time. > > This is done by queing addition

Re: [SSSD] [PATCH] PROXY: fix groups caching

On Fri, 2012-12-14 at 11:36 +0100, Ondrej Kos wrote: > https://fedorahosted.org/sssd/ticket/1685 > > we need to fix groups as well > > patch is attached ack. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing

Re: [SSSD] [PATCHES] sss_userdel and sss_groupdel remove entries from fastcache

On Fri, 2012-12-14 at 14:12 +0100, Michal Židek wrote: > On 12/13/2012 08:55 PM, Jakub Hrozek wrote: > > On Thu, Dec 13, 2012 at 02:16:25PM -0500, Simo Sorce wrote: > >> On Thu, 2012-12-13 at 13:19 -0500, Simo Sorce wrote: > >>> On Thu, 2012-12-13 at 18:06 +0100, Mich

[SSSD] [PATCH] gracefully handle mmap_cache calls when uninitialized

Failure to init the mmap_cache is a soft error, so just gracefully return a EINVAL error from public functions if the mc context is NULL and do not segfault. Fixes: https://fedorahosted.org/sssd/ticket/1716 Simo. -- Simo Sorce * Red Hat, Inc * New York >F

Re: [SSSD] [PATCH] gracefully handle mmap_cache calls when uninitialized

On Fri, 2012-12-14 at 15:17 +0100, Michal Židek wrote: > On 12/14/2012 02:59 PM, Simo Sorce wrote: > > Failure to init the mmap_cache is a soft error, so just gracefully > > return a EINVAL error from public functions if the mc context is NULL > > and do not segfault.

[SSSD] [PATCH] Add extra protection for side request

Add a timeout to side requests so they do not hang forever. Tested with SIGSTOPping sssd_be and monitor and then waiting for the request and later the idle timer to fire. Seem to work as expected here. Simo. -- Simo Sorce * Red Hat, Inc * New York >From 32f03cebf2570540c9d087c5d6d8fd8e46ec5

Re: [SSSD] [PATCH] RESOLV: Do not steal the resulting hostent on error

ly the correct thing to do. > > Ack. > > It may be also a good idea to use talloc_zfree() when freeing > state->rhostent instead of talloc_free(). Are we guaranteed that on error there is a valid value in state->rhostent ? Simo. -- Simo Sorce * Red Hat, Inc * New York _

Re: [SSSD] [PATCH] RESOLV: Do not steal the resulting hostent on error

On Mon, 2012-12-17 at 14:00 +0100, Pavel Březina wrote: > On 12/17/2012 01:54 PM, Simo Sorce wrote: > > On Mon, 2012-12-17 at 13:05 +0100, Pavel Březina wrote: > >> On 12/16/2012 11:38 PM, Jakub Hrozek wrote: > >>> I have not reproduced the access-after

[SSSD] [PATCH] Fix failure in memberof that can kill db updates

Fixes https://fedorahosted.org/sssd/ticket/1728 Simo. -- Simo Sorce * Red Hat, Inc * New York >From 7988a75e552918e164d0693c6c4de2a5c4a30db6 Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Tue, 18 Dec 2012 20:52:02 -0500 Subject: [PATCH] memberof: Prevent unneded failure case When deletin

Re: [SSSD] [PATCHES] Improve group handling in the PAC responder

ows/produces. Still a nack for me. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[SSSD] [PATCH] Fix very bad memory leak

I introduced a memory leak with the memory cache checks on initgroups. Oh the joy oh the sadness. Patch attached. Simo. -- Simo Sorce * Red Hat, Inc * New York >From 69f9660d680f42715c0478012235e88d778d6c9a Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Wed, 19 Dec 2012 08:48:06 -0

Re: [SSSD] [PATCH] Fix failure in memberof that can kill db updates

On Wed, 2012-12-19 at 08:51 -0500, Stephen Gallagher wrote: > On 12/18/2012 09:00 PM, Simo Sorce wrote: > > Fixes https://fedorahosted.org/sssd/ticket/1728 > > > > Simo. > > > > Ack from me as well. Do we know why the DB was in an incorrect state, > though? W

[SSSD] [PATCH] [RFE] Addiotinal protection against wild pointers

We have a segfault case that can be prevented by the attached patch. It does not address the actual source of the problem but it seem to be a reasonable compromise to plug this whole while we try to determine the cause. Simo. -- Simo Sorce * Red Hat, Inc * New York >F

[SSSD] [PATCH 1/3] Update free table when records are invalidated.

We were holding up slots when entries were invalidated directly an not through our primitive garbage collection scheme. --- src/responder/nss/nsssrv_mmap_cache.c | 37 1 files changed, 23 insertions(+), 14 deletions(-) diff --git a/src/responder/nss/nsssrv_mmap_

[SSSD] [PATCH 2/3] Carefully check records when forcibly invalidating

We should never try to invalidate an already invalid record as internal pointers will not be consistent. Carefully test that the record really is valid when we are fishing for free space, and properly invalidate records or return a fatal error if something goes wrong. In order to make the code more

[SSSD] [PATCH 3/3] mmap cache: invalidate cache on fatal error

If a fatal EFAULT error is returned by the internal function that frees used memory invalidate the whole cache and reinit it. This way we avoid further corruption and insure clients see consistent data. --- src/responder/nss/nsssrv_cmd.c|4 ++-- src/responder/nss/nsssrv_mmap_cache.c |

[SSSD] [PATCH 0/3] Improve robustness of mmap cache handling

table. I split the fixes in 3 small patches that should make it easier to review. I did some quick testing on my machine and it seem ok. Simo. Simo Sorce (3): Update free table when records are invalidated. Carefully check records when forcibly invalidating mmap cache: invalidate cache on

Re: [SSSD] [PATCH 3/3] mmap cache: invalidate cache on fatal error

On Thu, 2012-12-20 at 12:29 +0100, Pavel Březina wrote: > On 12/20/2012 06:10 AM, Simo Sorce wrote: > > -static errno_t sss_mc_get_record(struct sss_mc_ctx *mcc, > > +static errno_t sss_mc_get_record(struct sss_mc_ctx **_mcc, > >

Re: [SSSD] [PATCH 0/3] Improve robustness of mmap cache handling

On Thu, 2012-12-20 at 12:30 +0100, Pavel Březina wrote: > On 12/20/2012 06:10 AM, Simo Sorce wrote: > > The function that reclaims free slots of memory was not very robust and > > I think is the root cause of a segfault Jakub can easily reproduce as of > > late. It is augmente

Re: [SSSD] [PATCHES] SYSDB ghost fix

(nested linear loops). Simo. > [PATCH 2/2] SYSDB: split sysdb_add_user > > splits add_user code to more readable blocks > > Patches are attached > > -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel ma

Re: [SSSD] [PATCH 0/3] Improve robustness of mmap cache handling

On Thu, 2012-12-20 at 14:24 +0100, Jakub Hrozek wrote: > On Thu, Dec 20, 2012 at 12:30:17PM +0100, Pavel Březina wrote: > > On 12/20/2012 06:10 AM, Simo Sorce wrote: > > >The function that reclaims free slots of memory was not very robust and > > >I think is the root ca

Re: [SSSD] [PATCH 3/3] mmap cache: invalidate cache on fatal error

On Thu, 2012-12-20 at 16:14 +0100, Pavel Březina wrote: > On 12/20/2012 02:20 PM, Simo Sorce wrote: > > On Thu, 2012-12-20 at 12:29 +0100, Pavel Březina wrote: > >> On 12/20/2012 06:10 AM, Simo Sorce wrote: > >>> -static errno_t sss_mc_get_record(struct sss_mc_c

Re: [SSSD] [PATCH 3/3] mmap cache: invalidate cache on fatal error

On Thu, 2012-12-20 at 17:03 +0100, Pavel Březina wrote: > On 12/20/2012 04:41 PM, Simo Sorce wrote: > > On Thu, 2012-12-20 at 16:14 +0100, Pavel Březina wrote: > >> On 12/20/2012 02:20 PM, Simo Sorce wrote: > >>> On Thu, 2012-12-20 at 12:29 +0100, Pavel Březina wrote:

Re: [SSSD] [PATCH] explicit null dereferenced in sss_nss_mc_get_record()

ve us an extra protection, however in this case I think we should check for rec->len > max size rather than just rec->len == MC_INVALID_VAL32. We have an invalid value for any length that exceeds the mmap region and would get a segfault if we tried to copy that much data. So if we are goi

Re: [SSSD] [PATCH 0/4] Rev.2 - Create and use an auth token object

On Thu, 2013-01-03 at 11:03 +0100, Pavel Březina wrote: > On 12/04/2012 02:30 PM, Simo Sorce wrote: > > Fixed switch/case-return errors. > > The rest is the same. > > > > Simo Sorce (4): > >Code can only check for cached passwords > >Add function to

Re: [SSSD] [PATCHES] SYSDB ghost fix

On Thu, 2012-12-20 at 08:28 -0500, Simo Sorce wrote: > On Thu, 2012-12-20 at 14:05 +0100, Ondrej Kos wrote: > > > > > > Here are two patches for the SYSDB: > > > > > > [PATCH 1/2] SYSDB: replace ghost users properly > > > > this fixes htt

Re: [SSSD] [PATCHES] SYSDB ghost fix

On Fri, 2013-01-04 at 16:15 +0100, Jakub Hrozek wrote: > On Fri, Jan 04, 2013 at 09:13:04AM -0500, Simo Sorce wrote: > > On Thu, 2012-12-20 at 08:28 -0500, Simo Sorce wrote: > > > On Thu, 2012-12-20 at 14:05 +0100, Ondrej Kos wrote: > > > > > > > >

Re: [SSSD] [PATCHES] Improve group handling in the PAC responder

On Fri, 2013-01-04 at 17:15 +0100, Sumit Bose wrote: > On Fri, Jan 04, 2013 at 04:31:03PM +0100, Jakub Hrozek wrote: > > On Fri, Dec 21, 2012 at 12:31:32PM +0100, Sumit Bose wrote: > > > On Wed, Dec 19, 2012 at 08:10:02AM -0500, Simo Sorce wrote: > > > > On Tue, 20

[SSSD] [PATCH] Fix headers

Minor cleanup. -- Simo Sorce * Red Hat, Inc * New York >From d0891ed6a9c59492c74bf86a22a69f076866bcbf Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Sun, 6 Jan 2013 00:10:06 -0500 Subject: [PATCH] Remove unused header --- src/tests/sysdb_ssh-tests.c | 1 - 1 file changed, 1 deletion(-) d

[SSSD] [PATCH] Fix faulty usn reinit

ep through the cleanup to make sure it runs as it should I would be grateful. Simo. -- Simo Sorce * Red Hat, Inc * New York >From d62b140c5ca5272df89d87866887995bd07a42a3 Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Sun, 6 Jan 2013 00:10:33 -0500 Subject: [PATCH] Fix sdap reinit. This set o

[SSSD] [PATCH] Minor tevent_req style cleanup

Patch says it all. -- Simo Sorce * Red Hat, Inc * New York >From c6c41528b62df153588ada61a2f885f66d4ea8a2 Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Sun, 6 Jan 2013 01:59:20 -0500 Subject: [PATCH] Fix tevent_req style for sdap_async_sudo. Use correct name for _done() function from

Re: [SSSD] [PATCH] Fix headers

On Sun, 2013-01-06 at 14:25 +0100, Jakub Hrozek wrote: > On Sun, Jan 06, 2013 at 02:02:23PM +0100, Jakub Hrozek wrote: > > On Sun, Jan 06, 2013 at 12:28:22AM -0500, Simo Sorce wrote: > > > Minor cleanup. > > > > > > -- > > > Simo Sorce * Red Hat

[SSSD] [PATCH] Fix redundant defines

This was funny, patch should be obvious. Simo. -- Simo Sorce * Red Hat, Inc * New York >From b684cbcac5ab87633c32268762bfa75fea0edc95 Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Sun, 6 Jan 2013 10:50:38 -0500 Subject: [PATCH] Remove redundant definition. We had 2 defines for the s

Re: [SSSD] [PATCH] Search for SHORTNAME$@REALM instead of fqdn$@REALM by default

t; previous release would have to change their config to include > ldap_sasl_authid. ACK, Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] explicit null dereferenced in sss_nss_mc_get_record()

0002: > fixes the null dereference. I'm not quite sure if it is possible to > use > struct sss_cli_mc_ctx->dt_size and data_table to validate the length. > Are those fields identical to those in struct sss_mc_ctx? ACK n.2. Simo. > > -- Simo Sorce * Red Hat, Inc * N

Re: [SSSD] [PATCHES] SYSDB ghost fix

t; + talloc_free(req); > + > +return ret; > +} > + Yeah copy&paste from samba code is not straightforward :-) Once you fix these issues you get an ACK. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCHES] SYSDB ghost fix

On Mon, 2013-01-07 at 15:24 +0100, Ondrej Kos wrote: > Thanks for the review, the indentation looked fine in vim, however my > script somehow misbehaved and haven't replaced tab's with spaces. > > New patches are attached > ACK. Simo. -- Simo Sorce

Re: [SSSD] [PATCH] explicit null dereferenced in sss_nss_mc_get_record()

On Mon, 2013-01-07 at 15:39 +0100, Pavel Březina wrote: > Thanks, new patches are attached. > > I also changed logic of MC_CHECK_RECORD_LENGTH() so it returns true > when the length is valid. ACK to all three. Simo. -- Simo Sorce * Red Hat, In

Re: [SSSD] [PATCH] sss_userdel and sss_groupdel with use_fully_qualified_names

} > +goto done; > + } Please do not repeat the call to sss_mmap_cache_pw_invalidate() twice. Call it just once after the if/else setup for delete_name. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] sss_userdel and sss_groupdel with use_fully_qualified_names

On Mon, 2013-01-07 at 16:21 +0100, Michal Židek wrote: > On 01/07/2013 04:08 PM, Simo Sorce wrote: > > On Mon, 2013-01-07 at 16:04 +0100, Michal Židek wrote: > >> +if (dom->fqnames) { > >> +fqdn = talloc_asprintf(tmp_ctx, dom->names->fq_fmt, nam

[SSSD] On talloc_new(NULL) (ab)use in SSSD

return bar; } Discuss. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] On talloc_new(NULL) (ab)use in SSSD

On Mon, 2013-01-07 at 13:04 -0500, Stephen Gallagher wrote: > On Mon 07 Jan 2013 11:47:21 AM EST, Simo Sorce wrote: > > I've always had a beef with the use of this construct in recent sssd > > code: > > > > fn() > > { > > tmp_ctx = talloc_new(NULL

[SSSD] What are the sysdb_*_netgroup_tuple() functions for ?

They seem unused, they just have a test each. Ok to kill them ? Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[SSSD] [PATCH] remove vtable from sss_cache

This is needed for a patchset I am working on. Simo. -- Simo Sorce * Red Hat, Inc * New York >From 0192f20cd95c302c570c72e55a3cfd08e7bd629e Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Mon, 7 Jan 2013 22:22:42 -0500 Subject: [PATCH] Remove unhelpful vtable from sss_cache Using a vta

Re: [SSSD] [PATCH] Fix faulty usn reinit

On Sun, 2013-01-06 at 00:37 -0500, Simo Sorce wrote: > While looking at some code my eye fell on the fact that sdap_reinit.c > was including sysdb_private.h > > That's a no-no on its own, you don't get to use private headers > liberally, or I wouldn't have marked the

[SSSD] [PATCH] USe sysdb_serch_service() in sss_cacahe

In the patches that fix the sdap_reinit functions I introduced a new service search helper sysdb_search_services() Use this helper in sss_cache instead of a home grown one with poor-man filter parser. Simo. -- Simo Sorce * Red Hat, Inc * New York >From 0535e1f30ca11e451b71bd3db9bda8f7704df

Re: [SSSD] What are the sysdb_*_netgroup_tuple() functions for ?

On Tue, 2013-01-08 at 08:53 -0500, Stephen Gallagher wrote: > On Tue 08 Jan 2013 04:01:31 AM EST, Jakub Hrozek wrote: > > On Mon, Jan 07, 2013 at 09:21:13PM -0500, Simo Sorce wrote: > >> They seem unused, they just have a test each. > >> Ok to kill them ? > > >

[SSSD] [PATCH] Remove unused netgroups sysdb functions

While working on a patchset I found these function were unused. Let's get rid of them. Simo. -- Simo Sorce * Red Hat, Inc * New York >From 49cd02e7d641cbc2278d7bbd8237b96af38406d6 Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Tue, 8 Jan 2013 10:06:07 -0500 Subject: [PATCH] Rem

Re: [SSSD] [PATCH] Remove unused netgroups sysdb functions

On Tue, 2013-01-08 at 21:45 +0100, Jakub Hrozek wrote: > On Tue, Jan 08, 2013 at 12:02:25PM -0500, Simo Sorce wrote: > > While working on a patchset I found these function were unused. > > Let's get rid of them. > > > > Simo. > > Ack Thanks, pushed to maste

Re: [SSSD] [PATCH] remove vtable from sss_cache

On Tue, 2013-01-08 at 21:52 +0100, Jakub Hrozek wrote: > On Mon, Jan 07, 2013 at 10:32:12PM -0500, Simo Sorce wrote: > > This is needed for a patchset I am working on. > > > > Simo. > > > > -- > > Simo Sorce * Red Hat, Inc * New York > > Ack T

Re: [SSSD] [PATCH] Fix faulty usn reinit

On Tue, 2013-01-08 at 21:52 +0100, Jakub Hrozek wrote: > On Mon, Jan 07, 2013 at 11:13:03PM -0500, Simo Sorce wrote: > > On Sun, 2013-01-06 at 00:37 -0500, Simo Sorce wrote: > > > While looking at some code my eye fell on the fact that sdap_reinit.c > > > wa

Re: [SSSD] [PATCH] Add a default section to a swtich-statement

tch > should fix it. The default section wasn't missing, but was explicitly left out. So that if you add a new value to the enum then you start getting errors. Please initialize ret before the switch instead. (NACK) Simo. -- Simo Sorce * Red Hat, Inc * New York _

Re: [SSSD] [PATCH] Add a default section to a swtich-statement

on't see the warning even though I seem to be using very similar > > CFLAGS to Sumit's. But the patch is correct, Ack. > > I fixed a typo in the commit message (s/swtich/switch) and pushed to > patch to master. I will send a revert with the correct fix!

Re: [SSSD] [PATCH] Add a default section to a swtich-statement

On Wed, 2013-01-09 at 08:35 -0500, Simo Sorce wrote: > On Wed, 2013-01-09 at 11:37 +0100, Jakub Hrozek wrote: > > On Wed, Jan 09, 2013 at 11:31:53AM +0100, Jakub Hrozek wrote: > > > On Wed, Jan 09, 2013 at 10:51:34AM +0100, Sumit Bose wrote: > > > > Hi, > > &

Re: [SSSD] [PATCH] Add a default section to a swtich-statement

On Wed, 2013-01-09 at 08:38 -0500, Simo Sorce wrote: > On Wed, 2013-01-09 at 08:35 -0500, Simo Sorce wrote: > > On Wed, 2013-01-09 at 11:37 +0100, Jakub Hrozek wrote: > > > On Wed, Jan 09, 2013 at 11:31:53AM +0100, Jakub Hrozek wrote: > > > > On Wed, Jan 09, 2013 a

Re: [SSSD] [PATCH] Add a default section to a swtich-statement

On Wed, 2013-01-09 at 08:45 -0500, Simo Sorce wrote: > On Wed, 2013-01-09 at 08:38 -0500, Simo Sorce wrote: > > On Wed, 2013-01-09 at 08:35 -0500, Simo Sorce wrote: > > > On Wed, 2013-01-09 at 11:37 +0100, Jakub Hrozek wrote: > > > > On Wed, Jan 09, 2013 at 11:31:

Re: [SSSD] [PATCH] Fix faulty usn reinit

; one soon. > > Squash in the attached fix and you'll get an ack even for patch #3 :-) Rebase attached. Simo. -- Simo Sorce * Red Hat, Inc * New York >From aac67087730dd705292237b497d75bc508bb8983 Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Sun, 6 Jan 2013 00:10:33 -0500 Sub

Re: [SSSD] [PATCH] Add a default section to a swtich-statement

On Wed, 2013-01-09 at 16:31 +0100, Sumit Bose wrote: > On Wed, Jan 09, 2013 at 10:19:29AM -0500, Simo Sorce wrote: > > On Wed, 2013-01-09 at 08:45 -0500, Simo Sorce wrote: > > > On Wed, 2013-01-09 at 08:38 -0500, Simo Sorce wrote: > > > > On Wed, 2013-01-09 at

Re: [SSSD] [PATCH] USe sysdb_serch_service() in sss_cacahe

On Thu, 2013-01-10 at 11:22 +0100, Pavel Březina wrote: > On 01/08/2013 05:10 AM, Simo Sorce wrote: > > In the patches that fix the sdap_reinit functions I introduced a new > > service search helper sysdb_search_services() > > > > Use this helper in sss_cache instead of

Re: [SSSD] [PATCH] USe sysdb_serch_service() in sss_cacahe

On Thu, 2013-01-10 at 11:06 -0500, Simo Sorce wrote: > On Thu, 2013-01-10 at 11:22 +0100, Pavel Březina wrote: > > On 01/08/2013 05:10 AM, Simo Sorce wrote: > > > In the patches that fix the sdap_reinit functions I introduced a new > > > service search h

Re: [SSSD] [PATCH] USe sysdb_serch_service() in sss_cacahe

On Thu, 2013-01-10 at 17:28 +0100, Jakub Hrozek wrote: > On Thu, Jan 10, 2013 at 11:13:05AM -0500, Simo Sorce wrote: > > On Thu, 2013-01-10 at 11:06 -0500, Simo Sorce wrote: > > > On Thu, 2013-01-10 at 11:22 +0100, Pavel Březina wrote: > > > > On 01/08/2013 05:10 AM,

Re: [SSSD] [PATCH 0/4] Rev.2 - Create and use an auth token object

On Thu, 2013-01-10 at 11:04 +0100, Pavel Březina wrote: > On 12/04/2012 02:30 PM, Simo Sorce wrote: > > Fixed switch/case-return errors. > > The rest is the same. > > > > Simo Sorce (4): > >Code can only check for cached passwords > >Add function to

Re: [SSSD] [PATCHES] Initial refactoring for #1747

On Tue, 2013-01-08 at 23:15 -0500, Simo Sorce wrote: > Attached find a somewhat big patchset composed of 59 patches. > These patches start to address #1747 by changing a fundamental issue in > the current code where the sysdb_ctx structure includes a reference to a > sss_domain_info o

Re: [SSSD] [PATCH] USe sysdb_serch_service() in sss_cacahe

On Thu, 2013-01-10 at 19:44 +0100, Michal Židek wrote: > On 01/10/2013 06:04 PM, Simo Sorce wrote: > > On Thu, 2013-01-10 at 17:28 +0100, Jakub Hrozek wrote: > >> On Thu, Jan 10, 2013 at 11:13:05AM -0500, Simo Sorce wrote: > >>> On Thu, 2013-01-10 at 11:06 -0500, S

Re: [SSSD] [PATCHES] Initial refactoring for #1747

On Thu, 2013-01-10 at 20:29 +0100, Jakub Hrozek wrote: > On Thu, Jan 10, 2013 at 12:39:53PM -0500, Simo Sorce wrote: > > On Tue, 2013-01-08 at 23:15 -0500, Simo Sorce wrote: > > > Attached find a somewhat big patchset composed of 59 patches. > > > These patches start to

Re: [SSSD] [PATCH 0/2] [REBASE-2] Refactor krb5_child code

On Fri, 2013-01-11 at 09:46 +0100, Pavel Březina wrote: > On 12/02/2012 06:01 AM, Simo Sorce wrote: > > Rebased as per PAvel's requests. > > > > Simo Sorce (2): > >krb5_child style fix > >Refactor krb5 child > >

Re: [SSSD] [PATCHES] Initial refactoring for #1747

On Thu, 2013-01-10 at 20:34 +0100, Jakub Hrozek wrote: > On Thu, Jan 10, 2013 at 08:29:36PM +0100, Jakub Hrozek wrote: > > On Thu, Jan 10, 2013 at 12:39:53PM -0500, Simo Sorce wrote: > > > On Tue, 2013-01-08 at 23:15 -0500, Simo Sorce wrote: > > > > Attached find a

Re: [SSSD] [PATCHES] Initial refactoring for #1747

On Fri, 2013-01-11 at 08:54 -0500, Simo Sorce wrote: > On Thu, 2013-01-10 at 20:34 +0100, Jakub Hrozek wrote: > > On Thu, Jan 10, 2013 at 08:29:36PM +0100, Jakub Hrozek wrote: > > > On Thu, Jan 10, 2013 at 12:39:53PM -0500, Simo Sorce wrote: > > > > On Tue, 2013-01

[SSSD] [PATCHES] Minor cleanups

While working on a new patchset I found bits that can be cleaned up. These patches have been built on top of my previous big patchset but should apply as is against current master too. Simo. -- Simo Sorce * Red Hat, Inc * New York >From 275c46de8132a741ab730417080df06176cfc997 Mon Sep 17 00

<    7   8   9   10   11   12   13   14   15   16   >