[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (comment)

2016-09-06 Thread jhrozek
jhrozek commented on a pull request """ On Tue, Sep 06, 2016 at 04:54:29AM -0700, lslebodn wrote: > On (06/09/16 03:14), Jakub Hrozek wrote: > >The log said: > >(Tue Sep 6 15:18:31:935105 2016) [sss_groupadd] > >[sysdb_timestamp_cache_connect] (0x0400): No t

[SSSD] [sssd PR#10] UTIL: Remove support to libini older than 1.0.0 (comment)

2016-09-06 Thread jhrozek
jhrozek commented on a pull request """ On Tue, Sep 06, 2016 at 05:16:00AM -0700, fidencio wrote: > The distributions that would break with this patch are: > - RHEL/CentOS 5 and older I don't think we care about RHEL-5 with master and I'm not sure sssd master even buil

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (comment)

2016-09-06 Thread jhrozek
jhrozek commented on a pull request """ good idea """ See the full comment at https://github.com/SSSD/sssd/pull/15#issuecomment-244944667 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fed

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (-ack)

2016-09-06 Thread jhrozek
jhrozek's pull request #15: "Avoid returning System Error on clock skew" label *ack* has been removed See the full pull-request at https://github.com/SSSD/sssd/pull/15 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#16] TOOLS: sss_groupshow did not work (+nack)

2016-09-06 Thread jhrozek
mzidek-rh's pull request #16: "TOOLS: sss_groupshow did not work" label *nack* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/16 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (+nack)

2016-09-06 Thread jhrozek
jhrozek's pull request #15: "Avoid returning System Error on clock skew" label *nack* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/15 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (opened)

2016-09-06 Thread jhrozek
jhrozek's pull request #15: "Avoid returning System Error on clock skew" was opened PR body: """ Rather return ERR_NETWORK_IO and at least let the user authenticate offline. """ See the full pull-request at https://github.com/SSSD/sssd/pull/15 ... or pull the PR as Git branch: git remote add

[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (opened)

2016-09-06 Thread jhrozek
jhrozek's pull request #14: "Attempting to create a qualified name from a NULL pointer broke sss_groupadd" was opened PR body: """ The log said: (Tue Sep 6 15:18:31:935105 2016) [sss_groupadd] [sysdb_timestamp_cache_connect] (0x0400): No timestamp cache for LOCAL (Tue Sep 6 15:18:31:935255

[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (synchronize)

2016-09-06 Thread jhrozek
jhrozek's pull request #14: "Attempting to create a qualified name from a NULL pointer broke sss_groupadd" was synchronize See the full pull-request at https://github.com/SSSD/sssd/pull/14 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd

[SSSD] [sssd PR#7] Fix initgroups with nested groups (comment)

2016-09-01 Thread jhrozek
jhrozek commented on a pull request """ On Wed, Aug 31, 2016 at 07:15:10AM -0700, lslebodn wrote: > On (31/08/16 01:47), sumit-bose wrote: > >On Wed, Aug 31, 2016 at 01:30:12AM -0700, Jakub Hrozek wrote: > >> On Wed, Aug 31, 2016 at 12:36:37AM -0700, sumit-bose w

[SSSD] [sssd PR#8] MAN: Document the ldap_user_gid_number option (comment)

2016-09-01 Thread jhrozek
jhrozek commented on a pull request """ * master: 6f59bb822d1e54e178207be45e382f4ee173c434 """ See the full comment at https://github.com/SSSD/sssd/pull/8#issuecomment-244054299 ___ sssd-devel mailing list sssd-deve

[SSSD] [sssd PR#8] MAN: Document the ldap_user_gid_number option (closed)

2016-09-01 Thread jhrozek
jhrozek's pull request #8: "MAN: Document the ldap_user_gid_number option" was closed See the full pull-request at https://github.com/SSSD/sssd/pull/8 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/8/head:pr8 git checkout pr8

[SSSD] [sssd PR#7] Fix initgroups with nested groups (+pushed)

2016-09-01 Thread jhrozek
sumit-bose's pull request #7: "Fix initgroups with nested groups" label *pushed* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/7 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#9] SYSDB: Removing of unused parametr (+pushed)

2016-09-01 Thread jhrozek
celestian's pull request #9: "SYSDB: Removing of unused parametr" label *pushed* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/9 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#9] SYSDB: Removing of unused parametr (comment)

2016-09-01 Thread jhrozek
jhrozek commented on a pull request """ * master: 0d1d9d8001232f74eca63cbba6c400d507b33823 """ See the full comment at https://github.com/SSSD/sssd/pull/9#issuecomment-244058945 ___ sssd-devel mailing list sssd-deve

[SSSD] [sssd PR#9] SYSDB: Removing of unused parametr (closed)

2016-09-01 Thread jhrozek
celestian's pull request #9: "SYSDB: Removing of unused parametr" was closed See the full pull-request at https://github.com/SSSD/sssd/pull/9 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/9/head:pr9 git checkout pr9

[SSSD] [sssd PR#7] Fix initgroups with nested groups (comment)

2016-09-01 Thread jhrozek
jhrozek commented on a pull request """ * master: 5bd3bef4a655fdfacd2f5df8a2343fe7bc68a771 """ See the full comment at https://github.com/SSSD/sssd/pull/7#issuecomment-244058146 ___ sssd-devel mailing list sssd-deve

[SSSD] [sssd PR#7] Fix initgroups with nested groups (closed)

2016-09-01 Thread jhrozek
sumit-bose's pull request #7: "Fix initgroups with nested groups" was closed See the full pull-request at https://github.com/SSSD/sssd/pull/7 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/7/head:pr7 git checkout pr7

[SSSD] [sssd PR#7] Fix initgroups with nested groups (comment)

2016-08-30 Thread jhrozek
jhrozek commented on a pull request """ On Tue, Aug 30, 2016 at 11:47:09AM -0700, lslebodn wrote: > Please provide a test-case (probably a hierarchy of groups) I was able to reproduce with: $ ipa group-show group20 Group name: group20 GID: 935600011 Member groups

[SSSD] [sssd PR#7] Fix initgroups with nested groups (comment)

2016-08-30 Thread jhrozek
jhrozek commented on a pull request """ OK, also looking at gdb confirms this is the right fix of course: (gdb) frame 0 #0 sdap_initgr_nested_get_membership_diff (mem_ctx=0x1176190, sysdb=0x1120040, opts=0x1134d90, dom=0x110b610, group=0x1184b80, all_groups=0x1184a80,

[SSSD] [sssd PR#7] Fix initgroups with nested groups (+ack)

2016-08-30 Thread jhrozek
sumit-bose's pull request #7: "Fix initgroups with nested groups" label *ack* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/7 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (+rejected)

2016-09-07 Thread jhrozek
jhrozek's pull request #14: "Attempting to create a qualified name from a NULL pointer broke sss_groupadd" label *rejected* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/14 ___ sssd-devel mailing list

[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (comment)

2016-09-07 Thread jhrozek
jhrozek commented on a pull request """ On Tue, Sep 06, 2016 at 10:23:13AM -0700, mzidek-rh wrote: > The PR#16 includes jhrozek's patch from this PR as well as CI test + fix for > sss_groupshow. OK, thank you, I will close this one as rejected (just so that we don't tr

[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (-Changes requested)

2016-09-07 Thread jhrozek
jhrozek's pull request #14: "Attempting to create a qualified name from a NULL pointer broke sss_groupadd" label *Changes requested* has been removed See the full pull-request at https://github.com/SSSD/sssd/pull/14 ___ sssd-devel mailing list

[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (-rejected)

2016-09-07 Thread jhrozek
jhrozek's pull request #14: "Attempting to create a qualified name from a NULL pointer broke sss_groupadd" label *rejected* has been removed See the full pull-request at https://github.com/SSSD/sssd/pull/14 ___ sssd-devel mailing list

[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (+rejected)

2016-09-07 Thread jhrozek
jhrozek's pull request #14: "Attempting to create a qualified name from a NULL pointer broke sss_groupadd" label *rejected* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/14 ___ sssd-devel mailing list

[SSSD] [sssd PR#10] UTIL: Remove support to libini older than 1.0.0 (comment)

2016-09-07 Thread jhrozek
jhrozek commented on a pull request """ On Tue, Sep 06, 2016 at 11:49:09AM -0700, lslebodn wrote: > IMHO, it might be better to close this PR. > If we decide to dor support for libini_config < 1.1 or 1.2 > then it will be a different patch anyway. @see my previous

[SSSD] [sssd PR#6] Applications should never define _USE_GNU themselves, but rely on _GNU_SOURCE (comment)

2016-08-30 Thread jhrozek
jhrozek commented on a pull request """ * master: 1384d0ce6ea741aefb56b0006b6268d76e6cc2c2 """ See the full comment at https://github.com/SSSD/sssd/pull/6#issuecomment-243453157 ___ sssd-devel mailing list sssd-deve

[SSSD] [sssd PR#6] Applications should never define _USE_GNU themselves, but rely on _GNU_SOURCE (-ack)

2016-08-30 Thread jhrozek
jhrozek's pull request #6: "Applications should never define _USE_GNU themselves, but rely on _GNU_SOURCE" label *ack* has been removed See the full pull-request at https://github.com/SSSD/sssd/pull/6 ___ sssd-devel mailing list

[SSSD] [sssd PR#6] Applications should never define _USE_GNU themselves, but rely on _GNU_SOURCE (+pushed)

2016-08-30 Thread jhrozek
jhrozek's pull request #6: "Applications should never define _USE_GNU themselves, but rely on _GNU_SOURCE" label *pushed* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/6 ___ sssd-devel mailing list

[SSSD] [sssd PR#6] Applications should never define _USE_GNU themselves, but rely on _GNU_SOURCE (closed)

2016-08-30 Thread jhrozek
jhrozek's pull request #6: "Applications should never define _USE_GNU themselves, but rely on _GNU_SOURCE" was closed See the full pull-request at https://github.com/SSSD/sssd/pull/6 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd

[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (closed)

2016-09-07 Thread jhrozek
jhrozek's pull request #14: "Attempting to create a qualified name from a NULL pointer broke sss_groupadd" was closed See the full pull-request at https://github.com/SSSD/sssd/pull/14 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd

[SSSD] [sssd PR#19] KRB5: Send the output username, not internal fqname to krb5_child (opened)

2016-09-07 Thread jhrozek
jhrozek's pull request #19: "KRB5: Send the output username, not internal fqname to krb5_child" was opened PR body: """ Resolves: https://fedorahosted.org/sssd/ticket/3172 krb5_child calls krb5_kuserok() during the access phase which checks if a particular user is allowed to authenticate as

[SSSD] [sssd PR#19] KRB5: Send the output username, not internal fqname to krb5_child (comment)

2016-09-07 Thread jhrozek
jhrozek commented on a pull request """ btw feel free to ping me on RH IRC for a link that shows the patch fixes the RH tests.. """ See the full comment at https://github.com/SSSD/sssd/pull/19#issuecomment-245325705 __

[SSSD] [sssd PR#8] MAN: Document the ldap_user_gid_number option (opened)

2016-08-31 Thread jhrozek
jhrozek's pull request #8: "MAN: Document the ldap_user_gid_number option" was opened PR body: """ Some users, mostly those who cannot join the Linux machines to their AD domain resort to using the LDAP provider with ID mapping. But in order for that to work correctly, the ldap_user_gid_number

[SSSD] [sssd PR#7] Fix initgroups with nested groups (comment)

2016-08-31 Thread jhrozek
jhrozek commented on a pull request """ On Wed, Aug 31, 2016 at 12:36:37AM -0700, sumit-bose wrote: > On Tue, Aug 30, 2016 at 12:36:20PM -0700, Jakub Hrozek wrote: > > On Tue, Aug 30, 2016 at 11:47:09AM -0700, lslebodn wrote: > > > > About the dis

[SSSD] [sssd PR#5] Miscellanous patches for the sssd-secrets responder (closed)

2016-08-30 Thread jhrozek
jhrozek's pull request #5: "Miscellanous patches for the sssd-secrets responder" was closed See the full pull-request at https://github.com/SSSD/sssd/pull/5 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5/head:pr5 git checkout pr5

[SSSD] [sssd PR#5] Miscellanous patches for the sssd-secrets responder (+pushed)

2016-08-30 Thread jhrozek
jhrozek's pull request #5: "Miscellanous patches for the sssd-secrets responder" label *pushed* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/5 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#5] Miscellanous patches for the sssd-secrets responder (-ack)

2016-08-30 Thread jhrozek
jhrozek's pull request #5: "Miscellanous patches for the sssd-secrets responder" label *ack* has been removed See the full pull-request at https://github.com/SSSD/sssd/pull/5 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#19] KRB5: Send the output username, not internal fqname to krb5_child (closed)

2016-09-11 Thread jhrozek
jhrozek's pull request #19: "KRB5: Send the output username, not internal fqname to krb5_child" was closed See the full pull-request at https://github.com/SSSD/sssd/pull/19 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/19/head:pr19 git

[SSSD] [sssd PR#19] KRB5: Send the output username, not internal fqname to krb5_child (+Pushed)

2016-09-11 Thread jhrozek
jhrozek's pull request #19: "KRB5: Send the output username, not internal fqname to krb5_child" label *Pushed* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/19 ___ sssd-devel mailing list

[SSSD] [sssd PR#18] [PATCHES] sss_user/groupmod fixes (closed)

2016-09-11 Thread jhrozek
mzidek-rh's pull request #18: "[PATCHES] sss_user/groupmod fixes" was closed See the full pull-request at https://github.com/SSSD/sssd/pull/18 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/18/head:pr18 git checkout pr18

[SSSD] [sssd PR#17] Improve support for gdm Smartcard support (+Accepted)

2016-09-12 Thread jhrozek
sumit-bose's pull request #17: "Improve support for gdm Smartcard support" label *Accepted* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/17 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#17] Improve support for gdm Smartcard support (comment)

2016-09-12 Thread jhrozek
jhrozek commented on a pull request """ I only read the code, haven't done any testing, really. I will push once CI finishes. """ See the full comment at https://github.com/SSSD/sssd/pull/17#issuecomment-246290312 __

[SSSD] [sssd PR#16] TOOLS: sss_groupshow did not work (closed)

2016-09-12 Thread jhrozek
mzidek-rh's pull request #16: "TOOLS: sss_groupshow did not work" was closed See the full pull-request at https://github.com/SSSD/sssd/pull/16 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/16/head:pr16 git checkout pr16

[SSSD] [sssd PR#22] In commit c420ce830ac0b0b288a2a887ec2cfce5c748018c we changed a way how we (opened)

2016-09-12 Thread jhrozek
jhrozek's pull request #22: "In commit c420ce830ac0b0b288a2a887ec2cfce5c748018c we changed a way how we" was opened PR body: """ 'try a next server' in order to fix https://fedorahosted.org/sssd/ticket/3009. But since this change, results that return adminlimit exceeded (11) also mark the

[SSSD] [sssd PR#22] LDAP: Return partial results from adminlimit exceeded (edited)

2016-09-12 Thread jhrozek
jhrozek's pull request #22: "LDAP: Return partial results from adminlimit exceeded" was edited See the full pull-request at https://github.com/SSSD/sssd/pull/22 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/22/head:pr22 git checkout

[SSSD] [sssd PR#22] LDAP: Return partial results from adminlimit exceeded (edited)

2016-09-12 Thread jhrozek
jhrozek's pull request #22: "LDAP: Return partial results from adminlimit exceeded" was edited See the full pull-request at https://github.com/SSSD/sssd/pull/22 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/22/head:pr22 git checkout

[SSSD] [sssd PR#25] TESTS: Add integration tests for the proxy provider of sssd-secrets (comment)

2016-09-14 Thread jhrozek
jhrozek commented on a pull request """ btw here are CI tests on all supported systems: http://sssd-ci.duckdns.org/logs/job/53/41/summary.html """ See the full comment at https://github.com/SSSD/sssd/pull/25#issuecomment-246998696

[SSSD] [sssd PR#26] KRB5: Fixing FQ name of user in krb5_setup() (comment)

2016-09-14 Thread jhrozek
jhrozek commented on a pull request """ Why not do it the other way around and qualify all names in the mapping? That needs to be done only once unlike this approach that needs to unqualify the names every time they are used. """ See the full comment at https:

[SSSD] [sssd PR#26] KRB5: Fixing FQ name of user in krb5_setup() (+Changes requested)

2016-09-14 Thread jhrozek
celestian's pull request #26: "KRB5: Fixing FQ name of user in krb5_setup()" label *Changes requested* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/26 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#11] SECRETS: Don't remove a container when it has children (+Accepted)

2016-09-14 Thread jhrozek
fidencio's pull request #11: "SECRETS: Don't remove a container when it has children" label *Accepted* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/11 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#20] sss_override fails to export (closed)

2016-09-14 Thread jhrozek
mzidek-rh's pull request #20: "sss_override fails to export" was closed See the full pull-request at https://github.com/SSSD/sssd/pull/20 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/20/head:pr20 git checkout pr20

[SSSD] [sssd PR#24] MAN: Add a manpage for the sssd-secrets responder (opened)

2016-09-14 Thread jhrozek
jhrozek's pull request #24: "MAN: Add a manpage for the sssd-secrets responder" was opened PR body: """ The manpage lists the options and adds API examples. """ See the full pull-request at https://github.com/SSSD/sssd/pull/24 ... or pull the PR as Git branch: git remote add ghsssd

[SSSD] [sssd PR#25] TESTS: Add integration tests for the proxy provider of sssd-secrets (opened)

2016-09-14 Thread jhrozek
jhrozek's pull request #25: "TESTS: Add integration tests for the proxy provider of sssd-secrets" was opened PR body: """ Execrcies the basic operations of the sssd-secrets responder and can be used as a basis to add more tests. """ See the full pull-request at

[SSSD] [sssd PR#11] SECRETS: Don't remove a container when it has children (comment)

2016-09-14 Thread jhrozek
jhrozek commented on a pull request """ The first patch was already pushed. The second looks good to me visually and I wrote a simple patch to verify the fix: https://github.com/jhrozek/sssd/commit/374eff89472a3181548495ed74deadaa690e921e """ See the full comme

[SSSD] [sssd PR#22] LDAP: Return partial results from adminlimit exceeded (comment)

2016-09-14 Thread jhrozek
jhrozek commented on a pull request """ On Tue, Sep 13, 2016 at 01:33:49AM -0700, mzidek-rh wrote: > Makes sense, but I would prefer to add new "else if" branch with > ADMINLIMIT_EXCEEDED specific debug message. > > It would also make sense to chan

[SSSD] [sssd PR#22] LDAP: Return partial results from adminlimit exceeded (closed)

2016-09-14 Thread jhrozek
jhrozek's pull request #22: "LDAP: Return partial results from adminlimit exceeded" was closed See the full pull-request at https://github.com/SSSD/sssd/pull/22 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/22/head:pr22 git checkout

[SSSD] [sssd PR#22] LDAP: Return partial results from adminlimit exceeded (comment)

2016-09-14 Thread jhrozek
jhrozek commented on a pull request """ * master: 3319d964721396c07daba383ded6aaaf33ed6e3b """ See the full comment at https://github.com/SSSD/sssd/pull/22#issuecomment-246954357 ___ sssd-devel mailing list sssd-deve

[SSSD] [sssd PR#22] LDAP: Return partial results from adminlimit exceeded (+Pushed)

2016-09-14 Thread jhrozek
jhrozek's pull request #22: "LDAP: Return partial results from adminlimit exceeded" label *Pushed* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/22 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#22] LDAP: Return partial results from adminlimit exceeded (-Accepted)

2016-09-14 Thread jhrozek
jhrozek's pull request #22: "LDAP: Return partial results from adminlimit exceeded" label *Accepted* has been removed See the full pull-request at https://github.com/SSSD/sssd/pull/22 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (closed)

2016-09-13 Thread jhrozek
jhrozek's pull request #15: "Avoid returning System Error on clock skew" was closed See the full pull-request at https://github.com/SSSD/sssd/pull/15 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/15/head:pr15 git checkout pr15

[SSSD] [sssd PR#23] sss_groupshow does not work with mpg (+Pushed)

2016-09-13 Thread jhrozek
mzidek-rh's pull request #23: "sss_groupshow does not work with mpg" label *Pushed* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/23 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (+Pushed)

2016-09-13 Thread jhrozek
jhrozek's pull request #15: "Avoid returning System Error on clock skew" label *Pushed* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/15 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (-Accepted)

2016-09-13 Thread jhrozek
jhrozek's pull request #15: "Avoid returning System Error on clock skew" label *Accepted* has been removed See the full pull-request at https://github.com/SSSD/sssd/pull/15 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#23] sss_groupshow does not work with mpg (closed)

2016-09-13 Thread jhrozek
mzidek-rh's pull request #23: "sss_groupshow does not work with mpg" was closed See the full pull-request at https://github.com/SSSD/sssd/pull/23 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/23/head:pr23 git checkout pr23

[SSSD] [sssd PR#24][comment] MAN: Add a manpage for the sssd-secrets responder

2016-09-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/24 Title: #24: MAN: Add a manpage for the sssd-secrets responder jhrozek commented: """ it would be nice if @simo5 or @tiran could skim over the manpage """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#24][synchronized] MAN: Add a manpage for the sssd-secrets responder

2016-09-26 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/24 Author: jhrozek Title: #24: MAN: Add a manpage for the sssd-secrets responder Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/24/head:pr24 git checkout pr24 From

[SSSD] [sssd PR#31][comment] nss: allow UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME

2016-09-26 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/31 Title: #31: nss: allow UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME jhrozek commented: """ I'm sorry the review took so long. The patch mostly looks good, but see the two questions though the github review tool. I also wrote

[SSSD] [sssd PR#24][comment] MAN: Add a manpage for the sssd-secrets responder

2016-09-26 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/24 Title: #24: MAN: Add a manpage for the sssd-secrets responder jhrozek commented: """ Thank you for the review. I accepted both your suggestions. I hope we can merge the patch once the CI finishes. """ See the full comme

[SSSD] [sssd PR#24][-Accepted] MAN: Add a manpage for the sssd-secrets responder

2016-09-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/24 Title: #24: MAN: Add a manpage for the sssd-secrets responder Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#24][+Pushed] MAN: Add a manpage for the sssd-secrets responder

2016-09-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/24 Title: #24: MAN: Add a manpage for the sssd-secrets responder Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#24][comment] MAN: Add a manpage for the sssd-secrets responder

2016-09-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/24 Title: #24: MAN: Add a manpage for the sssd-secrets responder jhrozek commented: """ * master: 54c64aad71e6792edb7cf99988d9a7f4bc2b0c61 """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#33][comment] SECRETS: Some small misc fixes + fixing #3168

2016-09-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/33 Title: #33: SECRETS: Some small misc fixes + fixing #3168 jhrozek commented: """ On Thu, Sep 29, 2016 at 02:37:11PM -0700, fidencio wrote: > So, I've pushed a new version of the patches and I tried to address > all comments mad

[SSSD] [sssd PR#34][comment] cache_req: move from switch to plugins

2016-09-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/34 Title: #34: cache_req: move from switch to plugins jhrozek commented: """ I'm fine with the approach but I didn't read the code line-by-line. We should make sure the code coverage remains high. """ See the full comment at

[SSSD] [sssd PR#33][comment] SECRETS: Some small misc fixes + fixing #3168

2016-09-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/33 Title: #33: SECRETS: Some small misc fixes + fixing #3168 jhrozek commented: """ On Fri, Sep 30, 2016 at 12:26:46AM -0700, Jakub Hrozek wrote: > I just pushed the documentation patch. Could you please rebase this > series atop or

[SSSD] [sssd PR#34][comment] cache_req: move from switch to plugins

2016-09-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/34 Title: #34: cache_req: move from switch to plugins jhrozek commented: """ on another note, this commit might be a reason to split 1.14 and master.. """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#34][comment] cache_req: move from switch to plugins

2016-09-30 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/34 Title: #34: cache_req: move from switch to plugins jhrozek commented: """ Great. The next thing is...is there a way to split the commit a bit more? I have no idea how to review a 1800+ lines commit.. """ See the full

[SSSD] [sssd PR#36][+Accepted] Partial fix for #3169

2016-10-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/36 Title: #36: Partial fix for #3169 Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#36][comment] Partial fix for #3169

2016-10-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/36 Title: #36: Partial fix for #3169 jhrozek commented: """ Thank you, the patch looks good to me now and returns an error code (tested manually). ACK. """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#36][-Accepted] Partial fix for #3169

2016-10-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/36 Title: #36: Partial fix for #3169 Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#36][comment] Partial fix for #3169

2016-10-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/36 Title: #36: Partial fix for #3169 jhrozek commented: """ * master: 65a38b8c9cabde6c46cc0e9868f54cb9bb10afbf """ See the full comment at https://github.com/SSSD/sssd/pull/36#issuecomment-251634041 __

[SSSD] [sssd PR#36][+Pushed] Partial fix for #3169

2016-10-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/36 Title: #36: Partial fix for #3169 Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#36][closed] Partial fix for #3169

2016-10-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/36 Author: fidencio Title: #36: Partial fix for #3169 Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/36/head:pr36 git checkout pr36 ___

[SSSD] [sssd PR#38][comment] IPA: Initialize has_changes boolean control value

2016-10-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/38 Title: #38: IPA: Initialize has_changes boolean control value jhrozek commented: """ CI: http://sssd-ci.duckdns.org/logs/job/54/57/summary.html """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#37][closed] Add DEBUG messages to the sssd-secrets responder

2016-10-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/37 Author: jhrozek Title: #37: Add DEBUG messages to the sssd-secrets responder Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/37/head:pr37 git checkout pr37

[SSSD] [sssd PR#37][+Pushed] Add DEBUG messages to the sssd-secrets responder

2016-10-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/37 Title: #37: Add DEBUG messages to the sssd-secrets responder Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#38][+Pushed] IPA: Initialize has_changes boolean control value

2016-10-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/38 Title: #38: IPA: Initialize has_changes boolean control value Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#38][closed] IPA: Initialize has_changes boolean control value

2016-10-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/38 Author: jhrozek Title: #38: IPA: Initialize has_changes boolean control value Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/38/head:pr38 git checkout pr38

[SSSD] [sssd PR#38][comment] IPA: Initialize has_changes boolean control value

2016-10-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/38 Title: #38: IPA: Initialize has_changes boolean control value jhrozek commented: """ master: 7b07f50dfdfa1e94c82d86a957ee7c9852d7a322 """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#38][-Accepted] IPA: Initialize has_changes boolean control value

2016-10-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/38 Title: #38: IPA: Initialize has_changes boolean control value Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#37][comment] Add DEBUG messages to the sssd-secrets responder

2016-10-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/37 Title: #37: Add DEBUG messages to the sssd-secrets responder jhrozek commented: """ CI: http://sssd-ci.duckdns.org/logs/job/54/58/summary.html """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#37][-Accepted] Add DEBUG messages to the sssd-secrets responder

2016-10-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/37 Title: #37: Add DEBUG messages to the sssd-secrets responder Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#37][comment] Add DEBUG messages to the sssd-secrets responder

2016-10-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/37 Title: #37: Add DEBUG messages to the sssd-secrets responder jhrozek commented: """ Pushed to master in 41cd6072648bb7a9e14e56ed38004a2947f67657 f931864f46cb19346be45f3b6f55da54c8dc7078 8fe4f98192aa23729d3607bf2

[SSSD] [sssd PR#30][comment] sssctl: use systemd D-Bus API

2016-10-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/30 Title: #30: sssctl: use systemd D-Bus API jhrozek commented: """ Hey @pbrezina just making sure you didn't miss the review. About /sbin/service...since there are fewer and fewer non-systemd systemd, I wouldn't bother making this conf

[SSSD] [sssd PR#30][comment] sssctl: use systemd D-Bus API

2016-10-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/30 Title: #30: sssctl: use systemd D-Bus API jhrozek commented: """ Hey @pbrezina just making sure you didn't miss the review. About /sbin/service...since there are fewer and fewer non-systemd systems, I wouldn't bother making this conf

[SSSD] [sssd PR#38][comment] IPA: Initialize has_changes boolean control value

2016-10-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/38 Title: #38: IPA: Initialize has_changes boolean control value jhrozek commented: """ On Tue, Oct 04, 2016 at 12:32:44PM -0700, fidencio wrote: > Your text editor puts 4 spaces before the link for the bug. Please, avoid it. > A

[SSSD] [sssd PR#38][synchronized] IPA: Initialize has_changes boolean control value

2016-10-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/38 Author: jhrozek Title: #38: IPA: Initialize has_changes boolean control value Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/38/head:pr38 git checkout pr38 From

[SSSD] [sssd PR#38][comment] IPA: Initialize has_changes boolean control value

2016-10-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/38 Title: #38: IPA: Initialize has_changes boolean control value jhrozek commented: """ OK, pushed a new version of the patch (just the commit message differs) and I'll push it to upstream if there are no further comments. "&quo

[SSSD] [sssd PR#38][synchronized] IPA: Initialize has_changes boolean control value

2016-10-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/38 Author: jhrozek Title: #38: IPA: Initialize has_changes boolean control value Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/38/head:pr38 git checkout pr38 From

<    1   2   3   4   5   6   7   8   9   10   >