[SSSD] [sssd PR#15] Avoid returning System Error on clock skew (comment)

2016-09-07 Thread jhrozek
jhrozek commented on a pull request """ On Tue, Sep 06, 2016 at 06:09:58AM -0700, Jakub Hrozek wrote: > good idea ah, only when I started to implement this I realized it's already done :) See: https://github.com/SSSD/sssd/blob/master/src/providers/krb5/krb5_child.c#L1

[SSSD] [sssd PR#24][comment] MAN: Add a manpage for the sssd-secrets responder

2016-09-28 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/24 Title: #24: MAN: Add a manpage for the sssd-secrets responder jhrozek commented: """ On Mon, Sep 26, 2016 at 01:29:12PM -0700, lslebodn wrote: > lslebodn commented on this pull request. > > > > > +The se

[SSSD] [sssd PR#33][+Changes requested] SECRETS: Some small misc fixes + fixing #3136

2016-09-28 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/33 Title: #33: SECRETS: Some small misc fixes + fixing #3136 Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#33][comment] SECRETS: Some small misc fixes + fixing #3136

2016-09-28 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/33 Title: #33: SECRETS: Some small misc fixes + fixing #3136 jhrozek commented: """ Adding "Changes Requested" tag to reflect @lslebodn comment. I will also take a look at this patch set. """ See the full comment

[SSSD] [sssd PR#31][comment] nss: allow UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME

2016-09-28 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/31 Title: #31: nss: allow UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME jhrozek commented: """ On Mon, Sep 26, 2016 at 02:43:03AM -0700, sumit-bose wrote: > On Mon, Sep 26, 2016 at 02:13:08AM -0700, Jakub Hrozek wrote: >

[SSSD] [sssd PR#24][comment] MAN: Add a manpage for the sssd-secrets responder

2016-09-28 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/24 Title: #24: MAN: Add a manpage for the sssd-secrets responder jhrozek commented: """ On Wed, Sep 28, 2016 at 12:55:34AM -0700, Jakub Hrozek wrote: > On Mon, Sep 26, 2016 at 01:29:12PM -0700, lslebodn wrote: > > lslebodn commen

[SSSD] [sssd PR#32][comment] Requesting a pull to SSSD:master from fidencio:wip/#3138

2016-09-28 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/32 Title: #32: Requesting a pull to SSSD:master from fidencio:wip/#3138 jhrozek commented: """ Hi, thank you for working on this. I think there are two "architectural" questions we should answer. 1) Lukas raised the suggestion of

[SSSD] [sssd PR#33][comment] SECRETS: Some small misc fixes + fixing #3168

2016-09-28 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/33 Title: #33: SECRETS: Some small misc fixes + fixing #3168 jhrozek commented: """ On Wed, Sep 28, 2016 at 02:16:36AM -0700, fidencio wrote: > fidencio commented on this pull request. > > > > > @@ -447,6 +468,9 @@ stat

[SSSD] [sssd PR#31][+Changes requested] nss: allow UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME

2016-09-28 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/31 Title: #31: nss: allow UPNs in SSS_NSS_GETSIDBYNAME and SSS_NSS_GETORIGBYNAME Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#33][comment] SECRETS: Some small misc fixes + fixing #3168

2016-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/33 Title: #33: SECRETS: Some small misc fixes + fixing #3168 jhrozek commented: """ btw I also manually tested the config regexes and sssd is OK with known option but not OK with an unknown option, which is also good: (Mon Oct 3 15:30

[SSSD] [sssd PR#37][opened] Add DEBUG messages to the sssd-secrets responder

2016-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/37 Author: jhrozek Title: #37: Add DEBUG messages to the sssd-secrets responder Action: opened PR body: """ This patchset decorates sssd-secrets with DEBUG messages so that errors are easier to discover and by default (up to debug_lev

[SSSD] [sssd PR#33][+Accepted] SECRETS: Some small misc fixes + fixing #3168

2016-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/33 Title: #33: SECRETS: Some small misc fixes + fixing #3168 Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#33][comment] SECRETS: Some small misc fixes + fixing #3168

2016-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/33 Title: #33: SECRETS: Some small misc fixes + fixing #3168 jhrozek commented: """ On Fri, Sep 30, 2016 at 07:55:00AM -0700, fidencio wrote: > And here is the diff between the last series and the new one that's arriving > in a few

[SSSD] [sssd PR#33][-Accepted] SECRETS: Some small misc fixes + fixing #3168

2016-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/33 Title: #33: SECRETS: Some small misc fixes + fixing #3168 Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#33][closed] SECRETS: Some small misc fixes + fixing #3168

2016-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/33 Author: fidencio Title: #33: SECRETS: Some small misc fixes + fixing #3168 Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/33/head:pr33 git checkout pr33

[SSSD] [sssd PR#37][synchronized] Add DEBUG messages to the sssd-secrets responder

2016-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/37 Author: jhrozek Title: #37: Add DEBUG messages to the sssd-secrets responder Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/37/head:pr37 git checkout pr37 From

[SSSD] [sssd PR#33][+Pushed] SECRETS: Some small misc fixes + fixing #3168

2016-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/33 Title: #33: SECRETS: Some small misc fixes + fixing #3168 Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#32][comment] Requesting a pull to SSSD:master from fidencio:wip/#3138

2016-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/32 Title: #32: Requesting a pull to SSSD:master from fidencio:wip/#3138 jhrozek commented: """ Yes, as discussed, moving this functionality to the monitor is something we'll go with. Therefore I'm adding the Changes requested label. &q

[SSSD] [sssd PR#32][+Changes requested] Requesting a pull to SSSD:master from fidencio:wip/#3138

2016-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/32 Title: #32: Requesting a pull to SSSD:master from fidencio:wip/#3138 Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#30][+Changes requested] sssctl: use systemd D-Bus API

2016-09-26 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/30 Title: #30: sssctl: use systemd D-Bus API Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#30][comment] sssctl: use systemd D-Bus API

2016-09-26 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/30 Title: #30: sssctl: use systemd D-Bus API jhrozek commented: """ Looks like there are some warnings: {{{ Error: UNINIT (CWE-457): sssd-1.14.2/src/tools/sssctl/sssctl_systemd.c:60: var_decl: Declaring variable "msg" without ini

[SSSD] [sssd PR#30][comment] sssctl: use systemd D-Bus API

2016-09-26 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/30 Title: #30: sssctl: use systemd D-Bus API jhrozek commented: """ Looks like there are some warnings: ``` Error: UNINIT (CWE-457): sssd-1.14.2/src/tools/sssctl/sssctl_systemd.c:60: var_decl: Declaring variable "msg" without ini

[SSSD] [sssd PR#49][+Changes requested] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-10-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To

[SSSD] [sssd PR#57][comment] LDAP/AD: resolve domain local groups for remote users

2016-10-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users jhrozek commented: """ Thank you, this version reads better to me and still works fine (adding and removing the global group as well..) So far ACK, I will push the patc

[SSSD] [sssd PR#57][+Accepted] LDAP/AD: resolve domain local groups for remote users

2016-10-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#62][comment] PAM: add pam_response_filter option

2016-10-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option jhrozek commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/62#issuecomment-256572973 _

[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups

2016-10-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups jhrozek commented: """ The documentation now looks correct, I just wonder why did you remove the example paragraph in the last iteration of the patch? IMO it would be us

[SSSD] [sssd PR#65][comment] Fixing of nitpicks

2016-10-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/65 Title: #65: Fixing of nitpicks jhrozek commented: """ On Tue, Oct 25, 2016 at 09:28:27AM -0700, lslebodn wrote: > lslebodn commented on this pull request. > > > > > @@ -1104,7 +1104,6 @@ bool sss_krb5_

[SSSD] [sssd PR#43][comment] RESPONDER: Enable sudoRule in case insen. domains​ (1.15)

2016-10-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: RESPONDER: Enable sudoRule in case insen. domains​ (1.15) jhrozek commented: """ On Thu, Oct 27, 2016 at 03:56:21AM -0700, Pavel Březina wrote: > pbrezina requested changes on this pull request. > > Hi, there is o

[SSSD] [sssd PR#46][comment] sss_client: Defer thread cancellation until completion of nss/pam operations

2016-11-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/46 Title: #46: sss_client: Defer thread cancellation until completion of nss/pam operations jhrozek commented: """ Well, if the old code would be disabled and there would be nobody using the new config option from the start, I'm fine

[SSSD] [sssd PR#77][opened] Qualify ghost users with RFC2307bis and ldap_nesting_level=0

2016-11-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/77 Author: jhrozek Title: #77: Qualify ghost users with RFC2307bis and ldap_nesting_level=0 Action: opened PR body: """ None """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetc

[SSSD] [sssd PR#71][closed] MONITOR: Do not set up watchdog for monitor

2016-11-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/71 Author: jhrozek Title: #71: MONITOR: Do not set up watchdog for monitor Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/71/head:pr71 git checkout pr71

[SSSD] [sssd PR#71][+Pushed] MONITOR: Do not set up watchdog for monitor

2016-11-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/71 Title: #71: MONITOR: Do not set up watchdog for monitor Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#71][comment] MONITOR: Do not set up watchdog for monitor

2016-11-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/71 Title: #71: MONITOR: Do not set up watchdog for monitor jhrozek commented: """ master: fbe6644aa28d93f492434950680c5618eb567712 sssd-1-14: 2d88a121918e800b266d018d43dad9bd374b10a7 """ See the full comment at https:

[SSSD] [sssd PR#73][+Accepted] AD_PROVIDER: Enabled subdomains (1.13)

2016-11-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/73 Title: #73: AD_PROVIDER: Enabled subdomains (1.13) Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#43][comment] RESPONDER: Enable sudoRule in case insen. domains​ (1.15)

2016-11-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: RESPONDER: Enable sudoRule in case insen. domains​ (1.15) jhrozek commented: """ master: f4a1046bb88d7a0ab3617e49ae94bfa849d10645 23637e2fd2b1fe42bdd2335893a11ac8016f56bc sssd-1-14: 143b1dcbbe865a139616a22b1

[SSSD] [sssd PR#43][-Accepted] RESPONDER: Enable sudoRule in case insen. domains​ (1.15)

2016-11-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: RESPONDER: Enable sudoRule in case insen. domains​ (1.15) Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#43][+Pushed] RESPONDER: Enable sudoRule in case insen. domains​ (1.15)

2016-11-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: RESPONDER: Enable sudoRule in case insen. domains​ (1.15) Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#43][closed] RESPONDER: Enable sudoRule in case insen. domains​ (1.15)

2016-11-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/43 Author: celestian Title: #43: RESPONDER: Enable sudoRule in case insen. domains​ (1.15) Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/43/head:pr43 git checkout pr43

[SSSD] [sssd PR#39][comment] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) jhrozek commented: """ On Tue, Nov 08, 2016 at 04:13:43AM -0800, celestian wrote: > I pushed new version, only one difference -- I fix cherry-pick pointer. > Th

[SSSD] [sssd PR#39][comment] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) jhrozek commented: """ On Tue, Nov 08, 2016 at 05:06:41AM -0800, celestian wrote: > Yes, the second patch explicitly qualifies the names. I don't know if there >

[SSSD] [sssd PR#74][closed] IPA/AD: check auth ctx before using it

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/74 Author: sumit-bose Title: #74: IPA/AD: check auth ctx before using it Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/74/head:pr74 git checkout pr74

[SSSD] [sssd PR#74][comment] IPA/AD: check auth ctx before using it

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/74 Title: #74: IPA/AD: check auth ctx before using it jhrozek commented: """ master: ea11ed3ea6291488dd762033246edc4ce3951aeb sssd-1-14: 37e070c8c2ea79d8d84bae3da3a34c81212744ab """ See the full comment at https:

[SSSD] [sssd PR#53][-Accepted] Fixes in the config API related to secrets responder

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/53 Title: #53: Fixes in the config API related to secrets responder Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#53][+Pushed] Fixes in the config API related to secrets responder

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/53 Title: #53: Fixes in the config API related to secrets responder Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#53][comment] Fixes in the config API related to secrets responder

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/53 Title: #53: Fixes in the config API related to secrets responder jhrozek commented: """ Since there is no ticket, I only pushed the patches to master: 682c9c3467055c2149af28826f7458b857b0f8c4 da8801c363716533f60bc78e10f3a2100cebc3a1 &q

[SSSD] [sssd PR#53][closed] Fixes in the config API related to secrets responder

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/53 Author: fidencio Title: #53: Fixes in the config API related to secrets responder Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/53/head:pr53 git checkout pr53

[SSSD] [sssd PR#68][comment] MAN: Document different defaults for IPA and AD providers

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/68 Title: #68: MAN: Document different defaults for IPA and AD providers jhrozek commented: """ ACK. I won't push the patches until tomorrow though in case @lslebodn or someone else wanted to take a look as well. I'll also wait for CI re

[SSSD] [sssd PR#68][+Accepted] MAN: Document different defaults for IPA and AD providers

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/68 Title: #68: MAN: Document different defaults for IPA and AD providers Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#69][+Changes requested] krb5: Use command line arguments instead env vars for krb5_child

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/69 Title: #69: krb5: Use command line arguments instead env vars for krb5_child Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#74][+Pushed] IPA/AD: check auth ctx before using it

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/74 Title: #74: IPA/AD: check auth ctx before using it Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#74][-Accepted] IPA/AD: check auth ctx before using it

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/74 Title: #74: IPA/AD: check auth ctx before using it Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#53][comment] Fixes in the config API related to secrets responder

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/53 Title: #53: Fixes in the config API related to secrets responder jhrozek commented: """ Thanks, ACK """ See the full comment at https://github.com/SSSD/sssd/pull/53#issuecomment-259810451

[SSSD] [sssd PR#53][+Accepted] Fixes in the config API related to secrets responder

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/53 Title: #53: Fixes in the config API related to secrets responder Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#78][comment] ipa: Nested netgroups do not work

2016-11-11 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/78 Title: #78: ipa: Nested netgroups do not work jhrozek commented: """ btw just to help with the review, I also fired up a test job using our downstream tests with a 7.3 package and this test. I'll let you know how the test went. &q

[SSSD] [sssd PR#53][+Changes requested] Fixes in the config API related to secrets responder

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/53 Title: #53: Fixes in the config API related to secrets responder Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#53][comment] Fixes in the config API related to secrets responder

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/53 Title: #53: Fixes in the config API related to secrets responder jhrozek commented: """ On Tue, Nov 08, 2016 at 05:40:21AM -0800, lslebodn wrote: > On (08/11/16 05:15), fidencio wrote: > >@jhrozek: > >For the first patch th

[SSSD] [sssd PR#39][comment] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) jhrozek commented: """ oops...clicked send to early. I meant to say "So the filter never matches the lowercase sudoUser". """ See the full

[SSSD] [sssd PR#39][+Changes requested] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#39][comment] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) jhrozek commented: """ Are you sure this is enough? Because when the patch is applied, I see that we only match the sudoUser value with the original case. Don't we also

[SSSD] [sssd PR#43][+Accepted] RESPONDER: Enable sudoRule in case insen. domains​ (1.15)

2016-11-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: RESPONDER: Enable sudoRule in case insen. domains​ (1.15) Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#72][opened] Remove two unused methods from monitor's sbus interface

2016-11-07 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/72 Author: jhrozek Title: #72: Remove two unused methods from monitor's sbus interface Action: opened PR body: """ None """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd

[SSSD] [sssd PR#34][-Changes requested] cache_req: move from switch to plugins

2016-10-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/34 Title: #34: cache_req: move from switch to plugins Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#34][comment] cache_req: move from switch to plugins

2016-10-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/34 Title: #34: cache_req: move from switch to plugins jhrozek commented: """ On Wed, Oct 19, 2016 at 02:48:57AM -0700, Jakub Hrozek wrote: > Thank you, ACK. I sent the patch to CI and I will push the patch when CI > finishes.

[SSSD] [sssd PR#53][comment] Fixes in the config API related to secrets responder

2016-10-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/53 Title: #53: Fixes in the config API related to secrets responder jhrozek commented: """ On Wed, Oct 19, 2016 at 03:07:28AM -0700, fidencio wrote: > @jhrozek I'm removing "Changes requested" label as the last patchset

[SSSD] [sssd PR#53][+Changes requested] Fixes in the config API related to secrets responder

2016-10-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/53 Title: #53: Fixes in the config API related to secrets responder Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#34][+Accepted] cache_req: move from switch to plugins

2016-10-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/34 Title: #34: cache_req: move from switch to plugins Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#59][comment] ipa_netgroups: Lowercase key to htable

2016-10-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable jhrozek commented: """ On Thu, Oct 20, 2016 at 02:55:12AM -0700, lslebodn wrote: > On (20/10/16 02:20), Jakub Hrozek wrote: > >On Thu, Oct 20, 2016 at 01:40:15AM -0700, lslebodn

[SSSD] [sssd PR#59][comment] ipa_netgroups: Lowercase key to htable

2016-10-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable jhrozek commented: """ On Thu, Oct 20, 2016 at 05:04:20AM -0700, mzidek-rh wrote: > And yes, there are differences between plain LDAP and IPA providers. The > netgroup code is

[SSSD] [sssd PR#34][-Accepted] cache_req: move from switch to plugins

2016-10-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/34 Title: #34: cache_req: move from switch to plugins Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#34][closed] cache_req: move from switch to plugins

2016-10-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/34 Author: pbrezina Title: #34: cache_req: move from switch to plugins Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/34/head:pr34 git checkout pr34

[SSSD] [sssd PR#34][+Pushed] cache_req: move from switch to plugins

2016-10-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/34 Title: #34: cache_req: move from switch to plugins Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#34][comment] cache_req: move from switch to plugins

2016-10-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/34 Title: #34: cache_req: move from switch to plugins jhrozek commented: """ Pushed in ef39016..e083a6b """ See the full comment at https://github.com/SSSD/sssd/pull/34#issuecomment-255036044

[SSSD] [sssd PR#59][comment] ipa_netgroups: Lowercase key to htable

2016-10-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable jhrozek commented: """ before the patch: ``` [jhrozek@client] sssd $ [] getent netgroup ngr1 ngr1 (-,user1,ipa.test) [jhrozek@client] sssd $ [] geten

[SSSD] [sssd PR#59][comment] ipa_netgroups: Lowercase key to htable

2016-10-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable jhrozek commented: """ On Thu, Oct 20, 2016 at 01:40:15AM -0700, lslebodn wrote: > On (20/10/16 01:21), Jakub Hrozek wrote: > >before the patch: > >``` > >[jhrozek@cl

[SSSD] [sssd PR#47][comment] BUILD: Fix build without /sbin/service installed on the build host

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/47 Title: #47: BUILD: Fix build without /sbin/service installed on the build host jhrozek commented: """ @lslebodn suggested on IRC to only search for service in /sbin and /usr/sbin. I added another patch that does that.. CI: http://sssd

[SSSD] [sssd PR#47][synchronized] BUILD: Fix build without /sbin/service installed on the build host

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/47 Author: jhrozek Title: #47: BUILD: Fix build without /sbin/service installed on the build host Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/47/head:pr47 git checkout pr47

[SSSD] [sssd PR#47][synchronized] BUILD: Fix build without /sbin/service installed on the build host

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/47 Author: jhrozek Title: #47: BUILD: Fix build without /sbin/service installed on the build host Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/47/head:pr47 git checkout pr47

[SSSD] [sssd PR#13][comment] MEMBEROF: Don't resolve members if they are removed

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/13 Title: #13: MEMBEROF: Don't resolve members if they are removed jhrozek commented: """ yes, if we don't know how to trigger the code, we shouldn't push it. OK to push the two commits now? """ See the full comment at htt

[SSSD] [sssd PR#47][+Changes requested] BUILD: Fix build without /sbin/service installed on the build host

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/47 Title: #47: BUILD: Fix build without /sbin/service installed on the build host Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#34][-Changes requested] cache_req: move from switch to plugins

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/34 Title: #34: cache_req: move from switch to plugins Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#47][synchronized] BUILD: Fix build without /sbin/service installed on the build host

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/47 Author: jhrozek Title: #47: BUILD: Fix build without /sbin/service installed on the build host Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/47/head:pr47 git checkout pr47

[SSSD] [sssd PR#47][-Changes requested] BUILD: Fix build without /sbin/service installed on the build host

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/47 Title: #47: BUILD: Fix build without /sbin/service installed on the build host Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#34][+Changes requested] cache_req: move from switch to plugins

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/34 Title: #34: cache_req: move from switch to plugins Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#34][comment] cache_req: move from switch to plugins

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/34 Title: #34: cache_req: move from switch to plugins jhrozek commented: """ Actually, sorry, one more Coverity warning: ``` Error: FORWARD_NULL (CWE-476): sssd-1.14.2/src/responder/common/cache_req/cache_req_search.c:105: var_compar

[SSSD] [sssd PR#48][-Changes requested] sssctl: Flags for commadn initialization

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/48 Title: #48: sssctl: Flags for commadn initialization Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#13][comment] MEMBEROF: Don't resolve members if they are removed

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/13 Title: #13: MEMBEROF: Don't resolve members if they are removed jhrozek commented: """ btw since the memberof patch we couldn't test is gone, I'm fine with pushing these two. """ See the full comment at https:

[SSSD] [sssd PR#13][+Accepted] MEMBEROF: Don't resolve members if they are removed

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/13 Title: #13: MEMBEROF: Don't resolve members if they are removed Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#48][comment] sssctl: Flags for commadn initialization

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/48 Title: #48: sssctl: Flags for commadn initialization jhrozek commented: """ On Fri, Oct 14, 2016 at 08:03:20AM -0700, mzidek-rh wrote: > I see the comment did not get forwarded to the devel list, so pasting again: > > > So

[SSSD] [sssd PR#34][comment] cache_req: move from switch to plugins

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/34 Title: #34: cache_req: move from switch to plugins jhrozek commented: """ Apart from the nitpicks, the code looks better to me (I like that the lookup functionality is abstracted, so adding new lookups will be easy). I tested several k

[SSSD] [sssd PR#34][+Changes requested] cache_req: move from switch to plugins

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/34 Title: #34: cache_req: move from switch to plugins Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#48][+Changes requested] sssctl: Flags for commadn initialization

2016-10-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/48 Title: #48: sssctl: Flags for commadn initialization Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups

2016-10-25 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups jhrozek commented: """ Additionally, if there is some link to MSDN explaining what the OID is, it would be nice to add that link """ See the full comment at

[SSSD] [sssd PR#66][comment] Minor Dynamic DNS fixes

2016-10-25 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/66 Title: #66: Minor Dynamic DNS fixes jhrozek commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/66#issuecomment-256084328 ___ sssd-de

[SSSD] [sssd PR#57][comment] LDAP/AD: resolve domain local groups for remote users

2016-10-25 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users jhrozek commented: """ Thanks for the changes, at least with the previous version all the tests with the domain-local groups were working for me and the internal ad_fore

[SSSD] [sssd PR#49][comment] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-10-25 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too jhrozek commented: """ Bump. Could anyone review this patch, please? """ See the full comment at https:

[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups

2016-10-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups jhrozek commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/60#issuecomment-254876611

[SSSD] [sssd PR#78][comment] ipa: Nested netgroups do not work

2016-11-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/78 Title: #78: ipa: Nested netgroups do not work jhrozek commented: """ The downstream tests passed (the job ID is 1594128 if anyone wants to take a look). So I'm adding the Accepted tag. """ See the full comment at https:

[SSSD] [sssd PR#78][comment] ipa: Nested netgroups do not work

2016-11-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/78 Title: #78: ipa: Nested netgroups do not work jhrozek commented: """ master: ff565da1011aa4312847e28e7af66e57fccf8b90 sssd-1-14: 7de33877c7e39f9a5cae6baf815dc18ae5a18597 sssd-1-13: 9c4c3a204e1631f61378982d39cdba0ce25ee262 "&quo

[SSSD] [sssd PR#78][-Accepted] ipa: Nested netgroups do not work

2016-11-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/78 Title: #78: ipa: Nested netgroups do not work Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

<    1   2   3   4   5   6   7   8   9   10   >