[SSSD] [sssd PR#203][-Accepted] IPA: Enhance debug logging for ipa s2n operations

2017-03-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/203 Title: #203: IPA: Enhance debug logging for ipa s2n operations Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#215][comment] Support for non-POSIX users and groups

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/215 Title: #215: Support for non-POSIX users and groups jhrozek commented: """ CI: http://sssd-ci.duckdns.org/logs/job/66/47/summary.html there is a RHEL6 failure in the enumeration code. Because the test only failed on RHEL-6, I don't thi

[SSSD] [sssd PR#217][opened] KCM: Fix off-by-one error in secrets key validation

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/217 Author: jhrozek Title: #217: KCM: Fix off-by-one error in secrets key validation Action: opened PR body: """ This is a fix for a bug found by Fabiano. A simple reproducer is to try to kinit as root with KCM. """ To

[SSSD] [sssd PR#215][comment] Support for non-POSIX users and groups

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/215 Title: #215: Support for non-POSIX users and groups jhrozek commented: """ CI is happier now: http://sssd-ci.duckdns.org/logs/job/66/49/summary.html """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#209][+Accepted] IPA: lookup AD users by certificates on IPA clients

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/209 Title: #209: IPA: lookup AD users by certificates on IPA clients Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#209][comment] IPA: lookup AD users by certificates on IPA clients

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/209 Title: #209: IPA: lookup AD users by certificates on IPA clients jhrozek commented: """ anyway, these patches work and we can push them """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#209][comment] IPA: lookup AD users by certificates on IPA clients

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/209 Title: #209: IPA: lookup AD users by certificates on IPA clients jhrozek commented: """ So then the consumer of the API is expected to iterate over the paths and find a non-empty attribute? Because the paths from the domains

[SSSD] [sssd PR#201][closed] Fix handling of binary keys in the ssh responder

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/201 Author: sumit-bose Title: #201: Fix handling of binary keys in the ssh responder Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/201/head:pr201 git checkout pr201

[SSSD] [sssd PR#201][comment] Fix handling of binary keys in the ssh responder

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/201 Title: #201: Fix handling of binary keys in the ssh responder jhrozek commented: """ * master: 1b5d6b1afc9c3dc696b7b45f2d73b2634f42800a bd1fa0ec90be717c3b7796d74b6f243f40178d16 """ See the full comment at https:/

[SSSD] [sssd PR#204][+Pushed] krb5: return to responder that pkinit is not available

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/204 Title: #204: krb5: return to responder that pkinit is not available Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#204][closed] krb5: return to responder that pkinit is not available

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/204 Author: sumit-bose Title: #204: krb5: return to responder that pkinit is not available Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/204/head:pr204 git checkout pr204

[SSSD] [sssd PR#204][comment] krb5: return to responder that pkinit is not available

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/204 Title: #204: krb5: return to responder that pkinit is not available jhrozek commented: """ * master: 1c551b1373799643f3e9ba4f696d21b8fc57dafd """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#209][closed] IPA: lookup AD users by certificates on IPA clients

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/209 Author: sumit-bose Title: #209: IPA: lookup AD users by certificates on IPA clients Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/209/head:pr209 git checkout pr209

[SSSD] [sssd PR#209][+Pushed] IPA: lookup AD users by certificates on IPA clients

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/209 Title: #209: IPA: lookup AD users by certificates on IPA clients Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#209][comment] IPA: lookup AD users by certificates on IPA clients

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/209 Title: #209: IPA: lookup AD users by certificates on IPA clients jhrozek commented: """ * master: 82843754193b177275ce16f2901edac2060a3998 2cf7becc05996eb6d8a3352d3d7b97c75652e590 415d93196533a6fcd90889c67396ef5af5bf791a "&quo

[SSSD] [sssd PR#209][comment] IPA: lookup AD users by certificates on IPA clients

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/209 Title: #209: IPA: lookup AD users by certificates on IPA clients jhrozek commented: """ I started the review by running CI which passed except rawhide which seems broken: http://sssd-ci.duckdns.org/logs/job/66/06/summary.html "&quo

[SSSD] [sssd PR#204][comment] krb5: return to responder that pkinit is not available

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/204 Title: #204: krb5: return to responder that pkinit is not available jhrozek commented: """ I really don't mind one way or another. I find all the proposed versions of the condition complex, that's why I'm glad there is a comment atop th

[SSSD] [sssd PR#209][comment] IPA: lookup AD users by certificates on IPA clients

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/209 Title: #209: IPA: lookup AD users by certificates on IPA clients jhrozek commented: """ (the machine in CI is broken, not the patches..) """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#198][comment] secrets: support https in proxy provider

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/198 Title: #198: secrets: support https in proxy provider jhrozek commented: """ On Wed, Mar 29, 2017 at 12:29:27AM -0700, lslebodn wrote: > BTW the 1st patch "tcurl: add support for ssl and raw output" caused a hang >

[SSSD] [sssd PR#201][comment] Fix handling of binary keys in the ssh responder

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/201 Title: #201: Fix handling of binary keys in the ssh responder jhrozek commented: """ CI: http://sssd-ci.duckdns.org/logs/job/66/04/summary.html """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#201][+Accepted] Fix handling of binary keys in the ssh responder

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/201 Title: #201: Fix handling of binary keys in the ssh responder Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#201][comment] Fix handling of binary keys in the ssh responder

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/201 Title: #201: Fix handling of binary keys in the ssh responder jhrozek commented: """ The code looks good to me and seems to work fine: ``` ./sss_ssh_authorizedkeys administra...@win.tru

[SSSD] [sssd PR#187][+Accepted] Add support to lookup for users/groups in subdomains just by the user shortname

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/187 Title: #187: Add support to lookup for users/groups in subdomains just by the user shortname Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#187][comment] Add support to lookup for users/groups in subdomains just by the user shortname

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/187 Title: #187: Add support to lookup for users/groups in subdomains just by the user shortname jhrozek commented: """ * master: 16385568547351b5d2c562f3081f35f3341f695b 1e437af958f59a0b8bf2f751d3c2ea28365ac64d 66c8e92eb5a4985bb7f64c349

[SSSD] [sssd PR#187][+Pushed] Add support to lookup for users/groups in subdomains just by the user shortname

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/187 Title: #187: Add support to lookup for users/groups in subdomains just by the user shortname Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#187][closed] Add support to lookup for users/groups in subdomains just by the user shortname

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/187 Author: fidencio Title: #187: Add support to lookup for users/groups in subdomains just by the user shortname Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/187/head:pr187 git

[SSSD] [sssd PR#209][comment] IPA: lookup AD users by certificates on IPA clients

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/209 Title: #209: IPA: lookup AD users by certificates on IPA clients jhrozek commented: """ These patches look OK, but I suspect we might have a bug in the IFP list code. I added a certificate to a user's idview entry and now listing

[SSSD] [sssd PR#209][comment] IPA: lookup AD users by certificates on IPA clients

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/209 Title: #209: IPA: lookup AD users by certificates on IPA clients jhrozek commented: """ Hmm, looking at the debug output, it might be the cache_req's code fault: ``` (Wed Mar 29 11:30:04 2017) [sssd[ifp]] [cache_req_set_domain] (0x0400)

[SSSD] [sssd PR#204][+Accepted] krb5: return to responder that pkinit is not available

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/204 Title: #204: krb5: return to responder that pkinit is not available Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#204][comment] krb5: return to responder that pkinit is not available

2017-03-29 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/204 Title: #204: krb5: return to responder that pkinit is not available jhrozek commented: """ ok, thanks! """ See the full comment at https://github.com/SSSD/sssd/pull/204#issuecomment-290063709

[SSSD] [sssd PR#215][comment] Support for non-POSIX users and groups

2017-03-28 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/215 Title: #215: Support for non-POSIX users and groups jhrozek commented: """ the second iteration of patches should fix a coverity warning """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#204][comment] krb5: return to responder that pkinit is not available

2017-03-28 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/204 Title: #204: krb5: return to responder that pkinit is not available jhrozek commented: """ LGTM, the code comment helps understand the complex condition, thanks. I just ran CI and Coverity to rubber-stamp the patch before pushing. &q

[SSSD] [sssd PR#221][comment] sss_cert_pem_to_der: Accept certificate with data before header

2017-03-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/221 Title: #221: sss_cert_pem_to_der: Accept certificate with data before header jhrozek commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#197][comment] KCM responder

2017-03-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder jhrozek commented: """ I also squashed Lukas' patch to fix some python3 issues. I'm just waiting for our CI to finish. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#197][+Changes requested] KCM responder

2017-03-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#188][comment] Add the first version of the KCM responder

2017-03-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/188 Title: #188: Add the first version of the KCM responder jhrozek commented: """ Let's try this again from the branch that actually contains the current code """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#188][closed] Add the first version of the KCM responder

2017-03-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/188 Author: jhrozek Title: #188: Add the first version of the KCM responder Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/188/head:pr188 git checkout pr188

[SSSD] [sssd PR#197][edited] These patches add a new service for managing Kerberos credential patches. It follows the design document here: https://fedorahosted.org/sssd/wiki/DesignDocs/KCM

2017-03-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/197 Author: jhrozek Title: #197: These patches add a new service for managing Kerberos credential patches. It follows the design document here: https://fedorahosted.org/sssd/wiki/DesignDocs/KCM Action: edited Changed field: title Original value

[SSSD] [sssd PR#170][-Accepted] PROXY: Remove duplicit users from group

2017-03-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/170 Title: #170: PROXY: Remove duplicit users from group Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#170][+Pushed] PROXY: Remove duplicit users from group

2017-03-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/170 Title: #170: PROXY: Remove duplicit users from group Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#170][closed] PROXY: Remove duplicit users from group

2017-03-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/170 Author: celestian Title: #170: PROXY: Remove duplicit users from group Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/170/head:pr170 git checkout pr170

[SSSD] [sssd PR#170][comment] PROXY: Remove duplicit users from group

2017-03-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/170 Title: #170: PROXY: Remove duplicit users from group jhrozek commented: """ * master: ed2a5dad1ec82eda8a43ed8b0a05a6b01c3a6586 """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#186][+Pushed] Subdomain config

2017-03-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/186 Title: #186: Subdomain config Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#186][closed] Subdomain config

2017-03-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/186 Author: mzidek-rh Title: #186: Subdomain config Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/186/head:pr186 git checkout pr186 ___

[SSSD] [sssd PR#186][comment] Subdomain config

2017-03-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/186 Title: #186: Subdomain config jhrozek commented: """ * master: 61854f17c8de6548fb56bb7ad959708109d76fc3 62a1570f01053ec61e894ee3e58fc759ee809c6e 231bd1b34023daa3080cf461085e6e4aa7f4d733 ebe05e32b5af9b1ee404ebe492e52096d45fb675 &q

[SSSD] [sssd PR#186][-Accepted] Subdomain config

2017-03-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/186 Title: #186: Subdomain config Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#186][comment] Subdomain config

2017-03-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/186 Title: #186: Subdomain config jhrozek commented: """ The patches now look good to me, but I have some questions: 1) Could we (perhaps in a future patch) extend the dp_options structure with a boolean flag to indicate which options c

[SSSD] [sssd PR#186][comment] Subdomain config

2017-03-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/186 Title: #186: Subdomain config jhrozek commented: """ CI: http://sssd-ci.duckdns.org/logs/job/64/93/summary.html """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#194][comment] config-check: Message when sssd.conf is missing

2017-03-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/194 Title: #194: config-check: Message when sssd.conf is missing jhrozek commented: """ if this patch is already written and you'd ack it otherwise then yes. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#192][-Changes requested] Add certificate mapping library

2017-03-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/192 Title: #192: Add certificate mapping library Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#197][comment] KCM responder

2017-03-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder jhrozek commented: """ also, store the ccaches at cn=kcm not at cn=ccaches """ See the full comment at https://github.com/SSSD/sssd/pull/197#issuecomment-287805107

[SSSD] [sssd PR#197][comment] KCM responder

2017-03-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder jhrozek commented: """ also remove all the KCM-specific knowledge from sssd-secrets, like the session/peristent checks. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#197][comment] KCM responder

2017-03-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder jhrozek commented: """ I had an IRC discussion with @simo5 about the patches and he requested some changes: * don't special case /kcm in the routing protocol and allow routing KCM to Custodia * serialize w

[SSSD] [sssd PR#197][-Changes requested] KCM responder

2017-03-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#197][comment] KCM responder

2017-03-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder jhrozek commented: """ I pushed new patches that implement what Simo asked for: * the kcm_ops module now queues all requests from the same UID * the secrets module does no special casing of the KCM paths

[SSSD] [sssd PR#198][comment] secrets: support https in proxy provider

2017-03-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/198 Title: #198: secrets: support https in proxy provider jhrozek commented: """ Looks like the curl version on RHEL-7 is too old to support some features: ``` /var/lib/jenkins/workspace/ci/label/rhel7/src/util/tev_curl.c: In function '

[SSSD] [sssd PR#198][comment] secrets: support https in proxy provider

2017-03-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/198 Title: #198: secrets: support https in proxy provider jhrozek commented: """ Looks like the CI tests fail even on fedora..: ``` =

[SSSD] [sssd PR#198][comment] secrets: support https in proxy provider

2017-03-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/198 Title: #198: secrets: support https in proxy provider jhrozek commented: """ About the missing Content-Lenght, did you check with @tiran if this is a bug in Custodia? Finally, I'm conflicted if we need to allow the options

[SSSD] [sssd PR#198][+Changes requested] secrets: support https in proxy provider

2017-03-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/198 Title: #198: secrets: support https in proxy provider Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#197][comment] KCM responder

2017-03-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder jhrozek commented: """ I also removed the declaration of sss_krb5_marshal_creds which was a leftover from parsing the creds (which is something I have in a different branch until we need to renew credenti

[SSSD] [sssd PR#197][comment] KCM responder

2017-03-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder jhrozek commented: """ CI: http://sssd-ci.duckdns.org/logs/job/65/17/summary.html """ See the full comment at https://github.com/SSSD/sssd/pull/197#issuecomment-288347513 __

[SSSD] [sssd PR#197][comment] KCM responder

2017-03-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/197 Title: #197: KCM responder jhrozek commented: """ I made two fixes related to documentation and packaging. They are already squashed, but to ease the review, the documentation fix was: ``` diff --git a/src/man/sssd-kcm.8.xml b/src/man

[SSSD] [sssd PR#198][comment] secrets: support https in proxy provider

2017-03-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/198 Title: #198: secrets: support https in proxy provider jhrozek commented: """ I think you need to make libcurl detection not optional, but required if sssd is build with sssd-secrets to avoid errors like: ``` /builddir/build/BUILD/sssd-

[SSSD] [sssd PR#200][comment] Improve PAM test client

2017-03-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/200 Title: #200: Improve PAM test client jhrozek commented: """ I'm fine with adding this form to master now and asking for feedback in downstream as long as we agree that the functionality must be part of sssctl before the next upstream r

[SSSD] [sssd PR#225][opened] SECRETS: Apply separate quotas for cn=secrets and cn=kcm

2017-04-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/225 Author: jhrozek Title: #225: SECRETS: Apply separate quotas for cn=secrets and cn=kcm Action: opened PR body: """ While testing the KCM responder some more, I realized that we always checked the (hardcoded, no less) base DN of

[SSSD] [sssd PR#225][comment] SECRETS: Apply separate quotas for cn=secrets and cn=kcm

2017-04-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/225 Title: #225: SECRETS: Apply separate quotas for cn=secrets and cn=kcm jhrozek commented: """ cc @simo5 Simo, are you OK with the quotas being just per cn=secrets/cn=kcm top-level base DNs or do you think that we need to be more g

[SSSD] [sssd PR#234][opened] HBAC: Use memberof ASQ search instead of originalMemberOf

2017-04-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/234 Author: jhrozek Title: #234: HBAC: Use memberof ASQ search instead of originalMemberOf Action: opened PR body: """ This PR should fix the bug we were seeing in the HBAC evaluation of users from a trusted AD domain where the original

[SSSD] [sssd PR#234][edited] HBAC: Use memberof ASQ search instead of originalMemberOf

2017-04-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/234 Author: jhrozek Title: #234: HBAC: Use memberof ASQ search instead of originalMemberOf Action: edited Changed field: body Original value: """ This PR should fix the bug we were seeing in the HBAC evaluation of users from a trusted

[SSSD] [sssd PR#234][comment] HBAC: Use memberof ASQ search instead of originalMemberOf

2017-04-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/234 Title: #234: HBAC: Use memberof ASQ search instead of originalMemberOf jhrozek commented: """ I updated the description because previously I pushed a different version of the patch than I wanted """ See the full comme

[SSSD] [sssd PR#234][synchronized] HBAC: Use memberof ASQ search instead of originalMemberOf

2017-04-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/234 Author: jhrozek Title: #234: HBAC: Use memberof ASQ search instead of originalMemberOf Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/234/head:pr234 git checkout pr234 From

[SSSD] [sssd PR#206][+Changes requested] IFP: Fix of names in GetUserGroups method

2017-04-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/206 Title: #206: IFP: Fix of names in GetUserGroups method Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#206][comment] IFP: Fix of names in GetUserGroups method

2017-04-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/206 Title: #206: IFP: Fix of names in GetUserGroups method jhrozek commented: """ I think the best way would be to move `sized_member_name` to the responder common code and reuse it. """ See the full comment at https:/

[SSSD] [sssd PR#232][+Accepted] sbus: check connection for NULL before unregister it

2017-04-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/232 Title: #232: sbus: check connection for NULL before unregister it Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#234][+Changes requested] HBAC: Use memberof ASQ search instead of originalMemberOf

2017-04-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/234 Title: #234: HBAC: Use memberof ASQ search instead of originalMemberOf Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#242][synchronized] IPA: Improve DEBUG message if an external group has no SID

2017-04-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/242 Author: jhrozek Title: #242: IPA: Improve DEBUG message if an external group has no SID Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/242/head:pr242 git checkout pr242 From

[SSSD] [sssd PR#240][+Accepted] IFP: Fix of names in GetUserGroups method

2017-04-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/240 Title: #240: IFP: Fix of names in GetUserGroups method Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#242][comment] IPA: Improve DEBUG message if an external group has no SID

2017-04-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/242 Title: #242: IPA: Improve DEBUG message if an external group has no SID jhrozek commented: """ On Fri, Apr 21, 2017 at 04:22:44AM -0700, lslebodn wrote: > lslebodn commented on this pull request. > > > > > @

[SSSD] [sssd PR#242][opened] IPA: Improve DEBUG message if an external group has no SID

2017-04-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/242 Author: jhrozek Title: #242: IPA: Improve DEBUG message if an external group has no SID Action: opened PR body: """ Please see the commit message, the patch is hopefully trivial """ To pull the PR as Git branc

[SSSD] [sssd PR#240][closed] IFP: Fix of names in GetUserGroups method

2017-04-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/240 Author: jhrozek Title: #240: IFP: Fix of names in GetUserGroups method Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/240/head:pr240 git checkout pr240

[SSSD] [sssd PR#238][closed] SECRESTS: remove unused variable

2017-04-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/238 Author: lslebodn Title: #238: SECRESTS: remove unused variable Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/238/head:pr238 git checkout pr238

[SSSD] [sssd PR#238][comment] SECRESTS: remove unused variable

2017-04-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/238 Title: #238: SECRESTS: remove unused variable jhrozek commented: """ * master: 0e8f0c06cad5805b1a1161f60e3f2cdb7a5a2921 """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#238][+Pushed] SECRESTS: remove unused variable

2017-04-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/238 Title: #238: SECRESTS: remove unused variable Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#238][+Accepted] SECRESTS: remove unused variable

2017-04-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/238 Title: #238: SECRESTS: remove unused variable Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#240][+Pushed] IFP: Fix of names in GetUserGroups method

2017-04-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/240 Title: #240: IFP: Fix of names in GetUserGroups method Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#243][opened] IPA: Use search bases from sdap_domain instead of inferring search base from IPA domain structure

2017-04-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/243 Author: jhrozek Title: #243: IPA: Use search bases from sdap_domain instead of inferring search base from IPA domain structure Action: opened PR body: """ This PR fixes https://pagure.io/SSSD/sssd/issue/3378 To test the patch, ad

[SSSD] [sssd PR#237][comment] providers: Move hostid from ipa to sdap

2017-04-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/237 Title: #237: providers: Move hostid from ipa to sdap jhrozek commented: """ Hi, I'm sorry the review takes so long. We're swamped with fixing bugs at the moment and the Easter holidays didn't help either. I think since the patch mo

[SSSD] [sssd PR#235][comment] Allow using the "shortnames" feature without requiring any configuration from the client side

2017-04-13 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/235 Title: #235: Allow using the "shortnames" feature without requiring any configuration from the client side jhrozek commented: """ retest this please """ See the full comment at https://github.com/S

[SSSD] [sssd PR#239][opened] HBAC: Use memberof ASQ search instead of originalMemberOf

2017-04-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/239 Author: jhrozek Title: #239: HBAC: Use memberof ASQ search instead of originalMemberOf Action: opened PR body: """ This PR should fix the bug we were seeing in the HBAC evaluation of users from a trusted AD domain where the original

[SSSD] [sssd PR#240][opened] IFP: Fix of names in GetUserGroups method

2017-04-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/240 Author: jhrozek Title: #240: IFP: Fix of names in GetUserGroups method Action: opened PR body: """ This is a continuation of PR#206 that implements the suggestion brought up there during PR review. This PR fixes https://pagure.io/

[SSSD] [sssd PR#206][comment] IFP: Fix of names in GetUserGroups method

2017-04-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/206 Title: #206: IFP: Fix of names in GetUserGroups method jhrozek commented: """ Since this PR wasn't updated in a week and we need to merge the patch soon to fix downstream, I opened a new PR #240. """ See the full comme

[SSSD] [sssd PR#206][+Rejected] IFP: Fix of names in GetUserGroups method

2017-04-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/206 Title: #206: IFP: Fix of names in GetUserGroups method Label: +Rejected ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#206][closed] IFP: Fix of names in GetUserGroups method

2017-04-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/206 Author: celestian Title: #206: IFP: Fix of names in GetUserGroups method Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/206/head:pr206 git checkout pr206

[SSSD] [sssd PR#199][comment] SPEC: Drop conditional build for krb5_local_auth_plugin

2017-04-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/199 Title: #199: SPEC: Drop conditional build for krb5_local_auth_plugin jhrozek commented: """ ACK, I tested together with other patches: http://sssd-ci.duckdns.org/logs/job/67/94/summary.html """ See the full comment at

[SSSD] [sssd PR#199][+Accepted] SPEC: Drop conditional build for krb5_local_auth_plugin

2017-04-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/199 Title: #199: SPEC: Drop conditional build for krb5_local_auth_plugin Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#233][comment] SDAP: Fix handling of search bases

2017-04-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/233 Title: #233: SDAP: Fix handling of search bases jhrozek commented: """ nack, I'm getting a valgrind error with this patch: ``` ==31975== Conditional jump or move depends on uninitialised value(s) ==31975==at 0xDB1543E: ad_s

[SSSD] [sssd PR#233][+Changes requested] SDAP: Fix handling of search bases

2017-04-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/233 Title: #233: SDAP: Fix handling of search bases Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#239][closed] HBAC: Use memberof ASQ search instead of originalMemberOf

2017-04-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/239 Author: jhrozek Title: #239: HBAC: Use memberof ASQ search instead of originalMemberOf Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/239/head:pr239 git checkout pr239

[SSSD] [sssd PR#239][+Rejected] HBAC: Use memberof ASQ search instead of originalMemberOf

2017-04-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/239 Title: #239: HBAC: Use memberof ASQ search instead of originalMemberOf Label: +Rejected ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#239][comment] HBAC: Use memberof ASQ search instead of originalMemberOf

2017-04-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/239 Title: #239: HBAC: Use memberof ASQ search instead of originalMemberOf jhrozek commented: """ Sorry, i really can't use the `hub` tool apparently. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#206][-Changes requested] IFP: Fix of names in GetUserGroups method

2017-04-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/206 Title: #206: IFP: Fix of names in GetUserGroups method Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

<    4   5   6   7   8   9   10   11   12   13   >