Re: [request for stable inclusion] [2.6.32] ethtool: Report link-down while interface is down

2014-05-26 Thread Willy Tarreau
On Tue, May 27, 2014 at 11:24:28AM +0800, Wang Weidong wrote: > ~ # modprobe bonding > ~ # ethtool bond0 > Settings for bond0: >Link detected: no > ~ # ifconfig eth1 down > ~ # echo +eth1 > /sys/class/net/bond0/bonding/slaves > ~ # ethtool bond0 > Settings for bond0: >

Re: [PATCH] CIFS: Fix memory leaks in SMB2_open

2014-05-26 Thread Shirish Pargaonkar
Looks correct. Reviewed-by: Shirish Pargaonkar On Sat, May 24, 2014 at 7:42 AM, Pavel Shilovsky wrote: > Cc: # v3.12+ > Signed-off-by: Pavel Shilovsky > --- > fs/cifs/smb2pdu.c |7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2p

Re: [request for stable inclusion] [2.6.32] ethtool: Report link-down while interface is down

2014-05-26 Thread Wang Weidong
On 2014/5/26 21:51, Willy Tarreau wrote: > Hi Wang, > > On Mon, May 26, 2014 at 05:14:09PM +0800, Wang Weidong wrote: >> Hi Willy, >> >> e596e6e4d578f2639416e620d367a3af34814a40 >> ethtool: Report link-down while interface is down >> >> When I add slaves to bonding(bond0), the bond0 is down while

[request for stable inclusion][3.10.x] patches to avoid interrupt storm when perf sampling is too slow

2014-05-26 Thread Weng Meiling
Hi Dave, Stephane, Knut, Peter or Will, 14c63f17b1fde5a575a28e96547a22b451c71fb5 perf: Drop sample rate when sampling is too slow e5302920da9ef23f9d19d4e9ac85704cc25bee7a perf: Fix interrupt handler timing harness 723478c8a471403c53cf144999701f6e0c4bbd11 perf: Enforce 1 as lower limit for perf_

RE: [PATCH] KVM: lapic: sync highest ISR to hardware apic on EOI

2014-05-26 Thread Zhang, Yang Z
Paolo Bonzini wrote on 2014-05-26: > Il 26/05/2014 05:44, Zhang, Yang Z ha scritto: >> Paolo Bonzini wrote on 2014-05-23: >>> When Hyper-V enlightenments are in effect, Windows prefers to issue >>> an Hyper-V MSR write to issue an EOI rather than an x2apic MSR write. >>> The Hyper-V MSR write is no

Re: [PATCH] watchdog: sp805: Set watchdog_device->timeout from ->set_timeout()

2014-05-26 Thread Wim Van Sebroeck
Hi Viresh, > Implementation of ->set_timeout() is supposed to set 'timeout' field of > 'struct > watchdog_device' passed to it. sp805 was rather setting this in a local > variable. Fix it. > > Cc: # 2.6.36+ > Reported-by: Arun Ramamurthy > Signed-off-by: Viresh Kumar > --- > Greg, > > This d

Re: [PATCH] xtensa: add fixup for double exception raised in window overflow

2014-05-26 Thread czankel
Hi Max, On 5/24/14, 3:19 PM, Max Filippov wrote: There are two FIXMEs in the double exception handler 'for the extremely unlikely case'. This case gets hit by gcc during kernel build once in a few hours, resulting in an unrecoverable exception condition. So, it wasn't really that 'extremely' unl

Re: [PATCH] watchdog: ath79_wdt: avoid spurious restarts on AR934x

2014-05-26 Thread Wim Van Sebroeck
Hi Gabor, > On some AR934x based systems, where the frequency of > the AHB bus is relatively high, the built-in watchdog > causes a spurious restart when it gets enabled. > > The possible cause of these restarts is that the timeout > value written into the TIMER register does not reaches > the ha

[PATCH 48/63] USB: cdc-acm: fix write and resume race

2014-05-26 Thread Johan Hovold
Fix race between write() and resume() due to improper locking that could lead to writes being reordered. Resume must be done atomically and susp_count be protected by the write_lock in order to prevent racing with write(). This could otherwise lead to writes being reordered if write() grabs the wr

[PATCH 26/63] USB: usb_wwan: fix write and suspend race

2014-05-26 Thread Johan Hovold
Fix race between write() and suspend() which could lead to writes being dropped (or I/O while suspended) if the device is runtime suspended while a write request is being processed. Specifically, suspend() releases the susp_lock after determining the device is idle but before setting the suspended

[PATCH 25/63] USB: usb_wwan: fix race between write and resume

2014-05-26 Thread Johan Hovold
From: xiao jin We find a race between write and resume. usb_wwan_resume run play_delayed() and spin_unlock, but intfdata->suspended still is not set to zero. At this time usb_wwan_write is called and anchor the urb to delay list. Then resume keep running but the delayed urb have no chance to be c

[PATCH 29/63] USB: usb_wwan: fix potential blocked I/O after resume

2014-05-26 Thread Johan Hovold
Keep trying to submit urbs rather than bail out on first read-urb submission error, which would also prevent I/O for any further ports from being resumed. Instead keep an error count, for all types of failed submissions, and let USB core know that something went wrong. Also make sure to always cl

[PATCH 52/63] USB: cdc-acm: fix potential urb leak and PM imbalance in write

2014-05-26 Thread Johan Hovold
Make sure to check return value of autopm get in write() in order to avoid urb leak and PM counter imbalance on errors. Fixes: 11ea859d64b6 ("USB: additional power savings for cdc-acm devices that support remote wakeup") Cc: # v2.6.27 Signed-off-by: Johan Hovold --- drivers/usb/class/cdc-ac

[PATCH 27/63] USB: usb_wwan: fix urb leak at shutdown

2014-05-26 Thread Johan Hovold
The delayed-write queue was never emptied at shutdown (close), something which could lead to leaked urbs if the port is closed before being runtime resumed due to a write. When this happens the output buffer would not drain on close (closing_wait timeout), and after consecutive opens, writes could

[PATCH 03/63] USB: sierra: fix urb and memory leak in resume error path

2014-05-26 Thread Johan Hovold
Neither the transfer buffer or the urb itself were released in the resume error path for delayed writes. Also on errors, the remainder of the queue was not even processed, which leads to further urb and buffer leaks. The same error path also failed to balance the outstanding-urb counter, something

[PATCH 24/63] USB: usb_wwan: fix urb leak in write error path

2014-05-26 Thread Johan Hovold
From: xiao jin When enable usb serial for modem data, sometimes the tty is blocked in tty_wait_until_sent because portdata->out_busy always is set and have no chance to be cleared. We find a bug in write error path. usb_wwan_write set portdata->out_busy firstly, then try autopm async with error.

[PATCH 01/63] USB: sierra: fix AA deadlock in open error path

2014-05-26 Thread Johan Hovold
Fix AA deadlock in open error path that would call close() and try to grab the already held disc_mutex. Fixes: b9a44bc19f48 ("sierra: driver urb handling improvements") Cc: # v2.6.31 Signed-off-by: Johan Hovold --- drivers/usb/serial/sierra.c | 21 + 1 file changed, 13 i

[PATCH 05/63] USB: sierra: fix remote wakeup

2014-05-26 Thread Johan Hovold
Make sure that needs_remote_wake up is always set when there are open ports. Currently close() would unconditionally set needs_remote_wakeup to 0 even though there might still be open ports. This could lead to blocked input and possibly dropped data on devices that do not support remote wakeup (an

[PATCH 28/63] USB: usb_wwan: fix potential NULL-deref at resume

2014-05-26 Thread Johan Hovold
The interrupt urb was submitted unconditionally at resume, something which could lead to a NULL-pointer dereference in the urb completion handler as resume may be called after the port and port data is gone. Fix this by making sure the interrupt urb is only submitted and active when the port is op

[PATCH 50/63] USB: cdc-acm: fix runtime PM for control messages

2014-05-26 Thread Johan Hovold
Fix runtime PM handling of control messages by adding the required PM counter operations. Fixes: 11ea859d64b6 ("USB: additional power savings for cdc-acm devices that support remote wakeup") Cc: # v2.6.27 Signed-off-by: Johan Hovold --- drivers/usb/class/cdc-acm.c | 12 +++- 1 file

[PATCH 47/63] USB: cdc-acm: fix write and suspend race

2014-05-26 Thread Johan Hovold
Fix race between write() and suspend() which could lead to writes being dropped (or I/O while suspended) if the device is runtime suspended while a write request is being processed. Specifically, suspend() releases the write_lock after determining the device is idle but before incrementing the sus

[PATCH 51/63] USB: cdc-acm: fix shutdown and suspend race

2014-05-26 Thread Johan Hovold
We should stop I/O unconditionally at suspend rather than rely on the tty-port initialised flag (which is set prior to stopping I/O during shutdown) in order to prevent suspend returning with URBs still active. Fixes: 11ea859d64b6 ("USB: additional power savings for cdc-acm devices that support re

[PATCH 49/63] USB: cdc-acm: fix broken runtime suspend

2014-05-26 Thread Johan Hovold
The current ACM runtime-suspend implementation is broken in several ways: Firstly, it buffers only the first write request being made while suspended -- any further writes are silently dropped. Secondly, writes being dropped also leak write urbs, which are never reclaimed (until the device is unb

[PATCH 21/63] USB: option: fix runtime PM handling

2014-05-26 Thread Johan Hovold
Fix potential I/O while runtime suspended due to missing PM operations in send_setup. Fixes: 383cedc3bb43 ("USB: serial: full autosuspend support for the option driver") Cc: # v2.6.32 Signed-off-by: Johan Hovold --- drivers/usb/serial/option.c | 11 ++- 1 file changed, 10 insert

[PATCH 02/63] USB: sierra: fix use after free at suspend/resume

2014-05-26 Thread Johan Hovold
Fix use after free or NULL-pointer dereference during suspend and resume. The port data may never have been allocated (port probe failed) or may already have been released by port_remove (e.g. driver is unloaded) when suspend and resume are called. Fixes: e6929a9020ac ("USB: support for autosuspe

[PATCH 04/63] USB: sierra: fix urb and memory leak on disconnect

2014-05-26 Thread Johan Hovold
The delayed-write queue was never emptied on disconnect, something which would lead to leaked urbs and transfer buffers if the device is disconnected before being runtime resumed due to a write. Fixes: e6929a9020ac ("USB: support for autosuspend in sierra while online") Cc: # v2.6.32 Signed-o

Re: [PATCH] ext4: Fix zeroing of page during writeback

2014-05-26 Thread Theodore Ts'o
On Thu, May 22, 2014 at 05:06:43PM +0200, Jan Kara wrote: > Tail of a page straddling inode size must be zeroed when being written > out due to POSIX requirement that modifications of mmaped page beyond > inode size must not be written to the file. ext4_bio_write_page() did > this only for blocks f

Re: [PATCH] KVM: lapic: sync highest ISR to hardware apic on EOI

2014-05-26 Thread Michael S. Tsirkin
On Mon, May 26, 2014 at 04:56:54PM +0200, Paolo Bonzini wrote: > Il 26/05/2014 16:28, Michael S. Tsirkin ha scritto: > >> static inline void apic_clear_isr(int vec, struct kvm_lapic *apic) > >> { > >>- if (__apic_test_and_clear_vector(vec, apic->regs + APIC_ISR)) > >>+ struct kvm_vcpu *vcpu; >

Re: [PATCH] KVM: lapic: sync highest ISR to hardware apic on EOI

2014-05-26 Thread Paolo Bonzini
Il 26/05/2014 16:28, Michael S. Tsirkin ha scritto: static inline void apic_clear_isr(int vec, struct kvm_lapic *apic) { - if (__apic_test_and_clear_vector(vec, apic->regs + APIC_ISR)) + struct kvm_vcpu *vcpu; + if (!__apic_test_and_clear_vector(vec, apic->regs + APIC_ISR)) +

Re: [PATCH v2] regulator: s2mpa01: Use correct register for buck1 ramp delay

2014-05-26 Thread Mark Brown
On Mon, May 26, 2014 at 10:26:46AM +0200, Krzysztof Kozlowski wrote: > Fix the register for ramp delay of buck1 regulator. Buck1 and buck6 > share the field (offset 4) in ramp delay register S2MPA01_REG_RAMP2. Applied, thanks. signature.asc Description: Digital signature

Re: [PATCH] KVM: lapic: sync highest ISR to hardware apic on EOI

2014-05-26 Thread Michael S. Tsirkin
On Fri, May 23, 2014 at 04:51:53PM +0200, Paolo Bonzini wrote: > When Hyper-V enlightenments are in effect, Windows prefers to issue an > Hyper-V MSR write to issue an EOI rather than an x2apic MSR write. > The Hyper-V MSR write is not handled by the processor, and besides > being slower, this also

Re: [request for stable inclusion] [2.6.32] ethtool: Report link-down while interface is down

2014-05-26 Thread Willy Tarreau
Hi Wang, On Mon, May 26, 2014 at 05:14:09PM +0800, Wang Weidong wrote: > Hi Willy, > > e596e6e4d578f2639416e620d367a3af34814a40 > ethtool: Report link-down while interface is down > > When I add slaves to bonding(bond0), the bond0 is down while > ethtool gets the Link detected: yes. This commit

Re: [PATCH 1/2] arm: dts: Fix missing device_type="memory" for ste-ccu8540

2014-05-26 Thread Grant Likely
Oops, sent this series out by mistake. Sorry for the noise. g. On Mon, May 26, 2014 at 2:42 PM, Grant Likely wrote: > From: Leif Lindholm > > The current .dts for ste-ccu8540 lacks a 'device_type = "memory"' for > its memory node, relying on an old ppc quirk in order to discover its > memory. F

[PATCH 2/2] mips: dts: Fix missing device_type="memory" property in memory nodes

2014-05-26 Thread Grant Likely
From: Leif Lindholm A few platforms lack a 'device_type = "memory"' for their memory nodes, relying on an old ppc quirk in order to discover its memory. Add the missing data so that all parsing code can find memory nodes correctly. Signed-off-by: Leif Lindholm Cc: linux-m...@linux-mips.org Cc:

[PATCH 1/2] arm: dts: Fix missing device_type="memory" for ste-ccu8540

2014-05-26 Thread Grant Likely
From: Leif Lindholm The current .dts for ste-ccu8540 lacks a 'device_type = "memory"' for its memory node, relying on an old ppc quirk in order to discover its memory. Fix the data so that all parsing code can handle it correctly. Signed-off-by: Leif Lindholm Acked-by: Lee Jones Acked-by: Linu

Re: [PATCH] KVM: lapic: sync highest ISR to hardware apic on EOI

2014-05-26 Thread Paolo Bonzini
Il 26/05/2014 05:44, Zhang, Yang Z ha scritto: Paolo Bonzini wrote on 2014-05-23: When Hyper-V enlightenments are in effect, Windows prefers to issue an Hyper-V MSR write to issue an EOI rather than an x2apic MSR write. The Hyper-V MSR write is not handled by the processor, and besides being slo

[git:media_tree/master] [media] v4l: vsp1: Remove the unneeded vsp1_video_buffer video field

2014-05-26 Thread Mauro Carvalho Chehab
This is an automatic generated email to let you know that the following patch were queued at the http://git.linuxtv.org/media_tree.git tree: Subject: [media] v4l: vsp1: Remove the unneeded vsp1_video_buffer video field Author: Laurent Pinchart Date:Wed May 21 17:39:16 2014 -0300 The field

Re: [PATCH 3/3] synaptics: Change min/max quirk table to pnp-id matching

2014-05-26 Thread Hans de Goede
Hi Dmitry, On 05/19/2014 10:51 AM, Hans de Goede wrote: > Hi, > > On 05/18/2014 10:35 PM, Dmitry Torokhov wrote: >> On Fri, May 16, 2014 at 08:46:49PM +0200, Hans de Goede wrote: >>> Most of the affected models share pnp-ids for the touchpad. So switching >>> to pnp-ids give us 2 advantages: >>>

[PATCH resend] acpi-video: Add 4 new models to the use_native_backlight dmi list

2014-05-26 Thread Hans de Goede
Acer Aspire V5-171 https://bugzilla.redhat.com/show_bug.cgi?id=983342 Acer Aspire V5-471G Lenovo Yoga 2 11 Reported-and-tested-by: Vincent Gerris HP EliteBook 8470p https://bugzilla.redhat.com/show_bug.cgi?id=1093120 Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede --- drivers/acpi/vid

[request for stable inclusion] [2.6.32] ethtool: Report link-down while interface is down

2014-05-26 Thread Wang Weidong
Hi Willy, e596e6e4d578f2639416e620d367a3af34814a40 ethtool: Report link-down while interface is down When I add slaves to bonding(bond0), the bond0 is down while ethtool gets the Link detected: yes. This commit fix it. Looks applicable to stable 2.6.32, it was built successfully for me. what do y

Re: [PATCH v2] regulator: s2mpa01: Use correct register for buck1 ramp delay

2014-05-26 Thread Sachin Kamat
On 26 May 2014 13:56, Krzysztof Kozlowski wrote: > Fix the register for ramp delay of buck1 regulator. Buck1 and buck6 > share the field (offset 4) in ramp delay register S2MPA01_REG_RAMP2. > > The driver used the same register and field for ramp delay of buck3 and > buck1. This lead to updating o

Re: [RFT PATCH] regulator: s2mpa01: Use correct register for buck[36] ramp delay

2014-05-26 Thread Krzysztof Kozlowski
On pon, 2014-05-26 at 13:37 +0530, Sachin Kamat wrote: > Hi Krzysztof > > Apologies for the delay. I was on vacation during the early part of > this month and > got busy with some other stuff later and this mail fell through the cracks. > > > On 23 May 2014 19:49, Krzysztof Kozlowski wrote: > >

[PATCH v2] regulator: s2mpa01: Use correct register for buck1 ramp delay

2014-05-26 Thread Krzysztof Kozlowski
Fix the register for ramp delay of buck1 regulator. Buck1 and buck6 share the field (offset 4) in ramp delay register S2MPA01_REG_RAMP2. The driver used the same register and field for ramp delay of buck3 and buck1. This lead to updating of ramp delay of buck3 when setting buck1 and actually the r

Re: [RFT PATCH] regulator: s2mpa01: Use correct register for buck[36] ramp delay

2014-05-26 Thread Sachin Kamat
Hi Krzysztof Apologies for the delay. I was on vacation during the early part of this month and got busy with some other stuff later and this mail fell through the cracks. On 23 May 2014 19:49, Krzysztof Kozlowski wrote: > Hi Sachin, > > The s2mpa01 regulator driver uses wrong registers for ram