Re: [GIT PULL] Update dw-mmc controller

Hello, On Mon, 2015-08-17 at 12:32 +0200, Ulf Hansson wrote: > On 17 August 2015 at 12:12, Alexey Brodkin > wrote: > > Hi Ulf, > > > > On Mon, 2015-08-17 at 11:47 +0200, Ulf Hansson wrote: > > > On 10 August 2015 at 18:54, Jaehoon Chung wrote: > > &g

[PATCH v4] stmmac: fix check for phydev being open

ergei Shtylyov Cc: Giuseppe Cavallaro Cc: linux-ker...@vger.kernel.org Cc: stable@vger.kernel.org Cc: David Miller Signed-off-by: Alexey Brodkin --- Changes compared to v3: * Remove "else" branch after "return" as suggested by Sergei. Changes compared to v2: * Updated commi

Re: [PATCH v3] stmmac: fix check for phydev being open

Hi Sergei, On Tue, 2015-09-08 at 22:53 +0300, Sergei Shtylyov wrote: > Hello. > > On 09/08/2015 03:46 PM, Alexey Brodkin wrote: > > > > > Current check of phydev with IS_ERR(phydev) may make not much sense > > > > because of_phy_connect() returns NU

Re: [PATCH v3] stmmac: fix check for phydev being open

Hi Sergei, On Tue, 2015-09-08 at 14:20 +0300, Sergei Shtylyov wrote: > Hello. > > On 9/8/2015 11:43 AM, Alexey Brodkin wrote: > > > Current check of phydev with IS_ERR(phydev) may make not much sense > > because of_phy_connect() returns NULL on failure instead of error v

[PATCH v3] stmmac: fix check for phydev being open

ergei Shtylyov Cc: Giuseppe Cavallaro Cc: linux-ker...@vger.kernel.org Cc: stable@vger.kernel.org Cc: David Miller Signed-off-by: Alexey Brodkin --- Changes compared to v2: * Updated commit message with mention of of_phy_connect() instead of of_phy_attach(). * Return ENODEV in ca

Re: [PATCH v2] stmmac: fix check for phydev being open

Hi Sergei, On Tue, 2015-09-08 at 00:24 +0300, Sergei Shtylyov wrote: > On 09/07/2015 11:50 PM, Alexey Brodkin wrote: > > > Current implementation via IS_ERR(phydev) may make no sense because > > of_phy_attach() returns NULL on failure instead of error value. > >

Re: [PATCH v2] stmmac: fix check for phydev being open

Hi Sergei, On Mon, 2015-09-07 at 23:53 +0300, Sergei Shtylyov wrote: > On 09/07/2015 11:50 PM, Alexey Brodkin wrote: > > > Current implementation via IS_ERR(phydev) may make no sense because > > of_phy_attach() returns NULL on failure instead of error value. > > > >

[PATCH v2] stmmac: fix check for phydev being open

-ker...@vger.kernel.org Cc: stable@vger.kernel.org Cc: David Miller Cc: Sergei Shtylyov Signed-off-by: Alexey Brodkin --- Changes compared to v1: * Use IS_ERR_OR_NULL() instead of discrete checks for null and err drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1

[PATCH] stmmac: fix check for phydev being open

-ker...@vger.kernel.org Cc: stable@vger.kernel.org Cc: David Miller Signed-off-by: Alexey Brodkin --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet

Re: [PATCH 3.2 047/110] stmmac: troubleshoot unexpected bits in des0 & des1

Hi Ben, On Mon, 2015-08-10 at 12:12 +0200, Ben Hutchings wrote: > 3.2.71-rc1 review patch. If anyone has any objections, please let me know. > > -- > > From: Alexey Brodkin > > commit f1590670ce069eefeb93916391a67643e6ad1630 upstream. > > Current i

[PATCH] ARC: make sure instruction_pointer() returns unsigned value

libuClibc-0.9.34-git.so [.] memcpy 2.11% ls libuClibc-0.9.34-git.so [.] malloc 1.88% ls libuClibc-0.9.34-git.so [.] memset 1.64% ls [kernel.kallsyms][k] _raw_spin_unlock_irqrestore 1.41% ls [kernel.kallsyms][k] __d_lookup_rcu --

[PATCH v3] stmmac: troubleshoot unexpected bits in des0 & des1

on driver probe. [2] Do explicit zeroing of both "des0" and "des1" fields of all buffer descriptors during initialization of DMA transfer. And while at it fixed identation of dma_free_coherent() counterpart as well. Signed-off-by: Alexey Brodkin Cc: Giuseppe Cavallaro

Re: [PATCH v2] stmmac: troubleshoot unexpected bits in des0 & des1

Hi David, On Wed, 2015-06-24 at 01:44 -0700, David Miller wrote: > From: Alexey Brodkin > Date: Wed, 24 Jun 2015 11:07:26 +0300 > > > > > - priv->dma_tx = dma_alloc_coherent(priv->device, > > txsize * > > + priv->dma_tx = dma

[PATCH v2] stmmac: troubleshoot unexpected bits in des0 & des1

on driver probe. [2] Do explicit zeroing of both "des0" and "des1" fields of all buffer descriptors during initialization of DMA transfer. Signed-off-by: Alexey Brodkin Cc: Giuseppe Cavallaro Cc: arc-linux-...@synopsys.com Cc: linux-ker...@vger.kernel.org Cc: stable@vg

Re: [PATCH] stmmac: explicitly zero des0 & des1 on init

Hi David, On Mon, 2015-06-22 at 09:43 +0300, Alexey Brodkin wrote: > Hi David, > > On Sun, 2015-06-21 at 09:29 -0700, David Miller wrote: > > From: Alexey Brodkin > > Date: Tue, 16 Jun 2015 20:40:41 +0300 > > > > > Current implementtion of descriptor i

Re: [arc-linux-dev] [PATCH] stmmac: explicitly zero des0 & des1 on init

Hi all, On Wed, 2015-06-17 at 07:03 +, Vineet Gupta wrote: +CC linux-arch, linux-mm, Arnd and Marek On Tuesday 16 June 2015 11:11 PM, Alexey Brodkin wrote: Current implementtion of descriptor init procedure only takes care about ownership flag. While it is perfectly possible to have

Re: [PATCH] stmmac: explicitly zero des0 & des1 on init

Hi David, On Sun, 2015-06-21 at 09:29 -0700, David Miller wrote: > From: Alexey Brodkin > Date: Tue, 16 Jun 2015 20:40:41 +0300 > > > Current implementtion of descriptor init procedure only takes care > > about > > ownership flag. While it is perfectly possible to

[PATCH] stmmac: explicitly zero des0 & des1 on init

GMAC DMA block. Solution to this problem is as simple as explicit zeroing of both des0 and des1 fields of all buffer descriptors. Signed-off-by: Alexey Brodkin Cc: Giuseppe Cavallaro Cc: arc-linux-...@synopsys.com Cc: linux-ker...@vger.kernel.org Cc: stable@vger.kernel.org --- drivers/net