gt; Let's also use kvm_lookup_vcpu() for validation of the sending VCPU
> on external call injection.
>
> Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com>
> Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.com>
> Signed-off-by: Christian Borntraeger <borntr
by id, not array index.
Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com>
Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.com>
Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com>
[split stable/non-stable parts]
Cc: stable@vger.kernel.org # c3853a8: KVM: P
lls via SIGP IF.
Especially the 2. happens regularly. So this could produce two problems:
1. The guest losing/getting external calls.
2. Random memory overwrites in the host.
So this problem happens on every 127 + 128 created VM with 64 VCPUs.
Cc: stable@vger.kernel.org # v3.15+
Acked-by: Chr
than
sorry as we dont want to rely on the implementation of
macros. Opinions?
Christian Borntraeger (1):
macvtap: Fix regression for macvtap ioctls
drivers/net/macvtap.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
--
2.3.0
--
To unsubscribe from this list: send the line &q
net>
Reported-by: Mark A. Peloquin
Bisected-by: Matthew Rosato <mjros...@linux.vnet.ibm.com>
Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com>
Fixes: 39ec7de7092b ("macvtap: fix uninitialized access on TUNSETIFF")
Cc: stable@vger.kernel.org
---
drivers/net/macvtap.c
...@linux.vnet.ibm.com
Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com
Reviewed-by: Eric Farman far...@linux.vnet.ibm.com
Tested-by: Eric Farman far...@linux.vnet.ibm.com
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
Cc: stable@vger.kernel.org
---
drivers/s390/kvm/virtio_ccw.c | 11
even after a reset. Let's fix this by clearing the pending bitmap
and the parameters for service and machine check interrupts.
Cc: stable@vger.kernel.org # 4.1
Signed-off-by: Jens Freimann jf...@linux.vnet.ibm.com
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
---
arch/s390/kvm
Am 09.04.2015 um 10:44 schrieb l...@kernel.org:
From: Christian Borntraeger borntrae...@de.ibm.com
3.4.107-rc1 review patch. If anyone has any objections, please let me know.
--
commit 2dca485f8740208604543c3960be31a5dd3ea603 upstream.
Hmmm, I just realized
giving up the lock.
Cc: stable@vger.kernel.org # 3.18+: 69a8d4562638 KVM: s390: no need to hold...
Reviewed-by: David Hildenbrand d...@linux.vnet.ibm.com
Signed-off-by: Jens Freimann jf...@linux.vnet.ibm.com
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
Acked-by: Cornelia Huck
Am 31.03.2015 um 16:12 schrieb Heiko Carstens:
On Tue, Mar 31, 2015 at 03:01:58PM +0200, Christian Borntraeger wrote:
From: Jens Freimann jf...@linux.vnet.ibm.com
This fixes a bug introduced with commit c05c4186bbe4 (KVM: s390:
add floating irq controller).
get_all_floating_irqs() does
and returns -EFAULT in this special
case. This error is not recoverable, so let's fail hard. This can later
be avoided by not dequeuing the interrupt but working directly on the
locked list.
Signed-off-by: David Hildenbrand d...@linux.vnet.ibm.com
Cc: stable@vger.kernel.org # 3.16+
Signed-off-by: Christian
reinjected. Therefore the dequeued
interrupt is lost.
This patch fixes the problem while cleaning up the function and making the
cc and rc logic easier to handle.
Signed-off-by: David Hildenbrand d...@linux.vnet.ibm.com
Cc: stable@vger.kernel.org # 3.16+
Signed-off-by: Christian Borntraeger borntrae
Reviewed-by: David Hildenbrand d...@linux.vnet.ibm.com
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
---
arch/s390/kvm/priv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/s390/kvm/priv.c b/arch/s390/kvm/priv.c
index 3511169..c7fee9d 100644
--- a/arch/s390/kvm/priv.c
+++ b/arch
Am 25.02.2015 um 11:08 schrieb Ingo Molnar:
* Greg KH gre...@linuxfoundation.org wrote:
It's:
d6abfdb20223 x86/spinlocks/paravirt: Fix memory corruption on unlock
Yes, This is the original patch. Please note I have taken out the
READ_ONCE changes from the original patch to avoid build
...@linux.vnet.ibm.com
Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com
Signed-off-by: David Hildenbrand d...@linux.vnet.ibm.com
Cc: stable@vger.kernel.org # v3.15+
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
---
arch/s390/kvm/interrupt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch
...@linux.vnet.ibm.com
Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com
Signed-off-by: David Hildenbrand d...@linux.vnet.ibm.com
Cc: stable@vger.kernel.org # v3.15+
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
---
arch/s390/kvm/interrupt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch
-by: Dominik Dingel din...@linux.vnet.ibm.com
Signed-off-by: David Hildenbrand d...@linux.vnet.ibm.com
Cc: stable@vger.kernel.org # v3.15+
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
---
arch/s390/kvm/interrupt.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git
-by: Cornelia Huck cornelia.h...@de.ibm.com
Cc: stable@vger.kernel.org
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
---
arch/s390/kvm/kvm-s390.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
index 14cdf1c..37ef06c
. So lets use hrtimer_cancel instead of try_to_cancel.
A proper fix might be to introduce a RAW based hrtimer.
Reported-by: Christian Borntraeger borntrae...@de.ibm.com
Cc: stable@vger.kernel.org
Signed-off-by: David Hildenbrand d...@linux.vnet.ibm.com
Acked-by: Cornelia Huck cornelia.h
the ACCESS_ONCE scheme with a barrier() based scheme
that should work for all supported compilers.
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
Cc: stable@vger.kernel.org # v3.16+
---
arch/s390/kvm/gaccess.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git
the ACCESS_ONCE scheme with a barrier() based scheme
that should work for all supported compilers.
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
Cc: stable@vger.kernel.org # v3.16+
---
arch/s390/kvm/gaccess.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git
intercept should not happen that often.
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
Acked-by: Cornelia Huck cornelia.h...@de.ibm.com
Reviewed-by: David Hildenbrand d...@linux.vnet.ibm.com
Cc: stable@vger.kernel.org
---
arch/s390/kvm/priv.c | 4 ++--
1 file changed, 2 insertions
the ACCESS_ONCE scheme with a barrier() based scheme
that should work for all supported compilers.
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
Cc: stable@vger.kernel.org # v3.16+
---
arch/s390/kvm/gaccess.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git
-by: Christian Borntraeger borntrae...@de.ibm.com
---
arch/s390/kvm/interrupt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
index a398384..4fc3fed 100644
--- a/arch/s390/kvm/interrupt.c
+++ b/arch/s390/kvm/interrupt.c
@@ -270,7
On 09/26/2014 11:44 AM, Jiri Slaby wrote:
From: Christian Borntraeger borntrae...@de.ibm.com
3.12-stable review patch. If anyone has any objections, please let me know.
I just checked.
It seems that the referenced commit 4badad352a6bb202ec68afa7a574c0bb961e5ebc
(locking/mutex: Disable
On 09/26/2014 12:20 PM, Jiri Slaby wrote:
On 09/26/2014, 12:06 PM, Christian Borntraeger wrote:
On 09/26/2014 11:44 AM, Jiri Slaby wrote:
From: Christian Borntraeger borntrae...@de.ibm.com
3.12-stable review patch. If anyone has any objections, please let me know.
I just checked
in blk_mq_timeout_check().
Cc: stable@vger.kernel.org
Signed-off-by: David Hildenbrand d...@linux.vnet.ibm.com
Acked-by: Christian Borntraeger borntrae...@de.ibm.com
Can you please add
Reported-by: Paulo De Rezende Pinatti ppina...@linux.vnet.ibm.com
Tested-by: Paulo De Rezende Pinatti ppina
On 09/18/2014 11:04 AM, David Hildenbrand wrote:
This patch should fix the bug reported in https://lkml.org/lkml/2014/9/11/249.
We have to initialize at least the atomic_flags and the cmd_flags when
allocating storage for the requests.
Otherwise blk_mq_timeout_check() might dereference
in it might be read-only and due to a parallel scan old.
An do_wp_page will make it writeable and young. Due to software
reference tracking this page was invalid and now becomes valid.
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
Acked-by: Martin Schwidefsky schwidef...@de.ibm.com
Cc
in that case.
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
Acked-by: Martin Schwidefsky schwidef...@de.ibm.com
Cc: stable@vger.kernel.org # v3.12+
---
arch/s390/include/asm/pgtable.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/s390/include/asm
On 27/08/14 05:06, Ben Hutchings wrote:
On Mon, 2014-08-25 at 15:10 +0200, Christian Borntraeger wrote:
The PFMF instruction handler blindly wrote the storage key even if
the page was mapped R/O in the host. Lets try a COW before continuing
and bail out in case of errors.
Signed-off
The PFMF instruction handler blindly wrote the storage key even if
the page was mapped R/O in the host. Lets try a COW before continuing
and bail out in case of errors.
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
Reviewed-by: Dominik Dingel din...@linux.vnet.ibm.com
Cc: stable
structure. Unfortunately, this
allows userspace to trigger a kernel BUG. Let's just remove
this switch statement.
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com
Reviewed-by: David Hildenbrand d...@linux.vnet.ibm.com
Cc: stable
.
(We dont implement cmpxchg with locks).
Please note: This is a quick fix for s390, suitable for stable
as 3.16 unintenionally disabled optimistic spinning.
The proper fix is probably to use ARCH_HAVE_NMI_SAFE_CMPXCHG
instead of introducing ARCH_SUPPORTS_ATOMIC_RMW.
Signed-off-by: Christian
On hard exits (abort, sigkill) we have have some kvm_s390_interrupt_info
structures hanging around. Delete those on exit to avoid memory leaks.
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
CC: stable@vger.kernel.org
Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com
---
arch/s390
in the kernel and dont return to userspace,
even if in ucontrol mode.
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com
CC: stable@vger.kernel.org
---
arch/s390/kvm/kvm-s390.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
3.10.33 spits the following warning:
[ 14.463408] [ cut here ]
[ 14.463411] WARNING: at block/elevator.c:193
[ 14.463413] Modules linked in: vhost_net macvtap macvlan kvm dasd_eckd_mod
dasd_mod zfcp scsi_transport_fc scsi_tgt qeth qdio ccwgroup dm_multipath sunrpc
[
-by: Christian Borntraeger borntrae...@de.ibm.com
CC: stable@vger.kernel.org
---
arch/s390/kvm/kvm-s390.c | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
index a3d797b..39894aa 100644
--- a/arch/s390/kvm/kvm
On 28/02/13 23:26, Jiri Slaby wrote:
On 02/27/2013 12:57 AM, Greg Kroah-Hartman wrote:
3.0-stable review patch. If anyone has any objections, please let me know.
--
From: Christian Borntraeger borntrae...@de.ibm.com
commit 15bc8d8457875f495c59d933b05770ba88d1eacb upstream
a machine check
will happen) will revalidate all registers with the content of the
save area.
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
CC: stable@vger.kernel.org
---
arch/s390/kvm/kvm-s390.c | 8
1 file changed, 8 insertions(+)
diff --git a/arch/s390/kvm/kvm-s390.c b/arch
Marcelo,
here is a kvm related fix for s390. Please consider for the next merge window.
Since it is s390 core kernel, I will also push it into Martins s390 tree.
Christian Borntraeger (1):
Subject: [PATCH] s390/kvm: Fix address space mixup
arch/s390/kernel/entry64.S | 25
.
(Otherwise we have a kernel bug anyway).
We also have to compensate the rewinding, since the C-level handlers
will do that. Therefore we need to add a nop with the same length
as SIE before the sie_loop.
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
CC: stable@vger.kernel.org
CC: Martin
+0x6c/0x27c)
[ 2150.713749] [00233812] page_referenced+0x32a/0x410
[...]
CC: stable@vger.kernel.org
CC: Alex Graf ag...@suse.de
Signed-off-by: Martin Schwidefsky schwidef...@de.ibm.com
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com
---
arch/s390/kvm/kvm-s390.c | 2 +-
1 file
43 matches
Mail list logo
