Re: [PATCH] drm/i915: rip out the PM_IIR WARN

2012-06-22 Thread Daniel Vetter
On Thu, Jun 21, 2012 at 02:55:22PM +0200, Daniel Vetter wrote: After banging my head against this for the past few months, I still don't see how this could possible race under the premise that once an irq bit is masked in PM_IMR and reset in PM_IIR it won't show up again until we unmask

[PATCH] drm/edid: don't return stack garbage from supports_rb

2012-06-19 Thread Daniel Vetter
We need to initialize this to false, because the is_rb callback only ever sets it to true. Noticed while reading through the code. Cc: Adam Jackson a...@redhat.com Cc: stable@vger.kernel.org Signed-Off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_edid.c |2 +- 1 file

[PATCH] drm/i915: enable edp vdd in intel_dp_detect

2012-06-11 Thread Daniel Vetter
Reported-by: Linus Torvalds torva...@linux-foundation.org Bugreport: http://permalink.gmane.org/gmane.comp.video.dri.devel/69695 Tested-by: Yang Guang guang.a.y...@intel.com Cc: stable@vger.kernel.org Signed-Off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/i915/intel_dp.c | 16

[PATCH] drm/i915: hold forcewake around ring hw init

2012-06-04 Thread Daniel Vetter
://bugs.freedesktop.org/show_bug.cgi?id=50522 Signed-Off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/i915/i915_drv.c | 13 + drivers/gpu/drm/i915/i915_drv.h |3 +++ drivers/gpu/drm/i915/intel_ringbuffer.c |9 - 3 files changed, 20

Re: [Intel-gfx] [PATCH] drm/i915: hold forcewake around ring hw init

2012-06-04 Thread Daniel Vetter
On Mon, Jun 04, 2012 at 12:04:41PM +0300, Jani Nikula wrote: Hi Daniel, please find a couple of comments inline. Oops, a clear case of -ENOTENOUGHCOFFEE. Thanks for catching these, I'll follow up with a v2 shortly. -Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48

[PATCH] drm/i915: hold forcewake around ring hw init

2012-06-04 Thread Daniel Vetter
in init_ring_common, both noticed by Jani Nikula. Cc: stable@vger.kernel.org Reported-by: Yang Guang guang.a.y...@intel.com Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=50522 Signed-Off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/i915/i915_drv.c | 13 + drivers

Re: [PATCH] drm/i915: hold forcewake around ring hw init

2012-06-04 Thread Daniel Vetter
On Mon, Jun 04, 2012 at 11:18:15AM +0200, Daniel Vetter wrote: Empirical evidence suggests that we need to: On at least one ivb machine when running the hangman i-g-t test, the rings don't properly initialize properly - the RING_START registers seems to be stuck at all zeros. Holding

[PATCH] drm/i915: reject doubleclocked cea modes on dp

2012-05-23 Thread Daniel Vetter
-by: Yuang Guang guang.a.y...@intel.com Cc: stable@vger.kernel.org Signed-Off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/i915/intel_dp.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index a1a5ce7..736a3c8

Re: [PATCH v2 1/2] drm/i915: fix integer overflow in i915_gem_execbuffer2()

2012-04-23 Thread Daniel Vetter
picked up for -fixes, thanks. -Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 -- To unsubscribe from this list: send the line unsubscribe stable in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Intel-gfx] [PATCH] drm/i915: [GEN7] Use HW scheduler for fixed function shaders

2012-04-18 Thread Daniel Vetter
*seem* like we don't want to set this on HSW. Anyway, thanks for your review. ___ Intel-gfx mailing list intel-...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79

Re: [Intel-gfx] [PATCH] drm/i915: make rc6 module parameter read-only

2012-04-11 Thread Daniel Vetter
On Wed, Apr 11, 2012 at 09:39:02AM -0700, Jesse Barnes wrote: People have been getting confused and thinking this is a runtime control. Cc: stable@vger.kernel.org Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org Picked up for -fixes, thanks for the patch. -Daniel -- Daniel Vetter Mail

<    1   2   3   4   5