Re: [PATCH net-next] udp: properly support MSG_PEEK with truncated buffers

2015-12-30 Thread Herbert Xu
pstream kernels since Al Viro did a great > job to replace this into : > skb_copy_and_csum_datagram_msg(skb, sizeof(struct udphdr), msg); > This variant is safe vs short buffers. > > For the time being, instead reverting Herbert Xu patch and add back > skb->ip_summed invalid changes, simp

Re: [PATCH 2/2] chacha20poly1305: Skip encryption/decryption for 0-len

2015-12-09 Thread Herbert Xu
ion > key for AAD authentication. > > Signed-off-by: Jason A. Donenfeld <ja...@zx2c4.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To un

Re: [PATCH 1/2] blkcipher: Copy iv from desc even for 0-len walks

2015-12-09 Thread Herbert Xu
d-off-by: Jason A. Donenfeld <ja...@zx2c4.com> > Cc: <stable@vger.kernel.org> Applied to crypto. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this

netlink: Add missing goto statement to netlink_insert

2015-12-07 Thread Herbert Xu
ot;) Reported-by: Stefan Priebe <s.pri...@profihost.ag> Reported-by: Philipp Hahn <pmh...@pmhahn.de> Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index d139c43..0d6038c 100644 --- a/net/netlink/af_net

Re: Asterisk deadlocks since Kernel 4.1

2015-12-06 Thread Herbert Xu
gt; > Can you please confirm, that this is not correct and might cause > those issues. Well spotted! Yes this would be a fatal error and can cause the problems you guys are seeing. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herber

Re: [PATCH] crypto: mxs-dcp - Initialize .statesize fields

2015-11-27 Thread Herbert Xu
e@vger.kernel.org> # 4.1+ > Suggested-by: Stephan Mueller <smuel...@chronox.de> > Signed-off-by: Fabio Estevam <fabio.este...@freescale.com> It's not as simple as that. You must implement import and export for it before we can turn it back on. Thanks, -- Email: Herbert Xu

Re: [PATCH] crypto: mxs-dcp - Initialize .statesize fields

2015-11-27 Thread Herbert Xu
nd import needs to be able to read such a buffer and generate a hash state from it which can then be updated/finalised. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To u

Re: [PATCH] crypto: sun4i-ss: add missing statesize

2015-11-17 Thread Herbert Xu
@gmail.com> Patch applied to cryptodev as I don't think it needs to go into stable straight away. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe f

Re: [PATCH] crypto: sun4i-ss: add missing statesize

2015-11-17 Thread Herbert Xu
that bother people. Well it will hit stable eventually. I just don't feel comfortable with sending it in straight away. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To u

Re: [PATCH] [RESEND] crypto: qat - don't use userspace pointer

2015-11-13 Thread Herbert Xu
On Wed, Oct 21, 2015 at 02:57:09PM -0700, Tadeusz Struk wrote: > Bugfix - don't dereference userspace pointer. > > Resend with the correct way for inclusion in the stable kernel. Applied to crypto. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.

Re: [PATCH] crypto: sun4i-ss: add missing statesize

2015-11-08 Thread Herbert Xu
ahash - ensure statesize is non-zero > (...) > + This patch adds a check to prevent these drivers from registering > + ahash algorithms until they are fixed. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor

Re: [PATCH] crypto: sun4i-ss: add missing statesize

2015-11-05 Thread Herbert Xu
fiy statesize for sha1 and md5. > > > > Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> > > Cc: stable@vger.kernel.org > > Please also add a Fixes tag (and the stable version it applies to). I don't see the point for a fixes tag as it would simply refer to the original

Re: [PATCH] crypto: marvell: properly handle CRYPTO_TFM_REQ_MAY_BACKLOG-flagged requests

2015-09-21 Thread Herbert Xu
om> > Fixes: db509a45339fd ("crypto: marvell/cesa - add TDMA support") > Cc: <stable@vger.kernel.org> # v4.2+ > Signed-off-by: Thomas Petazzoni <thomas.petazz...@free-electrons.com> Applied to crypto. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page:

Re: [PATCH] crypto: caam - fix memory corruption in ahash_final_ctx

2015-08-13 Thread Herbert Xu
) Signed-off-by: Horia Geantă horia.gea...@freescale.com Applied to crypto. Thanks! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe

Re: FAILED: patch [PATCH] crypto: nx - Fix reentrancy bugs failed to apply to 4.1-stable tree

2015-08-11 Thread Herbert Xu
Finally the backport: commit 030f4e968741d65aea9cd5f7814d1164967801ef Author: Herbert Xu herb...@gondor.apana.org.au Date: Tue Jul 7 17:30:25 2015 +0800 crypto: nx - Fix reentrancy bugs This patch fixes a host of reentrancy bugs in the nx driver. The following algorithms are affected

Re: FAILED: patch [PATCH] crypto: nx - Fix reentrancy bugs failed to apply to 4.1-stable tree

2015-08-10 Thread Herbert Xu
call nx_build_sg_list directly and pass a previous calculated max_sg_len to it. Signed-off-by: Leonidas S. Barbosa leosi...@linux.vnet.ibm.com Signed-off-by: Herbert Xu herb...@gondor.apana.org.au diff --git a/drivers/crypto/nx/nx-sha256.c b/drivers/crypto/nx/nx-sha256.c index 23621da..4e91bdb 100644

Re: FAILED: patch [PATCH] crypto: nx - Fix reentrancy bugs failed to apply to 4.1-stable tree

2015-08-10 Thread Herbert Xu
-by: Leonidas S. Barbosa leosi...@linux.vnet.ibm.com Signed-off-by: Herbert Xu herb...@gondor.apana.org.au diff --git a/drivers/crypto/nx/nx.c b/drivers/crypto/nx/nx.c index 1da6dc5..4856f72 100644 --- a/drivers/crypto/nx/nx.c +++ b/drivers/crypto/nx/nx.c @@ -215,8 +215,15 @@ struct nx_sg

Re: [PATCH v3.17 .. v3.19] lib/rhashtable: fix race between rhashtable_lookup_compare and hashtable resize

2015-06-27 Thread Herbert Xu
your test to see if this patch makes your problem go away on the pre-4.0 kernels? Thanks! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line

Re: [PATCH] crypto: sha-mb - Add avx2_supported check.

2015-01-05 Thread Herbert Xu
Cc: stable@vger.kernel.org # 3.18+ Signed-off-by: Vinson Lee v...@twitter.com Patch applied to crypto. -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send

Re: [PATCH] hwrng: pseries - port to new read API and fix stack corruption

2014-11-06 Thread Herbert Xu
...@linux.vnet.ibm.com Patch applied to crypto. Thanks, -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe stable in the body of a message

Re: [PATCH] crypto: caam: fix missing dma unmap on error path

2014-11-06 Thread Herbert Xu
: stable@vger.kernel.org # 3.13+ Signed-off-by: Cristian Stoica cristian.sto...@freescale.com Patch applied to crypto. Thanks, -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from

Re: [PATCH] crypto: properly label AF_ALG socket

2014-07-31 Thread Herbert Xu
/show_bug.cgi?id=1115120 This patch clones the sock's label from the parent sock and resolves the issue (similar to AF_BLUETOOTH protocol family). Cc: stable@vger.kernel.org Signed-off-by: Milan Broz gmazyl...@gmail.com Applied to crypto. Thanks. -- Email: Herbert Xu herb

Re: [PATCH v2 2/2] virtio: rng: ensure reads happen after successful probe

2014-07-10 Thread Herbert Xu
: Kees Cook keesc...@chromium.org CC: Jason Cooper ja...@lakedaemon.net CC: Herbert Xu herb...@gondor.apana.org.au CC: stable@vger.kernel.org # For v3.15+ Signed-off-by: Amit Shah amit.s...@redhat.com --- drivers/char/hw_random/core.c | 6 ++ drivers/char/hw_random/virtio

Re: [PATCH v3] crypto: caam - fix memleak in caam_jr module

2014-07-10 Thread Herbert Xu
On Mon, Jul 07, 2014 at 11:52:41AM +0300, Cristian Stoica wrote: This patch fixes a memory leak that appears when caam_jr module is unloaded. Cc: stable@vger.kernel.org # 3.13+ Signed-off-by: Cristian Stoica cristian.sto...@freescale.com Patch applied. -- Email: Herbert Xu herb

Re: [PATCH] s390/crypto: fix aes,des ctr mode concurrency finding.

2014-05-08 Thread Herbert Xu
struct. Signed-off-by: Harald Freudenberger fre...@linux.vnet.ibm.com Patch applied to crypto. Thanks! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send

Re: [PATCH crypto 2/2] crypto: caam - add allocation failure handling in SPRINTFCAT macro

2014-04-28 Thread Herbert Xu
...@freescale.com Patch applied to the crypto tree. Thanks. -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe stable in the body of a message

Re: [PATCH crypto 1/2] crypto: caam - fix mem leak in ahash_setkey

2014-04-28 Thread Herbert Xu
crypto_ahash *ahash, DMA_TO_DEVICE); } +map_err: kfree(hashed_key); Reviewed-by: Marek Vasut ma...@denx.de Patch applied to cryptodev. I'm not pushing this to stable because it doesn't satisfy the conditions for it. Thanks, -- Email: Herbert Xu

Re: [PATCH crypto 2/2] crypto: caam - add allocation failure handling in SPRINTFCAT macro

2014-04-28 Thread Herbert Xu
On Mon, Apr 28, 2014 at 09:28:41PM +0200, Marek Vasut wrote: On Monday, April 28, 2014 at 12:24:41 PM, Herbert Xu wrote: On Fri, Apr 18, 2014 at 01:01:42PM +0300, Horia Geanta wrote: GFP_ATOMIC memory allocation could fail. In this case, avoid NULL pointer dereference and notify user

Re: [PATCH 1/4] crypto: ccm - Fix handling of zero plaintext when computing mac

2013-11-28 Thread Herbert Xu
and destination buffers (or else scatterlist length = max(plaintext_len, ciphertext_len)). All four patches applied. Thanks! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from

Re: [PATCH] crypto: caam - fix inconsistent assoc dma mapping direction

2013-05-13 Thread Herbert Xu
...@freescale.com Applied to crypto. Thanks! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe stable in the body of a message to majord

Re: [PATCH] Revert crypto: talitos - add IPsec ESN support

2013-03-21 Thread Herbert Xu
@ultra-3eti.com Signed-off-by: Horia Geanta horia.gea...@freescale.com --- Reviewed-by: Kim Phillips kim.phill...@freescale.com Both patches applied to crypto. Thanks! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: [PATCH] [v2] crypto: cryptd - disable softirqs in cryptd_queue_worker to prevent data corruption

2012-10-24 Thread Herbert Xu
Signed-off-by: Jussi Kivilinna jussi.kivili...@mbnet.fi Patch applied to crypto. Thanks! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line

Re: [PATCH] hw_random: atmel-rng: fix data valid check

2012-06-11 Thread Herbert Xu
it will not apply anymore? Oops, I'll fix this up. Thanks! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe stable in the body

Re: [PATCH] hw_random: atmel-rng: fix race condition leading to repeated bits

2012-05-31 Thread Herbert Xu
time atmel_trng_read() gets called, if that happens before the following data word is ready. Patch applied crypto. Thanks! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from