Re: [Intel-gfx] [PATCH v5] drm/i915: Pin the ifbdev for the info->system_base GGTT mmapping

.kernel.org >> > >> > This seems to have fixed my garbled text+fbcon dead after >> > suspend/hibernate issues. Well, only had the patch in for a day or so, >> > but so far so good. >> > >> > Tested-by: Ville Syrjälä >> > >> > Takas

Re: [PATCH v2] drm/i915: Unbreak check_digital_port_conflicts()

ng_connector_state(state, connector); > + if (!connector_state) > + connector_state = connector->state; > + > if (!connector_state->best_encoder) > continue; -- Jani Nikula, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Intel-gfx] [PATCH v2] drm/i915: Do a better job at disabling primary plane in the noatomic case.

static void intel_crtc_disable_noatomic(struct >> drm_crtc *crtc) >> WARN_ON(intel_crtc->unpin_work); >> >> intel_pre_disable_primary(crtc); >> + >> +intel_crtc_disable_planes(crtc, 1 << >> drm_plane_in

Re: [Intel-gfx] [PATCH] drm/i915: Unbreak check_digital_port_conflicts()

drm_for_each_connector(connector, dev) { >> +struct drm_connector_state *connector_state; >> +struct intel_encoder *encoder; >> + >> +connector_state = >> drm_atomic_get_existing_connector_state(state, connector); >> + if (!connec

Re: [Intel-gfx] [PATCH v2] drm/i915: Do a better job at disabling primary plane in the noatomic case.

On Wed, 09 Dec 2015, Tomas M wrote: > Hello, > > Is there any special reason this has not been merged yet? No special reason. There's just the ordinary reason there is no review on the patch yet. BR, Jani. > > Regards > > Tomas > > On Tue, Dec 1, 2015

Re: [PATCH] drm: Fix an unwanted master inheritance v2

On Thu, 03 Dec 2015, Thomas Hellstrom wrote: > Hi, > > On 12/03/2015 12:12 PM, Jani Nikula wrote: >> On Wed, 02 Dec 2015, Thomas Hellstrom wrote: >>> A client calling drmSetMaster() using a file descriptor that was opened >>> when another client was master

Re: [PATCH] drm: Fix an unwanted master inheritance v2

lanes:1; > /* true if client understands atomic properties */ > unsigned atomic:1; > + /* > + * This client is allowed to gain master privileges for @master. > + * Protected by struct drm_device::master_mutex. > + */ > + unsigned allowed_master:1;

Re: [Intel-gfx] [PATCH v2] drm/i915: Do a better job at disabling primary plane in the noatomic case.

<< > drm_plane_index(crtc->primary)); > + to_intel_plane_state(crtc->primary->state)->visible = false; > } > > - intel_crtc_disable_planes(crtc, crtc->state->plane_mask); > dev_priv->display.crtc_disable(crtc); > intel_crtc->active = false

Re: [Intel-gfx] [PATCH] drm/i915: Check the timeout passed to i915_wait_request

n to finding a > regression. The impact is 1 jiffie for each extra active ring for a > wait_ioctl with a timeout -- I don't think anyone has noticed. Pushed to drm-intel-fixes with some random copy-paste added about the 1 jiffy. Thanks for the patch and review. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Intel-gfx] [PATCH v4] drm/i915: Pin the ifbdev for the info->system_base GGTT mmapping

* BIOS is suitable for own access. >>224*/ >> > 225 ret = intel_pin_and_fence_fb_obj(NULL, >> ifbdev->fb->base, NULL); >>226 if (ret) >>227 goto out_unlock; >>228 &g

Re: [Intel-gfx] [PATCH v2] drm/i915: Mark uneven memory banks on gen4 desktop as unknown swizzling

; path for the existing uneven bank detection for mobile gen4. >> >> Reported-by: Matti Hämäläinen >> Tested--by: Matti Hämäläinen >> References: https://bugs.freedesktop.org/show_bug.cgi?id=90725 >> Signed-off-by: Chris Wilson >> Cc: Matti Hämäläinen

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Don't clobber the addfb2 ioctl params

; END > Subtest framebuffer-vs-set-tiling: FAIL (0.003s) > ... > > # ./tests/kms_addfb_basic --r framebuffer-vs-set-tiling > IGT-Version: 1.12-git (x86_64) (Linux: 4.4.0-rc1-stereo+ x86_64) > Subtest framebuffer-vs-set-tiling: SUCCESS (0.000s) > >>

Re: [PATCH 1/4] drm: Fix primary plane size for stereo doubled modes for legacy setcrtc

rc_h = set->mode->hdisplay << 16; >> -primary_state->src_w = set->mode->vdisplay << 16; >> +primary_state->src_h = hdisplay << 16; >> +primary_state->src_w = vdisplay << 16; >> } else { >>

Re: [Intel-gfx] [PATCH] drm/i915: quirk backlight present on Macbook 4, 1

On Mon, 09 Nov 2015, Ander Conselvan De Oliveira wrote: > Reviewed-by: Ander Conselvan de Oliveira Pushed to drm-intel-fixes, thanks for the review. BR, Jani. > > On Thu, 2015-11-05 at 11:49 +0200, Jani Nikula wrote: >> Unsurprisingly macbooks have backlights, just the VBT

Re: [Intel-gfx] [PATCH] drm: Use userspace compatible type in fourcc_mod_code macro

;> 0x00ffULL)) >> >> /* >> * Format Modifier tokens: >> -- >> 2.5.1 >> >> ___ >> Intel-gfx mailing list >> intel-...@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] drm/i915: quirk backlight present on Macbook 4,1

ot;) Cc: stable@vger.kernel.org # v3.15+ Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 7b3cfb64e7f6..b067147183e9 100644 --- a/drive

Re: [Intel-gfx] [PATCH 09/11] drm/i915/skl: Prevent unclaimed register writes on skylake.

On Fri, 23 Oct 2015, Jani Nikula wrote: > On Thu, 22 Oct 2015, Daniel Vetter wrote: >> On Thu, Oct 22, 2015 at 01:56:34PM +0200, Maarten Lankhorst wrote: >>> I'm getting unclaimed register writes when checking the WM registers >>> after the crtc is disabled. So I

Re: [Intel-gfx] [PATCH 09/11] drm/i915/skl: Prevent unclaimed register writes on skylake.

r_is_enabled(dev_priv, >> POWER_DOMAIN_PIPE(pipe))) >> +continue; >> + >> for_each_plane(dev_priv, pipe, plane) { >> val = I915_READ(PLANE_BUF_CFG(pipe, plane)); >> skl_ddb_entry_init_from_hw(&am

Re: [Intel-gfx] [PATCH 4.1, 4.2] drm/i915: Silence DDR DVFS errors on CHV

t;> -- >> 2.4.6 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe stable" in >> the body of a message to majord...@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > ___

Re: [Intel-gfx] [PATCH] drm/i915: Deny wrapping an userptr into a framebuffer

ixes, thanks for the patch and review. BR, Jani. > > Regards, > > Tvrtko > ___ > Intel-gfx mailing list > intel-...@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Tec

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Restore lost DPLL register write on gen2-4

On Tue, 13 Oct 2015, Daniel Vetter wrote: > On Tue, Oct 13, 2015 at 04:10:19PM +0300, Jani Nikula wrote: >> On Thu, 08 Oct 2015, Ville Syrjälä wrote: >> > On Thu, Oct 08, 2015 at 10:17:30AM +0200, Daniel Vetter wrote: >> >> On Wed, Oct 07, 2015 at 10:08:24PM +0300,

Re: [Intel-gfx] [PATCH] drm/i915: Flush pipecontrol post-sync writes

On Tue, 13 Oct 2015, Daniel Vetter wrote: > On Tue, Oct 13, 2015 at 03:45:58PM +0300, Jani Nikula wrote: >> On Wed, 26 Aug 2015, Chris Wilson wrote: >> > On Wed, Aug 26, 2015 at 11:16:34AM +0200, Daniel Vetter wrote: >> >> On Fri, Aug 21, 2015 at 04:08:41PM +0100,

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Restore lost DPLL register write on gen2-4

abilize. */ >> >POSTING_READ(reg); >> >udelay(150); >> > -- >> > 2.4.9 >> > >> > ___ >> > Intel-gfx mailing list >> > intel-...@lists.freedesktop.org >> > http://lists.fr

Re: [Intel-gfx] [PATCH] drm/i915: Flush pipecontrol post-sync writes

Intel Open Source Technology Centre > _______ > Intel-gfx mailing list > intel-...@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Intel-gfx] [PATCH] drm/i915: Pin the ifbdev for the info->system_base GGTT mmapping

got the two patches reverted in the first place. Thanks, Jani. [1] http://mid.gmane.org/55df3886.1060...@virtuousgeek.org > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre > _______ > Intel-gfx mailing list > intel-...@lists.

Re: [PATCH] drm: Fix locking for sysfs dpms file

AGE_SIZE, "%s\n", > - drm_get_dpms_name((int)dpms_status)); > + drm_get_dpms_name(dpms)); > } > > static ssize_t enabled_show(struct device *device, > -- > 2.5.1 > > ___ > dri-de

Re: [Intel-gfx] [PATCH] drm/i915: Only disable visible planes in intel_crtc_disable_planes

e->disable_plane(&intel_plane->base, > -- > 2.1.0 > > ___ > Intel-gfx mailing list > intel-...@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] drm/i915: Limit the number of loops for reading a split 64bit register

Signed-off-by: Chris Wilson >> Cc: Michał Winiarski >> Cc: Daniel Vetter >> Cc: Jani Nikula >> Cc: stable@vger.kernel.org > > Still Reviewed-by: Daniel Vetter Pushed to drm-intel-next-fixes, thanks for the patch and review. BR, Jani. > >> --- >> d

Re: [Intel-gfx] [PATCH] drm/i915: Limit the number of loops for reading a split 64bit register

_____ > Intel-gfx mailing list > intel-...@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] drm/i915: Always mark the object as dirty when used by the GPU

domains; >> @@ -1039,7 +1040,6 @@ i915_gem_execbuffer_move_to_active(struct list_head >> *vmas, >> >> i915_vma_move_to_active(vma, req); >> if (obj->base.write_domain) { >> -obj->dirty = 1; >>

Re: [Intel-gfx] [PATCH] i915: Set ddi_pll_sel in DP MST path

+void hsw_dp_set_ddi_pll_sel(struct intel_crtc_state *pipe_config); >> >> /* intel_dp_mst.c */ >> int intel_dp_mst_encoder_init(struct intel_digital_port *intel_dig_port, >> int conn_id); >> -- >> 2.4.3 >> >> ___ >> Intel-gfx mailing list >> intel-...@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > -- > Ville Syrjälä > Intel OTC > ___ > Intel-gfx mailing list > intel-...@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Intel-gfx] [PATCH] drm/i915: Check DP link status on long hpd too

drm_modeset_unlock(&dev->mode_config.connection_mutex); > -- > 2.4.6 > > ___ > Intel-gfx mailing list > intel-...@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] drm/i915: apply the PCI_D0/D3 hibernation workaround everywhere on pre GEN6

vice properly. The issue was seen on multiple old >> + * GENs with different BIOS vendors, so having an explicit blacklist >> + * is inpractical; apply the workaround on everything pre GEN6. The >> + * platforms where the issue was seen: >> + * Lenovo Thinkpad X301, X61s, X

Re: [Intel-gfx] [PATCH] drm/i915: Set the map-and-fenceable flag for preallocated objects

On Thu, 27 Aug 2015, Chris Wilson wrote: > On Thu, Aug 27, 2015 at 09:19:18AM -0700, Jesse Barnes wrote: >> On 08/27/2015 01:36 AM, Jani Nikula wrote: >> > On Wed, 26 Aug 2015, Daniel Vetter wrote: >> >> On Wed, Aug 26, 2015 at 12:55:57PM +0100, Chris Wilso

Re: [Intel-gfx] [PATCH] drm/i915: Set the map-and-fenceable flag for preallocated objects

amp; !obj->map_and_fenceable); >> } >> >> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c >> b/drivers/gpu/drm/i915/i915_gem_gtt.c >> index 4a76807143b1..112d84c32257 100644 >> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c >> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c

Re: [Intel-gfx] [PATCH] drm/i915: Check DP link status on long hpd too

normal hot plug > path later - > - * but for short hpds we should check it now > - */ > drm_modeset_lock(&dev->mode_config.connection_mutex, > NULL); > intel_dp_check_link_status(intel_dp); > drm_modeset_un

Re: [Intel-gfx] [PATCH] drm/i915: Flag the execlists context object as dirty after every use

l-gfx > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch > ___ > Intel-gfx mailing list > intel-...@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] drm/i915: calculate primary visibility changes instead of calling from set_config

On Tue, 11 Aug 2015, Maarten Lankhorst wrote: > This should be much cleaner, with the same effects. > > (cherry picked from commit fb9d6cf8c29bfcb0b3c602f7ded87f128d730382) > Signed-off-by: Maarten Lankhorst > Reviewed-by: Matt Roper > Signed-off-by: Jani Nikula > Cc: s

Re: [Intel-gfx] [PATCH] drm/dp/mst: Remove port after removing connector.

rm_dp_mst_put_payload_id(mgr, port->vcpi.vcpi); >> +kfree(port); >> } >> } >> >> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h >> index 574656965126..373b1bc6de96 100644 >> --- a/include/drm/drm_crtc.h >> +++ b/incl

Re: [PATCH] drm/i915: apply the PCI_D0/D3 hibernation workaround everywhere on pre GEN6

s going to >> > D3 has no real benefits. >> >> Sure it does. Eventually we'll want to avoid resuming runtime suspended >> devices when entering system suspend. For broken machines we'd need to >> resume the GPU at that point. > > You want to optimize transition

Re: [PATCH] drm/i915: apply the PCI_D0/D3 hibernation workaround everywhere on pre GEN6

ng reboot BR, Jani. > >> + * Lenovo Thinkpad X301, X61s, X60, T60, X41 >> + * Fujitsu FSC S7110 >> + * Acer Aspire 1830T > > What makes you think that BIOS writers will do something different for > Gen6+ hardware? X301 is not that old. >

Re: [Intel-gfx] [PATCH] drm/i915: Declare the swizzling unknown for L-shaped configurations

BR, Jani. > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre > ___ > Intel-gfx mailing list > intel-...@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3] drm/i915: fix backlight after resume on 855gm

On Fri, 26 Jun 2015, Jani Nikula wrote: > Some 855gm models (at least ThinkPad X40) regressed because of > > commit b0cd324faed23d10d66ba6ade66579c681feef6f > Author: Jani Nikula > Date: Wed Nov 12 16:25:43 2014 +0200 > > drm/i915: don't save/restore backlight hi

Re: [PATCH] agp/intel: Fix typo in needs_ilk_vtd_wa()

| >> gpu_devid == PCI_DEVICE_ID_INTEL_IRONLAKE_M_IG) && >> intel_iommu_gfx_mapped) >> return 1; >> -- >> 2.1.4 >> > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch -- Jani Nikula, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v3] drm/i915: fix backlight after resume on 855gm

Some 855gm models (at least ThinkPad X40) regressed because of commit b0cd324faed23d10d66ba6ade66579c681feef6f Author: Jani Nikula Date: Wed Nov 12 16:25:43 2014 +0200 drm/i915: don't save/restore backlight hist ctl registers which tried to make our driver more robust by not bl

[PATCH] drm/i915: fix backlight after resume on 855gm

Some 855gm models (at least ThinkPad X40) regressed because of commit b0cd324faed23d10d66ba6ade66579c681feef6f Author: Jani Nikula Date: Wed Nov 12 16:25:43 2014 +0200 drm/i915: don't save/restore backlight hist ctl registers which tried to make our driver more robust by not bl

Re: [PATCH 4.0 077/105] drm/i915: Dont skip request retirement if the active list is empty

On Thu, 25 Jun 2015, Greg Kroah-Hartman wrote: > On Thu, Jun 25, 2015 at 10:34:37AM +0300, Jani Nikula wrote: >> On Wed, 24 Jun 2015, Greg Kroah-Hartman wrote: >> > On Tue, Jun 23, 2015 at 10:29:13AM +0300, Jani Nikula wrote: >> >> On Fri, 19 Jun 2015, Gr

Re: [PATCH 4.0 077/105] drm/i915: Dont skip request retirement if the active list is empty

On Wed, 24 Jun 2015, Greg Kroah-Hartman wrote: > On Tue, Jun 23, 2015 at 10:29:13AM +0300, Jani Nikula wrote: >> On Fri, 19 Jun 2015, Greg Kroah-Hartman wrote: >> > 4.0-stable review patch. If anyone has any objections, please let me know. >> >> The commit to be

Re: [Intel-gfx] [PATCH] drm/i915: Officially give up on seqno coherency

else > DRM_INFO("Fake missed > irq on %s\n", > ring->name); > -- > 2.1.4 > > ___

Re: Patch "Revert "drm/i915: Don't skip request retirement if the active list is empty"" has been added to the 4.0-stable tree

> If you, or anyone else, feels it should not be added to the stable tree, > please let know about it. http://mid.gmane.org/87h9py288m@intel.com BR, Jani. > > > From 245ec9d85696c3e539b23e210f248698b478379c Mon Sep 17 00:00:00 2001 > From: Jani Nikula > Date: Mon, 15 Ju

Re: [PATCH 4.0 077/105] drm/i915: Dont skip request retirement if the active list is empty

of these: commit 0aedb1626566efd72b369c01992ee7413c82a0c5 Author: Ville Syrjälä Date: Thu May 28 18:32:36 2015 +0300 drm/i915: Don't skip request retirement if the active list is empty commit 245ec9d85696c3e539b23e210f248698b478379c Author: Jani Nikula Date: Mon Jun 15 12:59:37 20

Re: [PATCH] drm/i915: Avoid GPU hang when coming out of s3 or s4

iewed-by: Daniel Vetter > [Jani: fixed typo in subject, massaged the comments a bit] > Signed-off-by: Jani Nikula Acked-by: Jani Nikula ...although based on the patch context I'm not sure why this needs a separate backport. Does it not cherry-pick cleanly to 4.0? The stable team shou

Re: [PATCH] Revert "drm/i915: Don't skip request retirement if the active list is empty"

On Mon, 15 Jun 2015, Ville Syrjälä wrote: > On Mon, Jun 15, 2015 at 12:59:37PM +0300, Jani Nikula wrote: >> This reverts commit 0aedb1626566efd72b369c01992ee7413c82a0c5. >> >> I messed things up while applying [1] to drm-intel-fixes. Rectify. >> >> [1]  >>

[PATCH] Revert "drm/i915: Don't skip request retirement if the active list is empty"

the active list is empty") Cc: stable@vger.kernel.org Signed-off-by: Jani Nikula --- Note to stable team: please do *not* backport commit 0aedb1626566efd72b369c01992ee7413c82a0c5 Author: Ville Syrjälä Date: Thu May 28 18:32:36 2015 +0300 drm/i915: Don't skip request retirement i

Re: [Intel-gfx] [PATCH] drm/i915: Always reset vma->ggtt_view.pages cache on unbinding

and disassociated with the backing store. Kind of a cached > memory object. And then re-using it needs to clear the cached pages > pointer which is fixed above. Pushed to drm-intel-fixes with the above text added to commit message. Thanks for the patch and review. BR, Jani. > > Regard

Re: [PATCH v5] drm/i915: Fix DDC probe for passive adapters

On Tue, 02 Jun 2015, Ville Syrjälä wrote: > On Tue, Jun 02, 2015 at 07:21:15PM +0300, Jani Nikula wrote: >> Passive DP->DVI/HDMI dongles on DP++ ports show up to the system as HDMI >> devices, as they do not have a sink device in them to respond to any AUX >> traffic. Wh

Re: FAILED: patch "[PATCH] drm/i915: Avoid GPU hang when coming out of s3 or s4" failed to apply to 4.0-stable tree

setting up the context) > to complete before the interrupts have been turned on, thus hanging the > GPU. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89600 > Cc: stable@vger.kernel.org # 4.0+ > Signed-off-by: Peter Antoine > Reviewed-by: Daniel Vetter >

Re: [PATCH v5] drm/i915: Fix DDC probe for passive adapters

On Tue, 02 Jun 2015, Ville Syrjälä wrote: > On Tue, Jun 02, 2015 at 07:21:15PM +0300, Jani Nikula wrote: >> Passive DP->DVI/HDMI dongles on DP++ ports show up to the system as HDMI >> devices, as they do not have a sink device in them to respond to any AUX >> traffic. Wh

[PATCH v5] drm/i915: Fix DDC probe for passive adapters

v3: Move retry within gmbux_xfer, retry only on first message. v4: Initialize GMBUS0 on retry (Ville). v5: Take index reads into account (Ville). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=85924 Cc: Todd Previte Cc: stable@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/gpu/dr

[PATCH v4] drm/i915: Fix DDC probe for passive adapters

v3: Move retry within gmbux_xfer, retry only on first message. v4: Initialize GMBUS0 on retry (Ville). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=85924 Cc: Todd Previte Cc: stable@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_i2c.c | 17 ++

[PATCH v3] drm/i915: Fix DDC probe for passive adapters

v3: Move retry within gmbux_xfer, retry only on first message. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=85924 Cc: Todd Previte Cc: stable@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_i2c.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix DDC probe for passive adapters

On Thu, 28 May 2015, Daniel Vetter wrote: > On Thu, May 28, 2015 at 02:36:01PM +0300, Jani Nikula wrote: >> On Thu, 28 May 2015, Ville Syrjälä wrote: >> > On Thu, May 28, 2015 at 01:05:39PM +0300, Jani Nikula wrote: >> >> Passive DP->DVI/HDMI dongles on DP++ po

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix DDC probe for passive adapters

On Thu, 28 May 2015, Ville Syrjälä wrote: > On Thu, May 28, 2015 at 01:05:39PM +0300, Jani Nikula wrote: >> Passive DP->DVI/HDMI dongles on DP++ ports show up to the system as HDMI >> devices, as they do not have a sink device in them to respond to any AUX >> traffic. Wh

[PATCH v2] drm/i915: Fix DDC probe for passive adapters

://bugs.freedesktop.org/show_bug.cgi?id=85924 Cc: Todd Previte Cc: stable@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_i2c.c | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_i2c.c b/drivers/gpu/drm

[PATCH] drm/i915: Fix DDC probe for passive adapters

: Todd Previte Cc: stable@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_i2c.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_i2c.c b/drivers/gpu/drm/i915/intel_i2c.c index 92072f56e418..e58f39e

Re: [PATCH v2] drm: Only create a cmdline mode if no probed modes match

ode(connector); > if (count == 0 && connector->status == connector_status_connected) > count = drm_add_modes_noedid(connector, 1024, 768); > - count += drm_helper_probe_add_cmdline_mode(connector); Shouldn't this hunk be a separate patch? BR, Jani. > if (count == 0) > goto prune; > > -- > 2.1.4 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Intel-gfx] [PATCH] drm/plane-helper: Adapt cursor hack to transitional helpers

g hardware > overlays on Intel, as expected. > > So hardware cursors should be fine again, once the patch also ends in > stable kernels. Pushed to our topic/drm-fixes, thanks for the patch and review. BR, Jani. > > thanks, > -mario > _

Re: [PATCH] drm/i915: Fix ilk watermarks calculation when primary plane is disabled

On Thu, 21 May 2015, Josh Boyer wrote: > On Thu, May 21, 2015 at 3:21 AM, Ander Conselvan De Oliveira > wrote: >> On Wed, 2015-05-20 at 16:53 +0300, Jani Nikula wrote: >>> On Wed, 20 May 2015, Ander Conselvan de Oliveira >>> wrote: >>> > On Fedor

Re: [PATCH 3.12 071/142] drm/i915: cope with large i2c transfers

ot; which tries to consume multiple >> touchscreen/touchpad reports in a single transaction). >> >> Reviewed-by: Chris Wilson >> Signed-off-by: Dmitry Torokhov >> Signed-off-by: Jani Nikula >> Signed-off-by: Jiri Slaby >> --- >> drivers/gpu/drm/i915

Re: [Intel-gfx] Kernel panic every other reboot/poweroff since 3.19.3 ( commit 9a6f5130143 )

own. The only change > between the two kernels was the above patch. Stable team, please ensure 8218c3f4df3bb1c637c17552405039a6dd3c1ee1, already tagged cc: stable, is picked up for v3.19.4. This is also reported as Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=95621 Thanks, Jani.

Re: [Intel-gfx] [PATCH] drm/edid: set ELD for firmware and debugfs override EDIDs

On Fri, 27 Mar 2015, Alex Deucher wrote: > On Fri, Mar 27, 2015 at 8:08 AM, Jani Nikula wrote: >> On Thu, 26 Mar 2015, Daniel Vetter wrote: >>> On Thu, Mar 26, 2015 at 10:42:00AM +0200, Jani Nikula wrote: >>>> If the user supplies EDID through firmware or deb

Re: [Intel-gfx] [PATCH] drm/edid: set ELD for firmware and debugfs override EDIDs

On Thu, 26 Mar 2015, Daniel Vetter wrote: > On Thu, Mar 26, 2015 at 10:42:00AM +0200, Jani Nikula wrote: >> If the user supplies EDID through firmware or debugfs override, the >> driver callbacks are bypassed and the connector ELD does not get >> updated, and audio fails. Set

[PATCH] drm/edid: set ELD for firmware and debugfs override EDIDs

still up to the driver to use the ELD, if any. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82349 Reference: https://bugs.freedesktop.org/show_bug.cgi?id=80691 Reported-by: Emil Reported-by: Rob Engle Tested-by: Jolan Luff Cc: stable@vger.kernel.org Signed-off-by: Jani Nikula --- dr

Re: FAILED: patch "[PATCH] drm/i915: gen4: work around hang during hibernation" failed to apply to 3.19-stable tree

lem is that the fix depends on commit 888d0d421663 ("drm/i915: > add dev_to_i915 helper"). I've now verified that 3.19-stable builds > with both patches applied. > > But it's of course up to Imre/Daniel/Jani how this should be handled. I'm fine with either pickin

Re: [PATCH] drm/i915: Make WAIT_IOCTL negative timeouts be indefinite again

igt for this too? I think an wait while the buffer should >> > > be busy with a negative timeout is all that's needed to exercise this. >> > >> > Done. >> > Testcase: igt/gem_wait >> >> Thanks a lot. >> >> Reviewed-by: Daniel V

stable 3.19 backport request

ely also References: http://mid.gmane.org/20150131211609.GA3710@yulia-desktop References: http://mid.gmane.org/CA+55aFwCf+94-5E+axJNu3GdCTF=1tkda9d6gfm4sdovfnn...@mail.gmail.com BR, Jani. -- Jani Nikula, Intel Open Source Technology Center -- To unsubscribe from this list: send the l

Re: [Intel-gfx] [PATCH] drm/i915: Check for driver readyness before handling an underrun interrupt

On Fri, 27 Feb 2015, Chris Wilson wrote: > On Fri, Feb 27, 2015 at 10:20:05AM +0200, Jani Nikula wrote: >> On Fri, 27 Feb 2015, Jani Nikula wrote: >> > On Thu, 26 Feb 2015, Chris Wilson wrote: >> >> When we takeover from the BIOS and install our interrupt handler

Re: [Intel-gfx] [PATCH] drm/i915: Check for driver readyness before handling an underrun interrupt

On Fri, 27 Feb 2015, Jani Nikula wrote: > On Thu, 26 Feb 2015, Chris Wilson wrote: >> When we takeover from the BIOS and install our interrupt handler, the >> BIOS may have left us a few surprises in the form of spontaneous >> interrupts. (This is especially likely on hard

Re: [Intel-gfx] [PATCH] drm/i915: Check for driver readyness before handling an underrun interrupt

SPLAY(dev_priv->dev) && > - !__cpu_fifo_underrun_reporting_enabled(dev_priv, pipe)) > + !to_intel_crtc(crtc)->cpu_fifo_underrun_disabled) > return; > > if (intel_set_cpu_fifo_underrun_reporting(dev_priv, pipe, false)) > -- > 2.1.4 > > __

Re: [PATCH] drm/i915: Align initial plane backing objects correctly

On Mon, 16 Feb 2015, Jani Nikula wrote: > On Wed, 11 Feb 2015, Daniel Vetter wrote: >> Some bios really like to joke and start the planes at an offset ... >> hooray! >> >> Align start and end to fix this. >> >> v2: Fixup calculation of size, spotted by Chr

Re: [PATCH] drm/i915: Do not invalidate obj->pages under mempressure

On Tue, 10 Feb 2015, Jani Nikula wrote: > On Mon, 09 Feb 2015, Daniel Vetter wrote: >> From: Chris Wilson >> >> This (partially) reverts >> >> commit 5537252b6b6d71fb1a8ed7395a8e5babf91953fd >> Author: Chris Wilson >> Date: Tue Mar 25 13:23:06

Re: [Intel-gfx] [PATCH] drm/i915: Dell Chromebook 11 has PWM backlight

On Thu, 19 Feb 2015, Jani Nikula wrote: > On Thu, 19 Feb 2015, Jani Nikula wrote: >> Add quirk for Dell Chromebook 11 backlight. > > Also > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=93451 > >> Tested-by: Owen Garland >> Cc: stable@vger.kern

Re: [Intel-gfx] [PATCH] drm/i915: Dell Chromebook 11 has PWM backlight

On Thu, 19 Feb 2015, Jani Nikula wrote: > Add quirk for Dell Chromebook 11 backlight. Also Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=93451 > Tested-by: Owen Garland > Cc: stable@vger.kernel.org > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/i

[PATCH] drm/i915: Dell Chromebook 11 has PWM backlight

Add quirk for Dell Chromebook 11 backlight. Tested-by: Owen Garland Cc: stable@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c

Re: [PATCH] drm/i915: vlv: fix IRQ masking when uninstalling interrupts

n upstream and older kernels. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=85920 > Cc: stable@vger.kernel.org (v3.15+) > Signed-off-by: Imre Deak > Reviewed-by: Ville Syrjälä > Signed-off-by: Jani Nikula > (backported to v3.18.7 from commit c352d1ba1e1e2c8a96a

Re: [PATCH] drm/i915: Align initial plane backing objects correctly

spotted. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=86883 > Cc: stable@vger.kernel.org > Cc: Johannes W > Cc: Chris Wilson > Cc: Jani Nikula > Reported-by: Johannes W > Signed-off-by: Daniel Vetter Tested-by: Johannes W > > -- > > Johannes, can you p

Re: [Intel-gfx] [PATCH] drm/i915: Quietly reject attempts to create non-pagealigned stolen objects

rom the bug, the original patch gets Tested-by: Johannes W > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre -- Jani Nikula, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: FAILED: patch "[PATCH] drm/i915: vlv: fix IRQ masking when uninstalling interrupts" failed to apply to 3.18-stable tree

d get rid of the > problem reported there in upstream and older kernels. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=85920 > Cc: stable@vger.kernel.org (v3.15+) > Signed-off-by: Imre Deak > Reviewed-by: Ville Syrjälä > Signed-off-by: Jani Nikula > > diff --

Re: [PATCH] drm/i915: Do not invalidate obj->pages under mempressure

->f_count) == 1; > -} > - > void i915_gem_free_object(struct drm_gem_object *gem_obj) > { > struct drm_i915_gem_object *obj = to_intel_bo(gem_obj); > @@ -4524,8 +4481,6 @@ void i915_gem_free_object(struct drm_gem_object > *gem_obj) > > if (WARN_ON(obj->pa

Re: [Intel-gfx] [PATCH v2] drm/i915: Insert a command barrier on BLT/BSD cache flushes

On Mon, 09 Feb 2015, Chris Wilson wrote: > On Mon, Feb 09, 2015 at 06:00:25PM +0200, Jani Nikula wrote: >> On Thu, 22 Jan 2015, Chris Wilson wrote: >> > This looked like an odd regression from >> > >> > commit ec5cc0f9b019af95e4571a9fa162d94294c8d90b >>

Re: [Intel-gfx] [PATCH v2] drm/i915: Insert a command barrier on BLT/BSD cache flushes

1h or 3h." >*/ > if (invalidate & I915_GEM_DOMAIN_RENDER) > - cmd |= MI_INVALIDATE_TLB | MI_FLUSH_DW_STORE_INDEX | > - MI_FLUSH_DW_OP_STOREDW; > + cmd |= MI_INVALIDATE_TLB; > intel_ring_emit(ring, cmd); > intel_ring_emit(ring, I915_GEM_HWS_SCRATC

Re: FAILED: patch "[PATCH] drm/i915: Fix and clean BDW PCH identification" failed to apply to 3.18-stable tree

there we are receiveing logs with this incorrect > WARN. > And also according to local tests on all production BDW here ULT or HALO we > don't > need this force anymore. So let's clean this block for real. > > v2: Fix LPT_LP WARNs to avoid wrong warns on BDW_ULT (By

Re: [PATCH] drm/i915: BDW Fix Halo PCI IDs marked as ULT.

ug.cgi?id=87220 > Cc: Xion Zhang > Cc: Guo Jinxian > Cc: Jani Nikula > Cc: Stable > Signed-off-by: Rodrigo Vivi Pushed to drm-intel-fixes, thanks for the patch. BR, Jani. > --- > drivers/gpu/drm/i915/i915_drv.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-)

Re: [Intel-gfx] [PATCH] drm/i915: Quietly reject attempts to create non-pagealigned stolen objects

>> return NULL; >> -- >> 2.1.3 >> >> ___ >> Intel-gfx mailing list >> intel-...@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > -- > Daniel Vetter > So

[PATCH v3.18] drm/i915: Kill check_power_well() calls

lla: https://bugs.freedesktop.org/show_bug.cgi?id=86201 Tested-by: Wendy Wang Signed-off-by: Ville Syrjälä [Jani: s/intel_runtime_pm.c/intel_pm.c/g and wiggle for 3.18] Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_pm.c | 27 --- 1 file changed, 27 deletions(-) diff --git

Re: FAILED: patch "[PATCH] Revert "drm/i915: Preserve VGACNTR bits from the BIOS"" failed to apply to 3.18-stable tree

On Mon, 19 Jan 2015, Bruno Prémont wrote: > Hi Greg, stable team, > > Please find below the back-ported patch (only a little bit of fuzz and > changed offsets to handle). > Patch applies cleanly on top of v3.18.3. Thanks Bruno, FWIW this is Acked-by: Jani Nikula >

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Make hpd arrays big enough to avoid out of bounds access

change the sizes of the arrays. > Cc: stable@vger.kernel.org I'm not sure if that's appropriate in light of the above ("It must fix a real bug that bothers people"). But we should do this *before* it becomes a bug. Reviewed-by: Jani Nikula > Signed-off-

Re: [Intel-gfx] [PATCH] drm/i915: Fix mutex->owner inspection race under DEBUG_MUTEXES

On Wed, 07 Jan 2015, Chris Wilson wrote: > On Wed, Jan 07, 2015 at 02:12:14PM +0200, Jani Nikula wrote: >> On Mon, 05 Jan 2015, Daniel Vetter wrote: >> > On Fri, Jan 02, 2015 at 09:47:10AM +, Chris Wilson wrote: >> >> If CONFIG_DEBUG_MUTEXES is set, the mute

Re: [Intel-gfx] [PATCH] drm/i915: Fix mutex->owner inspection race under DEBUG_MUTEXES

;> /* Since UP may be pre-empted, we cannot assume that we own the lock */ >> -- >> 2.1.4 >> >> ___ >> Intel-gfx mailing list >> intel-...@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- Jani Nikula, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Intel-gfx] [PATCH] drm/i915: Unlock panel even when LVDS is disabled

s_connector->lid_notifier.notifier_call = intel_lid_notify; > if (acpi_lid_notifier_register(&lvds_connector->lid_notifier)) { > DRM_DEBUG_KMS("lid notifier registration failed\n"); > -- > 2.1.1 > > ___ > Intel-gfx mailing list > intel-.

  1   2   >