[PATCH] spi: fix parent-device reference leak

2015-12-14 Thread Johan Hovold
t;spi doesn't need class_device") Cc: stable # v2.6.24 Signed-off-by: Johan Hovold --- drivers/spi/spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 2b0a8ec3affb..dee1cb87d24f 100644 --- a/drivers/spi/spi.c +++ b/dr

Re: [PATCH v2] USB: qcserial: Fix support for HP lt4112 LTE/HSPA+ Gobi 4G Modem

2015-11-16 Thread Johan Hovold
On Mon, Nov 16, 2015 at 01:15:46PM +0100, Bjørn Mork wrote: > The DEVICE_HWI type was added under the faulty assumption that Huawei > devices based on Qualcomm chipsets and firmware use the static USB > interface numbering known from Gobi devices. But this model does > not apply to Huawei devices

Re: [PATCH] USB: qcserial: Fix support for HP lt4112 LTE/HSPA+ Gobi 4G Modem

2015-11-16 Thread Johan Hovold
On Sun, Nov 01, 2015 at 01:13:41AM +0100, Bjørn Mork wrote: > The DEVICE_HWI type was added under the faulty assumption that Huawei > devices based on Qualcomm chipsets and firmware use the static USB > interface numbering known from Gobi devices. But this model does > not apply to Huawei devices

Re: [PATCH] USB: qcserial: add Sierra Wireless MC74xx/EM74xx

2015-10-22 Thread Johan Hovold
On Thu, Oct 22, 2015 at 02:24:24PM +0200, Bjørn Mork wrote: > New device IDs shamelessly lifted from the vendor driver. > > Cc: > Signed-off-by: Bjørn Mork Acked-by: Johan Hovold Greg, can you pick this one directly for 4.4-rc1? Applies cleanly on top of my latest pull-requ

[PATCH] USB: whiteheat: fix potential null-deref at probe

2015-09-23 Thread Johan Hovold
fewer bulk endpoints would currently lead to an oops. Fixes CVE-2015-5257. Reported-by: Moein Ghasemzadeh Cc: stable Signed-off-by: Johan Hovold --- Greg, Could you take this one directly for 4.3-rc3? Thanks, Johan drivers/usb/serial/whiteheat.c | 31 +++ 1 file c

[PATCH 2/2] USB: qcserial: add HP lt4111 LTE/EV-DO/HSPA+ Gobi 4G Module

2015-08-18 Thread Johan Hovold
From: David Ward This is an HP-branded Sierra Wireless EM7355: https://bugzilla.redhat.com/show_bug.cgi?id=1223646#c2 Signed-off-by: David Ward Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/serial/qcserial.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/serial

[PATCH 1/2] USB: ftdi_sio: Added custom PID for CustomWare products

2015-08-18 Thread Johan Hovold
From: Matthijs Kooijman CustomWare uses the FTDI VID with custom PIDs for their ShipModul MiniPlex products. Signed-off-by: Matthijs Kooijman Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/serial/ftdi_sio.c | 4 drivers/usb/serial/ftdi_sio_ids.h | 8 2 files

Re: [PATCH 3.14 36/44] ARM: dts: am335x-boneblack: disable RTC-only sleep to avoid hardware damage

2015-06-22 Thread Johan Hovold
[ Responding to the review request with lkml on CC as well. ] On Fri, Jun 19, 2015 at 01:36:35PM -0700, Greg Kroah-Hartman wrote: > 3.14-stable review patch. If anyone has any objections, please let me know. This one can be dropped from 3.14-stable as it is only needed in 3.19 and later kernels

Re: Patch "ARM: dts: am335x-boneblack: disable RTC-only sleep to avoid hardware damage" has been added to the 3.14-stable tree

2015-06-22 Thread Johan Hovold
On Fri, Jun 19, 2015 at 12:43:27PM -0700, Greg Kroah-Hartman wrote: > > This is a note to let you know that I've just added the patch titled > > ARM: dts: am335x-boneblack: disable RTC-only sleep to avoid hardware > damage > > to the 3.14-stable tree which can be found at: > > http://w

Re: [PATCH] USB: serial: ftdi_sio: Add support for a Motion Tracker Development Board

2015-05-21 Thread Johan Hovold
On Tue, May 19, 2015 at 10:03:01AM +0200, Patrick Riphagen wrote: > This adds support for new Xsens device, Motion Tracker Development Board, > using Xsens' own Vendor ID > > Signed-off-by: Patrick Riphagen Applied, thanks. Johan -- To unsubscribe from this list: send the line "unsubscribe stab

Re: [PATCH v4] net: phy: micrel: Fix regression in kszphy_probe

2015-05-11 Thread Johan Hovold
like you forgot the "Fixes: " tag itself when updating. > Signed-off-by: Niklas Cassel Look good otherwise, feel free to add my Reviewed-by: Johan Hovold when resending (unless David wants to fix it up himself). Thanks, Johan -- To unsubscribe from this list: se

Re: [PATCH 1/2] mfd: da9052: fix broken regulator probe

2015-04-29 Thread Johan Hovold
On Tue, Apr 14, 2015 at 03:04:06PM +0200, Johan Hovold wrote: > Hi Mark and Lee, > > On Thu, Mar 26, 2015 at 08:32:09AM +, Lee Jones wrote: > > On Wed, 25 Mar 2015, Johan Hovold wrote: > > > > > Fix broken probe of da9052 regulators, which since commit b3f6c73

Re: Question: drivers/usb/serial/generic.c: usb_serial_generic_read_bulk_callback()

2015-04-27 Thread Johan Hovold
us not logging (by > default) what was a very noisy flood of messages. Does that simply > change timing enough such that the USB HCD has time to process the > disconnect? Or is there something else going on that I'm missing? > > -Original Message- > > From: Johan

[PATCH 01/23] gpio: sysfs: fix memory leaks and device hotplug

2015-04-21 Thread Johan Hovold
on pre-3.14 kernels (prior to kernfs). Fixes: d8f388d8dc8d ("gpio: sysfs interface") Cc: stable # v2.6.27: 01cca93a9491 Signed-off-by: Johan Hovold --- drivers/gpio/gpiolib-sysfs.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/gpio/gpiolib-sysfs.c

Re: [PATCH 1/2] mfd: da9052: fix broken regulator probe

2015-04-14 Thread Johan Hovold
Hi Mark and Lee, On Thu, Mar 26, 2015 at 08:32:09AM +, Lee Jones wrote: > On Wed, 25 Mar 2015, Johan Hovold wrote: > > > Fix broken probe of da9052 regulators, which since commit b3f6c73db732 > > ("mfd: da9052-core: Fix platform-device id collision") use a &g

Re: [PATCH 2/2] USB: ehci-tegra: fix inefficient copy of unaligned buffers

2015-04-07 Thread Johan Hovold
On Tue, Apr 07, 2015 at 11:30:15AM -0400, Alan Stern wrote: > On Tue, 7 Apr 2015, Johan Hovold wrote: > > > Make sure only to copy any actual data rather than the whole buffer, > > when releasing the temporary buffer used for unaligned transfer buffers. > > > > Note

[PATCH 1/2] USB: musb: fix inefficient copy of unaligned buffers

2015-04-07 Thread Johan Hovold
ement (un)map_urb_for_dma hooks") Cc: stable # v3.10 Signed-off-by: Johan Hovold --- drivers/usb/musb/musb_host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c index c3d5fc9dfb5b..d8327ec19a1f 100644 --- a/d

[PATCH 2/2] USB: ehci-tegra: fix inefficient copy of unaligned buffers

2015-04-07 Thread Johan Hovold
# v2.6.39 Signed-off-by: Johan Hovold --- drivers/usb/host/ehci-tegra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c index ff9af29b4e9f..dfe2a7abc36d 100644 --- a/drivers/usb/host/ehci-tegra.c +++ b/drivers/usb

Re: [PATCH] USB: ftdi_sio: Use jtag quirk for SNAP Connect E10

2015-03-25 Thread Johan Hovold
On Wed, Mar 25, 2015 at 08:51:26AM -0500, Doug Goldstein wrote: > On Wed, Mar 25, 2015 at 3:44 AM, Johan Hovold wrote: > > On Mon, Mar 23, 2015 at 08:34:48PM -0500, Doug Goldstein wrote: > >> This patch uses the existing CALAO Systems ftdi_8u2232c_probe in order > >>

[PATCH 2/2] mfd: core: fix platform-device name collisions

2015-03-25 Thread Johan Hovold
# v3.19 Reported-by: Bartlomiej Zolnierkiewicz Signed-off-by: Johan Hovold --- drivers/mfd/mfd-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c index 2a87f69be53d..1aed3b7b8d9b 100644 --- a/drivers/mfd/mfd-core.c +++ b/drivers/mfd/

[PATCH 1/2] mfd: da9052: fix broken regulator probe

2015-03-25 Thread Johan Hovold
il with an error message. Update the mfd-cell ids to be zero-based and use those to identify the cells when probing the regulator devices. Fixes: b3f6c73db732 ("mfd: da9052-core: Fix platform-device id collision") Cc: stable # v3.19 Signed-off-by: Johan Hovold --- drive

Re: [PATCH] USB: ftdi_sio: Use jtag quirk for SNAP Connect E10

2015-03-25 Thread Johan Hovold
On Mon, Mar 23, 2015 at 08:34:48PM -0500, Doug Goldstein wrote: > This patch uses the existing CALAO Systems ftdi_8u2232c_probe in order > to avoid attaching a TTY to the JTAG port as this board is based on the > CALAO Systems reference design and needs the same fix up. Thanks for the patch. Could

[PATCH 3/5] USB: serial: fix infinite wait_until_sent timeout

2015-03-04 Thread Johan Hovold
Make sure to handle an infinite timeout (0). Note that wait_until_sent is currently never called with a 0-timeout argument due to a bug in tty_wait_until_sent. Fixes: dcf010503966 ("USB: serial: add generic wait_until_sent implementation") Cc: stable # v3.10 Signed-off-by: Jo

[PATCH 1/5] net: irda: fix wait_until_sent poll timeout

2015-03-04 Thread Johan Hovold
.6.12-rc2") Cc: stable # v2.6.12 Signed-off-by: Johan Hovold --- net/irda/ircomm/ircomm_tty.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/irda/ircomm/ircomm_tty.c b/net/irda/ircomm/ircomm_tty.c index 40695b9751c1..4efe486baee6 100644 --- a/net/i

[PATCH 4/5] TTY: fix tty_wait_until_sent on 64-bit machines

2015-03-04 Thread Johan Hovold
ad an explicit check for negative timeouts, but all other tty drivers appear to be affected. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable # v2.6.12 Reported-by: ZIV-Asier Llano Palacios Signed-off-by: Johan Hovold --- drivers/tty/tty_ioctl.c | 12 +--- 1 file changed, 9 i

[PATCH] USB: mxuport: fix null deref when used as a console

2015-02-17 Thread Johan Hovold
Fix null-pointer dereference at probe when the device is used as a console, in which case the tty argument to open will be NULL. Fixes: ee467a1f2066 ("USB: serial: add Moxa UPORT 12XX/14XX/16XX driver") Cc: stable # v3.14 Signed-off-by: Johan Hovold --- drivers/usb/serial/mxu

[PATCH 2/3] USB: serial: fix tty-device error handling at probe

2015-02-17 Thread Johan Hovold
Add missing error handling when registering the tty device at port probe. This avoids trying to remove an uninitialised character device when the port device is removed. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Reported-by: Takashi Iwai Cc: stable # v2.6.12 Signed-off-by: Jo

[PATCH 1/3] USB: serial: fix potential use-after-free after failed probe

2015-02-17 Thread Johan Hovold
") Cc: stable # v2.6.31 Signed-off-by: Johan Hovold --- drivers/usb/serial/bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/serial/bus.c b/drivers/usb/serial/bus.c index 9374bd2aba20..5d8d8b90 100644 --- a/drivers/usb/serial/bus.c +++ b/drivers/

Re: [PATCH] USB: console: fix potential use after free

2015-02-15 Thread Johan Hovold
On Mon, Feb 16, 2015 at 03:49:17AM +, Ben Hutchings wrote: > On Wed, 2015-02-11 at 14:55 +0800, Johan Hovold wrote: > > On Tue, Feb 10, 2015 at 08:39:26PM +, Ben Hutchings wrote: > > > On Mon, 2015-01-05 at 16:04 +0100, Johan Hovold wrote: > > > > Use tty k

Re: [PATCH] USB: console: fix potential use after free

2015-02-10 Thread Johan Hovold
On Tue, Feb 10, 2015 at 08:39:26PM +, Ben Hutchings wrote: > On Mon, 2015-01-05 at 16:04 +0100, Johan Hovold wrote: > > Use tty kref to release the fake tty in usb_console_setup to avoid use > > after free if the underlying serial driver has acquired a reference. > > &g

[PATCH v2] gpio: sysfs: fix gpio device-attribute leak

2015-01-28 Thread Johan Hovold
attribute-creation race with userspace for these attributes. Remove contingent attributes in export error path and on unexport. Fixes: d8f388d8dc8d ("gpio: sysfs interface") Cc: stable # v2.6.27+ Signed-off-by: Johan Hovold Signed-off-by: Linus Walleij --- Backport to v3.12 (and 3.14). Cha

Re: [PATCH 3.12 140/176] gpio: sysfs: fix gpio device-attribute leak

2015-01-28 Thread Johan Hovold
On Wed, Jan 28, 2015 at 03:29:30PM +0100, Jiri Slaby wrote: > From: Johan Hovold > > 3.12-stable review patch. If anyone has any objections, please let me know. > > === > > commit 0915e6feb38de8d3601819992a5bd050201a56fa upstream. > > The gpio d

[PATCH v2] gpio: sysfs: fix gpio device-attribute leak

2015-01-28 Thread Johan Hovold
attribute-creation race with userspace for these attributes. Remove contingent attributes in export error path and on unexport. Fixes: d8f388d8dc8d ("gpio: sysfs interface") Cc: stable # v2.6.27+ Signed-off-by: Johan Hovold Signed-off-by: Linus Walleij --- Backport to v3.10 (and earlier) w

Re: [PATCH 3.12 140/176] gpio: sysfs: fix gpio device-attribute leak

2015-01-28 Thread Johan Hovold
On Wed, Jan 28, 2015 at 06:46:26PM +0100, Jiri Slaby wrote: > On 01/28/2015, 05:10 PM, Johan Hovold wrote: > > On Wed, Jan 28, 2015 at 03:29:30PM +0100, Jiri Slaby wrote: > >> From: Johan Hovold > >> > >> 3.12-stable review patch. If anyone has any

Re: [PATCH 3.14 02/77] gpio: sysfs: fix gpio device-attribute leak

2015-01-28 Thread Johan Hovold
On Wed, Jan 28, 2015 at 02:30:08PM +, Luis Henriques wrote: > On Tue, Jan 27, 2015 at 05:26:40PM -0800, Greg Kroah-Hartman wrote: > > @@ -994,6 +991,8 @@ void gpiod_unexport(struct gpio_desc *de > > > > dev = class_find_device(&gpio_class, NULL, desc, match_export); > >

[PATCH 2/2] gpio: sysfs: fix gpio device-attribute leak

2015-01-26 Thread Johan Hovold
attribute-creation race with userspace for these attributes. Remove contingent attributes in export error path and on unexport. Fixes: d8f388d8dc8d ("gpio: sysfs interface") Cc: stable # v2.6.27+ Signed-off-by: Johan Hovold Signed-off-by: Linus Walleij [johan: fix lea

[PATCH 1/2] gpio: sysfs: fix gpio-chip device-attribute leak

2015-01-26 Thread Johan Hovold
with userspace. Fixes: d8f388d8dc8d ("gpio: sysfs interface") Cc: stable # v2.6.27+ Signed-off-by: Johan Hovold Signed-off-by: Linus Walleij [johan: fix leak without device_create_with_groups, which wasn't introduced until 3.11 ] Signed-off-by: Johan Hovold --- drivers/gpi

[PATCH 2/2] gpio: sysfs: fix gpio device-attribute leak

2015-01-26 Thread Johan Hovold
attribute-creation race with userspace for these attributes. Remove contingent attributes in export error path and on unexport. Fixes: d8f388d8dc8d ("gpio: sysfs interface") Cc: stable # v2.6.27+ Signed-off-by: Johan Hovold Signed-off-by: Linus Walleij Signed-off-by: Johan Hovold --- dr

[PATCH 1/2] gpio: sysfs: fix gpio-chip device-attribute leak

2015-01-26 Thread Johan Hovold
with userspace. Fixes: d8f388d8dc8d ("gpio: sysfs interface") Cc: stable # v2.6.27+ Signed-off-by: Johan Hovold Signed-off-by: Linus Walleij Signed-off-by: Johan Hovold --- drivers/gpio/gpiolib.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git

Re: [PATCH] USB: cp210x: add ID for RUGGEDCOM USB Serial Console

2015-01-26 Thread Johan Hovold
On Wed, Jan 21, 2015 at 03:24:27PM -0500, Lennart Sorensen wrote: > Added the USB serial console device ID for Siemens Ruggedcom devices > which have a USB port for their serial console. > > Signed-off-by: Len Sorensen > --- > drivers/usb/serial/cp210x.c |1 + > 1 file changed, 1 insertion(+

[PATCH 1/2] gpio: sysfs: fix memory leak in gpiod_export_link

2015-01-26 Thread Johan Hovold
Fix memory leak in the gpio sysfs interface due to failure to drop reference to device returned by class_find_device when creating a link. Fixes: a4177ee7f1a8 ("gpiolib: allow exported GPIO nodes to be named using sysfs links") Cc: stable # v2.6.32 Signed-off-by: Johan Hovold --

[PATCH 2/2] gpio: sysfs: fix memory leak in gpiod_sysfs_set_active_low

2015-01-26 Thread Johan Hovold
Fix memory leak in the gpio sysfs interface due to failure to drop reference to device returned by class_find_device when setting the gpio-line polarity. Fixes: 0769746183ca ("gpiolib: add support for changing value polarity in sysfs") Cc: stable # v2.6.33 Signed-off-by: Jo

[PATCH 1/3] gpio: sysfs: fix gpio-chip device-attribute leak

2015-01-13 Thread Johan Hovold
rface") Cc: stable # v2.6.27+ Signed-off-by: Johan Hovold --- drivers/gpio/gpiolib-sysfs.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/gpio/gpiolib-sysfs.c b/drivers/gpio/gpiolib-sysfs.c index 2ac1800b58bb..33cf4bd0ed2d 100644 --- a/dr

[PATCH 2/3] gpio: sysfs: fix gpio device-attribute leak

2015-01-13 Thread Johan Hovold
. Remove contingent attributes in export error path and on unexport. Fixes: d8f388d8dc8d ("gpio: sysfs interface") Cc: stable # v2.6.27+ Signed-off-by: Johan Hovold --- drivers/gpio/gpiolib-sysfs.c | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) di

[PATCH 1/6] gpio: fix memory and reference leaks in gpiochip_add error path

2015-01-12 Thread Johan Hovold
uot;gpio / ACPI: register to ACPI events automatically") Cc: stable Signed-off-by: Johan Hovold --- drivers/gpio/gpiolib.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 487afe6f22fc..89c59f5f1924 10064

[PATCH 5/6] gpio: fix sleep-while-atomic in gpiochip_remove

2015-01-12 Thread Johan Hovold
ot;) Fixes: f23f1516b675 ("gpiolib: provide provision to register pin ranges") Cc: stable Signed-off-by: Johan Hovold --- drivers/gpio/gpiolib.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 0f8173051edc..37f91

[PATCH 4/6] gpio: fix memory leak and sleep-while-atomic

2015-01-12 Thread Johan Hovold
e holding a spinlock was added (a couple of irq-domain paths can end up grabbing mutexes). Fixes: afa82fab5e13 ("gpio / ACPI: Move event handling registration to gpiolib irqchip helpers") Fixes: 1425052097b5 ("gpio: add IRQ chip helpers in gpiolib") Cc: stable Signed-off-by: J

[PATCH v2 2/2] USB: console: fix potential use after free

2015-01-05 Thread Johan Hovold
Cc: stable Signed-off-by: Johan Hovold --- Changes since v1: - Use tty_kref_put to release tty also in setup() - Some more state must be initialised to avoid NULL derefs when the tty destructor is run after the underlying driver puts its reference. drivers/usb/serial/console.c | 15

[PATCH v2 1/2] USB: console: fix uninitialised ldisc semaphore

2015-01-05 Thread Johan Hovold
with ldisc_sem") Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/serial/console.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/serial/console.c b/drivers/usb/serial/console.c index 8d7fc48b1f30..e56f394b58d8 100644 --- a/drivers/usb/serial/console.c +++ b/drivers/

[PATCH 1/2] USB: console: fix uninitialised ldisc semaphore

2015-01-03 Thread Johan Hovold
with ldisc_sem") Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/serial/console.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/serial/console.c b/drivers/usb/serial/console.c index 8d7fc48b1f30..e56f394b58d8 100644 --- a/drivers/usb/serial/console.c +++ b/drivers/

[PATCH 2/2] USB: console: fix potential use after free

2015-01-03 Thread Johan Hovold
Use tty kref to release the fake tty in usb_console_setup to avoid use after free if the underlying serial driver has acquired a reference. Fixes: 4a90f09b20f4 ("tty: usb-serial krefs") Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/serial/console.c | 13 ++--- 1 fi

Re: [PATCH] leds: netxbig: fix oops at probe time

2014-12-03 Thread Johan Hovold
> [] (kernel_init_freeable) from [] (kernel_init+0xc/0xec) > [] (kernel_init) from [] (ret_from_fork+0x14/0x24) > [...] > > This bug was introduced by commit 588a6a99286ae30afb1339d8bc2163517b1b7dd1 > ("leds: netxbig: fix attribute-creation race"). Ouch. > Signed-off-by

[PATCH 2/3] USB: keyspan: fix overrun-error reporting

2014-11-18 Thread Johan Hovold
Fix reporting of overrun errors, which are not associated with a character. Instead insert a null character and report only once. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/serial/keyspan.c | 21 +++-- 1 file c

[PATCH 3/3] USB: ssu100: fix overrun-error reporting

2014-11-18 Thread Johan Hovold
Fix reporting of overrun errors, which should only be reported once using the inserted null character. Fixes: 6b8f1ca5581b ("USB: ssu100: set tty_flags in ssu100_process_packet") Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/serial/ssu100.c | 11 +++ 1 file

[PATCH 1/3] USB: keyspan: fix tty line-status reporting

2014-11-18 Thread Johan Hovold
("Linux-2.6.12-rc2") Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/serial/keyspan.c | 76 1 file changed, 48 insertions(+), 28 deletions(-) diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/keyspan.c index 93

Re: [PATCH] USB: cdc-acm: add quirk for control-line state requests

2014-11-07 Thread Johan Hovold
On Fri, Nov 07, 2014 at 10:05:12AM +0100, Oliver Neukum wrote: > On Thu, 2014-11-06 at 18:08 +0100, Johan Hovold wrote: > > Add new quirk for devices that cannot handle control-line state > > requests. > > > > Note that we currently send these requests to all

[PATCH] USB: cdc-acm: add quirk for control-line state requests

2014-11-06 Thread Johan Hovold
ned-off-by: Johan Hovold --- Greg, I believe this should into v3.18 as it fixes a reported regression with these devices. Johan drivers/usb/class/cdc-acm.c | 14 -- drivers/usb/class/cdc-acm.h | 2 ++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/usb/class

[PATCH Resend] USB: cdc-acm: only raise DTR on transitions from B0

2014-11-05 Thread Johan Hovold
Make sure to only raise DTR on transitions from B0 in set_termios. Also allow set_termios to be called from open with a termios_old of NULL. Note that DTR will not be raised prematurely in this case. Cc: stable Signed-off-by: Johan Hovold --- Greg, I just noticed that this one did not make

[PATCH 2/5] USB: opticon: fix non-atomic allocation in write path

2014-10-29 Thread Johan Hovold
Write may be called from interrupt context so make sure to use GFP_ATOMIC for all allocations in write. Fixes: 0d930e51cfe6 ("USB: opticon: Add Opticon OPN2001 write support") Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/serial/opticon.c | 2 +- 1 file changed, 1 inser

[PATCH 1/5] USB: kobil_sct: fix non-atomic allocation in write path

2014-10-29 Thread Johan Hovold
Write may be called from interrupt context so make sure to use GFP_ATOMIC for all allocations in write. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/serial/kobil_sct.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) di

Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-28 Thread Johan Hovold
On Mon, Oct 27, 2014 at 08:40:51PM +0100, Oliver Neukum wrote: > On Mon, 2014-10-27 at 19:07 +0100, Johan Hovold wrote: > > > I guess we could use that quirk, but I'm actually leaning towards just > > removing that quirk and reducing the log level of the message to info. &

Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-27 Thread Johan Hovold
On Mon, Oct 27, 2014 at 05:56:27PM +, Karl Palsson wrote: > On Mon, Oct 27, 2014 at 06:34:33PM +0100, Johan Hovold wrote: > > Add device-id entry for GW Instek AFG-2225, which has a byte swapped > > bInterfaceSubClass (0x20). > > > > Reported-by: Karl Palsson >

[PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-27 Thread Johan Hovold
Add device-id entry for GW Instek AFG-2225, which has a byte swapped bInterfaceSubClass (0x20). Reported-by: Karl Palsson Cc: stable Signed-off-by: Johan Hovold --- Care to give this patch a try as well, Karl? You can respond with a Tested-by tag if you want. Thanks, Johan drivers/usb

Re: [PATCH] usb: serial: ftdi_sio: add Awinda Station and Dongle products

2014-10-22 Thread Johan Hovold
On Fri, Oct 10, 2014 at 11:52:08AM +0200, Frans Klaver wrote: > Add new IDs for the Xsens Awinda Station and Awinda Dongle. > > While at it, order the definitions by PID and add a logical separation > between devices using Xsens' VID and those using FTDI's VID. > > Cc: > Signed-off-by: Frans Kla

[PATCH v2 01/20] rtc: omap: fix clock-source configuration

2014-10-21 Thread Johan Hovold
t for enabling 32khz clock") Cc: stable Reviewed-by: Felipe Balbi Signed-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c index 21142e6574a9..f842c216f2dd 100644 --- a/d

[PATCH v2 02/20] rtc: omap: fix missing wakealarm attribute

2014-10-21 Thread Johan Hovold
Cc: stable Reviewed-by: Felipe Balbi Signed-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c index f842c216f2dd..828cb9983cc2 100644 --- a/drivers/rtc/rtc-omap.c +++ b/drivers/rtc/

Re: [PATCH] usb: serial: ftdi_sio: add Awinda Station and Dongle products

2014-10-10 Thread Johan Hovold
On Fri, Oct 10, 2014 at 11:52:08AM +0200, Frans Klaver wrote: > Add new IDs for the Xsens Awinda Station and Awinda Dongle. > > While at it, order the definitions by PID and add a logical separation > between devices using Xsens' VID and those using FTDI's VID. > > Cc: > Signed-off-by: Frans Kla

Re: [PATCH v2] usb: serial: ftdi_sio: add Awinda Station and Dongle products

2014-10-10 Thread Johan Hovold
On Fri, Oct 10, 2014 at 11:32:27AM +0200, Frans Klaver wrote: > Add new IDs for the Xsens Awinda Station and Awinda Dongle. > > While at it, order the definitions by PID and add a logical separation > between devices using Xsens' VID and those using FTDI's VID. > > Cc: > Signed-off-by: Frans Kla

Re: [PATCH] usb: serial: ftdi_sio: add Awinda Station and Dongle products

2014-10-10 Thread Johan Hovold
On Fri, Oct 10, 2014 at 11:12:09AM +0200, Frans Klaver wrote: > On Fri, Oct 10, 2014 at 11:01:17AM +0200, Johan Hovold wrote: > > On Fri, Oct 10, 2014 at 10:44:54AM +0200, Frans Klaver wrote: > > > diff --git a/drivers/usb/serial/ftdi_sio_ids.h > > > b/driver

Re: [PATCH] usb: serial: ftdi_sio: add Awinda Station and Dongle products

2014-10-10 Thread Johan Hovold
On Fri, Oct 10, 2014 at 10:44:54AM +0200, Frans Klaver wrote: > Add new IDs for the Xsens Awinda Station and Awinda Dongle. > > Cc: > Signed-off-by: Frans Klaver > --- > drivers/usb/serial/ftdi_sio.c | 2 ++ > drivers/usb/serial/ftdi_sio_ids.h | 2 ++ > 2 files changed, 4 insertions(+) > >

[PATCH 01/12] rtc: omap: fix clock-source configuration

2014-10-09 Thread Johan Hovold
t for enabling 32khz clock") Cc: stable Signed-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c index 21142e6574a9..f842c216f2dd 100644 --- a/drivers/rtc/rtc-omap.c +++

[PATCH 02/12] rtc: omap: fix missing wakealarm attribute

2014-10-09 Thread Johan Hovold
Cc: stable Signed-off-by: Johan Hovold --- drivers/rtc/rtc-omap.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c index f842c216f2dd..828cb9983cc2 100644 --- a/drivers/rtc/rtc-omap.c +++ b/drivers/rtc/rtc-omap.c @@ -416,6 +416,8

Re: [PATCH] USB: zte_ev: fix removed PIDs

2014-09-02 Thread Johan Hovold
[ Please do not top post. ] On Tue, Sep 02, 2014 at 02:44:44PM +0800, 刘磊 wrote: > Dear Johan & Greg: > I can't find remove pid(0xfff6 to 0xfffd and 0xffec/0xffee) back > to zte_ev.c or option.c in git. > please make sure that pid had been added. thanks. Those PIDs will be added back to z

Re: [PATCH] USB: sierra: add 1199:68AA device ID

2014-09-01 Thread Johan Hovold
On Thu, Aug 28, 2014 at 03:08:16PM +0200, Bjørn Mork wrote: > This VID:PID is used for some Direct IP devices behaving > identical to the already supported 0F3D:68AA devices. > > Cc: > Reported-by: Lars Melin > Signed-off-by: Bjørn Mork > --- > This should be applied on top of my 'USB: sierra:

[PATCH] USB: zte_ev: fix removed PIDs

2014-08-28 Thread Johan Hovold
es. Fixes: 63a901c06e3c ("Revert "USB: option,zte_ev: move most ZTE CDMA devices to zte_ev"") Reported-by: Lei Liu Cc: stable Signed-off-by: Johan Hovold --- Greg, this one should also go in to rc3 along with the offending commit if possible. The zte_ev driver is scheduled

Re: Re: "Revert "USB: option,zte_ev: move most ZTE CDMA devices to zte_ev""

2014-08-28 Thread Johan Hovold
On Thu, Aug 28, 2014 at 11:25:30AM +0800, 刘磊 wrote: > Dear Johan: > Thanks for you reply. > i had been find the pid of 0x9008 and 0x3197 was in moto-modem and > qcserial drivers. > but the pid from 0xfff6 to 0xfffb and 0xffee/0xffec had been delete in > new patch, that pid was not in

[PATCH 2/2] USB: serial: fix potential heap buffer overflow

2014-08-27 Thread Johan Hovold
have been determined from device descriptors) did not exceed this limit. Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/serial/usb-serial.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c index eb0e8c6a8682

[PATCH 1/2] USB: serial: fix potential stack buffer overflow

2014-08-27 Thread Johan Hovold
exceed this limit. Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/serial/usb-serial.c | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c index 02de3110fe94..eb0e8c6a8682

Re: "Revert "USB: option,zte_ev: move most ZTE CDMA devices to zte_ev""

2014-08-27 Thread Johan Hovold
On Wed, Aug 27, 2014 at 03:42:09PM +0800, 刘磊 wrote: > Dear johan & gregkh: > i have been check the modify file of zte_ev.c. i have a few > question, some device pid you had been delete, but didn't add in > option.c. > that device pid probably in use, we can't losted. please add it for >

[PATCH] USB: ftdi_sio: add support for NOVITUS Bono E thermal printer

2014-08-18 Thread Johan Hovold
Add device id for NOVITUS Bono E thermal printer. Reported-by: Emanuel Koczwara Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/serial/ftdi_sio.c | 1 + drivers/usb/serial/ftdi_sio_ids.h | 6 ++ 2 files changed, 7 insertions(+) diff --git a/drivers/usb/serial/ftdi_sio.c b

[PATCH] USB: ftdi_sio: add Basic Micro ATOM Nano USB2Serial PID

2014-08-13 Thread Johan Hovold
Add device id for Basic Micro ATOM Nano USB2Serial adapters. Reported-by: Nicolas Alt Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/serial/ftdi_sio.c | 1 + drivers/usb/serial/ftdi_sio_ids.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/usb/serial/ftdi_sio.c b

[PATCH 3/4] USB: zte_ev: remove duplicate Qualcom PID

2014-08-07 Thread Johan Hovold
Remove dublicate Qualcom PID 0x3197 which is already handled by the moto-modem driver since commit 6986a978eec7 ("USB: add new moto_modem driver for some Morotola phones"). Fixes: 799ee9243d89 ("USB: serial: add zte_ev.c driver") Cc: Signed-off-by: Johan Hovold --- drivers

[PATCH 1/4] Revert "USB: option,zte_ev: move most ZTE CDMA devices to zte_ev"

2014-08-07 Thread Johan Hovold
th drivers prior to the commit being reverted. Reported-by: Lei Liu Cc: Signed-off-by: Johan Hovold --- drivers/usb/serial/option.c | 24 +--- drivers/usb/serial/zte_ev.c | 18 -- 2 files changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/usb/serial/

[PATCH 2/4] USB: zte_ev: remove duplicate Gobi PID

2014-08-07 Thread Johan Hovold
Remove dublicate Gobi PID 0x9008 which is already handled by the qcserial driver since commit f05932c0caf4 ("USB: qcserial: Add extra device IDs"). Fixes: 799ee9243d89 ("USB: serial: add zte_ev.c driver") Cc: Signed-off-by: Johan Hovold --- drivers/usb/serial/zte_ev.c | 1

Re: [PATCH] usb: option: add/modify Olivetti Olicard modems

2014-06-23 Thread Johan Hovold
On Fri, Jun 06, 2014 at 05:25:56PM +0200, Bjørn Mork wrote: > Adding a couple of Olivetti modems and blacklisting the net > function on a couple which are already supported. > > Reported-by: Lars Melin > Cc: > Signed-off-by: Bjørn Mork Applied, thanks! Johan -- To unsubscribe from this list:

Re: [PATCH 1/5] USB: ftdi_sio: fix null deref at port probe

2014-06-05 Thread Johan Hovold
On Thu, Jun 05, 2014 at 05:13:49PM +0100, Ben Hutchings wrote: > On Thu, 2014-06-05 at 16:05 +0200, Johan Hovold wrote: > > Fix NULL-pointer dereference when probing an interface with no > > endpoints. > > > > These devices have two bulk endpoints per interface, but t

[PATCH 1/5] USB: ftdi_sio: fix null deref at port probe

2014-06-05 Thread Johan Hovold
-uninitialized compiler warning for ep_desc after the loop. Fixes: 895f28badce9 ("USB: ftdi_sio: fix hi-speed device packet size calculation") Reported-by: Mike Remski Tested-by: Mike Remski Cc: # 2.3.61 Signed-off-by: Johan Hovold --- drivers/usb/serial/ftdi_sio.c | 7 +-- 1 file

Re: [PATCH usb-next] usb: qcserial: add additional Sierra Wireless QMI devices

2014-05-29 Thread Johan Hovold
; Cc: # backport in link above Signed-off-by: Johan Hovold Next time you should put your Signed-off-by tag after any other tags. Not everyone follows that, but it makes it possible to track who added which tag in the Signed-off-by chain (and can also be used to track other changes made to patch

Re: [PATCH] USB: qcserial: add Netgear AirCard 341U PID

2014-05-29 Thread Johan Hovold
On Thu, May 29, 2014 at 12:48:56PM +0200, Aleksander Morgado wrote: > On Thu, May 29, 2014 at 10:20 AM, Johan Hovold wrote: > > From: Aleksander Morgado > > > > Add Netgear AirCard 341U PID. > > > > Signed-off-by: Aleksander Morgado > > Link: http://marc.

[PATCH] USB: qcserial: add Netgear AirCard 341U PID

2014-05-29 Thread Johan Hovold
From: Aleksander Morgado Add Netgear AirCard 341U PID. Signed-off-by: Aleksander Morgado Link: http://marc.info/?l=linux-usb&m=140130486111309&w=2 Cc: # backport in link above Signed-off-by: Johan Hovold --- Aleksander, thanks for the patch and backport! I added a minimal commit

[PATCH 48/63] USB: cdc-acm: fix write and resume race

2014-05-26 Thread Johan Hovold
write_lock after susp_count is decremented, but before the delayed urb is submitted. Fixes: 11ea859d64b6 ("USB: additional power savings for cdc-acm devices that support remote wakeup") Cc: # v2.6.27 Signed-off-by: Johan Hovold --- drivers/usb/class/cdc-acm.c | 23 +---

[PATCH 26/63] USB: usb_wwan: fix write and suspend race

2014-05-26 Thread Johan Hovold
suspended flag, thus leaving a window where a concurrent write() can submit an urb. Fixes: 383cedc3bb43 ("USB: serial: full autosuspend support for the option driver") Cc: # v2.6.32 Signed-off-by: Johan Hovold --- drivers/usb/serial/usb_wwan.c | 13 + 1 file changed, 5 insert

[PATCH 25/63] USB: usb_wwan: fix race between write and resume

2014-05-26 Thread Johan Hovold
ring resume. Fixes: 383cedc3bb43 ("USB: serial: full autosuspend support for the option driver") Signed-off-by: xiao jin Signed-off-by: Zhang, Qi1 Reviewed-by: David Cohen Cc: # v2.6.32 Signed-off-by: Johan Hovold --- drivers/usb/serial/usb_wwan.c | 8 ++-- 1 file changed, 2 inser

[PATCH 29/63] USB: usb_wwan: fix potential blocked I/O after resume

2014-05-26 Thread Johan Hovold
failed. Fixes: 383cedc3bb43 ("USB: serial: full autosuspend support for the option driver") Cc: # v2.6.32 Signed-off-by: Johan Hovold --- drivers/usb/serial/usb_wwan.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/usb/serial/

[PATCH 52/63] USB: cdc-acm: fix potential urb leak and PM imbalance in write

2014-05-26 Thread Johan Hovold
Make sure to check return value of autopm get in write() in order to avoid urb leak and PM counter imbalance on errors. Fixes: 11ea859d64b6 ("USB: additional power savings for cdc-acm devices that support remote wakeup") Cc: # v2.6.27 Signed-off-by: Johan Hovold --- drivers/usb

[PATCH 27/63] USB: usb_wwan: fix urb leak at shutdown

2014-05-26 Thread Johan Hovold
could be corrupted with previously buffered data, transfered with reduced throughput or completely blocked. Note that unbusy_queued_urb() was simply moved out of CONFIG_PM. Fixes: 383cedc3bb43 ("USB: serial: full autosuspend support for the option driver") Cc: # v2.6.32 Signed-off

[PATCH 03/63] USB: sierra: fix urb and memory leak in resume error path

2014-05-26 Thread Johan Hovold
nline") Cc: # v2.6.32 Signed-off-by: Johan Hovold --- drivers/usb/serial/sierra.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c index 2c5c5a9330e2..dd9820d3fa03 100644 --- a/drivers/usb/serial/sierra.c +++

[PATCH 24/63] USB: usb_wwan: fix urb leak in write error path

2014-05-26 Thread Johan Hovold
;) Signed-off-by: xiao jin Signed-off-by: Zhang, Qi1 Reviewed-by: David Cohen Cc: # v2.6.32 Signed-off-by: Johan Hovold --- drivers/usb/serial/usb_wwan.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/serial/usb_wwan.c b/drivers/usb/serial/usb_wwan.c index

[PATCH 01/63] USB: sierra: fix AA deadlock in open error path

2014-05-26 Thread Johan Hovold
Fix AA deadlock in open error path that would call close() and try to grab the already held disc_mutex. Fixes: b9a44bc19f48 ("sierra: driver urb handling improvements") Cc: # v2.6.31 Signed-off-by: Johan Hovold --- drivers/usb/serial/sierra.c | 21 + 1 file c

[PATCH 05/63] USB: sierra: fix remote wakeup

2014-05-26 Thread Johan Hovold
(and which must therefore not be runtime suspended while open). Add an open_ports counter (protected by the susp_lock) and only clear needs_remote_wakeup when the last port is closed. Fixes: e6929a9020ac ("USB: support for autosuspend in sierra while online") Cc: # v2.6.32 Signed-off

  1   2   3   4   >