Re: [PATCH] mfd: omap-usb-tll: Don't hold lock during pm_runtime_get/put_sync()

2013-12-18 Thread Lee Jones
ata > *pdata) > } > } > > - pm_runtime_put_sync(tll_dev); > - > spin_unlock(&tll_lock); > + pm_runtime_put_sync(tll_dev); > > return 0; > } -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open sourc

Re: [PATCH 1/2] mfd: max77686: fix regmap resource leak on driver remove

2013-12-20 Thread Lee Jones
Always happy to move to managed resources. Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a mess

[PATCH] mfd: omap-usb-host: Fix improper mask use

2014-07-29 Thread Lee Jones
single-ulpi-bypass is a flag used for older OMAP3 silicon. The flag when set, can excite code that improperly uses the OMAP_UHH_HOSTCONFIG_UPLI_BYPASS define to clear the corresponding bit. Instead it clears all of the other bits disabling all of the ports in the process. Signed-off-by: Michael W

Re: [PATCH] mfd: omap-usb-host: Fix improper mask use

2014-07-29 Thread Lee Jones
On Tue, 29 Jul 2014, Greg KH wrote: > On Tue, Jul 29, 2014 at 09:33:25AM +0100, Lee Jones wrote: > > single-ulpi-bypass is a flag used for older OMAP3 silicon. > > > > The flag when set, can excite code that improperly uses the > > OMAP_UHH_HOSTCONFIG_UPLI

Re: [PATCH] usb: musb: ux500: don't propagate the OF node

2014-06-16 Thread Lee Jones
ply all the pin > control settings also to the HDRC device as it gets > instantiated. (The OMAP2430 for example, does not set the > of_node member.) > > Cc: stable@vger.kernel.org > Cc: Lee Jones > Cc: Arnd Bergmann > Cc: Felipe Balbi > Signed-off-by: Linus Walleij >

Re: [PATCH] mfd: 88pm800: Fix I2C device resource leak if probe fails

2014-02-12 Thread Lee Jones
800_pages_exit(chip); > err_page_init: > + pm800_pages_exit(chip); > err_subchip_alloc: > pm80x_deinit(); > out_init: If you're going to do this, then can you clean-up the superfluous goto labels please? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Lina

Re: [PATCH v2] mfd: 88pm800: Fix I2C device resource leak if probe fails

2014-02-12 Thread Lee Jones
ion(+), 2 deletions(-) Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to major

Re: [PATCH 1/2] mfd: tps65910: Fix possible invalid pointer dereference on regmap_add_irq_chip fail

2014-03-19 Thread Lee Jones
not null. > > Signed-off-by: Krzysztof Kozlowski > Cc: > Fixes: 4aab3fadad32 ("mfd: tps65910: Move interrupt implementation code to > mfd file") > --- > drivers/mfd/tps65910.c |4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Applied after cleaning up

Re: [PATCH v2] mfd: omap-usb-tll: Don't hold lock during pm_runtime_get/put_sync()

2014-01-08 Thread Lee Jones
alkeinen > Signed-off-by: Roger Quadros > Tested-by: Tomi Valkeinen > Cc: # 3.9+ > --- > drivers/mfd/omap-usb-tll.c | 36 > 1 file changed, 12 insertions(+), 24 deletions(-) Patch looks good to me now. Applied, thanks. -- Lee Jones Lina

Re: [PATCH] mfd: include all drivers in subsystem menu

2014-02-03 Thread Lee Jones
e selectable again. > > Cc: stable@vger.kernel.org > Cc: Andrea Adami > Cc: Dmitry Eremin-Solenikov > Signed-off-by: Linus Walleij > --- > drivers/mfd/Kconfig | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Applied, thanks. -- Lee Jones Linaro STMicroelect

Re: [PATCH] mfd: sec-core: Fix possible NULL pointer dereference when i2c_new_dummy error

2014-02-11 Thread Lee Jones
regmap_init_i2c() or i2c_unregister_device(). > > If i2c_new_dummy() fails for RTC device, fail also the probe for main > MFD driver. > > Signed-off-by: Krzysztof Kozlowski > Cc: stable@vger.kernel.org > --- > drivers/mfd/sec-core.c |4 > 1 file changed, 4 inse

Re: [PATCH 2/7] mfd: 88pm860x: Fix I2C device resource leak on regmap init fail

2014-02-11 Thread Lee Jones
"Failed to allocate register map: %d\n", ret); > + i2c_unregister_device(chip->companion); > return ret; > } > i2c_set_clientdata(chip->companion, chip); Applied, thanks. -- Le

Re: [PATCH 3/7] mfd: max77686: Fix possible NULL pointer dereference on i2c_new_dummy error

2014-02-11 Thread Lee Jones
for > RTC\n"); > + return -ENODEV; > + } > i2c_set_clientdata(max77686->rtc, max77686); > > max77686_irq_init(max77686); Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Lin

Re: [PATCH 1/7] mfd: 88pm860x: Fix possible NULL pointer dereference on i2c_new_dummy error

2014-02-11 Thread Lee Jones
2c(chip->companion, > &pm860x_regmap_config); > if (IS_ERR(chip->regmap_companion)) { Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM So

Re: [PATCH 5/7] mfd: max8925: Fix possible NULL pointer dereference on i2c_new_dummy error

2014-02-11 Thread Lee Jones
cate I2C device for ADC\n"); > + i2c_unregister_device(chip->rtc); > + return -ENODEV; > + } > i2c_set_clientdata(chip->adc, chip); > > device_init_wakeup(&client->dev, 1); Applied, thanks. -- Lee Jones Linaro STMicroelect

Re: [PATCH 6/7] mfd: max8997: Fix possible NULL pointer dereference on i2c_new_dummy error

2014-02-11 Thread Lee Jones
; pm_runtime_set_active(max8997->dev); > @@ -239,7 +255,9 @@ static int max8997_i2c_probe(struct i2c_client *i2c, > err_mfd: > mfd_remove_devices(max8997->dev); > i2c_unregister_device(max8997->muic); > +err_i2c_muic: > i2c_unregister_device(max8997-&

Re: [PATCH 7/7] mfd: max8998: Fix possible NULL pointer dereference on i2c_new_dummy error

2014-02-11 Thread Lee Jones
return -ENODEV; > + } > i2c_set_clientdata(max8998->rtc, max8998); > > max8998_irq_init(max8998); Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubsc

Re: [PATCH 4/7] mfd: max77693: Fix possible NULL pointer dereference on i2c_new_dummy error

2014-02-11 Thread Lee Jones
->haptic, max77693); > > /* > @@ -184,8 +193,9 @@ err_mfd: > max77693_irq_exit(max77693); > err_irq: > err_regmap_muic: > - i2c_unregister_device(max77693->muic); > i2c_unregister_device(max77693->haptic); > +err_i2c_haptic: > + i2c_unregister_devi

Re: [PATCH fixes v2] mfd: max77693: Fix always masked MUIC interrupts

2014-10-22 Thread Lee Jones
On Wed, 22 Oct 2014, Krzysztof Kozlowski wrote: > On pią, 2014-10-10 at 11:56 +0100, Lee Jones wrote: > > On Fri, 10 Oct 2014, Krzysztof Kozlowski wrote: > > > > > All interrupts coming from MUIC were ignored because interrupt source > > > register was masked. &

Re: [PATCH] mfd: tc6393xb fail ohci suspend if full state restore is required

2014-11-03 Thread Lee Jones
ing this shortly. > > Signed-off-by: Dmitry Eremin-Solenikov > > Cc: stable@vger.kernel.org > > --- > > drivers/mfd/tc6393xb.c | 13 - > > 1 file changed, 12 insertions(+), 1 deletion(-) > > > -- Lee Jones Linaro STMicroelectronics Landing

Re: [PATCH] mfd: tc6393xb fail ohci suspend if full state restore is required

2014-11-03 Thread Lee Jones
3xb_cells[] = { > .num_resources = ARRAY_SIZE(tc6393xb_ohci_resources), > .resources = tc6393xb_ohci_resources, > .enable = tc6393xb_ohci_enable, > - .suspend = tc6393xb_ohci_disable, > + .suspend = tc6393xb_ohci_suspend, >

Re: [PATCH] mfd: tc6393xb fail ohci suspend if full state restore is required

2014-11-04 Thread Lee Jones
On Tue, 04 Nov 2014, Dmitry Eremin-Solenikov wrote: > Hello. > > 2014-11-03 17:56 GMT+03:00 Lee Jones : > > On Fri, 24 Oct 2014, Dmitry Eremin-Solenikov wrote: > > > >> Some boards with TC6393XB chip require full state restore during system > >> resume th

Re: [PATCH] mfd: tc6393xb fail ohci suspend if full state restore is required

2014-11-04 Thread Lee Jones
.enable = tc6393xb_ohci_enable, > - .suspend = tc6393xb_ohci_disable, > + .suspend = tc6393xb_ohci_suspend, > .resume = tc6393xb_ohci_enable, > .disable = tc6393xb_ohci_disable, > }, -- Lee Jones Linaro STMicroelectron

Re: [PATCH 2/2] backlight: pwm: clean up pwm requested using legacy API

2014-11-10 Thread Lee Jones
pb->pwm = pwm_request(data->pwm_id, "pwm-backlight"); > } > > @@ -339,6 +341,8 @@ static int pwm_backlight_remove(struct platform_device > *pdev) > > if (pb->exit) > pb->exit(&pdev->dev); > + if (pb->lega

Re: [PATCH fixes 1/2] mfd: max77693: Use proper regmap for handling MUIC interrupts

2014-10-10 Thread Lee Jones
regmap_add_irq_chip(max77693->regmap, max77693->irq, > + ret = regmap_add_irq_chip(max77693->regmap_muic, max77693->irq, > IRQF_ONESHOT | IRQF_SHARED | > IRQF_TRIGGER_FALLING, 0, > &

Re: [PATCH fixes 2/2] extcon: max77693: Fix always masked MUIC interrupts

2014-10-10 Thread Lee Jones
linux/mfd/max77693-private.h > +++ b/include/linux/mfd/max77693-private.h > @@ -438,6 +438,11 @@ enum max77693_irq_source { > MAX77693_IRQ_GROUP_NR, > }; > > +#define SRC_IRQ_CHARGER BIT(0) > +#define SRC_IRQ_TOP BIT(1) > +#define SRC_IRQ_FL

Re: [PATCH fixes 2/2] extcon: max77693: Fix always masked MUIC interrupts

2014-10-10 Thread Lee Jones
On Fri, 10 Oct 2014, Krzysztof Kozlowski wrote: > On pią, 2014-10-10 at 09:58 +0100, Lee Jones wrote: > > On Fri, 10 Oct 2014, Krzysztof Kozlowski wrote: > > > > > All interrupts coming from MUIC were ignored because interrupt source > > > register was masked. &

Re: [PATCH fixes v2] mfd: max77693: Fix always masked MUIC interrupts

2014-10-10 Thread Lee Jones
> }; > > +#define SRC_IRQ_CHARGER BIT(0) > +#define SRC_IRQ_TOP BIT(1) > +#define SRC_IRQ_FLASHBIT(2) > +#define SRC_IRQ_MUIC BIT(3) > +#define SRC_IRQ_ALL (SRC_IRQ_CHARGER | SRC_IR

Re: [PATCH 1/2] mfd: da9052: fix broken regulator probe

2015-03-26 Thread Lee Jones
collision") > Cc: stable# v3.19 > Signed-off-by: Johan Hovold > --- > drivers/mfd/da9052-core.c| 8 > drivers/regulator/da9052-regulator.c | 5 +++-- Need an Ack from Mark, but looks good to me. Acked-by: Lee Jones > 2 files changed, 7 inserti

Re: [PATCH 2/2] mfd: core: fix platform-device name collisions

2015-03-26 Thread Lee Jones
d, > int platform_id; > int r; > > - if (id < 0) > + if (id == PLATFORM_DEVID_AUTO) > platform_id = id; > else > platform_id = id + cell->id; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source soft

Re: [PATCH 1/2] mfd: da9052: fix broken regulator probe

2015-03-30 Thread Lee Jones
tor; > config.regmap = da9052->regmap; > if (pdata && pdata->regulators) { > - config.init_data = pdata->regulators[pdev->id]; > + config.init_data = pdata->regulators[cell->id]; > } else { > #ifdef CONFIG_OF >

Re: [PATCH 1/5] mfd: tps65218: make INT[12] and STATUS registers volatile

2015-01-18 Thread Lee Jones
for them, we will > never be able to clear the interrupt, which will cause > our IRQ line to be disabled due to IRQ throttling. > > Fixes: 44b4dc6 mfd: tps65218: Add driver for the TPS65218 PMIC > Cc: # v3.15+ > Cc: Keerthy > Cc: Lee Jones > Signed-off-by: Felipe B

Re: [PATCH 2/5] mfd: tps65218: make INT1 our status_base register

2015-01-18 Thread Lee Jones
1, > + .status_base = TPS65218_REG_INT1, > }; > > static const struct of_device_id of_tps65218_match_table[] = { -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe fro

Re: [RESEND PATCH] mfd: max77843: Fix max77843_chg_init() return on error

2015-09-22 Thread Lee Jones
tic int max77843_chg_init(struct max77693_dev *max77843) > if (!max77843->i2c_chg) { > dev_err(&max77843->i2c->dev, > "Cannot allocate I2C device for Charger\n"); > - return PTR_ERR(max77843->i2c_c

Re: [PATCH 1/2] mfd: da9052: fix broken regulator probe

2015-04-29 Thread Lee Jones
On Wed, 29 Apr 2015, Johan Hovold wrote: > On Tue, Apr 14, 2015 at 03:04:06PM +0200, Johan Hovold wrote: > > Hi Mark and Lee, > > > > On Thu, Mar 26, 2015 at 08:32:09AM +, Lee Jones wrote: > > > On Wed, 25 Mar 2015, Johan Hovold wrote: > > > > &

[PATCH 01/14] rtc: ab8500-rtc: IRQF_ONESHOT when requesting a threaded IRQ

2012-06-12 Thread Lee Jones
From: Lee Jones Date: Tue, 22 May 2012 15:25:09 +0100 Subject: [PATCH 01/14] rtc: ab8500-rtc: IRQF_ONESHOT when requesting a threaded IRQ The kernel now forces IRQs to be ONESHOT if no IRQ handler is passed. Cc: Alessandro Zummo Cc: rtc-li...@googlegroups.com Cc: stable@vger.kernel.org Signed

Re: [PATCH 03/14] mfd: ab8500-gpadc: Enable IRQF_ONESHOT when requesting a threaded IRQ

2012-06-12 Thread Lee Jones
Lee Jones Linaro ST-Ericsson Landing Team Lead M: +44 77 88 633 515 Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From: Lee Jones Date: Tue, 22 May 2012 15:13:13 +0100 Subject: [PATCH 03/14] mfd: ab8500-gpadc: Enable IRQF_ONESHOT when requesting a

Re: [PATCH 01/14] rtc: ab8500-rtc: IRQF_ONESHOT when requesting a threaded IRQ

2012-06-14 Thread Lee Jones
On 13/06/12 23:25, Andrew Morton wrote: On Tue, 12 Jun 2012 09:57:37 +0100 Lee Jones wrote: The kernel now forces IRQs to be ONESHOT if no IRQ handler is passed. What does this mean. The kernel crashes? The registration fails? A warning is emitted? When fixing a bug, please fully

Re: [PATCH 01/14] rtc: ab8500-rtc: IRQF_ONESHOT when requesting a threaded IRQ

2012-06-14 Thread Lee Jones
On 14/06/12 08:30, Andrew Morton wrote: > On Thu, 14 Jun 2012 08:14:49 +0100 Lee Jones wrote: > >> On 13/06/12 23:25, Andrew Morton wrote: >>> On Tue, 12 Jun 2012 09:57:37 +0100 >>> Lee Jones wrote: >>> >>>> The kernel now forces IRQs to b

[PATCH 1/1] ARM: ux500: Fix build errors/warnings when MACH_UX500_DT is not set

2012-06-15 Thread Lee Jones
.c:66:6: warning: assignment makes pointer from integer without a cast Cc: stable@vger.kernel.org Signed-off-by: Lee Jones --- arch/arm/mach-ux500/board-mop500.c | 10 +- arch/arm/mach-ux500/timer.c|2 ++ 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/arc

Re: [PATCH 1/1] ARM: ux500: Fix build errors/warnings when MACH_UX500_DT is not set

2012-06-18 Thread Lee Jones
On 17/06/12 18:28, Linus Walleij wrote: On Fri, Jun 15, 2012 at 10:42 AM, Lee Jones wrote: When MACH_UX500_DT and all related Device Tree configurations are forced off the warning and error below prevent the kernel from compiling. This simple patch fixes both issues and allows for full build