Re: [PATCH] media: dvb-core: Don't force CAN_INVERSION_AUTO in oneshot mode.

2015-08-31 Thread Malcolm Priestley
On 31/08/15 18:03, Johann Klammer wrote: Why not just remove the line? info->caps |= FE_CAN_INVERSION_AUTO; The capabilities call interacting with the oneshot setting is rather weird and maybe unexpected. No, because in normal mode it can do auto inversion. -- To unsubscribe

Re: [PATCH] media: dvb-core: Don't force CAN_INVERSION_AUTO in oneshot mode.

2015-08-31 Thread Malcolm Priestley
Hi Devin On 31/08/15 19:07, Devin Heitmueller wrote: Hi Malcolm, The capabilities call interacting with the oneshot setting is rather weird and maybe unexpected. No, because in normal mode it can do auto inversion. ... If the goal was for the software-emulated auto inversion to be

[PATCH] media: dvb-core: Don't force CAN_INVERSION_AUTO in oneshot mode.

2015-08-31 Thread Malcolm Priestley
set FE_CAN_INVERSION_AUTO in modes other than FE_TUNE_MODE_ONESHOT Signed-off-by: Malcolm Priestley <tvbox...@gmail.com> Cc: <stable@vger.kernel.org> --- drivers/media/dvb-core/dvb_frontend.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/me

[PATCH] staging: vt6655: vnt_bss_info_changed check conf-beacon_rate is not NULL

2015-08-02 Thread Malcolm Priestley
conf-beacon_rate can be NULL on association. So check conf-beacon_rate BSS_CHANGED_BEACON_INFO needs to flagged in changed as the beacon_rate will appear later. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc: stable@vger.kernel.org # v3.19+ --- drivers/staging/vt6655/device_main.c | 5

[PATCH] staging: vt6656: check ieee80211_bss_conf bssid not NULL

2015-07-09 Thread Malcolm Priestley
Sometimes bssid can go null on failed association. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc: stable@vger.kernel.org # v3.17+ --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers

[PATCH 1/4] staging: vt6655: check ieee80211_bss_conf bssid not NULL

2015-07-09 Thread Malcolm Priestley
Sometimes bssid can go null on failed association. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc: stable@vger.kernel.org # v3.19+ --- drivers/staging/vt6655/device_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers

[PATCH 9/9] staging: vt6655: device_rx_srv check sk_buff is NULL

2015-05-31 Thread Malcolm Priestley
There is a small chance that pRD-pRDInfo-skb could go NULL while the interrupt is processing. Put NULL check on loop to break out. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc: stable@vger.kernel.org --- drivers/staging/vt6655/device_main.c | 4 1 file changed, 4 insertions

staging: vt6655: Upstream fixes for 3.19

2015-05-21 Thread Malcolm Priestley
The following upstream fixes issue with TX path for 3.19 and apply cleanly in the following order. commit 187e2a81805f4b7ba1acf118aed8937a718d894c staging: vt6655: move setting of PSTxDesc-buff_addr to vnt_tx_packet commit d17f4c8a42256dae6aa598bdbc00eff8b38cc949 staging: vt6655: Fix

[PATCH 1/3] staging: vt6655: vnt_tx_packet Correct TX order of OWNED_BY_NIC

2015-04-21 Thread Malcolm Priestley
the memory transfer. A back port patch will be needed for v3.19 Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc: stable@vger.kernel.org # v4.0+ --- drivers/staging/vt6655/device_main.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/staging

[PATCH 3/3] staging: vt6655: lock MACvWriteBSSIDAddress.

2015-04-21 Thread Malcolm Priestley
This function selects page 1 and cause intermittent problems on interrupt handler. lock call with spin_lock_irqsave. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc: stable@vger.kernel.org # v3.19+ --- drivers/staging/vt6655/device_main.c | 9 - 1 file changed, 8 insertions(+), 1

Re: [PATCH] staging: vt6655: Fix TX retransmission race condition

2015-04-18 Thread Malcolm Priestley
On 12/04/15 00:47, Malcolm Priestley wrote: With high tx flow the same buffer can transmit more than once and get stuck in loop. Reset TCR to zero in device_tx_srv. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc: stable@vger.kernel.org # v3.19+ --- drivers/staging/vt6655

[PATCH] staging: vt6655: Fix 80211 control and management status reporting.

2015-04-11 Thread Malcolm Priestley
Currently only TD_FLAGS_NETIF_SKB are reported back to mac80211. Move vnt_int_report_rate to report all frame types. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc: stable@vger.kernel.org # v3.19+ --- drivers/staging/vt6655/device_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH] staging: vt6655: Fix TX retransmission race condition

2015-04-11 Thread Malcolm Priestley
With high tx flow the same buffer can transmit more than once and get stuck in loop. Reset TCR to zero in device_tx_srv. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc: stable@vger.kernel.org # v3.19+ --- drivers/staging/vt6655/device_main.c | 3 +++ 1 file changed, 3 insertions

[PATCH 2/2] staging: vt6655: implement IEEE80211_TX_STAT_NOACK_TRANSMITTED

2015-04-09 Thread Malcolm Priestley
Make use of this macro for non ack frames. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc: stable@vger.kernel.org # v4.0 --- drivers/staging/vt6655/device_main.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers

[PATCH 1/2] staging: vt6655: device_free_tx_buf use only ieee80211_tx_status_irqsafe

2015-04-09 Thread Malcolm Priestley
TD_FLAGS_NETIF_SKB is only for data. Fixes issue of ack frames not being reported. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc: stable@vger.kernel.org # v3.19+ --- drivers/staging/vt6655/device_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers

[PATCH] staging: vt6656: use ieee80211_tx_info to select packet type.

2015-04-04 Thread Malcolm Priestley
Information for packet type is in ieee80211_tx_info band IEEE80211_BAND_5GHZ for PK_TYPE_11A. IEEE80211_TX_RC_USE_CTS_PROTECT via tx_rate flags selects PK_TYPE_11GB This ensures that the packet is always the right type. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc: stable

[PATCH 2/2] staging: vt6655: use ieee80211_tx_info to select packet type.

2015-04-01 Thread Malcolm Priestley
Information for packet type is in ieee80211_tx_info band IEEE80211_BAND_5GHZ for PK_TYPE_11A. IEEE80211_TX_RC_USE_CTS_PROTECT via tx_rate flags selects PK_TYPE_11GB This ensures that the packet is always the right type. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc: stable

Re: [PATCH] staging: vt6656: vnt_rf_setpower: fix missing rate RATE_12M

2015-03-26 Thread Malcolm Priestley
On 26/03/15 15:22, Luis Henriques wrote: Hi Malcolm, On Sat, Mar 07, 2015 at 04:36:37PM +, Malcolm Priestley wrote: When the driver sets this rate a power of zero value is set causing data flow stoppage until another rate is tried. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc

[PATCH resend 1/3] vt6655: RFbSetPower fix missing rate RATE_12M

2015-03-07 Thread Malcolm Priestley
When the driver sets this rate a power of zero value is set causing data flow stoppage until another rate is tried. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc: stable@vger.kernel.org --- drivers/staging/vt6655/rf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging

[PATCH resend 2/3] vt6655: Fix late setting of byRFType.

2015-03-07 Thread Malcolm Priestley
. byRevId not used by driver and is removed. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc: stable@vger.kernel.org # v3.19+ --- drivers/staging/vt6655/device_main.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b

[PATCH] staging: vt6656: vnt_rf_setpower: fix missing rate RATE_12M

2015-03-07 Thread Malcolm Priestley
When the driver sets this rate a power of zero value is set causing data flow stoppage until another rate is tried. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc: stable@vger.kernel.org # v3.17+ --- drivers/staging/vt6656/rf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

[PATCH 2/2 fix for 3.20] vt6655: Fix late setting of byRFType.

2015-02-22 Thread Malcolm Priestley
. byRevId not used by driver and is removed. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc: stable@vger.kernel.org # v3.19+ --- drivers/staging/vt6655/device_main.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b

[PATCH 1/2 fix for 3.20] vt6655: RFbSetPower fix missing rate RATE_12M

2015-02-22 Thread Malcolm Priestley
When the driver sets this rate a power of zero value is set causing data flow stoppage until another rate is tried. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc: stable@vger.kernel.org --- drivers/staging/vt6655/rf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging

[PATCH 1/5] lmedm04: Increase Interupt due time to 200 msec.

2015-01-02 Thread Malcolm Priestley
Ocassionally the device fails to report back an interrupt urb status which results in false no lock trigger on the RS2000 demodulator. Increase time from 60 msecs to 200 msecs. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc: stable@vger.kernel.org # v3.17+ --- drivers/media/usb/dvb-usb

[PATCH 2/5] lmedm04: Fix usb_submit_urb BOGUS urb xfer, pipe 1 != type 3 in interrupt urb

2015-01-02 Thread Malcolm Priestley
A quirk of some older firmwares that report endpoint pipe type as PIPE_BULK but the endpoint otheriwse functions as interrupt. Check if usb_endpoint_type is USB_ENDPOINT_XFER_BULK and set as usb_rcvbulkpipe. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc: stable@vger.kernel.org

[PATCH] af9035: new IDs: add support for PCTV 78e and PCTV 79e

2014-08-05 Thread Malcolm Priestley
add the following IDs USB_PID_PCTV_78E (0x025a) for PCTV 78e USB_PID_PCTV_79E (0x0262) for PCTV 79e For these it9135 devices. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc: Antti Palosaari cr...@iki.fi Cc: stable@vger.kernel.org # v3.14+ --- drivers/media/dvb-core/dvb-usb-ids.h | 2

[PATCH] [stable rebased backport 3.15] staging: vt6655: Fix Warning on boot handle_irq_event_percpu.

2014-08-05 Thread Malcolm Priestley
spin_lock_irqsave appears to fix this. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc: stable@vger.kernel.org # v3.10+ Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/vt6655/device_main.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff

Re: [PATCH 1/2] staging: vt6655: Fix Warning on boot handle_irq_event_percpu.

2014-07-24 Thread Malcolm Priestley
On 24/07/14 00:12, Greg KH wrote: On Wed, Jul 23, 2014 at 09:35:11PM +0100, Malcolm Priestley wrote: WARNING: CPU: 0 PID: 929 at /home/apw/COD/linux/kernel/irq/handle.c:147 handle_irq_event_percpu+0x1d1/0x1e0() irq 17 handler device_intr+0x0/0xa80 [vt6655_stage] enabled interrupts Using

[PATCH 1/2] staging: vt6655: Fix Warning on boot handle_irq_event_percpu.

2014-07-23 Thread Malcolm Priestley
WARNING: CPU: 0 PID: 929 at /home/apw/COD/linux/kernel/irq/handle.c:147 handle_irq_event_percpu+0x1d1/0x1e0() irq 17 handler device_intr+0x0/0xa80 [vt6655_stage] enabled interrupts Using spin_lock_irqsave appears to fix this. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc: stable

[PATCH 2/2] staging: vt6655: Fix disassociated messages every 10 seconds

2014-07-23 Thread Malcolm Priestley
byReAssocCount is incremented every second resulting in disassociated message being send every 10 seconds whether connection or not. byReAssocCount should only advance while eCommandState is in WLAN_ASSOCIATE_WAIT Change existing scope to if condition. Signed-off-by: Malcolm Priestley tvbox

[PATCH] [stable back port for = 3.8] staging: vt6656: [BUG] Fix for TX USB resets from vendors driver.

2013-12-01 Thread Malcolm Priestley
MESSAGE_REQUEST_MEM, 1, (PBYTE) byData); return TRUE;//ntStatus; A back port patch is needed for kernels less than 3.10. Signed-off-by: Malcolm Priestley tvbox...@gmail.com Cc: stable@vger.kernel.org

Re: [PATCH for stable/back-port] staging: vt6656: fix headers - key.c only

2013-01-13 Thread Malcolm Priestley
On Sun, 2013-01-13 at 15:26 +, Ben Hutchings wrote: On Sun, 2012-12-30 at 15:01 +, Malcolm Priestley wrote: On Sun, 2012-12-30 at 00:50 +0100, Ben Hutchings wrote: On Sat, 2012-12-29 at 13:10 +, Malcolm Priestley wrote: shorted back-ported version of upstream commit

Re: [PATCH for stable/back-port] staging: vt6656: fix headers - key.c only

2012-12-30 Thread Malcolm Priestley
On Sun, 2012-12-30 at 10:27 -0500, Ben Collins wrote: On Dec 29, 2012, at 6:50 PM, Ben Hutchings b...@decadent.org.uk wrote: On Sat, 2012-12-29 at 13:10 +, Malcolm Priestley wrote: shorted back-ported version of upstream commit 11d404cb56ecd53bb23499897fbe7be1a9ac4827 staging

Re: [PATCH upstream for stable 2/8] staging: vt6656: 64 bit- Correctly address void structure.

2012-12-28 Thread Malcolm Priestley
On Fri, 2012-12-28 at 00:52 +0100, Ben Hutchings wrote: On Thu, 2012-12-27 at 22:47 +, Malcolm Priestley wrote: On Thu, 2012-12-27 at 20:09 +0100, Ben Hutchings wrote: On Thu, 2012-12-27 at 13:01 +, Malcolm Priestley wrote: upstream commit

[PATCH upstream for stable 3/8]staging: vt6656: 64bit fixes: dpc.c incorrect addressing of void structure.

2012-12-27 Thread Malcolm Priestley
upstream commit eb304bddc47b59927b650d43c3f35b9266c807a9 Tested on kernels 2.6.35, 3.0, 3.2, 3.5 3.7 staging: vt6656: 64bit fixes: dpc.c incorrect addressing of void structure. Fixes the deadlock on 64 bit. Cc: sta...@kernel.org # 2.6.35+ Signed-off-by: Malcolm Priestley tvbox

[PATCH upstream for stable 1/8] staging: vt6656: [BUG] out of bound array reference in RFbSetPower.

2012-12-27 Thread Malcolm Priestley
-by: Malcolm Priestley tvbox...@gmail.com Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c index 593cdc7..74c0598 100644 --- a/drivers/staging/vt6656/rf.c +++ b/drivers/staging/vt6656/rf.c @@ -769,6 +769,9 @@ BYTEbyPwr

[PATCH upstream for stable 4/8]staging: vt6656: 64 bit fixes: use u32 for QWORD definition.

2012-12-27 Thread Malcolm Priestley
upstream commit a552397d5e4ef0cc0bd3e9595d6acc9a3b381171 Tested on kernels 2.6.35, 3.0, 3.2, 3.5 3.7 staging: vt6656: 64 bit fixes: use u32 for QWORD definition. Size of long issues replace with u32. Cc: sta...@kernel.org # 2.6.35+ Signed-off-by: Malcolm Priestley tvbox...@gmail.com

[PATCH upstream for stable 2/8] staging: vt6656: 64 bit- Correctly address void structure.

2012-12-27 Thread Malcolm Priestley
upstream commit e2efba763b472835fdface597fe2216b3403967e Tested on kernels 2.6.35, 3.0, 3.2, 3.5 3.7 staging: vt6656: 64 bit- Correctly address void structure. Fixes 64 bit deadlock on successful association. Cc: sta...@kernel.org # 2.6.35+ Signed-off-by: Malcolm Priestley tvbox

[PATCH upstream for stable 5/8]staging: vt6656: 64 bit fixes : correct all type sizes

2012-12-27 Thread Malcolm Priestley
+ Signed-off-by: Malcolm Priestley tvbox...@gmail.com Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org diff --git a/drivers/staging/vt6656/ttype.h b/drivers/staging/vt6656/ttype.h index 0f70562c..dfbf747 100644 --- a/drivers/staging/vt6656/ttype.h +++ b/drivers/staging/vt6656/ttype.h @@ -44,9

[PATCH upstream for stable 6/8]staging: vt6656: 64 bit fixes: fix long warning messages.

2012-12-27 Thread Malcolm Priestley
from patch [PATCH 08/14] staging: vt6656: 64 bit fixes : correct all type sizes Cc: sta...@kernel.org # 2.6.35+ Signed-off-by: Malcolm Priestley tvbox...@gmail.com Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org diff --git a/drivers/staging/vt6656/dpc.c b/drivers/staging/vt6656

[PATCH upstream for stable 7/8]staging: vt6656: 64bit fixes: key.c/h change unsigned long to u32

2012-12-27 Thread Malcolm Priestley
upstream commit c0d05b305b00c698b0a8c1b3d46c9380bce9db45 Tested on kernel 2.6.35, 3.0, 3.2, 3.5 3.7 staging: vt6656: 64bit fixes: key.c/h change unsigned long to u32 Fixes long issues. Cc: sta...@kernel.org # 2.6.35+ Signed-off-by: Malcolm Priestley tvbox...@gmail.com Signed-off

[PATCH upstream for stable 8/8]staging: vt6656: 64bit fixes: vCommandTimerWait change calculation of timer.

2012-12-27 Thread Malcolm Priestley
on 64 bit. A calculation of (MSecond * HZ) / 1000 appears to run satisfactory. Change BSSIDInfoCount to u32. After this patch the driver can be successfully connect on little endian 64/32 bit systems. Cc: sta...@kernel.org # 2.6.35+ Signed-off-by: Malcolm Priestley tvbox

Re: [PATCH upstream for stable 2/8] staging: vt6656: 64 bit- Correctly address void structure.

2012-12-27 Thread Malcolm Priestley
On Thu, 2012-12-27 at 20:09 +0100, Ben Hutchings wrote: On Thu, 2012-12-27 at 13:01 +, Malcolm Priestley wrote: upstream commit e2efba763b472835fdface597fe2216b3403967e Tested on kernels 2.6.35, 3.0, 3.2, 3.5 3.7 staging: vt6656: 64 bit- Correctly address void structure

Re: [stable for 3.2][patch] Kernel 3.2 add support for IT9135 chip version 2 devices.

2012-04-10 Thread Malcolm Priestley
On Tue, 2012-04-10 at 16:10 -0700, Greg KH wrote: On Sun, Apr 01, 2012 at 08:36:15AM -0700, Greg KH wrote: On Sun, Apr 01, 2012 at 02:30:54PM +0100, Malcolm Priestley wrote: Originally, IT9135 chip version 2 devices were never intended to be supported in kernel 3.2 as they were

[stable for 3.2][patch] Kernel 3.2 add support for IT9135 chip version 2 devices.

2012-04-01 Thread Malcolm Priestley
: it913x v1.23 use it913x_config.chip_ver to select firmware Cc: stable@vger.kernel.org # .32.x: fc594e3e5196d4cf7ace7735eeca399f7a80868b: sched: it913x ver 1.24 Make 0x60 default on version 2 devices Cc: stable@vger.kernel.org # .32.x Signed-off-by: Malcolm Priestley tvbox...@gmail.com