[PATCH-v4.1.y] target: Fix v4.1 UNIT_ATTENTION se_node_acl->device_list[] NULL pointer

2015-09-23 Thread Nicholas A. Bellinger
From: Nicholas Bellinger <n...@linux-iscsi.org> This patch fixes a v4.1 only regression bug as reported by Martin where UNIT_ATTENTION checking for pre v4.2-rc1 RCU conversion code legacy se_node_acl->device_list[] was hitting a NULL pointer dereference in: [ 1858.639654] CPU: 2 PID:

Re: [PATCH-v3.10.y] iscsi-target: Fix iscsit_start_kthreads failure OOPs

2015-08-13 Thread Nicholas A. Bellinger
On Thu, 2015-08-13 at 17:57 -0700, Greg-KH wrote: On Thu, Aug 13, 2015 at 05:48:26PM -0700, Nicholas A. Bellinger wrote: On Thu, 2015-08-13 at 17:45 -0700, Greg-KH wrote: On Thu, Aug 13, 2015 at 08:12:10PM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org

Re: Stable backports for qla2xxx target mode

2015-08-13 Thread Nicholas A. Bellinger
On Thu, 2015-08-13 at 17:49 -0700, Greg KH wrote: On Thu, Aug 13, 2015 at 02:00:45PM -0700, Nicholas A. Bellinger wrote: Hi Greg-KH, This is a follow up on a handful of 'WTF' emails for some of the recent qla2xxx target patches from v4.2-rc5 CC'ed for v3.18.y stable. a6ca8878

Re: [PATCH-v3.10.y] iscsi-target: Fix iscsit_start_kthreads failure OOPs

2015-08-13 Thread Nicholas A. Bellinger
On Thu, 2015-08-13 at 17:45 -0700, Greg-KH wrote: On Thu, Aug 13, 2015 at 08:12:10PM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch fixes a regression introduced with the following commit in v4.0-rc1 code, where a iscsit_start_kthreads

[PATCH-v3.10.y] iscsi-target: Stable backports

2015-08-13 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hi Greg-KH, Here is the remaining iscsi-target stable backport patch that has been updated to apply against v3.10.86. Please apply to queue-3.10. Thank you, Nicholas Bellinger (1): iscsi-target: Fix iscsit_start_kthreads failure OOPs drivers

[PATCH-v3.10.y] iscsi-target: Fix iscsit_start_kthreads failure OOPs

2015-08-13 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch fixes a regression introduced with the following commit in v4.0-rc1 code, where a iscsit_start_kthreads() failure triggers a NULL pointer dereference OOPs: commit 88dcd2dab5c23b1c9cfc396246d8f476c872f0ca Author: Nicholas Bellinger

[PATCH-v3.14.y] iscsi-target: Stable backports

2015-08-13 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hi Greg-KH, Here is the remaining iscsi-target stable backport patch that has been updated to apply against v3.14.50. Please apply to queue-3.14. Thank you, Nicholas Bellinger (1): iscsi-target: Fix iscsit_start_kthreads failure OOPs drivers

[PATCH-v3.14.y] iscsi-target: Fix iscsit_start_kthreads failure OOPs

2015-08-13 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch fixes a regression introduced with the following commit in v4.0-rc1 code, where a iscsit_start_kthreads() failure triggers a NULL pointer dereference OOPs: commit 88dcd2dab5c23b1c9cfc396246d8f476c872f0ca Author: Nicholas Bellinger

[PATCH-v3.14.y 0/8] Stable backport for dcache shrink list corruption

2015-08-13 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hi Greg-KH, Al, Co, So I've recently been repeatedly hitting the same dcache shrink list corruption bug on v3.14.47 that has been addressed in = v3.15 code, but it appears only one of the fixes: commit 22213318af7ae265bc6cd8aef2febbc2d69a2440

[PATCH-v3.14.y 1/8] fold d_kill() and d_free()

2015-08-13 Thread Nicholas A. Bellinger
From: Al Viro v...@zeniv.linux.org.uk commit 03b3b889e79cdb6b806fc0ba9be0d71c186bbfaa upstream. Signed-off-by: Al Viro v...@zeniv.linux.org.uk --- fs/dcache.c | 77 +++-- 1 file changed, 24 insertions(+), 53 deletions(-) diff --git

[PATCH-v3.14.y 2/8] fold try_prune_one_dentry()

2015-08-13 Thread Nicholas A. Bellinger
From: Al Viro v...@zeniv.linux.org.uk commit 5c47e6d0ad608987b91affbcf7d1fc12dfbe8fb4 upstream. Signed-off-by: Al Viro v...@zeniv.linux.org.uk --- fs/dcache.c | 75 + 1 file changed, 25 insertions(+), 50 deletions(-) diff --git

[PATCH-v3.14.y 5/8] dentry_kill(): don't try to remove from shrink list

2015-08-13 Thread Nicholas A. Bellinger
From: Al Viro v...@zeniv.linux.org.uk commit 41edf278fc2f042f4e22a12ed87d19c5201210e1 upstream. If the victim in on the shrink list, don't remove it from there. If shrink_dentry_list() manages to remove it from the list before we are done - fine, we'll just free it as usual. If not - mark it

[PATCH-v3.14.y 8/8] dcache: don't need rcu in shrink_dentry_list()

2015-08-13 Thread Nicholas A. Bellinger
From: Miklos Szeredi mszer...@suse.cz commit 60942f2f235ce7b817166cdf355eed729094834d upstream. Since now the shrink list is private and nobody can free the dentry while it is on the shrink list, we can remove RCU protection from this. Signed-off-by: Miklos Szeredi mszer...@suse.cz

[PATCH-v3.14.y 7/8] more graceful recovery in umount_collect()

2015-08-13 Thread Nicholas A. Bellinger
From: Al Viro v...@zeniv.linux.org.uk commit 9c8c10e262e0f62cb2530f1b076de979123183dd upstream. Start with shrink_dcache_parent(), then scan what remains. First of all, BUG() is very much an overkill here; we are holding -s_umount, and hitting BUG() means that a lot of interesting stuff will be

[PATCH-v3.14.y 3/8] new helper: dentry_free()

2015-08-13 Thread Nicholas A. Bellinger
From: Al Viro v...@zeniv.linux.org.uk commit b4f0354e968f5fabd39bc85b99fedae4a97589fe upstream. The part of old d_free() that dealt with actual freeing of dentry. Taken out of dentry_kill() into a separate function. Signed-off-by: Al Viro v...@zeniv.linux.org.uk --- fs/dcache.c | 15

[PATCH-v3.14.y 4/8] expand the call of dentry_lru_del() in dentry_kill()

2015-08-13 Thread Nicholas A. Bellinger
From: Al Viro v...@zeniv.linux.org.uk commit 01b6035190b024240a43ac1d8e9c6f964f5f1c63 upstream. Signed-off-by: Al Viro v...@zeniv.linux.org.uk --- fs/dcache.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/dcache.c b/fs/dcache.c index 3a0f252..16f9066 100644 ---

[PATCH-v3.14.y 6/8] don't remove from shrink list in select_collect()

2015-08-13 Thread Nicholas A. Bellinger
From: Al Viro v...@zeniv.linux.org.uk commit fe91522a7ba82ca1a51b07e19954b3825e4aaa22 upstream. If we find something already on a shrink list, just increment data-found and do nothing else. Loops in shrink_dcache_parent() and check_submounts_and_drop() will do the right thing -

Stable backports for qla2xxx target mode

2015-08-13 Thread Nicholas A. Bellinger
Hi Greg-KH, This is a follow up on a handful of 'WTF' emails for some of the recent qla2xxx target patches from v4.2-rc5 CC'ed for v3.18.y stable. a6ca8878 qla2xxx: delay plogi/prli ack until existing sessions are deleted daddf5cf qla2xxx: Abort stale cmds on qla_tgt_wq when plogi arrive

Re: Stable backports for qla2xxx target mode

2015-08-13 Thread Nicholas A. Bellinger
On Thu, 2015-08-13 at 18:13 -0700, Nicholas A. Bellinger wrote: On Thu, 2015-08-13 at 18:09 -0700, Greg KH wrote: On Thu, Aug 13, 2015 at 05:55:48PM -0700, Nicholas A. Bellinger wrote: On Thu, 2015-08-13 at 17:49 -0700, Greg KH wrote: On Thu, Aug 13, 2015 at 02:00:45PM -0700, Nicholas

Re: Stable backports for qla2xxx target mode

2015-08-13 Thread Nicholas A. Bellinger
On Thu, 2015-08-13 at 18:09 -0700, Greg KH wrote: On Thu, Aug 13, 2015 at 05:55:48PM -0700, Nicholas A. Bellinger wrote: On Thu, 2015-08-13 at 17:49 -0700, Greg KH wrote: On Thu, Aug 13, 2015 at 02:00:45PM -0700, Nicholas A. Bellinger wrote: Hi Greg-KH, This is a follow up

Upstream commit ce9a9fc20a - iser-target: Fix REJECT CM event use-after-free OOPs

2015-08-03 Thread Nicholas A. Bellinger
Hi Greg-KH, As requested off-list by Sagi, please hold off for the moment wrt v3.10+ stable tag for upstream: commit ce9a9fc20a78ad1e5222fae3a83d105f2d2fb9b9 Author: Nicholas Bellinger n...@linux-iscsi.org Date: Fri Jul 24 02:29:55 2015 + iser-target: Fix REJECT CM

Re: [PATCH-3.10.y 0/3] target: stable backports

2015-07-30 Thread Nicholas A. Bellinger
On Thu, 2015-07-30 at 18:03 -0700, Greg-KH wrote: On Thu, Jul 23, 2015 at 09:59:23PM -0700, Nicholas A. Bellinger wrote: Hi Greg, Likewise on this series as well. Please apply to v3.10.y queue at your earliest convenience. Sorry for the delay, both this, and the 3.14.y series

Re: [PATCH-3.10.y 0/3] target: stable backports

2015-07-23 Thread Nicholas A. Bellinger
Hi Greg, Likewise on this series as well. Please apply to v3.10.y queue at your earliest convenience. Thank you, --nab On Tue, 2015-07-07 at 05:44 +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Hi Greg-KH Sagi, Here are three outstanding backport

Re: [PATCH-3.14.y 0/3] target: stable backports

2015-07-23 Thread Nicholas A. Bellinger
Hi Greg, Would you be so kind to queue this series up for v3.14.y code..? There are a couple more fixes in flight for v4.2-rc that depend upon these patches. Thank you, --nab On Tue, 2015-07-07 at 05:40 +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Hi

[PATCH-4.0.y 0/1] target: stable backports

2015-07-06 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hi Greg-KH Sagi, Here is the one outstanding backport patch that has been updated to apply against v4.0.7. Please apply to queue-4.0. Thank you, --nab Sagi Grimberg (1): iser-target: release stale iser connections drivers/infiniband/ulp

[PATCH-4.0.y 1/1] iser-target: release stale iser connections

2015-07-06 Thread Nicholas A. Bellinger
is not already terminating (initiator driven disconnect) as this might lead us to access np_accept_mutex after the np was released in live shutdown scenarios. Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Jenny Falkovich jen...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux

[PATCH-3.14.y 3/3] iser-target: release stale iser connections

2015-07-06 Thread Nicholas A. Bellinger
is not already terminating (initiator driven disconnect) as this might lead us to access np_accept_mutex after the np was released in live shutdown scenarios. Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Jenny Falkovich jen...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux

[PATCH-3.14.y 1/3] iscsi-target: Convert iscsi_thread_set usage to kthread.h

2015-07-06 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org commit 88dcd2dab5c23b1c9cfc396246d8f476c872f0ca upstream. This patch converts iscsi-target code to use modern kthread.h API callers for creating RX/TX threads for each new iscsi_conn descriptor, and releasing associated RX/TX threads during

[PATCH-3.14.y 2/3] iser-target: Fix possible deadlock in RDMA_CM connection error

2015-07-06 Thread Nicholas A. Bellinger
-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/infiniband/ulp/isert/ib_isert.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert

[PATCH-3.14.y 0/3] target: stable backports

2015-07-06 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hi Greg-KH Sagi, Here are three outstanding backport patches that have been updated to apply against v3.14.47. Please apply to queue-3.14. Also, there are still two remaining iser-target patches marked for 3.14.y+, that currently don't apply due

[PATCH-3.10.y 2/3] iser-target: Fix possible deadlock in RDMA_CM connection error

2015-07-06 Thread Nicholas A. Bellinger
-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/infiniband/ulp/isert/ib_isert.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert

[PATCH-3.10.y 0/3] target: stable backports

2015-07-06 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hi Greg-KH Sagi, Here are three outstanding backport patches that have been updated to apply against v3.10.83. Please apply to queue-3.10. Also, there are still two remaining iser-target patches marked for 3.10.y+, that currently don't apply due

[PATCH-3.10.y 3/3] iser-target: release stale iser connections

2015-07-06 Thread Nicholas A. Bellinger
is not already terminating (initiator driven disconnect) as this might lead us to access np_accept_mutex after the np was released in live shutdown scenarios. Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Jenny Falkovich jen...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux

[PATCH-3.10.y 1/3] iscsi-target: Convert iscsi_thread_set usage to kthread.h

2015-07-06 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org commit 88dcd2dab5c23b1c9cfc396246d8f476c872f0ca upstream. This patch converts iscsi-target code to use modern kthread.h API callers for creating RX/TX threads for each new iscsi_conn descriptor, and releasing associated RX/TX threads during

Re: v4.0-rc1 + v3.19 target patches for stable

2015-03-20 Thread Nicholas A. Bellinger
Hi Greg-KH, Apologies for the delayed follow-up. Still digging out of emails after the LSF festivities last week. On Wed, 2015-03-11 at 15:06 +0100, Greg KH wrote: On Fri, Feb 27, 2015 at 11:40:20AM -0800, Nicholas A. Bellinger wrote: Hi Greg, Just a heads up on one patch in v4.0-rc1

Re: v4.0-rc1 + v3.19 target patches for stable

2015-03-04 Thread Nicholas A. Bellinger
On Tue, 2015-03-03 at 14:50 +, Luis Henriques wrote: Hi Nicholas, On Fri, Feb 27, 2015 at 11:40:20AM -0800, Nicholas A. Bellinger wrote: Hi Greg, Just a heads up on one patch in v4.0-rc1 that has been reverted in target-pending/master, that should not be going to stable

v4.0-rc1 + v3.19 target patches for stable

2015-02-27 Thread Nicholas A. Bellinger
Hi Greg, Just a heads up on one patch in v4.0-rc1 that has been reverted in target-pending/master, that should not be going to stable. iscsi-target: Avoid IN_LOGOUT failure case for iser-target

[PATCH-v3.14.y 1/1] target: Drop arbitrary maximum I/O size limit

2015-01-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org commit 046ba64285a4389ae5e9a7dfa253c6bff3d7c341 upstream. This patch drops the arbitrary maximum I/O size limit in sbc_parse_cdb(), which currently for fabric_max_sectors is hardcoded to 8192 (4 MB for 512 byte sector devices), and for hw_max_sectors

[PATCH-v3.14.y 0/1] target: Stable backports

2015-01-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hi Greg-KH, Here is the remaining stable backport patch that has been updated to apply against v3.14.29. Please apply to queue-3.14. Thank you, --nab Nicholas Bellinger (1): target: Drop arbitrary maximum I/O size limit drivers/target

Re: [patch NOT added to the 3.12 stable tree] tcm_loop: Fix wrong I_T nexus association

2015-01-30 Thread Nicholas A. Bellinger
instead. Signed-off-by: Hannes Reinecke h...@suse.de Cc: stable@vger.kernel.org # 3.0+ Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org The following patch for v3.10.y applies cleanly to v3.12.36: [PATCH-v3.10.y-v2 04/12] tcm_loop: Fix wrong I_T nexus association http

[PATCH-v3.10.y 09/12] iser-target: Fix connected_handler + teardown flow race

2015-01-30 Thread Nicholas A. Bellinger
...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/infiniband/ulp/isert/ib_isert.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c index

[PATCH-v3.10.y 03/12] vhost-scsi: Take configfs group dependency during VHOST_SCSI_SET_ENDPOINT

2015-01-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org commit ab8edab132829b26dd13db6caca3c242cce35dc1 upstream. This patch addresses a bug where individual vhost-scsi configfs endpoint groups can be removed from below while active exports to QEMU userspace still exist, resulting in an OOPs. It adds

[PATCH-v3.10.y 05/12] vhost-scsi: Add missing virtio-scsi - TCM attribute conversion

2015-01-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org commit 46243860806bdc2756f3ce8ac86b4d7c616bcd6c upstream. While looking at hch's recent conversion to drop the MSG_*_TAG definitions, I noticed a long standing bug in vhost-scsi where the VIRTIO_SCSI_S_* attribute definitions where incorrectly being

[PATCH-v3.10.y 01/12] IB/isert: Adjust CQ size to HW limits

2015-01-30 Thread Nicholas A. Bellinger
. This is the isert version of the patch that Minh Tran submitted for iser, and is simple a workaround required to function with existing ocrdma hardware. Signed-off-by: Chris Moore chris.mo...@emulex.com Reviewied-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org

[PATCH-v3.10.y 08/12] iser-target: Parallelize CM connection establishment

2015-01-30 Thread Nicholas A. Bellinger
: Acquire conn_mutex when changing connection state iser-target: Reject connect request in failure path Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/infiniband/ulp/isert/ib_isert.c | 90 - drivers

[PATCH-v3.10.y 06/12] iscsi,iser-target: Initiate termination only once

2015-01-30 Thread Nicholas A. Bellinger
get to connected (state UP). Same for the handling of REJECTED and UNREACHABLE cma events. Squashed: iscsi-target: Add call to wait_conn in establishment error flow Reported-by: Slava Shwartsman valyush...@gmail.com Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Nicholas Bellinger n

[PATCH-v3.10.y 00/12] target: Stable backports

2015-01-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hi Greg-KH, Here is the remaining stable backport patch that has been updated to apply against v3.10.65. The iser-target related changes have been tested by Chris Moore, and reviewed by Sagi Grimberg. Please apply to queue-3.10. Thank you, --nab

[PATCH-v3.10.y 02/12] ib_isert: Add max_send_sge=2 minimum for control PDU responses

2015-01-30 Thread Nicholas A. Bellinger
-by: Or Gerlitz ogerl...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/infiniband/ulp/isert/ib_isert.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/ulp/isert

[PATCH-v3.10.y 04/12] tcm_loop: Fix wrong I_T nexus association

2015-01-30 Thread Nicholas A. Bellinger
group instead of the correct one. The nexus needs to be associated with the target portal group instead. Signed-off-by: Hannes Reinecke h...@suse.de Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/target/loopback/tcm_loop.c | 29 ++--- drivers/target

[PATCH-v3.10.y 07/12] iser-target: Fix flush + disconnect completion handling

2015-01-30 Thread Nicholas A. Bellinger
...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/infiniband/ulp/isert/ib_isert.c | 50 +++-- drivers/infiniband/ulp/isert/ib_isert.h | 2 +- 2 files changed, 30 insertions(+), 22 deletions(-) diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b

[PATCH-v3.10.y-v2 03/12] vhost-scsi: Take configfs group dependency during VHOST_SCSI_SET_ENDPOINT

2015-01-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org commit ab8edab132829b26dd13db6caca3c242cce35dc1 upstream. This patch addresses a bug where individual vhost-scsi configfs endpoint groups can be removed from below while active exports to QEMU userspace still exist, resulting in an OOPs. It adds

[PATCH-v3.10.y-v2 04/12] tcm_loop: Fix wrong I_T nexus association

2015-01-30 Thread Nicholas A. Bellinger
group instead of the correct one. The nexus needs to be associated with the target portal group instead. Signed-off-by: Hannes Reinecke h...@suse.de Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/target/loopback/tcm_loop.c | 29 ++--- drivers/target

[PATCH-v3.10.y-v2 09/12] iser-target: Fix connected_handler + teardown flow race

2015-01-30 Thread Nicholas A. Bellinger
...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/infiniband/ulp/isert/ib_isert.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c index

[PATCH-v3.10.y-v2 08/12] iser-target: Parallelize CM connection establishment

2015-01-30 Thread Nicholas A. Bellinger
: Acquire conn_mutex when changing connection state iser-target: Reject connect request in failure path Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/infiniband/ulp/isert/ib_isert.c | 90 - drivers

[PATCH-v3.10.y-v2 00/12] target: Stable backports

2015-01-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hi Greg-KH, (Email hiccup, resending original series as -v2 with missing patches) Here is the remaining stable backport patch that has been updated to apply against v3.10.65. The iser-target related changes have been tested by Chris Moore

[PATCH-v3.10.y-v2 11/12] iser-target: Fix implicit termination of connections

2015-01-30 Thread Nicholas A. Bellinger
and WQ_UNBOUND_MAX_ACTIVE to spread the concurrency of release works. Reported-by: Slava Shwartsman valyush...@gmail.com Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/infiniband/ulp/isert/ib_isert.c | 45

[PATCH-v3.10.y-v2 07/12] iser-target: Fix flush + disconnect completion handling

2015-01-30 Thread Nicholas A. Bellinger
...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/infiniband/ulp/isert/ib_isert.c | 50 +++-- drivers/infiniband/ulp/isert/ib_isert.h | 2 +- 2 files changed, 30 insertions(+), 22 deletions(-) diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b

[PATCH-v3.10.y-v2 10/12] iser-target: Handle ADDR_CHANGE event for listener cm_id

2015-01-30 Thread Nicholas A. Bellinger
this is the second event a listener np cm_id may encounter, we move the np cm_id event handling to a routine. Squashed: iser-target: Move cma_id setup to a function Reported-by: Slava Shwartsman valyush...@gmail.com Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux

[PATCH-v3.10.y-v2 06/12] iscsi,iser-target: Initiate termination only once

2015-01-30 Thread Nicholas A. Bellinger
get to connected (state UP). Same for the handling of REJECTED and UNREACHABLE cma events. Squashed: iscsi-target: Add call to wait_conn in establishment error flow Reported-by: Slava Shwartsman valyush...@gmail.com Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Nicholas Bellinger n

[PATCH-v3.10.y-v2 02/12] ib_isert: Add max_send_sge=2 minimum for control PDU responses

2015-01-30 Thread Nicholas A. Bellinger
-by: Or Gerlitz ogerl...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/infiniband/ulp/isert/ib_isert.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/ulp/isert

[PATCH-v3.10.y-v2 01/12] IB/isert: Adjust CQ size to HW limits

2015-01-30 Thread Nicholas A. Bellinger
. This is the isert version of the patch that Minh Tran submitted for iser, and is simple a workaround required to function with existing ocrdma hardware. Signed-off-by: Chris Moore chris.mo...@emulex.com Reviewied-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org

[PATCH-v3.10.y-v2 05/12] vhost-scsi: Add missing virtio-scsi - TCM attribute conversion

2015-01-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org commit 46243860806bdc2756f3ce8ac86b4d7c616bcd6c upstream. While looking at hch's recent conversion to drop the MSG_*_TAG definitions, I noticed a long standing bug in vhost-scsi where the VIRTIO_SCSI_S_* attribute definitions where incorrectly being

[PATCH-v3.10.y-v2 12/12] target: Drop arbitrary maximum I/O size limit

2015-01-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org commit 046ba64285a4389ae5e9a7dfa253c6bff3d7c341 upstream. This patch drops the arbitrary maximum I/O size limit in sbc_parse_cdb(), which currently for fabric_max_sectors is hardcoded to 8192 (4 MB for 512 byte sector devices), and for hw_max_sectors

[PATCH-v3.18.y 0/1] target: Stable backports

2015-01-21 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hi Greg-KH, Hi Greg, Here are the remaining one stable backport patches that have been updated to apply against v3.18.3. Please apply to queue-3.18. Thank you! Nicholas Bellinger (1): vhost-scsi: Add missing virtio-scsi - TCM attribute

[PATCH-v3.18.y 1/1] vhost-scsi: Add missing virtio-scsi - TCM attribute conversion

2015-01-21 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org commit 46243860806bdc2756f3ce8ac86b4d7c616bcd6c upstream. While looking at hch's recent conversion to drop the MSG_*_TAG definitions, I noticed a long standing bug in vhost-scsi where the VIRTIO_SCSI_S_* attribute definitions where incorrectly being

[PATCH-v3.14.y 4/9] iscsi,iser-target: Initiate termination only once

2015-01-21 Thread Nicholas A. Bellinger
get to connected (state UP). Same for the handling of REJECTED and UNREACHABLE cma events. Squashed: iscsi-target: Add call to wait_conn in establishment error flow Reported-by: Slava Shwartsman valyush...@gmail.com Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Nicholas Bellinger n

[PATCH-v3.14.y 6/9] iser-target: Parallelize CM connection establishment

2015-01-21 Thread Nicholas A. Bellinger
: Acquire conn_mutex when changing connection state iser-target: Reject connect request in failure path Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/infiniband/ulp/isert/ib_isert.c | 84 +++-- drivers

[PATCH-v3.14.y 9/9] iser-target: Fix implicit termination of connections

2015-01-21 Thread Nicholas A. Bellinger
and WQ_UNBOUND_MAX_ACTIVE to spread the concurrency of release works. Reported-by: Slava Shwartsman valyush...@gmail.com Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/infiniband/ulp/isert/ib_isert.c | 42

[PATCH-v3.14.y 3/9] vhost-scsi: Add missing virtio-scsi - TCM attribute conversion

2015-01-21 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org commit 46243860806bdc2756f3ce8ac86b4d7c616bcd6c upstream. While looking at hch's recent conversion to drop the MSG_*_TAG definitions, I noticed a long standing bug in vhost-scsi where the VIRTIO_SCSI_S_* attribute definitions where incorrectly being

[PATCH-v3.14.y 8/9] iser-target: Handle ADDR_CHANGE event for listener cm_id

2015-01-21 Thread Nicholas A. Bellinger
this is the second event a listener np cm_id may encounter, we move the np cm_id event handling to a routine. Squashed: iser-target: Move cma_id setup to a function Reported-by: Slava Shwartsman valyush...@gmail.com Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux

[PATCH-v3.14.y 2/9] tcm_loop: Fix wrong I_T nexus association

2015-01-21 Thread Nicholas A. Bellinger
group instead of the correct one. The nexus needs to be associated with the target portal group instead. Signed-off-by: Hannes Reinecke h...@suse.de Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/target/loopback/tcm_loop.c | 66 +- drivers

[PATCH-v3.14.y 7/9] iser-target: Fix connected_handler + teardown flow race

2015-01-21 Thread Nicholas A. Bellinger
...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/infiniband/ulp/isert/ib_isert.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c index

[PATCH-v3.14.y 5/9] iser-target: Fix flush + disconnect completion handling

2015-01-21 Thread Nicholas A. Bellinger
...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/infiniband/ulp/isert/ib_isert.c | 52 +++-- drivers/infiniband/ulp/isert/ib_isert.h | 2 +- 2 files changed, 31 insertions(+), 23 deletions(-) diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b

[PATCH-v3.14.y 0/9] target: Stable backports

2015-01-21 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hi Greg-KH, Here are the remaining nine stable backport patches that have been updated to apply against v3.14.29. Please apply to queue-3.14. Thank you! --nab Hannes Reinecke (2): tcm_loop: Fixup tag handling tcm_loop: Fix wrong I_T nexus

[PATCH-v3.14.y 1/9] tcm_loop: Fixup tag handling

2015-01-21 Thread Nicholas A. Bellinger
value itself. Signed-off-by: Hannes Reinecke h...@suse.de Reviewed-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/target/loopback/tcm_loop.c | 23 --- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/drivers

Re: [PATCH v2 06/34] iser-target: Introduce state ISER_CONN_FULL_FEATURE

2014-12-02 Thread Nicholas A. Bellinger
Hi Greg Co, On Mon, 2014-12-01 at 17:30 -0800, Greg KH wrote: On Mon, Dec 01, 2014 at 07:49:56PM +0200, Sagi Grimberg wrote: ISER_CONN_UP state is not sufficient to know if we should wait for completion of flush errors and disconnected_handler event. Instead, split it to 2 states:

[PATCH-3.14.y 2/2] iser-target: Disable TX completion interrupt coalescing

2014-12-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org commit 0d0f660d882c1c02748ced13966a2413aa5d6cc2 upstream. This patch explicitly disables TX completion interrupt coalescing logic in isert_put_response() and isert_put_datain() that was originally added as an efficiency optimization in commit

[PATCH-3.14.y 0/2] iscsi-target: Stable backports

2014-12-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hi Greg-KH, Here are two upstream bugfixes that where missing from v3.14.y. Thank you, --nab Nicholas Bellinger (1): iser-target: Disable TX completion interrupt coalescing Sagi Grimberg (1): Target/iser: Fix a wrong dereference in case

[PATCH-3.14.y 1/2] Target/iser: Fix a wrong dereference in case discovery session is over iser

2014-12-01 Thread Nicholas A. Bellinger
prepare to the text pdu that will follow. Signed-off-by: Sagi Grimberg sa...@mellanox.com Reported-by: Alex Tabachnik al...@mellanox.com Cc: stable@vger.kernel.org # 3.14+ Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/infiniband/ulp/isert/ib_isert.c | 3 ++- 1 file changed, 2

Re: [PATCH 3.15 099/139] libiscsi, iser: Adjust data_length to include protection information

2014-07-02 Thread Nicholas A. Bellinger
. Signed-off-by: Sagi Grimberg sa...@mellanox.com Reviewed-by: Mike Christie micha...@cs.wisc.edu Acked-by: Mike Christie micha...@cs.wisc.edu Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org

[PATCH-v3.10.y 2/2] Target/iser: Wait for proper cleanup before unloading

2014-06-28 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org commit f5ebec9629cf78a4b8258882a9f439ab2404 uptream. disconnected_handler works are scheduled on system_wq. When attempting to unload, first make sure all works have cleaned up. Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off

[PATCH-v3.10.y 1/2] Target/iser: Improve cm events handling

2014-06-28 Thread Nicholas A. Bellinger
isert_disconnected_handler() for DEVICE_REMOVAL (Or + Sag) Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/infiniband/ulp/isert/ib_isert.c | 26 ++ drivers/infiniband/ulp/isert/ib_isert.h | 1 + 2 files changed, 15

Re: target patches for v3.15.3 + v3.14.10 + v3.10.46

2014-06-28 Thread Nicholas A. Bellinger
On Fri, 2014-06-27 at 17:15 -0700, Greg KH wrote: On Thu, Jun 26, 2014 at 10:36:23PM -0700, Nicholas A. Bellinger wrote: Hi Greg-KH, The following is the list of target commits merged for v3.16-rc1 that have yet to be included in stable, and should be included for v3.15.3 + v3.14.10

target patches for v3.15.3 + v3.14.10 + v3.10.46

2014-06-26 Thread Nicholas A. Bellinger
Hi Greg-KH, The following is the list of target commits merged for v3.16-rc1 that have yet to be included in stable, and should be included for v3.15.3 + v3.14.10 + v3.10.46 code. e346ab3 Target/iser: Bail from accept_np if np_thread is trying to close (v3.10+) 9d49f5e Target/iser: Fix hangs in

[STABLE] target: Fix NULL pointer dereference for XCOPY in target_put_sess_cmd

2014-06-17 Thread Nicholas A. Bellinger
Hi Greg, Kamal, Jiri, Please bump up the priority on the following regression fix in v3.16-rc1 that is CC'ed to = v3.12.y code: target: Fix NULL pointer dereference for XCOPY in target_put_sess_cmd

[PATCH] target: Explicitly clear ramdisk_mcp backend pages

2014-06-16 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hi Greg, Please apply the following patch to stable, as it addresses a potential security issue as reported by Jorge. Note that a different patch to address the same issue went in during v3.15-rc1 (commit 4442dc8a), but includes a bunch of other

[PATCH-v3.10.y 2/5] iser-target: Fix multi network portal shutdown regression

2014-06-10 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org commit 2363d196686e44c0158929e7cf96c8589a24a81b upstream. This patch fixes a iser-target specific regression introduced in v3.15-rc6 with: commit 14f4b54fe38f3a8f8392a50b951c8aa43b63687a Author: Sagi Grimberg sa...@mellanox.com Date: Tue Apr 29 13

[PATCH-v3.10.y 4/5] target: Allow READ_CAPACITY opcode in ALUA Standby access state

2014-06-10 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org commit e7810c2d2c37fa8e58dda74b00790dab60fe6fba upstream. This patch allows READ_CAPACITY + SAI_READ_CAPACITY_16 opcode processing to occur while the associated ALUA group is in Standby access state. This is required to avoid host side LUN probe

[PATCH-v3.10.y 0/5] target: Stable backports

2014-06-10 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hi Greg, Here are the remaining three stable backports patches that have been updated to apply against v3.10.42. Please apply to queue-3.10 ASAP. Thank you! --nab Nicholas Bellinger (3): iser-target: Fix multi network portal shutdown

[PATCH-v3.10.y 3/5] iscsi-target: Fix wrong buffer / buffer overrun in iscsi_change_param_value()

2014-06-10 Thread Nicholas A. Bellinger
at the ragged edge here) (Fix up context changes for v3.10.y - nab) Reported-by: Santosh Kulkarni santosh.kulka...@calsoftinc.com Signed-off-by: Roland Dreier rol...@purestorage.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/target/iscsi/iscsi_target_login.c | 50

[PATCH-v3.10.y 1/5] Target/iscsi,iser: Avoid accepting transport connections during stop stage

2014-06-10 Thread Nicholas A. Bellinger
iscsi_np login threads are cleaned up. (Fix up context changes for v3.10.y - nab) Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/infiniband/ulp/isert/ib_isert.c | 8 drivers/target/iscsi/iscsi_target_core.h | 1 + drivers

[PATCH-v3.10.y 5/5] target: Fix alua_access_state attribute OOPs for un-configured devices

2014-06-10 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org commit f1453773514bb8b0bba0716301e8c8f17f8d39c7 upstream. This patch fixes a OOPs where an attempt to write to the per-device alua_access_state configfs attribute at: /sys/kernel/config/target/core/$HBA/$DEV/alua/$TG_PT_GP/alua_access_state

[PATCH-v3.14.y 3/3] target: Allow READ_CAPACITY opcode in ALUA Standby access state

2014-06-09 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch allows READ_CAPACITY + SAI_READ_CAPACITY_16 opcode processing to occur while the associated ALUA group is in Standby access state. This is required to avoid host side LUN probe failures during the initial scan if an ALUA group has already

[PATCH-v3.14.y 1/3] Target/iscsi,iser: Avoid accepting transport connections during stop stage

2014-06-09 Thread Nicholas A. Bellinger
iscsi_np login threads are cleaned up. (Fix up context changes for v3.14.y - nab) Signed-off-by: Sagi Grimberg sa...@mellanox.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/infiniband/ulp/isert/ib_isert.c | 8 drivers/target/iscsi/iscsi_target_core.h | 1 + drivers

[PATCH-v3.14.y 2/3] iser-target: Fix multi network portal shutdown regression

2014-06-09 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org commit 2363d196686e44c0158929e7cf96c8589a24a81b upstream. This patch fixes a iser-target specific regression introduced in v3.15-rc6 with: commit 14f4b54fe38f3a8f8392a50b951c8aa43b63687a Author: Sagi Grimberg sa...@mellanox.com Date: Tue Apr 29 13

[PATCH-v3.14.y 0/3] target: Stable backports

2014-06-09 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hi Greg, Here are the remaining three stable backports patches that have been updated to apply against v3.14.6. Please apply to queue-3.14 ASAP. Thank you! --nab Nicholas Bellinger (2): iser-target: Fix multi network portal shutdown regression

Re: [PATCH-v3.14.y 3/3] target: Allow READ_CAPACITY opcode in ALUA Standby access state

2014-06-09 Thread Nicholas A. Bellinger
Hi Greg, On Tue, 2014-06-10 at 05:17 +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Ugh, this one causes a compile error on v3.14.6 code.. Here is the updated patch to avoid using set_ascq(). Please apply instead of the original. Thank you, --nab From

Re: FAILED: patch [PATCH] Target/iscsi,iser: Avoid accepting transport connections failed to apply to 3.14-stable tree

2014-06-04 Thread Nicholas A. Bellinger
connection request. The iscsi_np is enabled after successful transport setup, and disabled before iscsi_np login threads are cleaned up. Signed-off-by: Sagi Grimberg sa...@mellanox.com Cc: stable@vger.kernel.org # 3.10+ Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org diff --git a/drivers

Re: FAILED: patch [PATCH] Target/iscsi,iser: Avoid accepting transport connections failed to apply to 3.14-stable tree

2014-06-04 Thread Nicholas A. Bellinger
On Wed, 2014-06-04 at 11:29 -0700, Greg KH wrote: On Wed, Jun 04, 2014 at 11:18:47AM -0700, Nicholas A. Bellinger wrote: Hi Greg, On Tue, 2014-06-03 at 23:06 -0700, gre...@linuxfoundation.org wrote: The patch below does not apply to the 3.14-stable tree. If someone wants it applied

[PATCH-v3.12.y 1/2] iser-target: Match FRMR descriptors to available session tags

2014-05-06 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org commit f46d6a8a01d6bbd83a97140f30a72a89b038807b upstream. This patch changes isert_conn_create_fastreg_pool() to follow logic in iscsi_target_locate_portal() for determining how many FRMR descriptors to allocate based upon the number of possible per

  1   2   >