[PATCH] audit: Make testing for a valid loginuid explicit.

2013-05-16 Thread Richard Guy Briggs
4.6 32-bit architecture warnings. Cc: # 3.7 Reported-By: Steve Grubb Signed-off-by: "Eric W. Biederman" Tested-by: Richard Guy Briggs Signed-off-by: Eric Paris Backported-by: Richard Guy Briggs --- include/linux/audit.h |5 + include/uapi/linux/audit.h |1 + kernel/auditf

[PATCH 2/5] audit: convert PPIDs to the inital PID namespace.

2013-12-23 Thread Richard Guy Briggs
() for PPIDs to anchor all audit filters in the init_pid_ns. (informed by ebiederman's 6c621b7e) Cc: stable@vger.kernel.org Cc: Eric W. Biederman Signed-off-by: Richard Guy Briggs --- kernel/audit.c |4 ++-- kernel/auditsc.c |2 +- 2 files changed, 3 insertions(+), 3 deletions(-)

[PATCH 1/5] pid: get pid_t ppid of task in init_pid_ns

2013-12-23 Thread Richard Guy Briggs
(informed by ebiederman's 6c621b7e) Cc: stable@vger.kernel.org Cc: Eric W. Biederman Signed-off-by: Richard Guy Briggs --- include/linux/sched.h | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/include/linux/sched.h b/include/linux/sched.

[PATCH] audit: cast decimal constant for invalid uid to unsigned

2013-05-20 Thread Richard Guy Briggs
ng. Cc: stable@vger.kernel.org # v3.9 Cc: Eric Paris Cc: Stephen Rothwell Cc: "Eric W. Biederman" Signed-off-by: Richard Guy Briggs --- include/uapi/linux/audit.h |2 ++ kernel/auditfilter.c |2 +- 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/include/uap

[PATCH] [STABLE] audit: remove superfluous new- prefix in AUDIT_LOGIN messages

2014-06-17 Thread Richard Guy Briggs
The new- prefix on ses and auid are un-necessary and break ausearch. Upstream-commit: aa589a1 Cc: stable@vger.kernel.org # v3.14-rc1 to v3.14 Reported-by: Steve Grubb Signed-off-by: Richard Guy Briggs --- kernel/auditsc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH 1/5] pid: get pid_t ppid of task in init_pid_ns

2014-02-19 Thread Richard Guy Briggs
(informed by ebiederman's 6c621b7e) Cc: stable@vger.kernel.org Cc: Eric W. Biederman Signed-off-by: Richard Guy Briggs --- include/linux/sched.h | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/include/linux/sched.h b/include/linux/sched.h index 5

[PATCH 2/5] audit: convert PPIDs to the inital PID namespace.

2014-02-19 Thread Richard Guy Briggs
() for PPIDs to anchor all audit filters in the init_pid_ns. (informed by ebiederman's 6c621b7e) Cc: stable@vger.kernel.org Cc: Eric W. Biederman Signed-off-by: Richard Guy Briggs --- kernel/audit.c |4 ++-- kernel/auditsc.c |2 +- 2 files changed, 3 insertions(+), 3 deletions(-)

Re: [PATCH 7/7] pid: get pid_t ppid of task in init_pid_ns

2014-02-21 Thread Richard Guy Briggs
On 14/02/20, Oleg Nesterov wrote: > On 01/23, Richard Guy Briggs wrote: > > > > Added the functions task_ppid_nr_ns() and task_ppid_nr() to abstract the > > lookup > > of the PPID (real_parent's pid_t) of a process, including rcu locking, in > > the &

[PATCH] audit: don't generate loginuid log when audit disabled

2014-03-03 Thread Richard Guy Briggs
From: Gao feng If audit is disabled, we shouldn't generate loginuid audit log. Cc: stable@vger.kernel.org # v3.13-rc1 Acked-by: Eric Paris Signed-off-by: Gao feng Signed-off-by: Richard Guy Briggs Signed-off-by: Eric Paris --- Already upstream in 3.14-rc1. This fixes a bug introduc

Re: [PATCH] audit: don't generate loginuid log when audit disabled

2014-03-03 Thread Richard Guy Briggs
On 14/03/03, Greg KH wrote: > On Mon, Mar 03, 2014 at 05:30:50PM -0500, Richard Guy Briggs wrote: > > From: Gao feng > > > > If audit is disabled, we shouldn't generate loginuid audit > > log. > > > > Cc: stable@vger.kernel.org # v3.13-rc1 > >

[PATCH 7/7] pid: get pid_t ppid of task in init_pid_ns

2014-01-23 Thread Richard Guy Briggs
(informed by ebiederman's 6c621b7e) Cc: stable@vger.kernel.org Cc: Eric W. Biederman Signed-off-by: Richard Guy Briggs --- include/linux/sched.h | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/include/linux/sched.h b/include/linux/sched.h index 2

[PATCH] audit: restore order of tty and ses fields in log output

2014-01-24 Thread Richard Guy Briggs
When being refactored from audit_log_start() to audit_log_task_info(), in commit e23eb920 the tty and ses fields in the log output got transposed. Restore to original order to avoid breaking search tools. Cc: stable@vger.kernel.org # v3.6 Signed-off-by: Richard Guy Briggs Signed-off-by: Eric

[PATCH][STABLE] audit: correct AUDIT_GET_FEATURE return message type

2014-10-29 Thread Richard Guy Briggs
-paste-eo in commit b0fed40. Reported-by: Steve Grubb Cc: stable@vger.kernel.org # v3.13-rc1 Signed-off-by: Richard Guy Briggs --- kernel/audit.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/audit.c b/kernel/audit.c index d20f00f..3a80abb 100644 --- a/kernel

Re: [PATCH][STABLE] audit: correct AUDIT_GET_FEATURE return message type

2014-10-29 Thread Richard Guy Briggs
On 14/10/29, Greg KH wrote: > On Wed, Oct 29, 2014 at 09:35:06AM -0400, Richard Guy Briggs wrote: > > When an AUDIT_GET_FEATURE message is sent from userspace to the kernel, it > > should reply with a message tagged as an AUDIT_GET_FEATURE type with a > > struct > >

Re: [PATCH][STABLE] audit: correct AUDIT_GET_FEATURE return message type

2014-10-29 Thread Richard Guy Briggs
On 14/10/29, Richard Guy Briggs wrote: > On 14/10/29, Greg KH wrote: > > On Wed, Oct 29, 2014 at 09:35:06AM -0400, Richard Guy Briggs wrote: > > > When an AUDIT_GET_FEATURE message is sent from userspace to the kernel, it > > > should reply with a message tagged as an AU

Re: FAILED: patch "[PATCH] audit: convert PPIDs to the inital PID namespace." failed to apply to 3.14-stable tree

2014-05-02 Thread Richard Guy Briggs
riginal commit in Linus's tree -- > > From c92cdeb45eea38515e82187f48c2e4f435fb4e25 Mon Sep 17 00:00:00 2001 > From: Richard Guy Briggs > Date: Tue, 10 Dec 2013 22:10:41 -0500 > Subject: [PATCH] audit: convert PPIDs to the inital PID namespace. > > sys_getppid()

Re: FAILED: patch "[PATCH] audit: convert PPIDs to the inital PID namespace." failed to apply to 3.14-stable tree

2014-05-04 Thread Richard Guy Briggs
On 14/05/04, Ben Hutchings wrote: > On Sat, 2014-05-03 at 14:28 -0400, Greg KH wrote: > > On Sat, May 03, 2014 at 02:18:30PM -0400, Greg KH wrote: > > > On Fri, May 02, 2014 at 12:32:56PM -0400, Richard Guy Briggs wrote: > > > > On 14/05/01, gr

[PATCH] audit: restore AUDIT_LOGINUID unset ABI

2014-09-17 Thread Richard Guy Briggs
: exit,never auid=-1 (0x) syscall=all Cc: stable@vger.kernel.org # v3.10-rc1+ Signed-off-by: Richard Guy Briggs --- kernel/auditfilter.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c index 40ed981..d0715a7 100644

Re: [patch NOT added to the 3.12 stable tree] audit: don't generate loginuid log when audit disabled

2014-03-23 Thread Richard Guy Briggs
ackported to 3.12. > === > > commit c2412d91c68426e22add16550f97ae5cd988a159 upstream. > > If audit is disabled, we shouldn't generate loginuid audit > log. > > Acked-by: Eric Paris > Signed-off-by: Gao feng > Signed-off-by: Richard Guy Briggs > Signed-off-by: Eric Paris

[PATCH 2/2] audit: restore AUDIT_LOGINUID unset ABI

2014-12-11 Thread Richard Guy Briggs
: exit,never auid=-1 (0x) syscall=all Tag it so that it is reported the same way it was set. Cc: stable@vger.kernel.org # v3.10-rc1+ Signed-off-by: Richard Guy Briggs --- include/linux/audit.h |3 +++ kernel/auditfilter.c | 10 +- 2 files changed, 12 insertions(+), 1

Re: [PATCH][RESEND 2] Revert "AUDIT: Allow login in non-init namespaces"

2015-01-13 Thread Richard Guy Briggs
eturn EPERM > - * userspace will reject all logins. This should be removed when we > - * support non init namespaces!! > - */ > if (current_user_ns() != &init_user_ns) > - return -ECONNREFUSED; > + return -EPERM; > > switch (msg_type) {

Re: [PATCH][RESEND 2] Revert "AUDIT: Allow login in non-init namespaces"

2015-01-13 Thread Richard Guy Briggs
On 15/01/13, Richard Guy Briggs wrote: > On 15/01/08, Calvin Owens wrote: > > This reverts 543bc6a1a987 "AUDIT: Allow login in non-init namespaces". > > > > This commit incorrectly assumes that libpam treats -ECONNREFUSED as > > an indicator that audit is di