[PATCH] md/raid5: fix locking in handle_stripe_clean_event()

2015-10-28 Thread Roman Gushchin
rim support. The following script was used: for i in `seq 1 32`; do dd if=/dev/zero of=large$i bs=10M count=100 & done Signed-off-by: Roman Gushchin Cc: Neil Brown Cc: Shaohua Li Cc: linux-r...@vger.kernel.org Cc: # 3.10 - 3.19 --- drivers/md/raid5.c | 6 -- 1 file changed, 4 insert

Re: [PATCH] md/raid5: fix locking in handle_stripe_clean_event()

2015-10-29 Thread Roman Gushchin
29.10.2015, 03:35, "Neil Brown" : > On Wed, Oct 28 2015, Roman Gushchin wrote: > >>  After commit 566c09c53455 ("raid5: relieve lock contention in >> get_active_stripe()") >>  __find_stripe() is called under conf->hash_locks + hash. >>  But

[PATCH] md/raid5: fix locking in handle_stripe_clean_event()

2015-11-06 Thread Roman Gushchin
6 ssd disks. The devices_handle_discard_safely option should be set to enable trim support. The following script was used: for i in `seq 1 32`; do dd if=/dev/zero of=large$i bs=10M count=100 & done Signed-off-by: Roman Gushchin Fixes: 566c09c53455 ("raid5: relieve lock contention in get_active_stripe()"

Re: [ 072/102] ipv6: do not clear pinet6 field

2013-05-21 Thread Roman Gushchin
Hi, all! I think, it's good, but not enough. We still can't rely on the sk->sk_family field by dereferencing the inet_sk(sk)->pinet6 field, because we can set the sk_family field to the PF_INET6 value before setting pinet6 to an appropriate value (assuming it is NULL just because it was not a

Re: [ 072/102] ipv6: do not clear pinet6 field

2013-05-22 Thread Roman Gushchin
On 22.05.2013 01:47, Eric Dumazet wrote: On Tue, 2013-05-21 at 15:44 +0400, Roman Gushchin wrote: Hi, all! I think, it's good, but not enough. We still can't rely on the sk->sk_family field by dereferencing the inet_sk(sk)->pinet6 field, because we can set the sk_family field

Re: WTF: patch "[PATCH] net_dma: simple removal" was seriously submitted to be applied to the 3.17-stable tree?

2014-10-23 Thread Roman Gushchin
> That find by Roman discovered that even though NET_DMA was marked > broken we were still attempting to pin pages for dma offload. Not really. Actually I had NET_DMA in my config by mistake. -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majord..

[PATCH] mm: fix arithmetic overflow in __vm_enough_memory()

2015-01-29 Thread Roman Gushchin
tiple times (with VM_SHARED flag) 3) try to malloc() large amount of memory It also can be reproduced on newer kernels, but miss-configured sysctl_user_reserve_kbytes is required. Fix this issue by switching to signed arithmetic here. Signed-off-by: Roman Gushchin Cc: Andrew Morton Cc: And

Re: [PATCH] mm: fix arithmetic overflow in __vm_enough_memory()

2015-01-30 Thread Roman Gushchin
29.01.2015, 22:57, "Andrew Shewmaker" : > On Thu, Jan 29, 2015 at 04:06:03PM +0300, Roman Gushchin wrote: >>  I noticed, that "allowed" can easily overflow by falling below 0, >>  because (total_vm / 32) can be larger than "allowed". The problem &g

[PATCH] mm/nommu.c: fix arithmetic overflow in __vm_enough_memory()

2015-01-30 Thread Roman Gushchin
tiple times (with VM_SHARED flag) 3) try to malloc() large amount of memory It also can be reproduced on newer kernels, but miss-configured sysctl_user_reserve_kbytes is required. Fix this issue by switching to signed arithmetic here. Signed-off-by: Roman Gushchin Cc: Andrew Morton Cc: And