Re: [PATCH] sound: depend on ZONE_DMA

2015-11-15 Thread Takashi Iwai
On Sun, 15 Nov 2015 11:53:11 +0100, Boaz Harrosh wrote: > > On 11/12/2015 10:38 PM, Takashi Iwai wrote: > > On Thu, 12 Nov 2015 21:13:57 +0100, > > Dan Williams wrote: > >> > >> There are several sound drivers that 'select ZONE_DMA'. This is

Re: [PATCH] sound: depend on ZONE_DMA

2015-11-16 Thread Takashi Iwai
On Mon, 16 Nov 2015 09:58:28 +0100, Boaz Harrosh wrote: > > On 11/16/2015 09:40 AM, Takashi Iwai wrote: > > On Sun, 15 Nov 2015 11:53:11 +0100, > > Boaz Harrosh wrote: > >> > >> On 11/12/2015 10:38 PM, Takashi Iwai wrote: > >>> On Thu, 12 N

Re: [PATCH] ALSA: hda - Fix headphone noise after Dell XPS 13 resume back from S3

2015-11-23 Thread Takashi Iwai
On Tue, 24 Nov 2015 04:08:18 +0100, Hui Wang wrote: > > We have a machine Dell XPS 13 with the codec alc256, after resume back > from S3, the headphone has noise when play sound. > > Through comparing with the coeff vaule before and after S3, we found > restoring a coeff register will help remove

Re: [PATCH] ALSA: hda - Add inverted dmic for Packard Bell DOTS

2015-12-07 Thread Takashi Iwai
On Mon, 07 Dec 2015 11:29:31 +0100, David Henningsson wrote: > > On the internal mic of the Packard Bell DOTS, one channel > has an inverted signal. Add a quirk to fix this up. > > Cc: stable@vger.kernel.org > BugLink: https://bugs.launchpad.net/bugs/1523232 > Signed-off-by: David Henningsson A

Re: [PATCH] ALSA: hda - Fixing speaker noise on two thinkpad machines

2015-12-07 Thread Takashi Iwai
On Mon, 07 Dec 2015 15:31:52 +0100, Hui Wang wrote: > > Disable the aamix can fix this problem. Which codec do these machines have? Takashi > > Cc: stable@vger.kernel.org > BugLink: https://bugs.launchpad.net/bugs/1523517 > Signed-off-by: Hui Wang > --- > sound/pci/hda/patch_realtek.c | 9 +

Re: [alsa-devel] [PATCH] ALSA: hda - Fixing speaker noise on two thinkpad machines

2015-12-07 Thread Takashi Iwai
On Mon, 07 Dec 2015 15:38:05 +0100, Hui Wang wrote: > > On 12/07/2015 10:35 PM, Takashi Iwai wrote: > > On Mon, 07 Dec 2015 15:31:52 +0100, > > Hui Wang wrote: > >> Disable the aamix can fix this problem. > > Which codec do these machines have? > > C

Re: [alsa-devel] [PATCH] ALSA: hda - Fixing speaker noise on two thinkpad machines

2015-12-07 Thread Takashi Iwai
On Mon, 07 Dec 2015 16:01:02 +0100, Hui Wang wrote: > > On 12/07/2015 10:47 PM, Takashi Iwai wrote: > > On Mon, 07 Dec 2015 15:38:05 +0100, > > Hui Wang wrote: > >> On 12/07/2015 10:35 PM, Takashi Iwai wrote: > >>> On Mon, 07 Dec 2015 15:31:52 +0100, > &g

Re: [PATCH v2] ALSA: hda - Fixing speaker noise on the two latest thinkpad models

2015-12-07 Thread Takashi Iwai
On Tue, 08 Dec 2015 05:27:18 +0100, Hui Wang wrote: > > We have two latest thinkpad laptop models which are all based on the > Intel skylake platforms, and all of them have the codec alc293 on > them. When the machines boot to the desktop, an greeting dialogue > shows up with the notification soun

Re: [Intel-gfx] [PATCH v5] drm/i915: Pin the ifbdev for the info->system_base GGTT mmapping

2015-12-10 Thread Takashi Iwai
On Thu, 10 Dec 2015 17:36:04 +0100, Ville Syrjälä wrote: > > On Fri, Dec 04, 2015 at 04:05:26PM +, Chris Wilson wrote: > > A long time ago (before 3.14) we relied on a permanent pinning of the > > ifbdev to lock the fb in place inside the GGTT. However, the > > introduction of stealing the BIO

Re: [PATCH 1/2 v2] ALSA: usb-audio: Add a more accurate volume quirk for AudioQuest DragonFly

2015-12-14 Thread Takashi Iwai
On Sun, 13 Dec 2015 19:49:58 +0100, Anssi Hannula wrote: > > AudioQuest DragonFly DAC reports a volume control range of 0..50 > (0x..0x0032) which in USB Audio means a range of 0 .. 0.2dB, which > is obviously incorrect and would cause software using the dB information > in e.g. volume sliders

Re: [PATCH 2/2] ALSA: usb-audio: Add sample rate inquiry quirk for AudioQuest DragonFly

2015-12-14 Thread Takashi Iwai
On Sun, 13 Dec 2015 19:49:59 +0100, Anssi Hannula wrote: > > Avoid getting sample rate on AudioQuest DragonFly as it is unsupported > and causes noisy "cannot get freq at ep 0x1" messages when playback > starts. > > Signed-off-by: Anssi Hannula > Cc: Applied, thanks. Takashi > --- > > No c

Re: [PATCH] ALSA: hda - Fix headphone mic input on a few Dell ALC293 machines

2015-12-15 Thread Takashi Iwai
On Tue, 15 Dec 2015 14:44:03 +0100, David Henningsson wrote: > > These laptops support both headphone, headset and mic modes > for the 3.5mm jack. > > Cc: stable@vger.kernel.org > BugLink: https://bugs.launchpad.net/bugs/1526330 > Signed-off-by: David Henningsson Applied, thanks. Takashi > -

Re: [PATCH] ALSA: hda/realtek - Fix silent headphone output on MacPro 4,1 (v2)

2015-12-22 Thread Takashi Iwai
ut i don't know if it has any > positive or adverse effects there or not. > > (v2) Implement feedback from Takashi Iwai: Reuse > alc889_fixup_mbp_vref and just add a new nid > 0x19 for the MacPro 4,1. > > Signed-off-by: Mario Kleiner > Cc: Applied, thanks.

Re: [PATCH 1/2] ALSA: hda - Add mic mute hotkey quirk for Lenovo ThinkCentre AIO

2015-12-23 Thread Takashi Iwai
On Thu, 24 Dec 2015 04:46:37 +0100, Hui Wang wrote: > > From: Kailang > > The Lenovo ThinkCenter AIO uses Line2 (NID 0x1b) to implement the > micmute hotkey, here we register an input device and use Line2 unsol > event to collect the hotkey pressing or releasing. > > In the meanwhile, the micmu

Re: [PATCH 1/2] ALSA: hda - Add mic mute hotkey quirk for Lenovo ThinkCentre AIO

2015-12-23 Thread Takashi Iwai
On Thu, 24 Dec 2015 07:44:22 +0100, Takashi Iwai wrote: > > On Thu, 24 Dec 2015 04:46:37 +0100, > Hui Wang wrote: > > > > From: Kailang > > > > The Lenovo ThinkCenter AIO uses Line2 (NID 0x1b) to implement the > > micmute hotkey, here we register an inp

Re: [alsa-devel] [PATCH 1/2] ALSA: hda - Add mic mute hotkey quirk for Lenovo ThinkCentre AIO

2015-12-24 Thread Takashi Iwai
On Thu, 24 Dec 2015 10:39:48 +0100, Hui Wang wrote: > > On 12/24/2015 03:45 PM, Takashi Iwai wrote: > > On Thu, 24 Dec 2015 07:44:22 +0100, > > Takashi Iwai wrote: > >> On Thu, 24 Dec 2015 04:46:37 +0100, > >> Hui Wang wrote: > >>> From: Kailang &

Re: [PATCH 2/2] ALSA: hda - Add keycode map for alc input device

2015-12-24 Thread Takashi Iwai
On Thu, 24 Dec 2015 04:46:38 +0100, Hui Wang wrote: > > Then users can remap the keycode from userspace. If without the remap, > the input device will pass KEY_MICMUTE to userspace, but in X11 layer, > it uses KEY_F20 rather than KEY_MICMUTE for XF86AudioMicMute. After > adding the keycode map, us

Re: [PATCH v2 1/2] ALSA: hda - Add mic mute hotkey quirk for Lenovo ThinkCentre AIO

2015-12-29 Thread Takashi Iwai
On Mon, 28 Dec 2015 04:35:24 +0100, Hui Wang wrote: > > From: Kailang > > The Lenovo ThinkCenter AIO uses Line2 (NID 0x1b) to implement the > micmute hotkey, here we register an input device and use Line2 unsol > event to collect the hotkey pressing or releasing. > > In the meanwhile, the micmu

Re: [PATCH] ALSA: intel8x0: Add clock quirk entry for AD1981B on IBM ThinkPad X41.

2016-03-14 Thread Takashi Iwai
gt; Cc: > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Signed-off-by: Vittorio Gambaletta > --- > > When the clock measurement doesn't fail, the `pos` variable after line 2861 > will be around 48367, but when it does fail it will be somewhere between > 45000 and 4750

[PATCH 3.9.y] ALSA: hda - Fix 3.9 regression of EAPD init on Conexant codecs

2013-05-10 Thread Takashi Iwai
patch fixes the problem by simply assuming the static EAPD on for such old Conexant codecs as we did until 3.8 kernel. Reported-and-tested-by: Christopher K. Cc: [v3.9] Signed-off-by: Takashi Iwai --- Greg, this is the revised patch to be applied cleanly to 3.9.y. sound/pci/hda

Re: [PATCH] ALSA: hda - mute LEDs on HP: also check PCI SSID

2013-01-14 Thread Takashi Iwai
At Mon, 14 Jan 2013 12:59:10 +0100, David Henningsson wrote: > > If the codec subvendor is not set to HP, maybe the PCI SSID is set > to HP. If so, there might still be a valid mute LED string in BIOS/UEFI. > > Cc: stable@vger.kernel.org > Buglink: https://bugs.launchpad.net/bugs/1099372 > Report

Re: [PATCH] ALSA: usb - fix race in creation of M-Audio Fast track pro driver

2013-01-16 Thread Takashi Iwai
At Thu, 17 Jan 2013 01:30:55 -0500 (EST), CAI Qian wrote: > > Hello Takashi and David, > > b98ae2729dea161edc96c9d177459b6c28bcbba5 > Looks applicable for the stable >= 3.2 kernels. What do you think? > It is applied and built cleanly as it-is for both 3.4.x and > 3.7.x. The only question is whe

Re: [PATCH] ALSA: hda - Fix mute led for another HP machine

2013-01-18 Thread Takashi Iwai
At Fri, 18 Jan 2013 12:00:47 +0100, David Henningsson wrote: > > This machine also has the "HP_Mute_LED_0_A" string in DMI information. > > Cc: > BugLink: https://bugs.launchpad.net/bugs/1096789 > Tested-by: Tammy Yang > Signed-off-by: David Henningsson Thanks, applied. Takashi > --- > so

Re: [PATCH 3.2.y 0/6] USB disconnect race fixes

2013-01-19 Thread Takashi Iwai
At Fri, 18 Jan 2013 14:26:55 -0600, Chris J Arges wrote: > > ALSA: usb-audio: Fix races at disconnection > From: Takashi Iwai suse.de> > commit 978520b75f0a1ce82b17e1e8186417250de6d545 upstream. > > I've noticed that this backported patch causes a kernel panic when &g

Re: [PATCH 3.2.y 0/6] USB disconnect race fixes

2013-01-21 Thread Takashi Iwai
At Sat, 19 Jan 2013 12:03:23 +0100, Takashi Iwai wrote: > > At Fri, 18 Jan 2013 14:26:55 -0600, > Chris J Arges wrote: > > > > ALSA: usb-audio: Fix races at disconnection > > From: Takashi Iwai suse.de> > > commit 978520b75f0a1ce82b17e1e8186417250de6d545

Re: [PATCH 3.2.y 0/6] USB disconnect race fixes

2013-01-22 Thread Takashi Iwai
At Tue, 22 Jan 2013 09:57:12 -0600, Chris J Arges wrote: > > On 01/21/2013 10:50 AM, Takashi Iwai wrote: > > At Sat, 19 Jan 2013 12:03:23 +0100, > > Takashi Iwai wrote: > >> > >> At Fri, 18 Jan 2013 14:26:55 -0600, > >> Chris J Arges wrote: > >&

[PATCH] ALSA: usb-audio: Fix regression by disconnection-race-fix patch

2013-01-22 Thread Takashi Iwai
reverting the shutdown flag check in that code. Reported-and-tested-by: Chris J Arges Cc: [v3.2..v3.4] Signed-off-by: Takashi Iwai --- Looking at linux-stable git tree, 3.2.y and 3.4.y are affected at least. Ben, Greg, please apply this. I'm not sure whether other trees (3.3.y, 3.5.y) al

Re: [PATCH] ALSA: hda - fix inverted internal mic on Acer AOA150/ZG5

2013-01-28 Thread Takashi Iwai
At Mon, 28 Jan 2013 05:45:47 +0100, David Henningsson wrote: > > This patch enables internal mic input on the machine. > > Cc: stable@vger.kernel.org > BugLink: https://bugs.launchpad.net/bugs/1107477 > Signed-off-by: David Henningsson Thanks, applied. Takashi > --- > sound/pci/hda/patch_re

Re: [PATCH] ALSA: hda - Fix default multichannel HDMI mapping regression

2013-02-04 Thread Takashi Iwai
At Sun, 3 Feb 2013 17:55:45 +0200, Anssi Hannula wrote: > > Commit d45e6889ee69456a4d5b1bbb32252f460cd48fa9 ("ALSA: hda - Provide > the proper channel mapping for generic HDMI driver") added support for > custom channel maps in the HDA HDMI driver. Due to a mistake in an > 'if' condition the cust

Re: [PATCH] drm/i915: write backlight harder

2013-02-06 Thread Takashi Iwai
At Wed, 6 Feb 2013 11:24:41 +0100, Daniel Vetter wrote: > > 770c12312ad617172b1a65b911d3e6564fc5aca8 is the first bad commit > commit 770c12312ad617172b1a65b911d3e6564fc5aca8 > Author: Takashi Iwai > Date: Sat Aug 11 08:56:42 2012 +0200 > > drm/i915: Fix blank p

Re: [alsa-devel] [PATCH] ALSA: hda - hdmi: Make jacks phantom, if they're not detectable

2013-02-22 Thread Takashi Iwai
At Fri, 22 Feb 2013 10:16:28 +0100, David Henningsson wrote: > > Just as for analog codecs, a jack that isn't suitable for detection > (in this case, NO_PRESENCE was set) should be a phantom Jack > instead of a normal one. > > Thanks to Raymond Yau for spotting. > > Cc: stable@vger.kernel.org >

Re: [PATCH] ALSA: hda - Fix Line Out automute on Realtek multifunction jacks

2013-11-12 Thread Takashi Iwai
At Tue, 12 Nov 2013 11:10:57 +0100, David Henningsson wrote: > > In case there is both a multifunction headset jack and a Line Out > jack, automuting was not working properly from the Line Out jack. > This patch fixes that issue. > > Cc: stable@vger.kernel.org (3.10+) > BugLink: https://bugs.laun

Re: [PATCH] ALSA: hda - Add mono speaker quirk for Dell Inspiron 5439

2013-11-28 Thread Takashi Iwai
At Fri, 29 Nov 2013 15:10:20 +0800, David Henningsson wrote: > > This machine also has mono output if run through DAC node 0x03. > > Cc: stable@vger.kernel.org (v3.10+) > BugLink: https://bugs.launchpad.net/bugs/1256212 > Tested-by: David Chen > Signed-off-by: David Henningsson Thanks, applied

Re: [Ksummit-2013-discuss] When to push bug fixes to mainline

2013-07-16 Thread Takashi Iwai
At Tue, 16 Jul 2013 00:19:16 -0700 (PDT), David Lang wrote: > > On Fri, 12 Jul 2013, Willy Tarreau wrote: > > > And maybe in the end, having 1/10 patch cause a regression is not *that* > > dramatic, and probably less than not fixing the 9 other bugs. In one case > > we rely on -stable to merge th

Re: [Ksummit-2013-discuss] When to push bug fixes to mainline

2013-07-16 Thread Takashi Iwai
At Tue, 16 Jul 2013 09:42:34 -0700 (PDT), David Lang wrote: > > On Tue, 16 Jul 2013, Takashi Iwai wrote: > > > At Tue, 16 Jul 2013 00:19:16 -0700 (PDT), > > David Lang wrote: > >> > >> On Fri, 12 Jul 2013, Willy Tarreau wrote: > >> > >>>

Re: [PATCH] ALSA: compress: fix the return value for SNDRV_COMPRESS_VERSION

2013-07-29 Thread Takashi Iwai
At Sun, 28 Jul 2013 20:04:03 +0530, Vinod Koul wrote: > > Reported-by: Haynes > CC: stable@vger.kernel.org > Signed-off-by: Vinod Koul The fix is trivial, but please give a bit more description so that people can understand what this commit does and why it's needed, without reading the code cha

Re: [PATCH] ALSA: compress: fix the return value for SNDRV_COMPRESS_VERSION

2013-07-29 Thread Takashi Iwai
At Mon, 29 Jul 2013 15:10:22 +0530, Vinod Koul wrote: > > the return value of SNDRV_COMPRESS_VERSION always return default -ENOTTY as > the > return value was never updated for this call > assign return value from put_user() > > Reported-by: Haynes > CC: stable@vger.kernel.org > Signed-off-by:

Re: FAILED: patch "[PATCH] ALSA: hiface: return correct XRUN indication" failed to apply to 3.10-stable tree

2013-07-29 Thread Takashi Iwai
as expected by snd_pcm_update_hw_ptr0(). > > Caught by sparse. > > Cc: Antonio Ospite > Signed-off-by: Eldad Zack > Cc: > Signed-off-by: Takashi Iwai > > diff --git a/sound/usb/hiface/pcm.c b/sound/usb/hiface/pcm.c > index 6430ed2a..c21a3df9 100644 > --

Re: [alsa-devel] [PATCH] Fix invalid volume resolution for Logitech HD Webcam C525

2013-08-08 Thread Takashi Iwai
At Wed, 07 Aug 2013 23:24:46 +0400, Бойко Максим wrote: > > From: Maksim Boyko > > Add the volume control quirk for avoiding the kernel warning for Logitech HD > Webcam C525. > The similar patch was previously reported for Logitech HD Webcam C310 (see > 36691e1be6ec551eef4a5225f126a281f8c051c2

Re: [alsa-devel] [PATCH] usb-audio: Fix invalid volume resolution for Logitech HD Webcam C525

2013-08-12 Thread Takashi Iwai
At Sat, 10 Aug 2013 12:20:02 +0400, Maksim A. Boyko wrote: > > Add the volume control quirk for avoiding the kernel warning > for the Logitech HD Webcam C525 > as in the similar commit 36691e1be6ec551eef4a5225f126a281f8c051c2 > for the Logitech HD Webcam C310. > > Reported-by: Maksim Boyko > Tes

Re: [PATCH] ALSA: hda - One more Dell headset detection quirk

2013-12-10 Thread Takashi Iwai
At Wed, 11 Dec 2013 11:41:31 +0800, Hui Wang wrote: > > On the Dell machines with codec whose Subsystem Id is 0x10280624, > no external microphone can be detected when plugging a 3-ring > headset. If we add "model=dell-headset-multi" for the > snd-hda-intel.ko, the problem will disappear. > > Bug

Re: [PATCH] ALSA: hda - hdmi: Fix IEC958 ctl indexes for some simple HDMI devices

2013-12-10 Thread Takashi Iwai
At Tue, 10 Dec 2013 22:46:34 +0200, Anssi Hannula wrote: > > In case a single HDA card has both HDMI and S/PDIF outputs, the S/PDIF > outputs will have their IEC958 controls created starting from index 16 > and the HDMI controls will be created starting from index 0. > > However, HDMI simple_play

Re: [PATCH] ALSA: hda - Add enable_msi=0 workaround for four HP machines

2013-12-12 Thread Takashi Iwai
At Thu, 12 Dec 2013 09:52:03 +0100, David Henningsson wrote: > > While enabling these machines, we found we would sometimes lose an > interrupt if we change hardware volume during playback, and that > disabling msi fixed this issue. (Losing the interrupt caused underruns > and crackling audio, as

Re: [PATCH] ALSA: hda - Add Dell headset detection quirk for three laptop models

2013-12-13 Thread Takashi Iwai
At Fri, 13 Dec 2013 11:57:05 +0800, Hui Wang wrote: > > On the Dell machines with codec whose Subsystem Id is 0x10280610, > 0x10280629 or 0x1028063e, no external microphone can be detected when > plugging a 3-ring headset. If we add "model=dell-headset-multi" for > the snd-hda-intel.ko, the proble

Re: [ 28/45] ALSA: hda - Add a fixup for Gateway LT27

2013-08-19 Thread Takashi Iwai
At Mon, 19 Aug 2013 10:48:06 -0700, Greg Kroah-Hartman wrote: > > On Mon, Aug 19, 2013 at 11:42:28AM -0600, Nathanael D. Noblet wrote: > > No objection, other than that I submitted a revision to that > > patch... Added an additional piece of hardware. The full patch > > should be include two lines

Re: [PATCH 1/9] ALSA: Compress - dont use lock for all ioctls

2013-08-27 Thread Takashi Iwai
At Tue, 27 Aug 2013 12:10:31 +0530, Vinod Koul wrote: > > Some simple ioctls like timsetamp query, capabities query can be done anytime > and should not be under the stream lock. Move these to > snd_compress_simple_iotcls() which is invoked without lock held > > While at it, improve readblity a b

Re: [PATCH 2/9] ALSA: compress: use mutex in drain

2013-08-27 Thread Takashi Iwai
At Tue, 27 Aug 2013 12:10:32 +0530, Vinod Koul wrote: > > Since we dont have lock over the function, we need to aquire mutex when > checking > and modfying states in drain and partial_drain handlers > > Signed-off-by: Vinod Koul > Cc: > --- > sound/core/compress_offload.c | 22 +

Re: [PATCH 9/9] ALSA: compress: use rate values for passing sampling rates

2013-08-27 Thread Takashi Iwai
At Tue, 27 Aug 2013 12:10:39 +0530, Vinod Koul wrote: > > Clarify that its better to use the rate values like 8000, 12000, 11025, 44100, > 48000 etc to send sampling rate values to driver. The changes kernel ABI but > no > drivers exist upstream so okay to change now > Tinycompress to be fixed as

Re: [PATCH 2/9] ALSA: compress: use mutex in drain

2013-08-27 Thread Takashi Iwai
At Tue, 27 Aug 2013 15:17:41 +0530, Vinod Koul wrote: > > On Tue, Aug 27, 2013 at 12:25:23PM +0200, Takashi Iwai wrote: > > At Tue, 27 Aug 2013 12:10:32 +0530, > > Vinod Koul wrote: > > > > > > Since we dont have lock over the function, we need to aquire

Re: [PATCH 1/9] ALSA: Compress - dont use lock for all ioctls

2013-08-27 Thread Takashi Iwai
At Tue, 27 Aug 2013 15:14:15 +0530, Vinod Koul wrote: > > On Tue, Aug 27, 2013 at 12:22:31PM +0200, Takashi Iwai wrote: > > At Tue, 27 Aug 2013 12:10:31 +0530, > > Vinod Koul wrote: > > > > > > Some simple ioctls like timsetamp query, capabities query can be

Re: [PATCH] ALSA: hda - hdmi: Fallback to ALSA allocation when selecting CA

2013-09-02 Thread Takashi Iwai
At Sun, 1 Sep 2013 14:36:47 +0300, Anssi Hannula wrote: > > hdmi_channel_allocation() tries to find a HDMI channel allocation that > matches the number channels in the playback stream and contains only > speakers that the HDMI sink has reported as available via EDID. If no > such allocation is fo

Re: [PATCH] ALSA: hda - hdmi: Fallback to ALSA allocation when selecting CA

2013-09-06 Thread Takashi Iwai
The patch was already merged to Linus git tree now, so it'll be in 3.12-rc1. The commit was marked with Cc to stable, thus it'll be picked up to stable kernels eventually later. Takashi > > Thanks > Etienne > > Le 2 sept. 2013 à 15:06, Takashi Iwai a écrit : > >

Re: [PATCH] ALSA: hda - hdmi: Fix channel map switch not taking effect

2013-10-07 Thread Takashi Iwai
At Wed, 2 Oct 2013 21:13:32 +0300, Anssi Hannula wrote: > > Currently hdmi_setup_audio_infoframe() reprograms the HDA channel > mapping only when the infoframe is not up-to-date or the non-PCM flag > has changed. > > However, when just the channel map has been changed, the infoframe may > still

Re: [PATCH] ALSA: hda - hdmi: Fix channel map switch not taking effect

2013-10-07 Thread Takashi Iwai
At Mon, 07 Oct 2013 13:31:17 +0300, Anssi Hannula wrote: > > Takashi Iwai kirjoitti 2013-10-07 10:48: > > At Wed, 2 Oct 2013 21:13:32 +0300, > > Anssi Hannula wrote: > > > > Currently hdmi_setup_audio_infoframe() reprograms the HDA channel > > mapping only

Re: [PATCH] ALSA: hda - hdmi: Fix channel map switch not taking effect

2013-10-07 Thread Takashi Iwai
At Mon, 07 Oct 2013 15:45:09 +0300, Anssi Hannula wrote: > > Takashi Iwai kirjoitti 2013-10-07 13:43: > > At Mon, 07 Oct 2013 13:31:17 +0300, > > Anssi Hannula wrote: > > > > Takashi Iwai kirjoitti 2013-10-07 10:48: > > > At Wed, 2 Oct 2013 21

Re: [PATCH v2] ALSA: hda - hdmi: Fix channel map switch not taking effect

2013-10-08 Thread Takashi Iwai
At Mon, 7 Oct 2013 19:24:52 +0300, Anssi Hannula wrote: > > Currently hdmi_setup_audio_infoframe() reprograms the HDA channel > mapping only when the infoframe is not up-to-date or the non-PCM flag > has changed. > > However, when just the channel map has been changed, the infoframe may > still

Re: [PATCH 2/2] ALSA: hda - Fix microphone for Sony VAIO Pro 13 (Haswell model)

2013-10-10 Thread Takashi Iwai
At Thu, 10 Oct 2013 12:19:24 +0200, David Henningsson wrote: > > The external mic showed up with a precense detect of "always present", > essentially disabling the internal mic. Therefore turn off presence > detection for this pin. > > Note: The external mic seems not yet working, but an internal

[PATCH 3.11.y] ALSA: hda - Fix GPIO for Acer Aspire 3830TG

2013-10-10 Thread Takashi Iwai
model. Reported-by: Christopher Cc: Signed-off-by: Takashi Iwai --- This is a refreshed patch to be applicable cleanly to 3.11. sound/pci/hda/patch_conexant.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c index

Re: [PATCH 2/2] ALSA: hda - Fix microphone for Sony VAIO Pro 13 (Haswell model)

2013-10-10 Thread Takashi Iwai
At Thu, 10 Oct 2013 15:26:03 +0200, David Henningsson wrote: > > On 10/10/2013 01:18 PM, Takashi Iwai wrote: > > At Thu, 10 Oct 2013 12:19:24 +0200, > > David Henningsson wrote: > >> > >> The external mic showed up with a precense detect of "always

Re: [ 42/66] ALSA: Avoid endless sleep after disconnect

2012-11-14 Thread Takashi Iwai
p when possible, too. Sorry for inconvenience. thanks, Takashi > > -- > > > From: Takashi Iwai > > commit 0914f7961babbf28aaa2f19b453951fb4841c03f upstream. > > When disconnect callback is called, each component should wake up > sleepers and ch

[PATCH 3.6.y] ALSA: usb-audio: Fix crash at re-preparing the PCM stream

2012-11-19 Thread Takashi Iwai
This patch adds a new function to synchronize the pending stop operation on an endpoint, and calls in the prepare callback for avoiding the crash above. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=49181 Reported-and-tested-by: Artem S. Tashkinov Cc: [v3.6] Signed-off-by: Takashi Iwai ---

Re: [PATCH] ALSA: hda - Add support for Realtek ALC292

2012-11-21 Thread Takashi Iwai
At Wed, 21 Nov 2012 08:57:58 +0100, David Henningsson wrote: > > We found a new codec ID 292, and that just a simple quirk would enable > sound output/input on this ALC292 chip. > > BugLink: https://bugs.launchpad.net/bugs/1081466 > Cc: stable@vger.kernel.org > Tested-by: Acelan Kao > Signed-off

Re: [PATCH] ALSA: hda - Cirrus: Correctly clear line_out_pins when moving to speaker

2012-11-21 Thread Takashi Iwai
At Wed, 21 Nov 2012 10:03:10 +0100, David Henningsson wrote: > > If this array is not cleared, the jack related code later might > fail to create "Internal Speaker Phantom Jack" on Dell Inspiron 3420 and > Dell Vostro 2420. > > BugLink: https://bugs.launchpad.net/bugs/1076840 > Cc: stable@vger.ke

Re: [alsa-devel] [PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 49

2012-11-26 Thread Takashi Iwai
At Sun, 25 Nov 2012 23:01:27 +0100, Clemens Ladisch wrote: > > Jonathan Nieder wrote: > > Some USB MIDI keyboards fail to operate after a USB autosuspend. > > Make that *all* USB MIDI devices with input ports. > > This is not a bug in the device, but one of the many bugs introduced > with the au

Re: [alsa-devel] [PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 49

2012-11-26 Thread Takashi Iwai
At Mon, 26 Nov 2012 13:35:31 +0100, Clemens Ladisch wrote: > > Takashi Iwai wrote:> At Sun, 25 Nov 2012 23:01:27 +0100, > > Clemens Ladisch wrote: > >> > >> Jonathan Nieder wrote: > >>> Some USB MIDI keyboards fail to operate after a USB autosuspen

Re: [alsa-devel] [PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 49

2012-11-26 Thread Takashi Iwai
At Mon, 26 Nov 2012 14:43:13 +0100, Clemens Ladisch wrote: > > Takashi Iwai wrote: > > Clemens Ladisch wrote: > >> Takashi Iwai wrote: > >>> Clemens Ladisch wrote: > >>>> I'm working on a fix that adds proper power management for input ports,

Re: FAILED: patch "[PATCH] ALSA: snd-usb: properly initialize the sync endpoint" failed to apply to 3.6-stable tree

2012-11-30 Thread Takashi Iwai
tialize the sync endpoint from > configure_endpoint(). > > Reported-by: Jeffrey Barish > Signed-off-by: Daniel Mack > Cc: sta...@kernel.org [3.5+] > Signed-off-by: Takashi Iwai > > diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c > index 5c12a3f..ef6fa24 100644 >

Re: [PATCH 1/2] ALSA: hda - add mute LED for HP Pavilion 17 (Realtek codec)

2013-01-07 Thread Takashi Iwai
At Mon, 7 Jan 2013 10:51:29 +0100, David Henningsson wrote: > > The mute LED is in this case connected to the Mic1 VREF. > > The machine also exposes the following string in BIOS: > "HP_Mute_LED_0_A", so if more machines are coming, it probably > makes sense to try to do something more generic,

Re: [PATCH v2] ALSA: hda - add mute LED for HP Pavilion 17 (Realtek codec)

2013-01-07 Thread Takashi Iwai
At Mon, 7 Jan 2013 12:03:47 +0100, David Henningsson wrote: > > The mute LED is in this case connected to the Mic1 VREF. > > The machine also exposes the following string in BIOS: > "HP_Mute_LED_0_A", so if more machines are coming, it probably > makes sense to try to do something more generic,

Re: [alsa-devel] [stable] usb-audio validation fixes [3.0, 3.2]

2013-05-27 Thread Takashi Iwai
At Tue, 28 May 2013 02:27:49 +0100, Ben Hutchings wrote: > > It looks these fixes are suitable for inclusion in the 3.0.y and 3.2.y > stable branches: > > commit 4fa0e81b83503900be277e6273a79651b375e288 > Author: Xi Wang > Date: Sun Jan 8 09:02:52 2012 -0500 > > ALSA: usb-audio: fix possi

Re: [ 044/184] ALSA: ice1712: Initialize card->private_data

2013-06-06 Thread Takashi Iwai
At Fri, 7 Jun 2013 07:34:01 +0200, Willy Tarreau wrote: > > Hi Ben, > > On Fri, Jun 07, 2013 at 04:48:58AM +0100, Ben Hutchings wrote: > > > From: Sean Connor > > > > > > commit 69a4cfdd444d1fe5c24d29b3a063964ac165d2cd upstream. > > > > > > Set card->private_data in snd_ice1712_create for fixi

Re: [alsa-devel] [stable] usb-audio validation fixes [3.0, 3.2]

2013-06-17 Thread Takashi Iwai
At Thu, 13 Jun 2013 02:30:39 +0100, Ben Hutchings wrote: > > On Tue, 2013-05-28 at 08:28 +0200, Takashi Iwai wrote: > > At Tue, 28 May 2013 02:27:49 +0100, > > Ben Hutchings wrote: > > > > > > It looks these fixes are suitable for inclusion in the 3

Re: [PATCH 3.14 00/59] 3.14.11-stable review

2014-07-05 Thread Takashi Iwai
At Sat, 05 Jul 2014 18:21:04 +0900, Satoru Takeuchi wrote: > > Hi Greg, > > Add Takashi Iwai to this thread. > > At Sat, 05 Jul 2014 16:00:41 +0900, > Satoru Takeuchi wrote: > > > > At Fri, 04 Jul 2014 22:45:42 -0700, > > Guenter Roeck wrote: > >

Re: [PATCH 3.14 59/59] ALSA: hda - Adjust speaker HPF and add LED support for HP Spectre 13

2014-07-05 Thread Takashi Iwai
-- > > From: Takashi Iwai > > commit 8b3dfdaf0c25a584cb31d04d2574115cf2d422ab upstream. > > HP Spectre 13 has the IDT 92HD95 codec, and BIOS seems to set the > default high-pass filter in some "safer" range, which results in the > very soft tone from the built-i

Re: [PATCH] ALSA: hda - Add several entries for enabling HP mute led

2014-07-07 Thread Takashi Iwai
At Mon, 7 Jul 2014 17:07:43 +0800, Hui Wang wrote: > > BugLink: https://bugs.launchpad.net/bugs/1329580 > Cc: David Henningsson > Cc: Kailang Yang > Cc: stable@vger.kernel.org > Signed-off-by: Hui Wang Thanks, applied. Note that the original fix for HP mute LED is for 3.17 without Cc, so I d

Re: [alsa-devel] [PATCH] ALSA: hda - initialize audio InfoFrame to be all zero

2014-07-22 Thread Takashi Iwai
At Tue, 22 Jul 2014 08:52:31 +0200, David Henningsson wrote: > > Hi, > > It looks like this patch should have been sent to stable, is there any > reason why it wasn't? Just forgotten, I suppose. This should be included in stable, indeed. Greg, could you cherry-pick this upstream commit caaf5e

Re: [alsa-devel] [PATCH] ALSA: hda - initialize audio InfoFrame to be all zero

2014-07-23 Thread Takashi Iwai
At Tue, 22 Jul 2014 17:08:52 -0700, Greg KH wrote: > > On Tue, Jul 22, 2014 at 09:01:51AM +0200, Takashi Iwai wrote: > > At Tue, 22 Jul 2014 08:52:31 +0200, > > David Henningsson wrote: > > > > > > Hi, > > > > > > It looks like th

Re: [PATCH] ALSA: hda - fix an external mic jack problem on a HP machine

2014-07-29 Thread Takashi Iwai
At Wed, 30 Jul 2014 11:11:48 +0800, Hui Wang wrote: > > ON the machine, two pin complex (0xb and 0xe) are both routed to > the same external right-side mic jack, this makes the jack can't work. > > To fix this problem, set the 0xe to "not connected". > > BugLink: https://bugs.launchpad.net/bugs/

Re: [PATCH] ALSA: hda - Add quirk for external mic on Lifebook U904

2014-06-13 Thread Takashi Iwai
At Fri, 13 Jun 2014 11:15:44 +0200, David Henningsson wrote: > > According to the bug reporter (Данило Шеган), the external mic > starts to work and has proper jack detection if only pin 0x19 > is marked properly as an external headset mic. > > AlsaInfo at > https://bugs.launchpad.net/ubuntu/+so

Re: Patch "ALSA: hda/realtek - Avoid invalid COEFs for ALC271X" has been added to the 3.12-stable tree

2014-02-17 Thread Takashi Iwai
erged to Linus tree now). thanks, Takashi > > > >From d3c56568f43807135f2c2a09582a69f809f0d8b7 Mon Sep 17 00:00:00 2001 > From: Takashi Iwai > Date: Mon, 3 Feb 2014 09:56:13 +0100 > Subject: ALSA: hda/realtek - Avoid invalid COEFs for ALC271X > > From: Takashi Iwai > > commit

Re: [PATCH] ALSA: hda - add headset mic detect quirks for two Dell laptops

2014-02-17 Thread Takashi Iwai
At Tue, 18 Feb 2014 10:56:46 +0800, Hui Wang wrote: > > When we plug a 3-ring headset on the Dell machines (Vendor ID: > 0x10ec0255, Subsystem ID: 0x10280657; Vendor ID: 0x10ec0255, > Subsystem ID: 0x1028065f), the headset mic can't be > detected, after apply this patch, the headset mic can work w

Re: [PATCH] ALSA: hda - Enable front audio jacks on one HP desktop model

2014-02-19 Thread Takashi Iwai
At Thu, 20 Feb 2014 11:47:21 +0800, Hui Wang wrote: > > The front headphone and mic jackes on a HP desktop model (Vendor Id: > 0x111d76c7 Subsystem Id: 0x103c2b17) can not work, the codec on this > machine has 8 physical ports, 6 of them are routed to rear jackes > and all of them work very well,

Re: [PATCH] ALSA: hda - add automute fix for another dell AIO model

2014-03-04 Thread Takashi Iwai
At Tue, 4 Mar 2014 16:20:18 +0800, Hui Wang wrote: > > When plugging a headphone or headset, lots of noise is heard from > internal speaker, after changing the automute via amp instead of > pinctl, the noise disappears. > > BugLink: https://bugs.launchpad.net/bugs/1268468 > Cc: David Henningsson

Re: [patch added to the 3.12 stable tree] ALSA: hda - Fix possible races in HDMI driver

2014-03-12 Thread Takashi Iwai
At Wed, 12 Mar 2014 11:29:38 +0100, Jiri Slaby wrote: > > From: Takashi Iwai > > This patch has been added to the 3.12 stable tree. If you have any > objections, please let us know. > > === > > commit cbbaa603a03cc46681e24d6b2804b62fde95a2af upstream. &

Re: [PATCH] ALSA: hda - Prevent speaker from entering automute on some AIO models

2014-01-13 Thread Takashi Iwai
At Mon, 13 Jan 2014 14:52:27 +0800, Hui Wang wrote: > > On some AIO (All In One) models with the codec alc668 > (Vendor ID: 0x10ec0668) on it, when we plug a headphone into the jack, > the system will switch the output to headphone and set the speaker to > automute as well as change the speaker Pi

Re: [PATCH v2] ALSA: hda - automute via amp instead of pinctl on some AIO models

2014-01-14 Thread Takashi Iwai
At Tue, 14 Jan 2014 14:07:36 +0800, Hui Wang wrote: > > On some AIO (All In One) models with the codec alc668 > (Vendor ID: 0x10ec0668) on it, when we plug a headphone into the jack, > the system will switch the output to headphone and set the speaker to > automute as well as change the speaker Pi

Re: [PATCH] ALSA: hda - add headset mic detect quirks for some Dell machines

2014-01-16 Thread Takashi Iwai
At Thu, 16 Jan 2014 15:51:10 +0800, Hui Wang wrote: > > When we plug a 3-ring headset on some Dell machines, the headset > mic can't be detected, after apply this patch, the headset mic > can work well on all those machines. > > On the machine with the Subsytem ID 0x10280610, if we use > ALC269_F

[PATCH 3.13.y] ALSA: hda - Explicitly keep codec powered up in hdmi_present_sense

2014-01-24 Thread Takashi Iwai
+0x9a/0x3a0 [snd_hda_codec_hdmi] [] hdmi_repoll_eld+0x34/0x50 [snd_hda_codec_hdmi] Fixes: cbbaa603a03c ('ALSA: hda - Fix possible races in HDMI driver') Signed-off-by: David Henningsson Cc: [v3.13] Signed-off-by: Takashi Iwai --- Greg, please take it for 3.13.y; the regression o

Re: [PATCH] ALSA: hda - add headset mic detect quirks for another Dell laptop

2014-01-30 Thread Takashi Iwai
At Thu, 30 Jan 2014 10:55:51 +0800, Hui Wang wrote: > > When we plug a 3-ring headset on the Dell machine (Vendor ID: > 0x10ec0255, Subsystem ID: 0x1028064d), the headset mic can't be > detected, after apply this patch, the headset mic can work well. > > BugLink: https://bugs.launchpad.net/bugs/1

Re: [PATCH] ALSA: hda/hdmi - allow PIN_OUT to be dynamically enabled

2014-01-30 Thread Takashi Iwai
At Thu, 30 Jan 2014 11:52:16 -0700, Stephen Warren wrote: > > From: Stephen Warren > > Commit 384a48d71520 "ALSA: hda: HDMI: Support codecs with fewer cvts > than pins" dynamically enabled each pin widget's PIN_OUT only when the > pin was actively in use. This was required on certain NVIDIA CODE

[PATCH 3.13.y] ALSA: hda - Don't set indep_hp flag for old AD codecs

2014-02-03 Thread Takashi Iwai
l.org/show_bug.cgi?id=68081 Cc: [v3.12+] Signed-off-by: Takashi Iwai --- Greg, this is the revised patch that had failed to cherry-pick. It's applicable cleanly to 3.12.y and 3.13.y. No need to apply to 3.11.y and older. sound/pci/hda/patch_analog.c | 16 1 file changed, 8

Re: [PATCH 3.13.y] ALSA: hda - Don't set indep_hp flag for old AD codecs

2014-02-04 Thread Takashi Iwai
At Tue, 4 Feb 2014 09:22:07 -0800, Greg KH wrote: > > On Tue, Feb 04, 2014 at 08:02:40AM +0100, Takashi Iwai wrote: > > commit e7729a415315fcd9516912050d85d5aaebcededc upstream. > > Are you sure? That commit is: > ALSA: hda - Fix silent output on MacBook Air 1,1 &g

[PATCH v2] ALSA: hda - Don't set indep_hp flag for old AD codecs

2014-02-04 Thread Takashi Iwai
l.org/show_bug.cgi?id=68081 Cc: [v3.12+] Signed-off-by: Takashi Iwai --- This is the right one with the correct upstream commit id. Please apply this for 3.12.y and 3.13.y. sound/pci/hda/patch_analog.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sound/pc

Re: [PATCH] ALSA: hda - Add a headset quirk for Dell XPS 13

2014-02-07 Thread Takashi Iwai
At Fri, 7 Feb 2014 11:00:16 +0100, David Henningsson wrote: > > This quirk is needed for the headset microphone to work. > > Alsa-info at > http://www.alsa-project.org/db/?f=8c7dfe857ceff462ca2de133e67023c0f68de9cb > > Cc: stable@vger.kernel.org (3.10+) > Reported-by: Po-Hsu Lin > Signed-off-

Re: [PATCH] ALSA: hda - hdmi: Fix missing ELD change event on plug/unplug

2014-10-19 Thread Takashi Iwai
At Sun, 19 Oct 2014 19:25:19 +0300, Anssi Hannula wrote: > > The ELD ALSA control change event is sent by hdmi_present_sense() when > eld_changed is true. > > Currently, it is only true when the ELD buffer contents have been > modified. However, the user-visible ELD controls also change to a > ze

Re: [PATCH] ALSA: hda - Add missing terminating entry to SND_HDA_PIN_QUIRK macro

2014-10-24 Thread Takashi Iwai
At Fri, 24 Oct 2014 10:00:38 +0200, David Henningsson wrote: > > Without this terminating entry, the pin matching would continue > across random memory until a zero or a non-matching entry was found. > > The result being that in some cases, the pin quirk would not be > applied correctly. > > Cc:

Re: [PATCH 1/2] ALSA: hda - Set GPIO 4 low for a few HP machines

2014-10-30 Thread Takashi Iwai
At Thu, 30 Oct 2014 08:26:01 +0100, David Henningsson wrote: > > These HP machines needs GPIO 4 low to enable the headphone amplifier. > In addition, we still need to control LEDs via vref and GPIO. > > Cc: stable@vger.kernel.org > BugLink: https://bugs.launchpad.net/bugs/1387128 > Tested-by: Tie

Re: [PATCH 1/2] [media] sound: simplify au0828 quirk table

2014-10-30 Thread Takashi Iwai
At Thu, 30 Oct 2014 08:53:04 -0200, Mauro Carvalho Chehab wrote: > > From: Mauro Carvalho Chehab > > Add a macro to simplify au0828 quirk table. That makes easier > to check it against the USB IDs at drivers/media/usb/au0828-card.c > > Cc: stable@vger.kernel.org > Signed-off-by: Mauro Carvalho

Re: Backport of CDCLK/Haswell patches

2014-10-31 Thread Takashi Iwai
At Fri, 31 Oct 2014 12:07:13 +0100, Jiri Slaby wrote: > > On 10/08/2014, 10:09 AM, David Henningsson wrote: > > Hi stable maintainers, > > > > These two patches: c149dcb5c60bfea8871f16dfcc0690255eeb825f > > drm/i915: provide interface for audio driver to query cdclk > > and > > e4d9e513dedb5ac4e1

Re: [PATCH] ALSA: hda - fix mute led problem for three HP laptops

2014-11-04 Thread Takashi Iwai
At Wed, 5 Nov 2014 12:17:58 +0800, Hui Wang wrote: > > Without the fix, the mute led can't work on these three machines. > > After apply this fix, these three machines will fall back on the led > control quirk as below, and through testing, the mute led works very > well. > PIN_QUIRK(0x10ec0282,

  1   2   >