Re: [PATCH] TTY: n_gsm, fix false positive WARN_ON

2015-11-25 Thread xinhui
hi, Jiri On 2015/11/25 17:56, Jiri Slaby wrote: Hi, On 11/25/2015, 07:32 AM, xinhui wrote: This warning should blame on commit 5a640967 ("tty/n_gsm.c: fix a memory leak in gsmld_open()"). Oh, yes, I messed up the "Fixes" line then. It should write: Fixes: 5a640967

Re: [PATCH] TTY: n_gsm, fix false positive WARN_ON

2015-11-24 Thread xinhui
st modify the codes like below: if(gsm_mux[gsm->num] == gsm) other work else return; I think it would work, and the logic is correct. Or I just miss something important? thanks xinhui On 2015/11/25 00:54, Jiri Slaby wrote: Dmitry reported, that the current cleanup code in n_gsm