Re: [Intel-gfx] [PATCH] drm/i915: Unconditionally flush writes before execbuffer

2015-05-19 Thread Chris Wilson
On Mon, May 11, 2015 at 04:25:52PM +0100, Chris Wilson wrote: > On Mon, May 11, 2015 at 12:34:37PM +0200, Daniel Vetter wrote: > > On Mon, May 11, 2015 at 08:51:36AM +0100, Chris Wilson wrote: > > > With the advent of mmap(wc), we have a path to write directly into > > > active GPU buffers. When co

Re: [Intel-gfx] [PATCH] drm/i915: Unconditionally flush writes before execbuffer

2015-05-21 Thread Chris Wilson
On Tue, May 19, 2015 at 03:41:48PM +0100, Chris Wilson wrote: > On Mon, May 11, 2015 at 04:25:52PM +0100, Chris Wilson wrote: > > On Mon, May 11, 2015 at 12:34:37PM +0200, Daniel Vetter wrote: > > > On Mon, May 11, 2015 at 08:51:36AM +0100, Chris Wilson wrote: > > > > With the advent of mmap(wc), w

Re: [Intel-gfx] [PATCH] drm/i915: Unconditionally flush writes before execbuffer

2015-05-21 Thread Daniel Vetter
On Thu, May 21, 2015 at 02:00:34PM +0100, Chris Wilson wrote: > On Tue, May 19, 2015 at 03:41:48PM +0100, Chris Wilson wrote: > > On Mon, May 11, 2015 at 04:25:52PM +0100, Chris Wilson wrote: > > > On Mon, May 11, 2015 at 12:34:37PM +0200, Daniel Vetter wrote: > > > > On Mon, May 11, 2015 at 08:51:

Re: [Intel-gfx] [PATCH] drm/i915: Unconditionally flush writes before execbuffer

2015-05-21 Thread Chris Wilson
On Thu, May 21, 2015 at 03:07:54PM +0200, Daniel Vetter wrote: > On Thu, May 21, 2015 at 02:00:34PM +0100, Chris Wilson wrote: > > On Tue, May 19, 2015 at 03:41:48PM +0100, Chris Wilson wrote: > > > On Mon, May 11, 2015 at 04:25:52PM +0100, Chris Wilson wrote: > > > > On Mon, May 11, 2015 at 12:34:

Re: [Intel-gfx] [PATCH] drm/i915: Unconditionally flush writes before execbuffer

2015-05-21 Thread Daniel Vetter
On Thu, May 21, 2015 at 02:13:01PM +0100, Chris Wilson wrote: > On Thu, May 21, 2015 at 03:07:54PM +0200, Daniel Vetter wrote: > > On Thu, May 21, 2015 at 02:00:34PM +0100, Chris Wilson wrote: > > > On Tue, May 19, 2015 at 03:41:48PM +0100, Chris Wilson wrote: > > > > On Mon, May 11, 2015 at 04:25:

Re: [Intel-gfx] [PATCH] drm/i915: Unconditionally flush writes before execbuffer

2015-05-21 Thread Chris Wilson
On Thu, May 21, 2015 at 04:21:46PM +0200, Daniel Vetter wrote: > Hm right. What about emphasising this a bit more in the comment: > > /* >* Empirical evidence indicates that we need a write barrier to >* make sure write-combined writes (both to the gtt, but also to >*

Re: [Intel-gfx] [PATCH] drm/i915: Unconditionally flush writes before execbuffer

2015-05-21 Thread Daniel Vetter
On Thu, May 21, 2015 at 04:22:55PM +0100, Chris Wilson wrote: > On Thu, May 21, 2015 at 04:21:46PM +0200, Daniel Vetter wrote: > > Hm right. What about emphasising this a bit more in the comment: > > > > /* > > * Empirical evidence indicates that we need a write barrier to > > * make

Re: [Intel-gfx] [PATCH] drm/i915: Unconditionally flush writes before execbuffer

2015-05-21 Thread Jesse Barnes
On 05/21/2015 06:00 AM, Chris Wilson wrote: > On Tue, May 19, 2015 at 03:41:48PM +0100, Chris Wilson wrote: >> On Mon, May 11, 2015 at 04:25:52PM +0100, Chris Wilson wrote: >>> On Mon, May 11, 2015 at 12:34:37PM +0200, Daniel Vetter wrote: On Mon, May 11, 2015 at 08:51:36AM +0100, Chris Wilson

Re: [Intel-gfx] [PATCH] drm/i915: Unconditionally flush writes before execbuffer

2015-05-26 Thread Daniel Vetter
On Thu, May 21, 2015 at 5:30 PM, Daniel Vetter wrote: > On Thu, May 21, 2015 at 04:22:55PM +0100, Chris Wilson wrote: >> On Thu, May 21, 2015 at 04:21:46PM +0200, Daniel Vetter wrote: >> > Hm right. What about emphasising this a bit more in the comment: >> > >> > /* >> > * Empirical evide