Re: [Intel-gfx] [PATCH v4 2/3] drm/i915: Fix userptr deadlock with aliased GTT mmappings

2015-09-10 Thread Tvrtko Ursulin
On 09/10/2015 11:25 AM, Tvrtko Ursulin wrote: + +active = false; +if (pinned < 0) +ret = pinned; +else if (pinned < num_pages) +ret = __i915_gem_userptr_get_pages_schedule(obj, ); +else ret = __i915_gem_userptr_set_pages(obj, pvec, num_pages); -

Re: [Intel-gfx] [PATCH v4 2/3] drm/i915: Fix userptr deadlock with aliased GTT mmappings

2015-09-10 Thread Tvrtko Ursulin
On 09/10/2015 10:51 AM, Chris Wilson wrote: MichaƂ Winiarski found a really evil way to trigger a struct_mutex deadlock with userptr. He found that if he allocated a userptr bo and then GTT mmaped another bo, or even itself, at the same address as the userptr using MAP_FIXED, he could then