Re: [PATCH] Kernel OOPS in xen_netbk_rx_action / xenvif_gop_skb

2014-07-11 Thread Philipp Hahn
Hello Wei Liu, On 10.07.2014 14:41, Wei Liu wrote: On Wed, Jul 02, 2014 at 09:45:44AM +0200, Philipp Hahn wrote: @Wei Liu: You said that the patch is only a quick hack to detect, if my analysis is correct and a proper fix would be needed. For us the attached patch works, as the problem does

Re: [PATCH] Kernel OOPS in xen_netbk_rx_action / xenvif_gop_skb

2014-07-11 Thread Wei Liu
On Fri, Jul 11, 2014 at 11:41:22AM +0200, Philipp Hahn wrote: Hello Wei Liu, On 10.07.2014 14:41, Wei Liu wrote: On Wed, Jul 02, 2014 at 09:45:44AM +0200, Philipp Hahn wrote: @Wei Liu: You said that the patch is only a quick hack to detect, if my analysis is correct and a proper fix

Re: [PATCH] Kernel OOPS in xen_netbk_rx_action / xenvif_gop_skb

2014-07-11 Thread Wei Liu
On Fri, Jul 11, 2014 at 11:41:22AM +0200, Philipp Hahn wrote: Hello Wei Liu, On 10.07.2014 14:41, Wei Liu wrote: On Wed, Jul 02, 2014 at 09:45:44AM +0200, Philipp Hahn wrote: @Wei Liu: You said that the patch is only a quick hack to detect, if my analysis is correct and a proper fix

Re: [Xen-devel] [PATCH] Kernel OOPS in xen_netbk_rx_action / xenvif_gop_skb

2014-07-11 Thread Philipp Hahn
Hello Wei Liu, On 11.07.2014 12:32, Wei Liu wrote: On Fri, Jul 11, 2014 at 11:41:22AM +0200, Philipp Hahn wrote: On 10.07.2014 14:41, Wei Liu wrote: On Wed, Jul 02, 2014 at 09:45:44AM +0200, Philipp Hahn wrote: @Wei Liu: You said that the patch is only a quick hack to detect, if my analysis

Re: [Xen-devel] [PATCH] Kernel OOPS in xen_netbk_rx_action / xenvif_gop_skb

2014-07-11 Thread Wei Liu
On Fri, Jul 11, 2014 at 01:02:18PM +0200, Philipp Hahn wrote: Hello Wei Liu, On 11.07.2014 12:32, Wei Liu wrote: On Fri, Jul 11, 2014 at 11:41:22AM +0200, Philipp Hahn wrote: On 10.07.2014 14:41, Wei Liu wrote: On Wed, Jul 02, 2014 at 09:45:44AM +0200, Philipp Hahn wrote: @Wei Liu: You

Re: [PATCH] Kernel OOPS in xen_netbk_rx_action / xenvif_gop_skb

2014-07-10 Thread Wei Liu
On Wed, Jul 02, 2014 at 09:45:44AM +0200, Philipp Hahn wrote: Hello Wei Liu, On 27.06.2014 20:24, Philipp Hahn wrote: On 27.06.2014 19:48, Philipp Hahn wrote: I guess we found the problem ourselves: For thus removed skb's the reference counter on the associated vif was not decremented,

Re: [PATCH] Kernel OOPS in xen_netbk_rx_action / xenvif_gop_skb

2014-07-02 Thread Philipp Hahn
Hello Wei Liu, On 27.06.2014 20:24, Philipp Hahn wrote: On 27.06.2014 19:48, Philipp Hahn wrote: I guess we found the problem ourselves: For thus removed skb's the reference counter on the associated vif was not decremented, as it is normally done in two locations at the end of the function